Commit Graph

6522 Commits

Author SHA1 Message Date
Vinit Nayak f8d55e0e2a Merge "Respect StatusBarManager back/home disable flags" into sc-v2-dev 2021-08-18 20:54:09 +00:00
Bryce Lee 6e2d149ac7 Merge "Revert "Draw rounded corners above the taskbar"" into sc-v2-dev 2021-08-18 20:51:05 +00:00
Bryce Lee a997ca437a Revert "Draw rounded corners above the taskbar"
This reverts commit 157d3b950d.

Reason for revert: b/197129604
Bug: 197129604
Change-Id: Idf2267528fade23291aedea9787d98601495537c
2021-08-18 20:50:58 +00:00
Sunny Goyal 741107cc53 Merge "Updating test build rules" into sc-v2-dev 2021-08-18 19:23:33 +00:00
Tracy Zhou d571905aa6 Merge "Tint task bar based on sampling of colors in the area" into sc-v2-dev 2021-08-18 18:32:35 +00:00
Sunny Goyal 4af8cf9269 Updating test build rules
> Moving definition to bp files
> Adding mokito-inline to allow mocking final classes
> Moving src_common to src to avoid unnecessary code split

Bug: 196825541
Test: Presubmit
Change-Id: Ib6879cda6aee74f5b9050a16eb6ca94ed3b7e28c
2021-08-18 10:22:52 -07:00
Vinit Nayak 54dccc2465 Respect StatusBarManager back/home disable flags
* Also use the same signals provided by SysUi flags
instead of directly from the disable API just for
consistency. (Disable2 flags still need to be migrated
over, so we're keeping the API for now).

Bug: 194870114
Test: Locking screen w/ 3 button nav
w/ various keyguards

Change-Id: I858ea36876061cddf0debbd43e8fcfe1d5712839
2021-08-18 07:44:50 -07:00
TreeHugger Robot a7f7c4b432 Merge "Logging for Nexus home activity appearing after to-home gesture in L3." into sc-v2-dev 2021-08-18 11:19:26 +00:00
Alex Chau 2683bd7728 Merge "Support different task icon margin for grid tasks" into sc-v2-dev 2021-08-18 08:41:42 +00:00
Tracy Zhou 334cae420e Tint task bar based on sampling of colors in the area
TODO: Add transition animation

Bug: 193938970
Test: manual
Change-Id: I0ffb94e0f11d47685a268ee8d057b6997f3a2ff6
2021-08-17 23:26:28 -07:00
vadimt bc79473313 Logging for Nexus home activity appearing after to-home gesture in L3.
Utilities.IS_RUNNING_IN_TEST_HARNESS is used as a condition
for logging in the background NexusLauncher where sDebugTracing is
not set.

Bug: 192018189
Test: presubmit
Change-Id: Ib08656a12c778b7bf968532e3ba899a03031fd7b
2021-08-17 18:13:50 -07:00
TreeHugger Robot 89d3f7d12a Merge changes Ibc81d80b,I51d99207 into sc-v2-dev
* changes:
  Don't draw taskbar background during gestures
  Draw rounded corners above the taskbar
2021-08-18 00:05:13 +00:00
Vinit Nayak ca1d523734 Merge "Add GroupedTaskView for gestures in staged split." into sc-v2-dev 2021-08-17 23:26:53 +00:00
Tony Wickham 3974edc46a Don't draw taskbar background during gestures
In this case, the ScrimView for BackgroundAppState will handle drawing behind the whole screen, and prevents taskbar from drawing the rounded corners on top of TaskViews.

Added a hack to defer resuming last task by a frame to ensure taskbar is drawing first.

Test: Quick switch to an app, ensure it isn't covered by the taskbar's rounded corner
Bug: 196257194
Change-Id: Ibc81d80bc3bf1d908e6912b179cbcafbdcc56c0f
2021-08-17 15:07:50 -07:00
Tony Wickham 157d3b950d Draw rounded corners above the taskbar
- Increase height of taskbar window, but not contentInsets
- Draw the inverted corners as part of TaskbarDragLayer#dispatchDraw() (which handles the background already)

Test: visual

Bug: 196257194
Change-Id: I51d992078579e877c85a1d71ee4c00d85fd9db2e
2021-08-17 15:06:18 -07:00
Vinit Nayak 17c4b33db6 Add GroupedTaskView for gestures in staged split.
* Currently only works for portrait 50/50 split
* Have gesture swipe animation flow use multiple
TaskViewSimulators, one for each app in split
* Added new APIs in shell to query for actively running
tasks to determine if we're in split screen
* Lots of UI polish needed during gesture
* Launching into staged split after live tile ends
not implemented yet.

Bug: 181704764
Change-Id: Ib90e99e1e10b19121e8709385e1334b9380d6502
2021-08-17 13:46:43 -07:00
TreeHugger Robot 6a384092a3 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-08-17 19:31:34 +00:00
TreeHugger Robot 54ce7e6cf8 Merge changes I2cc102d7,Ifba9aa59 into sc-v2-dev
* changes:
  Only show Taskbar Edu once (first time an app is opened).
  Adds initial Taskbar Edu implementation.
2021-08-17 19:13:31 +00:00
Nick Chameyev caa713bc1a Merge "Add quick search bar width unfold animation" into sc-v2-dev 2021-08-17 17:58:50 +00:00
Alex Chau eaa6d682d4 Support different task icon margin for grid tasks
- Focused and non focused grid now have differnt margin between icon and snapshot
- The overall margin above snapshot is still the same
- Invoke updateChildTaskOrientations when focus task changes to update the margin
- Also lowered the row spacing according to spec

Bug: 194194694
Test: manual
Change-Id: I25267bef19d5a8b1dc1cf96fc1babdc3ebc39330
2021-08-17 18:33:21 +01:00
Andy Wickham b8eac86b63 Only show Taskbar Edu once (first time an app is opened).
Bug: 180605356
Test: Manual
Change-Id: I2cc102d7ce36e0b1c2c75482e2bbb97218618e61
2021-08-17 09:57:55 -07:00
Andy Wickham 13f3ffed95 Adds initial Taskbar Edu implementation.
Currently it just pops up with one placeholder image for splitscreen.
The Next button doesn't do anything.

Screenshots:
Light: https://screenshot.googleplex.com/B27CwBcwobHTghN.png
Dark: https://screenshot.googleplex.com/48EuJZv8evd5RGW.png

Known issues:
 - Back gesture is picked up behind by the app behind the taskbar.
 - When the flag is enabled, the Edu shows up each time you open
   an app, rather than only the first time.

Bug: 180605356
Test: Manual
Change-Id: Ifba9aa59abf1501b5f8ddebb3fcc13df85f6efaa
2021-08-17 09:57:47 -07:00
Nick Chameyev 4ba48cdb8b Add quick search bar width unfold animation
Adds unfold animation to quick search bar in launcher
which changes the width of the quick search bar
from 70% to 100%.

Bug: 193795041
Test: manual
Change-Id: I8c55ca1cc5b5894847503beac8ecd8adec3e5674
2021-08-17 16:58:57 +01:00
Tony Wickham 40f86763bc Merge changes from topic "taskbar-crop-tasks" into sc-v2-dev
* changes:
  Extend taskbar color to entire screen in overview
  Use WindowBounds#insets instead of WindowInsets in DeviceProfile
2021-08-17 14:52:50 +00:00
Dave Mankoff 6eeb12e3eb Merge "Updates to constructor of PluginInstanceManager.Factory" into sc-v2-dev 2021-08-17 13:07:50 +00:00
Bill Yi 42476b5bb0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3d9b9856af9a823121595b8f6c880d4a5b3c891
2021-08-17 02:12:27 -07:00
Vadim Tryshev 0ec3e647ba Merge "Revert "Removing old workaround"" into sc-v2-dev 2021-08-17 01:20:24 +00:00
Vinit Nayak 2ad3d6b4c3 Merge "Add logs when clearing TaskViewId" into sc-v2-dev 2021-08-17 00:59:41 +00:00
Tony Wickham 635e180e56 Extend taskbar color to entire screen in overview
Only when taskbar is unstashed in apps:
- Scrim workspace with the taskbar color when opening apps and in BackgroundAppState
- Crop opening apps to above the taskbar
- Crop TaskViews to above the taskbar during gestures

If taskbar is stashed in apps, behavior is the same as before, i.e. no scrim over the wallpaper and no cropping of tasks.

Added a field DeviceProfile#taskbkarPresentInApps to distinguish these cases. LauncherTaskbarUIController and TaskbarStashController ensure this value is set appropriately.

Test: Ensure tasks don't appear behind taskbar when it's unstashed; set ENABLE_SCRIM_FOR_APP_LAUNCH = true to test the whole screen scrimming when opening an app

Bug: 196257194
Fixes: 190681228
Change-Id: I481501457a5a6d49c380feea3db3b4058e4cf3f8
2021-08-16 16:50:52 -07:00
Vadim Tryshev f11d0fac78 Revert "Removing old workaround"
This reverts commit 714d071f76.

Reason for revert: Perhaps caused b/196876329

Change-Id: I0763c44d54134034885471ce74324a8c6c6c296e
Test: presubmit
Bug: 196876329
2021-08-16 22:54:30 +00:00
Vinit Nayak dda7772452 Add logs when clearing TaskViewId
Bug: 195430732
Change-Id: I0554f27e6b82d98dd585afb895b8ee5eababff9e
2021-08-16 14:56:56 -07:00
Thales Lima 242c8c0b0f Merge "overview: rebalance hidden tasks in grid" into sc-v2-dev 2021-08-16 19:16:30 +00:00
Thales Lima 4a08ce60dc overview: rebalance hidden tasks in grid
The tasks that are not showing in the screen will be rearranged. This
doesn't change anything for tasks before the dismissed task because the
grid is already balanced there.

Fixes: 194189955
Test: manual with 10 tasks, normal and RTL mode
Change-Id: I07ddbb752110339751bd1ed6056fe9f645b5497f
2021-08-16 16:24:35 +01:00
Dave Mankoff 9847a6a75b Merge "Pass main executor to PluginInstanceManager.Factory." into sc-v2-dev 2021-08-16 15:05:20 +00:00
Dave Mankoff d72a60f953 Merge "Pass Executor to to PluginInstanceManager.Factory." into sc-v2-dev 2021-08-16 15:04:52 +00:00
TreeHugger Robot 77c08b045e Merge "Removing old workaround" into sc-v2-dev 2021-08-16 10:21:45 +00:00
TreeHugger Robot e22e3aaa9a Merge "Removing old workaround" into sc-v2-dev 2021-08-16 06:45:19 +00:00
TreeHugger Robot 348065811f Merge "Constrain scroll amount" into sc-v2-dev 2021-08-14 00:57:13 +00:00
Lucas Dupin b259a896f5 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
2021-08-13 15:57:41 -07:00
Dave Mankoff 78f9648aec Merge "Changes to the signature of PluginManagerImpl." into sc-v2-dev 2021-08-13 21:12:40 +00:00
TreeHugger Robot 87cf3efe06 Merge "Removing some instrumentation for a workarounded bug" into sc-v2-dev 2021-08-13 18:42:22 +00:00
Dave Mankoff 1095a50dfa Updates to constructor of PluginInstanceManager.Factory
Bug: 194781951
Test: manual

Change-Id: I510dcd3b405988320052944b412e1d18360144ef
2021-08-13 10:50:21 -04:00
Dave Mankoff 630ae94833 Pass main executor to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I1667023887e0c8d1dc86fce1717a3032b6721684
2021-08-13 10:18:01 -04:00
Dave Mankoff 1d5e1dc8d1 Pass Executor to to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I6dc699869d041aab8f5d1e7a128b4f67adfd78dc
2021-08-13 10:16:09 -04:00
Dave Mankoff 13f50b9898 Changes to the signature of PluginManagerImpl.
Bug: 194781951
Test: manual
Change-Id: Iafc5232dfdb1cc1c554de925c2f0d2ad5f6439e2
2021-08-13 10:01:42 -04:00
Ben Lin 99b5d13952 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev 2021-08-13 01:09:19 +00:00
Ben Lin 1e49216401 Do not set user active hints when Shell Transition is on.
Previously, we hint at user active in order to let the launcher know at
an earlier time that the user is about to go home, to provide PiP a
shelf offset. However with Shell Transitions, this is now being done
instantly as the launcher activity is resumed right as user touches down
on the gesture pill. We then no longer need this for shell transitions.

Bug: 165793917
Test: Enable Shell Transitions, go home to enter PIP, and open another
app - see that PIP auto moves downward now that shelf height has changed

Change-Id: I347c885425ce820a42ebfcc15082862d04aa1a7d
2021-08-12 15:17:31 -07:00
Alex Chau 2886a13d7a Clean up test logging and ScreenRecord
Bug: 194114179
Bug: 193125090
Test: manual
Change-Id: I086d011a39b74a24d5629d43dc74b741fcf5994e
2021-08-12 11:34:27 +01:00
vadimt 714d071f76 Removing old workaround
Test: presubmit
Bug: 165029151
Change-Id: I5a64c6e381c0bbbf849658648bd5b75a1e660381
2021-08-11 15:44:39 -07:00
vadimt c353b1adb2 Removing old workaround
Bug: 139137636
Test: presubmit
Change-Id: Iaa307c3d58f76ab7ee3b0a4a4a364b2b97d0efb7
2021-08-11 15:06:07 -07:00