Commit Graph

73572 Commits

Author SHA1 Message Date
Android Build Coastguard Worker e63a5f4aef Snap for 11282454 from 7a9686b49d to 24Q2-release
Change-Id: Ic71a3622de684b8f583fbf2e240ee190558d7583
2024-01-06 22:20:48 +00:00
Jagrut Desai 7a9686b49d Merge "Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-01-06 19:11:01 +00:00
Android Build Coastguard Worker 14fc234f24 Snap for 11281094 from ec88372892 to 24Q2-release
Change-Id: I3f06304bb9ad6669f3b2914a13e2f7f9c3334e49
2024-01-06 02:20:53 +00:00
Brandon Dayauon 8b35defbaf Merge "Fix right-bottom corner edge to curve in PS container." into main 2024-01-06 01:20:04 +00:00
Jagrut Desai 4f56608aec Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Test: Presubmit
Bug: 317798731
Flag: NONE
Change-Id: I05d430a4d8a306b672e89bb3033dfb41bbb9d000
2024-01-05 17:00:53 -08:00
Jagrut Desai ec88372892 Merge "Fixing com.android.launcher3.ui.widget.TaplAddWidgetTest#testDragIcon" into main 2024-01-05 23:34:27 +00:00
Jagrut Desai 21f3d770a0 Merge "Taskbar Pinning Animation Improvements" into main 2024-01-05 23:21:57 +00:00
Tony Wickham 8424eed91a Merge "Fix onIsStashedChanged() not called in 3 button mode" into main 2024-01-05 22:18:18 +00:00
Brandon Dayauon 17477dbf42 Fix right-bottom corner edge to curve in PS container.
This happens when there isn't enough apps to fill in the private space container.

* Added test to check the correct regions are being set depending on the apps in the list.
* Need to set ROUND_BOTTOM_RIGHT to the last app item and the decorator would take care of it.
* Changed to use mNumAppsPerRowAllApps that is already set in ctor.

bug: 316116551
Test: manual/presubmit/photos:
before: https://screenshot.googleplex.com/4Uo5Vtu3a6MDuGa
after: https://screenshot.googleplex.com/878g8yv5LgPsHaL
Flag: None
Change-Id: Ic481628b824c75e5578f3129e3a48f575c6a3655
2024-01-05 13:54:46 -08:00
Tracy Zhou 899c28193c Merge "Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig" into main 2024-01-05 21:20:33 +00:00
Liran Binyamin fdc5c72aa1 Merge "Add a test for stashed bubble bar" into main 2024-01-05 21:19:19 +00:00
Jagrut Desai a3d3c06967 Taskbar Pinning Animation Improvements
Test: Manual
Bug: 312178646
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I708127be8301a61994168f780474c75be726815d
2024-01-05 12:12:12 -08:00
Tony Wickham 438e6c90af Fix onIsStashedChanged() not called in 3 button mode
Calling this ensures we update touchableRegion accordingly.

Since this will also start the stashed handle region sampling,
which we don't need for 3 button mode, also adjust logic to
check that the StashedHandleView is actually visible.

Flag: None
Test: Lock screen, run `adb shell cmd uimode night yes`, unlock
Test: Lock screen, rotate, unlock
  In both cases, verify touchableRegion is accurate
Fixes: 315393203
Change-Id: I951af6b97cad0ee0f362dc22f3996cfd9286a21e
2024-01-05 19:19:57 +00:00
Vadim Tryshev 8d42081b23 Merge "Waiting for Normal state after dismissing Home AllApps by touching outside" into main 2024-01-05 18:59:51 +00:00
Vadim Tryshev c8e6763fbb Merge "Waiting for AllApps state when opening all apps with keyboard" into main 2024-01-05 18:59:45 +00:00
Jagrut Desai ad88561612 Merge "Migrating Tapl Overview test to platform scenario project" into main 2024-01-05 18:53:24 +00:00
Tracy Zhou ef8e4e2e77 Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig
It's merged with split_contextual in ag/25511408

Bug: 270394122
Test: N/A
Change-Id: Idabddee7c566ec426be744261ff50d7b360e2afa
2024-01-05 10:45:22 -08:00
Jordan Silva 49374a905d Merge "Reduce the iconSize to fit inside the cellSize when display size largest" into main 2024-01-05 18:33:40 +00:00
Jagrut Desai a7cf2ac11b Fixing com.android.launcher3.ui.widget.TaplAddWidgetTest#testDragIcon
Test: Presubmit
Bug: 316910614
Flag: NONE
Change-Id: I7728664ddae5538dabaa8a78de6c4c3b84e3c2d6
2024-01-05 10:00:22 -08:00
Jordan Silva 10ce3f5fe2 Reduce the iconSize to fit inside the cellSize when display size largest
For some cases, even after reducing the iconSize and iconTextSize the content of the cell does not fit inside the cell height. This issue leads the icons or labels of the folders and workspace to crop. To prevent the icons of cropping when the display size or font size is largest (for acessibility) we allow the icons and labels shrink until it fits inside the defined cell height.

Bug: 314285621
Bug: 316087877
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Change-Id: Id8da3ee89658b9fc53a36d8605b9bd56ce168834
2024-01-05 13:24:32 -03:00
Charlie Anderson 67636269dd add metrics for when db grid migration fails
Flag: ACONFIG enable_launcher_br_metrics TEAMFOOD
Test: locally verified
Bug: 307527314

Change-Id: Iab84a337d76d63bb3bc2ed81fdf4b6fd50dc5661
2024-01-05 10:48:40 -05:00
Liran Binyamin 40c1b93aee Add a test for stashed bubble bar
This change introduces a new test protocol event for unstashing the bubble bar.

It's not possible to do this via a UI event because the stashed handle is only visible when an app is in the foreground, but in that state none of the elements in TaskbarDragLayer are visible to accessbility.

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Change-Id: I4581bf95b07691429966ecbd573232047f820b69
2024-01-05 08:49:27 -05:00
Sergey Pinkevich 0f8d28024e Merge "Java crash on RecentsView.isTaskViewVisible method" into main 2024-01-05 11:34:55 +00:00
Jakob Schneider b88ba19233 Merge "Add support for progress bar during unarchival of app." into main 2024-01-05 10:21:58 +00:00
Vadim Tryshev 6a8a4ba0b8 Merge "Waiting for Split Select state after tapping split menu item" into main 2024-01-05 03:09:54 +00:00
Charlie Anderson 6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Jagrut Desai 71e8dcca46 Migrating Tapl Overview test to platform scenario project
- Removes tapl overview test form platinum test suite
 - adds individual overview test to platform scenario test.

Test: Presubmit, Manual
Bug: 303256981
Flag: NONE
Change-Id: I7d04dc5dc63ba3a5e63ad03d98760dbd24c974f8
2024-01-04 16:25:17 -08:00
Android Build Coastguard Worker 29c637b277 Snap for 11275524 from 852a70f994 to 24Q2-release
Change-Id: I94c1f3c4dc5c27b9cfddb13e867ec5e2c29b7487
2024-01-05 00:20:54 +00:00
Sunny Goyal 1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Vadim Tryshev 710634b192 Merge "Explicitly waiting for Launcher to restart after enabling test content provider" into main 2024-01-04 23:11:24 +00:00
Vadim Tryshev 25c1b792d8 Waiting for AllApps state when opening all apps with keyboard
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idc17322fc8c22cd3fdcfe459e012bd04bc98b071
2024-01-04 15:06:00 -08:00
Vadim Tryshev 5675734d97 Waiting for Split Select state after tapping split menu item
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I54edb4e2b79c5dae0acedecae0f0b858a2ed0ddb
2024-01-04 14:58:05 -08:00
Charlie Anderson a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Charlie Anderson f0b1ddc038 Merge "Adds restore metrics to RestoreDbTask.java" into main 2024-01-04 22:25:09 +00:00
Vadim Tryshev b2d111d90c Waiting for Normal state after dismissing Home AllApps by touching outside
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I4fc90a791d0264aee3b81306fdb1b15814dccfd8
2024-01-04 14:14:13 -08:00
Andy Wickham 93504b4225 Merge "Ensure header view expected height accounts for tabs." into main 2024-01-04 21:32:13 +00:00
Vadim Tryshev d151784801 Explicitly waiting for Launcher to restart after enabling test content provider
I hope that this will prevent diagnostics that the Launcher has restated during the test.

This CL is a partial revert of ag/25428448

Bug: 314809015
Test: presubmit
Flag: N/A
Change-Id: I52f9641a5efcb67465794abca4f8ead621fad434
2024-01-04 21:09:59 +00:00
Johannes Gallmann 852a70f994 Merge "Hide app icon during predictive back to home" into main 2024-01-04 19:39:05 +00:00
Sergey Pinkevich f78644b4eb Merge "Revert "Wrong app icon position in seascape mode for RTL layout"" into main 2024-01-04 17:54:32 +00:00
Tony Wickham 97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal 4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Sergey Pinkevich 387e99f4bc Revert "Wrong app icon position in seascape mode for RTL layout"
This reverts commit 9b6587d80f.

Reason for revert: Show app icons in wrong order

Change-Id: I0fcc6b6f6431a8e596a504f5f7eb2c2d533be887
2024-01-04 14:54:30 +00:00
Jordan Silva 873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Jordan Silva 9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Sergey Pinkevich e8f4fbf012 Merge "Wrong app icon position in seascape mode for RTL layout" into main 2024-01-04 12:07:40 +00:00
Vinit Nayak e4b5ab6523 Merge "Null out launcher reference to prevent leak" into main 2024-01-04 00:59:28 +00:00
Andy Wickham f495102326 Ensure header view expected height accounts for tabs.
This was already handled except for the case where there were no
predicted apps and no all apps divider, i.e. suggested apps are
disabled and a work profile is added (so tabs show instead of the
divider).

Why did the other cases work? Predicted apps and the divider are
FloatingHeaderRows which call FloatingHeaderView#onHeightUpdated
whenever they are updated (triggering updateExpectedHeight()).

And why did this sometimes "fix itself" until a reboot? When the
search bar is tapped, the search transition causes the expected
height to be updated. So that is my guess.

The key to this change is to wait to update the expected height
until after we have defined mTabsHidden during setup(). It is
normal for the header to be initialized without tabs and then
updated to show the tabs when the work apps are available. So
this was previously incorrectly using mTabsHidden=true for the
calculations.

Fix: 245516031
Test: Manual (force stop launcher and verify tabs scroll correctly)
Flag: NA
Change-Id: Ifcc2f39649c5494b5f3ebefc1cdddfbefbe5d9a0
2024-01-03 18:54:24 -06:00
Android Build Coastguard Worker 8a1b1ad341 Snap for 11270238 from e1c3332532 to 24Q2-release
Change-Id: I70819384943a9d2e2ee6bf1264bcc1e65a2fe87d
2024-01-04 00:21:15 +00:00
Tony Wickham c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vinit Nayak e363a611d2 Null out launcher reference to prevent leak
Bug: 314806687
Flag: None
Test: Enabled flag and played with taskbar/home transitions,
seemed fine

Change-Id: I86ab417eccf1fd6255195025890a1b93bf5d3bb4
2024-01-03 15:08:47 -08:00