Commit Graph

34630 Commits

Author SHA1 Message Date
Pinyao Ting 0d97f8d19a Disable Database overwrite upon restore
Launcher overwrites user's favorites table (icons in WorkSpace) upon new
install session from Play Store with install reason being restore. The
overwrite was introduced in the attempt to mitigate failed restore
session due to asynchronous nature of user profile restore, but it has
been causing general instability in backup and restore. Going forward
Launcher should be moving away from table overwrite approach, this will
be implemented in b/148284747.

Bug: 171774227
Test: manual
Change-Id: I91221544dbaeb42224ce9f595906b6d9f0e4aa89
2020-12-05 07:05:12 -08:00
Hongwei Wang f4b60d5f9c Add ROTATE_SURFACE_FLINGER permission to Launcher
This permission is requried for arbitrary rotation (other than 90
degreee) on a Surface. Which is useful for Launcher to rotate the app
leash when animating from fullscreen landscape to PiP window onto home
in portrait mode.

Bug: 171802909
Test: m -j
Change-Id: I09e3b2915c17154ef3c91aff888a391dc337a18a
2020-12-04 16:40:13 -08:00
vadimt 1e71ba5b98 Moving removing task after QS to a background thread.
Blocking binder call was creating jank.

Test: manual, presubmit
Bug: 173467481, 173072373
Change-Id: Ib19d2a97ed8cf3e9763008b042ef48d89532cb58
2020-12-04 14:18:52 -08:00
Vadim Tryshev 2fe8e76bd1 Merge "Jank: not blocking UI thread when starting a task" 2020-12-03 23:40:23 +00:00
Xin Li 71d4d3299b [automerger skipped] Merge rvc-qpr-dev-plus-aosp-without-vendor@6881855 am: ecb18a6573 -s ours am: 89962500fb -s ours
am skip reason: Change-Id I56abeae5adec79a1c7bdad1a261f0f62c055cf2e with SHA-1 b3ab1189d2 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13122822

Change-Id: I53d2916c3602028ae40c6350424fab176db1e7f7
2020-12-03 04:39:35 +00:00
Xin Li 89962500fb [automerger skipped] Merge rvc-qpr-dev-plus-aosp-without-vendor@6881855 am: ecb18a6573 -s ours
am skip reason: Change-Id I56abeae5adec79a1c7bdad1a261f0f62c055cf2e with SHA-1 b3ab1189d2 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13122822

Change-Id: Id25ecb094b953989fe20b66838d721d57852b608
2020-12-03 04:25:15 +00:00
Jon Spivack 446daa2678 Merge "Add the Share App system shortcut to the Go Launcher" 2020-12-02 23:29:33 +00:00
Schneider Victor-tulias f0d79cbac1 Merge "Disable app theme crossfade animation." 2020-12-02 16:02:30 +00:00
android-build-team Robot a4e9e2d132 Snap for 7004988 from ec5e095430 to rvc-qpr2-release
Change-Id: Id60dafadba144629dc47f2dee9db453da39a9fd7
2020-12-02 00:07:26 +00:00
Tracy Zhou 620c249929 Merge "Log grid size change" 2020-12-01 16:50:43 +00:00
icechang 212cff1dec Add swipes left method in Background.java
Bug: 153276032
Test: TF_GLOBAL_CONFIG=/google/src/cloud/<ldap>/<workspace>/google3/wireless/android/test_tools/forrest/configs/local-host-config.xml \
pts-tradefed run commandAndExit cuj/<testname> \
--primary-abi-only \
--log-level verbose --log-level-display verbose \
--wifi-network GoogleGuest

Test:

Change-Id: Ib1cbc609f47a547f173e8170f00af9e8bdfa77bb
2020-12-01 21:34:26 +08:00
Jason Chang 5feda22006 Merge "Fix abnormal flicking when swiping up to exit OHM" 2020-12-01 07:41:09 +00:00
Jon Spivack a89a5084f2 Add the Share App system shortcut to the Go Launcher
This shortcut allows users to initiate peer-to-peer app sharing from an app's long-press menu on the home screen. It does so by passing an intent to the specified component. In this base implementation, that specification in config.xml is left blank, and the button will not appear. In GMS Launchers such as LauncherGoGoogle, the config should be set to point to Nearby Sharing.

This also establishes Launcher3QuickStepGo as a distinct subclass of QuickstepLauncher instead of merely a build configuration.

Bug: 157515296
Bug: 174286192
Test: Manual (tested on local wembley devices)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I826bd03721d2e7e963b15d5958e9a18a1cc16f1d
2020-11-30 18:53:56 -08:00
Samuel Fufa 870d733617 [automerger skipped] [DO NOT MERGE] Encode launch location for hotseat items am: ec5e095430 am: 3a1286108c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13112292

Change-Id: I9d37ae71e11e4b72756b51907d63837b31c9b342
2020-11-30 23:47:48 +00:00
Samuel Fufa 3a1286108c [DO NOT MERGE] Encode launch location for hotseat items am: ec5e095430
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13112292

Change-Id: Ib1204c9794548cc1c1ba45957686b14cc755565c
2020-11-30 23:29:25 +00:00
TreeHugger Robot 20decea517 Merge "Removing binder call from the gesture injection" 2020-11-30 21:49:21 +00:00
Jason Chang e08dd5861e Fix abnormal flicking when swiping up to exit OHM
Defer the action of onStopGestureDetected() from ACTION_MOVE
to ACTION_UP in OneHandedInputConsumer.

Bug: 171307756

Test: manual
Change-Id: Ie4a3cb0ba4477c131191a7ed1cf4daec2d364285
2020-11-27 18:03:33 +08:00
TreeHugger Robot c3a3805301 Merge "Rename flag to remove reference to blocked word." 2020-11-25 22:13:11 +00:00
linalex 8492c67639 [DO NOT MERGE ANYWHERE] Add swipes left method in Background.java
Bug: 153276032
Test: TF_GLOBAL_CONFIG=/google/src/cloud/<ldap>/<workspace>/google3/wireless/android/test_tools/forrest/configs/local-host-config.xml \
pts-tradefed run commandAndExit cuj/<testname> \
--primary-abi-only \
--log-level verbose --log-level-display verbose \
--wifi-network GoogleGuest

Change-Id: Ib1cbc609f47a547f173e8170f00af9e8bdfa77bb
2020-11-25 12:09:31 +08:00
Pinyao Ting 0646dde219 Don't crash Launcher when attempting to endTransaction on an
already-closed DB.

Since the DB is already closed, if we can't end the
transaction, it should not put the code in a bad state.

Bug: 173162852
Test: manually tested backup and restore flow and existing tests
Change-Id: I2692d98f0a8efc8aeb6bfd826fe738e4436c6ee4
2020-11-24 15:16:10 -08:00
Schneider Victor-tulias f6f41535bf Disable app theme crossfade animation.
Pending the resolution of b/172467144, disabling the app theme crossfade animation.

Test: manual
Change-Id: Id18d2022601d7c5d7debb2365d4b65e5fcf6c5a5
2020-11-24 15:03:36 -05:00
Xin Li ecb18a6573 Merge rvc-qpr-dev-plus-aosp-without-vendor@6881855
Bug: 172690556
Merged-In: I56abeae5adec79a1c7bdad1a261f0f62c055cf2e
Change-Id: I2efd8b65312e25c5c96bf36b3c4a655baffe2eaa
2020-11-23 17:13:54 -08:00
Tony Wickham 7199acdbad Add null check to AbstractStateChangeTouchController#onDragEnd()
Fixes: 171444185
Change-Id: I32eec545c849164463e2820603bfb6dc26260f11
2020-11-23 16:09:07 -08:00
TreeHugger Robot 64594c803a Merge "Revert "Add ActivityOptions for SecondDisplayLaucher to launch activity"" 2020-11-23 20:38:50 +00:00
Samuel Fufa ec5e095430 [DO NOT MERGE] Encode launch location for hotseat items
Bug: 162003157
Test: Manual
Change-Id: I18f8f3f431dbabb3d22898d27d70c8730ad0150f
(cherry picked from commit 9b947993be)
2020-11-23 19:39:00 +00:00
TreeHugger Robot cd0c18460a Merge "fix the issue widget id wasn't being migrated in backup" 2020-11-23 17:49:16 +00:00
Sean Stout beb416cd4f Revert "Add ActivityOptions for SecondDisplayLaucher to launch activity"
This reverts commit 3a8075366c.

Reason for revert: This behavior is no longer needed and was requested to be removed here: b/165931807

Change-Id: I3f16528403fb2e33eba620f8082ac2dcbe9591bf
2020-11-23 16:35:53 +00:00
Pierre Barbier de Reuille c63e16f99e Rename flag to remove reference to blocked word.
Change-Id: I145f5dfb2ba020331a4cae3225a4345a6d10233a
2020-11-23 11:16:25 +00:00
vadimt 6b193434ee Jank: not blocking UI thread when starting a task
This created jank at the end of quick switch.
Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db

Change-Id: I96f821013d900ef57d61c462f897cba17f106bb8
2020-11-20 19:48:45 -08:00
TreeHugger Robot f8d7e3428c Merge "Fixing jank in launching app from recents" 2020-11-21 03:38:39 +00:00
Pinyao Ting 7aaaa35501 fix the issue widget id wasn't being migrated in backup
After SuW the favorite table is copied into backup table, but the widget
id in the backup table hasn't been migrated. This introduces general
unstabality and can sometimes leads to the disappearance of widgets
after a restore.

Bug: 171774227
Test: run Backup Restore flows and verified database status with arbitrary
logging

Change-Id: If275a6b5395504d6de90e26c3998f759e797f6e1
2020-11-20 18:18:52 -08:00
Tracy Zhou 5b468d252f Log grid size change
Test: manually make sure that the correct path is fired
Fixes: 173481818
Change-Id: I7dc2143eb9c0527287398590d46fc2408bc47e44
2020-11-20 17:15:30 -08:00
vadimt 6c1fa64a1d Fixing jank in launching app from recents
Moving expensive actions from the last
frame's rendering.

This reduces the max frame time from > 16 ms
to <= 8 ms, which is good for now.

Test: Trace, metrics
Bug: 173640772
Bug: 173072373
Change-Id: I6d06a129f68d9b26f52c773b817558c77604ae5e
2020-11-21 00:09:42 +00:00
TreeHugger Robot b4f5e6f016 Merge "Removing obsolete shadows" 2020-11-20 20:35:43 +00:00
Samuel Fufa cb6ac3df97 Merge "hide app results if app info can't be found" 2020-11-20 16:29:57 +00:00
Samuel Fufa e5d2ad8e34 Even more logs for flaky work test
Bug: 159671700
Change-Id: I009f243b5e3076d15bc89a4755d5ddb9a5b3119e
2020-11-19 22:54:02 +00:00
vadimt daa731f1fe Removing binder call from the gesture injection
This causes jank under lock contention stress.

Test: local
Bug: 173072373
Change-Id: I3a44e510254f6d651cedb91f72e1789ae97d9b67
2020-11-19 22:12:09 +00:00
Samuel Fufa d41dfd3288 hide app results if app info can't be found
Bug: 173673806
Change-Id: I337912a354ba4374240c4be1c3f2595c4228ec74
2020-11-19 12:55:06 -06:00
John Li b43d8fa9a5 Merge "Haptic effect on alphabetical scroll in Pixel Launcher" 2020-11-19 08:15:06 +00:00
Sunny Goyal 3751be0f1c Removing obsolete shadows
Change-Id: I9dcaa69e4e86130642be15e3585f5898dd866839
2020-11-18 21:45:14 +00:00
Tiger Huang 2f4654ee04 Merge "Replace the system UI visibility with appearance (Launcher)" 2020-11-18 13:30:06 +00:00
John Li ce7f9f2ae1 Haptic effect on alphabetical scroll in Pixel Launcher
Bug: 169397156
Test: manual
Change-Id: Id0c51ac9e9ca7d0f3aaf9b490874de6ee0e97a28
2020-11-18 08:13:25 +00:00
Sunny Goyal 8bc273056f Merge "Resolve auto close on widget swipe" 2020-11-18 06:18:14 +00:00
Sreyas 0da8d424e8 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
(cherry picked from commit ed5e43bd25)
2020-11-17 18:46:48 +00:00
Samuel Fufa 2c86122fa4 Resolve auto close on widget swipe
Bug: 172891360
Test: Manual
Change-Id: Icb384b6dc5ec9a29b6a9a7811b862a2d83ca11a7
(cherry picked from commit 5fa6f3ce503cde51687985ebc9dee6f163b9b1ea)
2020-11-17 18:34:46 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 2cd8dd6282 Merge "Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON" into ub-launcher3-master 2020-11-13 19:24:40 +00:00
vadimt 4dd0fb173b Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON
This is a part of Blue Chip de-janking effort and is
a P0 item in our CUJ list.

In the last frame of the app-open animation, we have
a
android.view.IRemoteAnimationFinishedCallback$Stub$Proxy.onAnimationFinished call
which is blocking and prone to lock contention in WindowManager.

Moving the call to after the animation.

Bug: 173072373
Change-Id: If5eb6469900d1892b861eda6d6b4807d90630b6b
2020-11-12 18:42:20 -08:00
Schneider Victor-tulias 64154ead74 Fix hotseat predicted app update regression.
Hotseat predicted app updates were only being allowed then the hotseat was invisible or when the workspace was loading. This was too strict. Changed the logic to ignore hotseat visibility when the workspace is loading, when there are empty spots in the hotseat and when the predicted items are unchanged. This ensures the hotseat always has the intended number of icons and that icons can be updated in-place.

Fixes: 172597819

Demo: https://drive.google.com/file/d/100svnqX048Da7vues2p-vvQNN6sIF8v4/view?usp=sharing
Change-Id: I2f93ff44618c0282a6411918c34d70f75ec73b73
2020-11-12 11:22:53 -05:00
Schneider Victor-tulias 7bbec50031 Fix AllAppsSearchPlugin icon redrawing without special-casing.
Preventing icon animations in deep shortcuts fixed the icon redrawing issue in the all apps search page, however other icons could still be redrawn, yet could not be special-cased without removing icon update animations altogether. Added logic to only animate icon updates outside of the all apps search page.

Demo: https://drive.google.com/file/d/1ReT2O_1tV20terY0Jr1NJGxIxPblHCK4/view?usp=sharing

Change-Id: Ibe0b43801ec5340c3551125aef13170d569d2c55
2020-11-12 10:31:20 -05:00