Commit Graph

34630 Commits

Author SHA1 Message Date
Tony Wickham 79ec120b3f Merge "Fix TaskViewTouchController crash in seascape" 2020-12-15 18:45:15 +00:00
vadimt 0d9cb19453 Checking menu item test to improve test fail diags
Test: atest
Bug: 75641613
Change-Id: Idb5c7fe744e4a3e69ee0fdb59d1a5a58bc6ce0b2
2020-12-14 19:57:59 -08:00
vadimt dad74879cc Using default timeout for 3-button QS
It's 5 sec, and it works better both
for test runs under stress and for
users in the field that invoke the gesture
slowly.

Test: presubmit
Bug: 169221288
Change-Id: If1d04b63e3d490d7865b9141fc3be34a21693c39
2020-12-14 15:42:44 -08:00
Tracy Zhou d0269cd0da Merge "Match the live tile cut out to the correct task view position in landscape mode" 2020-12-14 23:34:39 +00:00
Tracy Zhou 51d9ab7a22 Match the live tile cut out to the correct task view position in landscape mode
Bug: 171838067
Test: test live tile in landscape mode

Change-Id: I12c375305e19917a53e30d9e40dc709f828ad4a6
2020-12-14 13:58:37 -08:00
Sunny Goyal fee1b25fee Fixing PendingArgs not cleared when going home
Bug: 174781600
Test: manual
Change-Id: I2f192b0f60d843b49b290fa70b76f562fca81e36
2020-12-14 12:30:47 -08:00
TreeHugger Robot e1358149fc Merge "Removing unused tracing" 2020-12-14 18:21:37 +00:00
Ice Chang feb22118bf Merge "Add swipes left method in Background.java" 2020-12-12 16:33:16 +00:00
TreeHugger Robot 04099cdabe Merge "Add FeatureFlag for ENABLE_FOUR_COLUMNS." 2020-12-12 10:31:41 +00:00
vadimt c610f26404 Removing unused tracing
Test: presubmit
Bug: 139891609
Change-Id: I30b432d329d6606b3d955409c167bddbacce8a37
2020-12-11 19:43:49 -08:00
Tony Wickham e3386502cf Fix TaskViewTouchController crash in seascape
Previously, we were using scroll direction POSITIVE as a catch all
to mean "up" but in seascape, we actually want NEGATIVE. Added
getUpDirection() to capture that. Tried to clarify the code a bit
by putting all the methods used solely by TaskViewTouchController
together with documentation. It's still pretty confusing and feels
redundant, but couldn't think of an obvious way to simplify.

Test: Swipe up and down on a task in all permutations of:
- 3 button mode
- Gesture navigation
- Portrait
- Landscape
- Seascape
- LTR
- RTL
- Home rotation allowed
- Home rotation disallowed

Fixes: 174009771
Fixes: 173567204
Change-Id: Id0f8d6f4365d888eb46182d8544d18206795dfb8
2020-12-11 17:30:41 -08:00
TreeHugger Robot 3b83609977 Merge "Not using blocking call to populate task title for logging" 2020-12-11 23:38:44 +00:00
TreeHugger Robot 38cdbb4690 Merge "Add null check to AbstractStateChangeTouchController#onDragEnd()" 2020-12-11 22:57:44 +00:00
TreeHugger Robot 04ed82860e Merge "Jank: taking screenshot in helper thread for quick switch" 2020-12-11 22:44:42 +00:00
Jon Miranda 73dcc9878d Add FeatureFlag for ENABLE_FOUR_COLUMNS.
Will be paired with new device profile used to dogfood
upcoming grid changes.

Bug: 175329686
Change-Id: Iab08d9ed0dec14fd6a05c4485ac4e066533d2540
2020-12-11 14:19:13 -08:00
TreeHugger Robot ef9f1e0af5 Merge "Adding tracing for app-to-overview" 2020-12-11 19:25:06 +00:00
Sunny Goyal e98f980a98 Ignoring crash if the 3p icon surface is no longer valid
Test: Verified on device locally
Change-Id: I5684731c3a66d5690f83878f3c4726d859349bd4
2020-12-10 16:59:28 -08:00
Sunny Goyal cfcefb0c47 Synchronizing model data access
Test: Presubmit
Bug: 173328873
Change-Id: Ifc1724e17ebfa2ee5f21bb3f272986b8a14fdbc1
2020-12-10 16:24:19 -08:00
android-build-team Robot 6c9849a0e8 Snap for 7025657 from 980c089d2f to rvc-qpr2-release
Change-Id: I51306b58d8fe57bb04c4d01fec956ffe1589048a
2020-12-11 00:08:01 +00:00
Samuel Fufa 06ade42dd7 Merge "Resolve Flaky work tab tests" 2020-12-10 23:49:34 +00:00
vadimt 4b77e83a42 Not using blocking call to populate task title for logging
For now, passing null title

Bug: 175048504, 173072373
Test: presubmit
Change-Id: Ia2ed5433be9490d71786c98b8244f1c76e4e3088
2020-12-10 23:47:12 +00:00
vadimt 5794fa1aba Jank: taking screenshot in helper thread for quick switch
This operation is prone to lock contention.

Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db
2020-12-10 12:48:05 -08:00
TreeHugger Robot cbf8fe08da Merge "Moving removing task after QS to a background thread." 2020-12-10 20:34:15 +00:00
Samuel Fufa b8df6a573a Resolve Flaky work tab tests
In cases where test execution and launcher relayout overlap, mLauncher.getAppsView().getContentView() returns a recyclerview instead of pagedView. This is resolved when rebindAdapters is later called with showTabs=true. The issue here is we are keeping a stale value of mLauncher.getAppsView().getContentView() in WorkEduView which is problematic as pagedView is required to set the right tab index for the test.

This behavior also affects work testWorkEduIntermittent as we need to verify the a pagedView is visible before text execution.
Bug: 149867607
Bug: 159671700
Test: flake -t com.android.launcher3.ui.WorkTabTest

Change-Id: I4b0968d6b9daa5c8fe741d4b1ed090f9c7acabed
2020-12-10 11:02:13 -06:00
Hyunyoung Song e387285f0f Merge "Fix NPE inside SEarchResultThumbnailView on cropping Bug: 175161949 Test: builds. Created screenshot of landscape portion and verified" 2020-12-10 05:53:19 +00:00
Xin Li c45d46054f [automerger skipped] Merge "DO NOT MERGE - Merge Android R QPR1" am: 053a3415fe -s ours am: 49665ae5f9 -s ours am: dc0b212582 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1521195

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I67d4293ee3e14dcc1dbdd059e777243a7774c7e6
2020-12-10 03:58:46 +00:00
Sunny Goyal da134ae0c4 [automerger skipped] [DO NOT MERGE] Keeping Launcher in overview UI if activity is restarting am: 980c089d2f am: 05d2ab3f68 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13192821

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ia99f7dce294fb45331902082026838214172f552
2020-12-10 03:55:26 +00:00
Xin Li dc0b212582 [automerger skipped] Merge "DO NOT MERGE - Merge Android R QPR1" am: 053a3415fe -s ours am: 49665ae5f9 -s ours
am skip reason: Change-Id I2efd8b65312e25c5c96bf36b3c4a655baffe2eaa with SHA-1 ecb18a6573 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1521195

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ib590035a7b3f124b2a767279623d51bc8c0dbd18
2020-12-10 03:46:46 +00:00
Sunny Goyal 05d2ab3f68 [DO NOT MERGE] Keeping Launcher in overview UI if activity is restarting am: 980c089d2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13192821

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Id2a3c6c21c3c00464fa0384d5f78943cbbbe8e97
2020-12-10 03:35:50 +00:00
Xin Li 49665ae5f9 [automerger skipped] Merge "DO NOT MERGE - Merge Android R QPR1" am: 053a3415fe -s ours
am skip reason: Change-Id I2efd8b65312e25c5c96bf36b3c4a655baffe2eaa with SHA-1 ecb18a6573 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1521195

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I7810ffdbc32a066d249324b95c02ad3c2e74f5b9
2020-12-10 03:04:58 +00:00
Xin Li 053a3415fe Merge "DO NOT MERGE - Merge Android R QPR1" 2020-12-10 02:18:21 +00:00
Hongwei Wang 6bd835ada2 Merge "Add ROTATE_SURFACE_FLINGER permission to Launcher" 2020-12-10 01:56:48 +00:00
Sunny Goyal 980c089d2f [DO NOT MERGE] Keeping Launcher in overview UI if activity is restarting
due to UI mode changes

Test: Verified Launcher behavior locally
Bug: 148988542
Change-Id: Id83e5e0892666af1420e8f8c711b83f1ea355188
(cherry picked from commit 6c0c61acd8)
2020-12-09 23:40:46 +00:00
Sunny Goyal 189fa681b1 Merge "DO NOT MERGE Revert "Handle uiMode changes"" 2020-12-09 22:37:05 +00:00
Hyunyoung Song 4b2403bbdf Fix NPE inside SEarchResultThumbnailView on cropping
Bug: 175161949
Test: builds. Created screenshot of landscape portion and verified

Change-Id: Ib80147bcb40cf73364e8bed91f38019716aa71c8
2020-12-09 14:33:32 -08:00
vadimt 3b55aab715 Adding tracing for app-to-overview
It will help finding jank in the quick switch
scenario.

Also removing tracing for cases when it's done
by the jank monitor.

Test: manual
Bug: 174892351
Change-Id: I16fc784ddb52203dba54eab2700b5a04a10088ff
2020-12-09 12:32:23 -08:00
Samuel Fufa df0ae18170 Merge "Fix flaky enter key" 2020-12-09 20:12:39 +00:00
Sunny Goyal 9b1d362f78 Merge "Keeping Launcher in overview UI if activity is restarting due to UI mode changes" 2020-12-09 19:22:38 +00:00
Samuel Fufa d0ae95aa04 Merge "Separate QSB from on device search" 2020-12-09 18:55:59 +00:00
Samuel Fufa 2ea01e4871 Separate QSB from on device search
Bug: 175125073
[Preview attached to BR]

Change-Id: If967d95e32b58263ede5eb8a3c1b773cef789f28
2020-12-09 12:46:30 -06:00
Tracy Zhou 2268a7cb27 Merge "Render animation for launching settings in live tile mode" 2020-12-09 18:16:35 +00:00
Tracy Zhou f985f13ec1 Render animation for launching settings in live tile mode
Right now the animation is pretty basic. Will need to fine tune it.

Fixes: 172626326
Test: manual
Change-Id: Ibc64f6a988e1c7ad3f32732e1db2f0f29489e3f9
2020-12-09 00:18:00 -08:00
Xin Li 6d9bdefeb2 DO NOT MERGE - Merge Android R QPR1
Bug: 172690556
Merged-In: I2efd8b65312e25c5c96bf36b3c4a655baffe2eaa
Change-Id: I349fad5007e99ec4c02ba78a0c43a913ebba0fda
2020-12-08 23:49:36 -08:00
Winson Chung ff6d94dd92 DO NOT MERGE Revert "Handle uiMode changes"
Bug: 171707437
Test: Repro steps on bug

This reverts commit 0ad7b172e6.

Change-Id: If30cbb6c155e879dc8307a0a4a06dfb548b389a1
(cherry picked from commit 4b4341d3a7)
2020-12-09 07:33:40 +00:00
Sunny Goyal 6c0c61acd8 Keeping Launcher in overview UI if activity is restarting
due to UI mode changes

Test: Verified Launcher behavior locally
Bug: 148988542
Change-Id: Id83e5e0892666af1420e8f8c711b83f1ea355188
2020-12-08 19:22:01 -08:00
Winson Chung c4bef358b0 DO NOT MERGE Revert "Defer recreation until resumed"
Bug: 171707437
Test: Repro steps in bug

This reverts commit 3f8d868110.

Change-Id: I909ab701c674fe975982a7de06dc9e89dcd03aea
(cherry picked from commit 272f4541f9)
2020-12-09 02:50:37 +00:00
Samuel Fufa 1dcf18af6e Fix flaky enter key
Avoid launching market search if highlighted item is SearchTargetHandler

Bug: 174170510
Test: Manual
Change-Id: I1e60168db7a38924cf6fe08ebc7b3ee004dfdd98
2020-12-07 14:28:06 -06:00
Pinyao Ting e676914740 Merge "Disable Database overwrite upon restore" 2020-12-07 19:11:09 +00:00
Schneider Victor-tulias e5764199de Merge "Add the ability to control the mock app thumbnail and app icon to TutorialControllers." 2020-12-07 17:43:04 +00:00
Schneider Victor-tulias 7f66dde4de Add the ability to control the mock app thumbnail and app icon to TutorialControllers.
Giving the gesture nav tutorial sandbox environment a more accurate look and feel requires the ability to inject mock drawables. The choice of drawables should go to TutorialControllers.

Bug: 175019879

Change-Id: Ie5b03b3fa07b017c0596a58dedf65d3e866a0727
2020-12-07 16:27:37 +00:00