Commit Graph

34630 Commits

Author SHA1 Message Date
Pierre Barbier de Reuille 199aec50ad Avoid calling AppWidgetHostViedw#updateAppWidgetSize
We cannot call it anymore, because the system padding is not always
used.

Bug: 191612352
Test: Manually, using CtsVerifier and dedicated widgets
Change-Id: I06353ba49a8e62127e593cdbcb86fadcf89ecb24
2021-07-02 10:03:44 +01:00
Tracy Zhou 3022d5f9f3 [automerger skipped] Enable live tile in 3 button mode am: 1fe5fda3d8 -s ours
am skip reason: Merged-In Iffaea18afb2179b5bb7dadda49e56efefa5658bc with SHA-1 d09ebe660f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14254546

Change-Id: I1c104b0ff71d9a9571a3be3da019d600e948fab7
2021-07-02 06:52:37 +00:00
Tracy Zhou d2039614e0 Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00
Hyunyoung Song 9804c0472e Fix NPE inside dispatchRestoreInstanceState
Bug: 192559704
Test: manual
Change-Id: I212518ac4a7feddd8e87f4be601332ea62e99313
2021-07-01 23:26:57 -07:00
Tracy Zhou 1fe5fda3d8 Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Tracy Zhou d09ebe660f Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-01 18:40:56 -07:00
Alex Chau e526fd6a00 Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270

Change-Id: I4cc43374c577299c7be3d63bb8a7393a90447231
2021-07-01 22:28:30 +00:00
Alex Chau 679f8bb9ca Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev 2021-07-01 22:12:54 +00:00
Tracy Zhou 1dd0ca7bec [automerger skipped] Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev am: e54f789de9 -s ours
am skip reason: skipped by user tracyzhou

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15176734

Change-Id: Ic5c12013c702c683417ab706c06d6c71b26ecb4f
2021-07-01 20:15:54 +00:00
Tracy Zhou e54f789de9 Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev 2021-07-01 19:32:39 +00:00
Jonathan Miranda e6f0509d1d Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770

Change-Id: I38ace4adec4591e9259a8859ed547e1b951b922c
2021-07-01 18:36:20 +00:00
Jonathan Miranda aa560506ba Merge "Cancel existing preview item animation during non-animated update." into sc-dev am: 81501a563c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164771

Change-Id: I667763f65219cf259b8cf0db929d7dc0c848163e
2021-07-01 18:36:16 +00:00
Jonathan Miranda 3334c32120 Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev 2021-07-01 18:34:47 +00:00
Jonathan Miranda 81501a563c Merge "Cancel existing preview item animation during non-animated update." into sc-dev 2021-07-01 18:32:49 +00:00
Sunny Goyal 2e5176e51f Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037

Change-Id: I3e8d01451a9ad4b14128bf90a9d758e922d04f4e
2021-07-01 18:32:02 +00:00
Sunny Goyal f3d3dcf4a1 Merge "Fixing some dimentions in AllSet activity" into sc-dev 2021-07-01 18:16:45 +00:00
Tracy Zhou 99adef95b3 Do not switch to screenshot and finish recents animation for menu options that already do so
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.

Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Alex Chau e0fcee01b3 Restore previous currentPage in applyLoadPlan in case task is re-ordered
Fix: 186537288
Test: Repeatededly launch task from home and swipe to home, animation is correct
Test: Quick switch, launch task then swipe up, there is no jump
Change-Id: I9fd7416d9811ce4e54a1c6d20374d89d00417cd5
2021-07-01 18:43:20 +01:00
Tony Wickham 5fac02bc5e Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.

- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: I7b5fb3d21ab7a7a7044fcec7f2c1e39afe23c5dd
2021-07-01 07:39:59 -10:00
Winson Chung 2ae6a3e3c9 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: I4183018dbe6ad644824f842cae259ab0786c9657
2021-07-01 17:15:48 +00:00
Cyrus Boadway 270a9c734f Merge "Use nullable field and boolean rather than optional" into sc-dev am: 048a858575
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15171711

Change-Id: I6b6b6bf2ecb367f81fdb82321c7e7bb3cd8a228a
2021-07-01 17:15:38 +00:00
Winson Chung eb0a38c5f2 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev 2021-07-01 17:11:35 +00:00
Winson Chung 6a777d84b8 Remove unused logs
Bug: 191698994
Test: Just removing logs
Change-Id: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
Merged-In: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
2021-07-01 17:09:40 +00:00
Winson Chung efa5e9f5ea Merge "Remove unused logs" into sc-v2-dev 2021-07-01 17:09:22 +00:00
Cyrus Boadway 048a858575 Merge "Use nullable field and boolean rather than optional" into sc-dev 2021-07-01 16:57:24 +00:00
Samuel Fufa 1d7a4410e3 Merge "Polish changes for work tab" into sc-dev am: 9010e773e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15157942

Change-Id: Ic3aa2d63e943b41eb65517d2f25154128edb0432
2021-07-01 16:43:29 +00:00
Samuel Fufa 9010e773e4 Merge "Polish changes for work tab" into sc-dev 2021-07-01 16:30:39 +00:00
Cyrus Boadway 551b4297ed Use nullable field and boolean rather than optional
Optional won't hold null parameters, so use a boolean flag and
colorschange fields to represent the value and whether changes are
present.

Bug: 190818220
Test: manual
Change-Id: I794507340345864e73f04039f12a035c8053fd96
2021-07-01 15:05:43 +00:00
Alina Zaidi f03b1aeeb6 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev am: eefccccb19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15155531

Change-Id: I92c997fbd0d0f47e78e5169e8cad9938bd2af0a0
2021-07-01 11:52:05 +00:00
Steven Ng 5dce7fef9b [automerger skipped] Merge "Fix widget animation truncated at drop if a widget is resized" into sc-dev am: d9128413cc -s ours
am skip reason: Merged-In I901743f8ba392de37f3ef69ca386c4b36bfebd7f with SHA-1 39a87fda17 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15159890

Change-Id: I3608ee9892ecc3b99ab6f2a83667161ea9ef566e
2021-07-01 11:52:01 +00:00
Pierre Barbier de Reuille 2fa6e35341 Merge "resolve merge conflicts of 25e37a85ae to sc-v2-dev" into sc-v2-dev 2021-07-01 11:50:42 +00:00
Alina Zaidi eefccccb19 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev 2021-07-01 11:10:26 +00:00
Steven Ng d9128413cc Merge "Fix widget animation truncated at drop if a widget is resized" into sc-dev 2021-07-01 10:29:49 +00:00
Pierre Barbier de Reuille 41f78f1e13 resolve merge conflicts of 25e37a85ae to sc-v2-dev
Change-Id: I78062d68d051a5f3c369214929f569b17c5a3471
Fix: 192532604
Bug: 192354264
Test: Manual
Merged-In: If573641e4bb5a98ed6b5008e00f70f4bbe492c24
2021-07-01 09:47:10 +00:00
Steven Ng 39a87fda17 Fix widget animation truncated at drop if a widget is resized
Set the widget outline to DragView rather than the content view
hosting a Picture record of AppWidgetHostView at drop.

Bug: 191646816
Test: Manual
Change-Id: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
Merged-In: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
2021-07-01 09:22:25 +00:00
Alina Zaidi 1b5efa3216 Reduce margin for DropTargetBar to avoid buttons to be truncated.
Bug: 187036287
Test: Tested manually by QA testing team on 4X5 grid size
Change-Id: Iaa4cd3e464ccf50427a5aa96d97093601e1d2948
2021-07-01 09:50:46 +01:00
TreeHugger Robot 25e37a85ae Merge "Correct color extraction on App Widget drop." into sc-dev 2021-07-01 08:31:16 +00:00
Winson Chung 8185663b6e Remove unused logs
Bug: 191698994
Test: Just removing logs
Change-Id: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
2021-07-01 04:44:04 +00:00
Vinit Nayak 837359b1ea Set correct divider dimension for task menu options
Previously divider drawable dimension was set on height,
which only works when things are divided vertically.
For horizontal layouts, we need to set divider width.

Bug: 192398954
Test: Tested portrait + fake/real landscape
+ tablet

Change-Id: I5a63df9749bf37c3a563e923a1b4724aa17d9409
2021-07-01 02:05:42 +00:00
Tracy Zhou d25ee3294c Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev 2021-07-01 01:11:11 +00:00
Jon Miranda 2cc33ed29a Cancel existing preview item animation during non-animated update.
Otherwise we end up in a bad folder icon state.

Bug: 191227370
Test: Drag icon out of folder bounds,
      Suddenly drop it so its forced to go back to the folder
      Close folder before the animation finishes

Change-Id: Ib751a8209d66c5e9772731fdc1d7f365ae47531a
2021-06-30 17:59:17 -07:00
Jon Miranda 17cc821c28 Fix bug where app icon is gone for first frame on cold start.
We need the icon to be full alpha during the init pass, then when
the actual animation starts, we can swap the icon with the window
(splash screen that draws the icon).

Bug: 192366079
Test: slow down window animations
      check no empty frame on cold start app launch
      check no empty frame on warm start app launch

Change-Id: I16a1779e5252d8e88bc3c408e1dc40b264fe4cf4
2021-07-01 00:11:41 +00:00
Vadim Tryshev 93eac82376 Merge "Converting some TAPL sequence mismatches to human-readable diags." into sc-dev am: eead98d493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15150391

Change-Id: I56e042d5f646cd13058f7e5127faf4cdd81d17a1
2021-06-30 23:17:22 +00:00
Vadim Tryshev eead98d493 Merge "Converting some TAPL sequence mismatches to human-readable diags." into sc-dev 2021-06-30 23:03:34 +00:00
vadimt 4903c7823e Converting some TAPL sequence mismatches to human-readable diags.
Test: local runs
Bug: 187761685
Change-Id: Ie2c64a22f56b0bed1cd175486b42beedb06285cc
2021-06-30 13:58:02 -07:00
Steven Ng 12b0dfb826 Fix widget animation truncated at drop if a widget is resized
Set the widget outline to DragView rather than the content view
hosting a Picture record of AppWidgetHostView at drop.

Fix: 191646816
Test: Manual
Change-Id: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
Merged-In: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
2021-06-30 20:47:57 +00:00
Vadim Tryshev 0c3a3125a5 Merge "Verifying success of setting default Launcher in tests" into sc-dev am: ba302e8a6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15158349

Change-Id: I45b7cdf29ea93351fb2a47a7ec207739de5e3745
2021-06-30 20:44:53 +00:00
Vadim Tryshev ba302e8a6a Merge "Verifying success of setting default Launcher in tests" into sc-dev 2021-06-30 20:43:36 +00:00
Brian Isganitis bb6b8eef8f [automerger skipped] Merge "Intercept touch events for launcher preview root view" into sc-dev am: e99ed7b9d1 -s ours
am skip reason: Merged-In I98d462eca699cf368dcd5894f15584f280932ccc with SHA-1 3b39f3164b is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15146793

Change-Id: I3d0ce0869b0eeca1785bcc1e8e6547855d0d79d8
2021-06-30 20:39:55 +00:00
Brian Isganitis e99ed7b9d1 Merge "Intercept touch events for launcher preview root view" into sc-dev 2021-06-30 20:36:55 +00:00