TreeHugger Robot
21a4d558c3
Merge "Disabling OverviewActions when rotated." into ub-launcher3-rvc-dev am: c0c0991231
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11710644
Change-Id: Ie2c1fe459d25db2bc4a0229ee2d97e89fe56ebab
2020-06-17 21:01:15 +00:00
TreeHugger Robot
0e938697d6
Merge "Fixing broken tests on 2 and 3 button devices." into ub-launcher3-rvc-dev am: d6e3775726
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11891563
Change-Id: Ie9f00e8e24bd6423cf38f79b03cf7133836e2f8a
2020-06-17 21:01:06 +00:00
Miranda Kephart
1bb17f2658
Merging from ub-launcher3-rvc-dev @ build 6595814 am: efdc4e2318 am: 9cb1795a71 am: ad4bd43b8f am: 9269333de9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885879
Change-Id: Ie7d2e841b2d41504e07633f116d80b4e3adde59f
2020-06-17 20:49:31 +00:00
TreeHugger Robot
c0c0991231
Merge "Disabling OverviewActions when rotated." into ub-launcher3-rvc-dev
2020-06-17 20:40:56 +00:00
TreeHugger Robot
d6e3775726
Merge "Fixing broken tests on 2 and 3 button devices." into ub-launcher3-rvc-dev
2020-06-17 20:38:25 +00:00
Sreyas
f91c1d0ef1
Disabling OverviewActions when rotated.
...
Bug: 157272300
Bug: 159135247
Change-Id: I9c9eeb49b7d18c1c81a830b7a35113070e7ac793
2020-06-17 12:37:14 -07:00
TreeHugger Robot
78d8acf1c5
Merge "Don't reset RecentsView in onIdpChanged()" into ub-launcher3-rvc-dev am: 1f325ab01e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11871905
Change-Id: I3c877043376859877fb87a40b6652ed6e498ad6a
2020-06-17 18:22:58 +00:00
TreeHugger Robot
7abd0ad331
Merge "Replaces StatsLogManager.log with StatsLogManager.logger()" into ub-launcher3-rvc-dev am: 349194569f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11889162
Change-Id: Idaab7cc7d8a6c27f85ee0177e4bc8cbe6f9a6e60
2020-06-17 18:22:45 +00:00
TreeHugger Robot
1f325ab01e
Merge "Don't reset RecentsView in onIdpChanged()" into ub-launcher3-rvc-dev
2020-06-17 18:15:39 +00:00
TreeHugger Robot
349194569f
Merge "Replaces StatsLogManager.log with StatsLogManager.logger()" into ub-launcher3-rvc-dev
2020-06-17 18:11:32 +00:00
Becky Qiu
41a0fa9d88
[Overview Actions] For in-place landscape, add select only when aiai works. am: ff6bc2ab5f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873444
Change-Id: I3de8007af26460090220122c084587014b80b871
2020-06-17 17:42:49 +00:00
Becky Qiu
ff6bc2ab5f
[Overview Actions] For in-place landscape, add select only when aiai works.
...
When display orientation is not the same as device orientation, aiai won't work for select mode highlight. So we should only show the select button in task menu for in-place landscape when the display rotation is the same as the device rotation which is portrait.
Screenshot would be in the task menu for in-place landscape all the time.
Test: demo video: https://drive.google.com/file/d/1OQrjww2lFTTsthz4dB3BSa-jw943KLWp/view?usp=sharing
Change-Id: I58b6f6da234ea36eef0af5bb966c33ebda3625b8
2020-06-17 17:39:56 +00:00
TreeHugger Robot
af2bb8d172
Merge "Fixing OAV buttons not working and removing logs." into ub-launcher3-rvc-dev am: 4de12a2424
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11881553
Change-Id: I1db09fdbaeec0cea24c4d3a36592be3722c4d611
2020-06-17 17:38:02 +00:00
thiruram
c6a38ba5d8
Replaces StatsLogManager.log with StatsLogManager.logger()
...
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
TreeHugger Robot
4de12a2424
Merge "Fixing OAV buttons not working and removing logs." into ub-launcher3-rvc-dev
2020-06-17 17:26:14 +00:00
thiruram
9f66df6b7f
Replace StatsLogManager with builder pattern. am: d8405a63d2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885456
Change-Id: I0a715a3010a4ad9f896e368d61a4f114902f1429
2020-06-17 17:20:54 +00:00
vadimt
d8e5660b13
Fixing broken tests on 2 and 3 button devices.
...
Bug: 143488140
Change-Id: I30886da129825b800984baa08742ac4dfcf4a599
2020-06-17 10:19:51 -07:00
thiruram
d8405a63d2
Replace StatsLogManager with builder pattern.
...
Follow up CLs will remove the deprecating log methods and update their references.
Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Bill Lin
f69563e935
Revert "Update state and touch region after one handed overlay changed"
...
This reverts commit a66dafe617 .
Reason for revert: b/159183864 introduce com.android.launcher3.memory.MemoryTests failed after this CL merged.
Due to I need more time to investigate the root cause and do not block MemoryTests, revert this CL temporary.
Change-Id: I0408123e36c55a262ee0f1080cd6612785b3f527
2020-06-17 11:21:24 +00:00
Vinit Nayak
8401308c14
Don't rely on nav mode change listener for oriented state
...
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.
The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.
Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.
Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
2020-06-16 19:41:16 -07:00
TreeHugger Robot
e328ff79f4
Merge "[Overview Actions] Disable swiping on modal recentsView for talkback." into ub-launcher3-rvc-dev am: cbe1251ce7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11886213
Change-Id: I99c3ff2a23f9ade5b37fa51d8c98954bb19466af
2020-06-16 23:33:50 +00:00
TreeHugger Robot
139b7fc9f2
Merge "Increase Predicted app icon sing size" into ub-launcher3-rvc-dev am: ded59ac331
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885882
Change-Id: Ia707467c3d80c0ae9ea414ec42f84e343e1389df
2020-06-16 23:33:43 +00:00
Samuel Fufa
e8c0f83fb2
Avoid Crash when longpressing disabled predicted item
...
If a view does not handle its long press and return true, View.java calls getParent().showContextMenuForChild(this). However, in Hybrid hotseat case, predicted icons are removed from the hotseat when user long presses an icon. This will result in getParent() returning null.
Bug: 159064799
Change-Id: I80d8f27cbc20b94b0381e767584a1f6854d17e2c
2020-06-16 16:28:37 -07:00
TreeHugger Robot
cbe1251ce7
Merge "[Overview Actions] Disable swiping on modal recentsView for talkback." into ub-launcher3-rvc-dev
2020-06-16 23:23:12 +00:00
TreeHugger Robot
ded59ac331
Merge "Increase Predicted app icon sing size" into ub-launcher3-rvc-dev
2020-06-16 23:18:45 +00:00
Becky Qiu
8798440600
[Overview Actions] Disable swiping on modal recentsView for talkback.
...
When it is select mode, disabling swiping on the parent container for a11y to avoid exiting select mode UI.
This will only disable swiping and talkback on other tasks and the cleanall button, but will keep the modal task container app info and content description, also keep the action buttons description working.
Test: local
Bug: 155947513
Change-Id: I6d513c7eb3e7deeaa233550749f8be0d95e56daf
2020-06-16 15:47:20 -07:00
Tony Wickham
b22770d18f
Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev am: f2b8c927a9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873446
Change-Id: Id5ea73f5285e8d3feac9d73588ee3241eafbe1ae
2020-06-16 22:27:35 +00:00
TreeHugger Robot
86b52bab05
Merge "Create hotseat predictor onCreate" into ub-launcher3-rvc-dev am: 89e39a6dfa
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885442
Change-Id: I2eff9e2abff2530f4f5934d95f9eff2d38297aab
2020-06-16 22:27:25 +00:00
Tony Wickham
f2b8c927a9
Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev
2020-06-16 22:12:28 +00:00
TreeHugger Robot
89e39a6dfa
Merge "Create hotseat predictor onCreate" into ub-launcher3-rvc-dev
2020-06-16 22:11:56 +00:00
Samuel Fufa
eb957403a8
Increase Predicted app icon sing size
...
Bug: 159041772
Change-Id: I0b71c6a2b2da9e4b058554e60cf0c59d242368c6
2020-06-16 14:34:36 -07:00
Samuel Fufa
345f728f2c
Create hotseat predictor onCreate
...
ModelTask posted in setupViews does not get called.
Bug: 159151258
Change-Id: I45bfe7cf8ea18b09faaf3c0e612be90722e1e410
2020-06-16 14:22:02 -07:00
TreeHugger Robot
a336cbe4f5
Merge "Attempt to workaround a leak on Taimen" into ub-launcher3-rvc-dev am: 9354de6c91
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885441
Change-Id: I0455fa144bc241483f1d38a7c6b169e3e0e9b313
2020-06-16 21:11:36 +00:00
TreeHugger Robot
9354de6c91
Merge "Attempt to workaround a leak on Taimen" into ub-launcher3-rvc-dev
2020-06-16 20:58:39 +00:00
Miranda Kephart
efdc4e2318
Merging from ub-launcher3-rvc-dev @ build 6595814
...
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6595814.html
Change-Id: I4be85d0e52cc3cb8801012a7313a269851680c8b
2020-06-16 20:52:28 +00:00
vadimt
6a3de331af
Attempt to workaround a leak on Taimen
...
It's a flake.
It was likely caused by enabling fallback tests, and we don't know
what's leaked and why.
Bug: 143488140
Change-Id: I0d0c88ac9b0de316861f16ba023a596c1f39cde4
2020-06-16 20:21:49 +00:00
Sreyas
826bb2e932
Fixing OAV buttons not working and removing logs.
...
Bug: 154838868
Change-Id: Icde83dc527a1aacf6a8a79325e6a33c5235a64fb
2020-06-16 12:20:25 -07:00
TreeHugger Robot
80f0dc6fed
Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev am: cf4e6cd055
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11872996
Change-Id: I535bdfc4dfb5b6e57b611318c8ef9671fd656f0e
2020-06-16 19:14:03 +00:00
TreeHugger Robot
cf4e6cd055
Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev
2020-06-16 19:00:24 +00:00
Vinit Nayak
746b82e831
Updated recents oriented state on split screen
...
Launcher defaults to sensor rotation when in split
screen instead of the fixed portrait orientation.
We were setting the multi window flag but never
updating RecentsOrientedState's internal state to
reflect it.
Fixes: 158537350
Change-Id: Ib0e1cf4c2e0674a5af41ac11c532a50db0a6f0fa
2020-06-16 11:57:47 -07:00
TreeHugger Robot
1dafdfb572
Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev am: a36605ee90
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11855094
Change-Id: I737466c21e1baad37d83f0b35783baca295a6e4a
2020-06-16 18:36:50 +00:00
TreeHugger Robot
a36605ee90
Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev
2020-06-16 18:20:51 +00:00
Bill Lin
a66dafe617
Update state and touch region after one handed overlay changed
...
The matrix for overall modes x state changes:
-----------------------------------------------------
Mode | State changed | *Before|*After
-----------------------------------------------------
OneHanded | Portrait->Landscape | 80dp | 32dp
OneHanded | Landscape->Portrait | 32dp | 80dp
-----------------------------------------------------
OneHanded | Disable->Enable | 32dp | 32dp
(Landscape)| Enable->Disable | 32dp | 32dp
-----------------------------------------------------
OneHanded | Disable->Enable | 32dp | 80dp
(Portrait) | Enable->Disable | 80dp | 32dp
-----------------------------------------------------
NO_BUTTON | Portrait->Landscape | 32dp | 32dp
NO_BUTTON | Landscape->Portrait | 32dp | 32dp
2 BUTTON | Portrait->Landscape | 48dp | 48dp
2 BUTTON | Landscape->Portrait | 48dp | 48dp
3 BUTTON | Portrait->Landscape | 48dp | 48dp
3 BUTTON | Landscape->Portrait | 48dp | 48dp
-----------------------------------------------------
* dimen : navigation_bar_gesture_height
Test: adb bugrepot | grep mOneHandedModeRegion
Test: manually triger one handed
Test: atest WindowInsetsBehaviorTests
Bug: 157958539
Change-Id: I0f4b5d18053058730a06c3c216e849850c0390f4
2020-06-16 14:11:21 +08:00
Samuel Fufa
523c18d273
Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev am: dc122e816a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11863507
Change-Id: Ic9a5da21bd2900d0dc7348cbdb997e6f876df971
2020-06-16 04:49:34 +00:00
Samuel Fufa
dc122e816a
Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev
2020-06-16 04:41:54 +00:00
Tony Wickham
80846543b5
Fix qsb when flinging to home during gesture to overview from home
...
- AllAppsTransitionController should not animate alphas for atomic
components even when failing fast (we already had this check for
the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
and overview peek anim are finished
Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly
Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa
e9c4f401bd
[WW logging] Log rankings for app launches
...
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
TreeHugger Robot
870764d506
Merge "Add null check before applying fullscreen params" into ub-launcher3-rvc-dev am: eb9f60adab
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873472
Change-Id: I6d02dc367338c96cf041387889d3b5949430ac60
2020-06-15 22:44:54 +00:00
TreeHugger Robot
6cfcd406d0
Merge "fix a11y issue where scroll next can still be triggered on final page in RecentsView" into ub-launcher3-rvc-dev am: 4dc44cb405
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873216
Change-Id: Iea4f9f153302ccdf8ea2fc5769303b40dfb24a6f
2020-06-15 22:44:42 +00:00
TreeHugger Robot
eb9f60adab
Merge "Add null check before applying fullscreen params" into ub-launcher3-rvc-dev
2020-06-15 22:37:26 +00:00