Commit Graph

73814 Commits

Author SHA1 Message Date
Sunny Goyal dff4231a67 Merge "Moving view inflation in Launcher to a separate class" into main 2024-01-25 01:13:12 +00:00
Saumya Prakash 12e11605fe Merge "Allow gesture tutorial to work for both orientations for square aspect ratios." into main 2024-01-25 00:48:50 +00:00
Tony Wickham ff08ceb595 Merge "Promote testQuickSwitchToPreviousAppForTablet to pre-submit" into main 2024-01-25 00:12:52 +00:00
Saumya Prakash e3d14a686a Allow gesture tutorial to work for both orientations for square aspect ratios.
Devices with a square aspect ratio were previously seeing a prompt to rotate the screen for the gesture navigation tutorial. This change enables the tutorial for such devices but will still show the prompt to rotate the device if the aspect ratio would make the tutorial animations look wrong.

Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fix: 321650001
Test: Tried gesture tutorial on various devices of different aspect
ratios and ensured that the prompt to rotate the device only shows up on
devices that do not have a square aspect ratio.

Change-Id: I7a6ca40e09a8202a9b54d898e0c68cc142694342
2024-01-24 23:39:39 +00:00
Sunny Goyal 4e0142328f Moving view inflation in Launcher to a separate class
Bug: 318539160
Test: Presubmit
Flag: None
Change-Id: Iacf9bec39c63cc7a31fae5628bb588ccb765663c
2024-01-24 15:06:31 -08:00
Tracy Zhou e49c26dd79 Merge "Use nearest region for all the nav buttons in 3-button folded mode" into main 2024-01-24 22:12:14 +00:00
Saumya Prakash 59b009e938 Merge "Increase Done button size to be more accessible for the gesture tutorial" into main 2024-01-24 19:35:51 +00:00
Tony Wickham a119f81854 Promote testQuickSwitchToPreviousAppForTablet to pre-submit
Fixes: 314873201
Test: testQuickSwitchToPreviousAppForTablet
Flag: None
Change-Id: I9d6b8b6aa1925f5133269a874cf7ca888c945ed3
2024-01-24 19:32:18 +00:00
Ats Jenk feb2b098cb Merge "Move bubble bar stashed handle to the left for RTL" into main 2024-01-24 19:22:58 +00:00
Tracy Zhou 9c9befae5f Use nearest region for all the nav buttons in 3-button folded mode
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.

Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
2024-01-24 11:06:01 -08:00
Sebastián Franco a37a99a156 Merge "Making sure the reorder animation goes back to the initial position." into main 2024-01-24 17:55:14 +00:00
Vinit Nayak 5f3b761451 Merge "Rename isSplitSelectionEnabled() to isSplitSelectionActive()" into main 2024-01-24 05:53:44 +00:00
Holly Jiuyu Sun e5d943e848 Merge "[PS] Update resource files to include round background." into main 2024-01-24 03:53:28 +00:00
Ats Jenk e1701b05f0 Merge "Skip bubble bar arrow animation if arrow detached" into main 2024-01-24 01:23:49 +00:00
Ats Jenk 14f76fe13b Move bubble bar stashed handle to the left for RTL
When system language is set to an RTL language, we move the bubble bar
to the left.
Move the stashed bubble bar handle to the left in this case.
Tweak the bubble bar expand animation so that the bubbles expand from
the left edge.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: repeat following steps with LTR and RTL system languages
  - add couple of bubbles to bubble bar, open an app, observe stashed
    handle on the left
  - swipe up from system navbar to show taskbar and bubble bar
  - swipe up from bubble bar handle to show bubble bar and expand it
  - drag bubble bar to dismiss target and back out and release
Change-Id: Ia3b7892bba732a5278168d63db0594087f55fad4
2024-01-23 17:16:49 -08:00
Tracy Zhou 05ca003b41 Merge "Do not enter stage split from keyboard shortcuts if the user is already in split" into main 2024-01-24 00:26:31 +00:00
Holly Jiuyu Sun 766b80bb91 Merge "[PS] Log event for private space add button click." into main 2024-01-24 00:03:21 +00:00
Vinit Nayak 7c7ece3efe Rename isSplitSelectionEnabled() to isSplitSelectionActive()
Bug: 295467097
Change-Id: I5c518c3e7227c034956fb92590b7472ba4a71d39
2024-01-23 15:41:14 -08:00
Sebastian Franco e2910d84ee Making sure the reorder animation goes back to the initial position.
The animation ReorderPreviewAnimation handles two animations, one when
the mode is MODE_HINT and the other MODE_PREVIEW. The animation is
basically the same but MODE_PREVIEW ocilates to finalDelta and back
to initDelta. MODE_HINT stays in finalDelta. When finish, we have to
go back to the initial position.

This behaviour is currently done using logic, making sure the view stays
in finalDelta no matter the value of the animation, the bug is in this
logic. I think is better to do this with the current animation API by
setting setRepeatCount to 0 on the HINT case and reverting the animation
when finish so it goes back to the initial position.

This seems to have been there for a long time, at least since the
creating of git_main, but it became more aparent now. In a follow up cl
I will move this class to it's own file and into kotlin to help if there
are issues here again.

Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I4ac5de3ce8a8170944a072c6ce41c65d0963a780
2024-01-23 15:33:49 -08:00
Ats Jenk e0b2ef481c Skip bubble bar arrow animation if arrow detached
Arrow can become detached from the bubble bar background. This can
happen when bubble bar is pinned to the left and the right-most bubble
is selected. When the selected, right-most bubble is removed by drag and
dismiss, the view is removed and bubble bar background is immediately
updated. But we try to animate the arrow to the new selected position.
Before starting to animate arrow position, check if arrow position is
greater than bubble bar width. If it is, the arrow is detached and we
should not try to animate it to the new position. Just move it.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: switch to RTL language, have 3 bubbles in bar, expand and select
  the right-most bubble, then dismiss it via drag, observe arrow jumps
  to new position and does not become detached from background
Test: switch to LTR language, try the same, 3 bubbles and dismiss the
  left-most bubble, observe arrow jumps the same and does not become
  detached
Test: select other bubbles, observe arrow position animates to the new
  position
Change-Id: I399db3c3e32b65b9125262bba0a0c32e45865bba
2024-01-23 15:18:09 -08:00
Ats Jenk 1721e8a7ae Merge "Bubble bar expland/collapse animation when on left" into main 2024-01-23 21:44:25 +00:00
Tracy Zhou 93ce09ac04 Merge "Add multitasking folks to launcher OWNERS" into main 2024-01-23 19:50:09 +00:00
Sebastián Franco 4d4c7e06eb Merge "Send ACTION_UP if there is an exception" into main 2024-01-23 18:40:53 +00:00
Sebastián Franco 4dc58c9d8b Merge "Send ACTION_POINTER_UP if there is an exception" into main 2024-01-23 18:40:33 +00:00
Himanshu Gupta 4b75bca8c9 Merge "Allowing ProxyActivityStarter without result." into main 2024-01-23 11:03:13 +00:00
Jakob Schneider dc817bbf62 Merge "Prefix PromiseIconUiTest with Tapl in AndroidManifest.xml for archiving." into main 2024-01-23 10:44:34 +00:00
Himanshu Gupta 70fd052cd9 Allowing ProxyActivityStarter without result.
This is required in some cases, when we do not want
the Launcher (ProxyActivityStarter) Activity to come
in recents.

Bug: 320664417
Flag: ACONFIG com.android.launcher3.private_space_app_installer_button TEAMFOOD
Test: Manual build and flash.
Change-Id: I94d9dfab19f8a2410fa82adc0c0c22a3ac238a0b
2024-01-23 05:17:20 +00:00
Tracy Zhou be498432cd Do not enter stage split from keyboard shortcuts if the user is already in split
Fixes: 319640005
Test: Nothing happens when triggering split shortcuts in full split
Change-Id: I7bfe82a9255d2822ca90ed5bb1733021e2465602
2024-01-22 20:17:00 -08:00
Ats Jenk feb3a68db7 Bubble bar expland/collapse animation when on left
Fix bubble bar collapse and expand animations when bubble bar is pinned
to the left.
When system language is set to an RTL language, bubble bar gets pinned
to the left edge of the screen.
Bubble bar should expand to the right and collapse to the left. Bubbles
in the bubble bar should be ordered from right to left. The most recent
bubble should be at the right in the bubble bar.

Known issue:
  - when the most recent bubble is removed, the arrow animates to a new
    position, but the background is not animated, resulting in arrow
    getting detached from the container. Will be fixed by animating the
    background.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: with LTR language set as the system language
  - expand bubble bar with 1 bubble
  - expand bubble bar with multiple bubbles
  - select second bubble, observe after collapse it is set as first
  - dismiss a bubble from bubble bar by dragging
Test: with RTL language set as the system language
  - expand bubble bar with 1 bubble
  - expand bubble bar with multiple bubbles
  - select second bubble, observe after collapse it is set as first
  - dismiss a bubble from bubble bar by dragging

Change-Id: Ic46a5b1a6e45ad225ba509a61147cc6a8cdd0397
2024-01-22 19:06:29 -08:00
Tracy Zhou f9f8bb6514 Add multitasking folks to launcher OWNERS
Change-Id: I3d17ed3b5bee70015c07e205af8df5add11b9df4
Bug: N/A
Test: N/A
2024-01-23 01:48:30 +00:00
Mady Mellor 0e08d300e4 Merge "Add Ats and Liran as owners to taskbar bubbles" into main 2024-01-23 00:34:10 +00:00
Vadim Tryshev 6be6906321 Send ACTION_UP if there is an exception
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I22fa5a9da7384a44b35bdd3b21c79837dbbd11d2
2024-01-22 16:24:31 -08:00
Vadim Tryshev d1108f24e5 Send ACTION_POINTER_UP if there is an exception
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: Ica5fec6e5732383aed764682619453b2b3fac113
2024-01-22 16:14:10 -08:00
Saumya Prakash cc0a69e0ca Increase Done button size to be more accessible for the gesture tutorial
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in the gesture navigation tutorial menu
was previously too small.

Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fixes: 319752098
Test: Opened the gesture tutorial menu in smaller and larger screens.
Change-Id: I7d9b856ad4829e4ffe26a7df00f42e5e4fcf1b2e
2024-01-22 23:15:09 +00:00
Winson Chung 5a1c88629b Merge "Remove path to provide Launcher with the nav bar surface" into main 2024-01-22 21:10:51 +00:00
Vinit Nayak 520f284e3a Merge "Implement bounce animation for invalid split target" into main 2024-01-22 20:57:29 +00:00
Vinit Nayak 40f5f0102d Merge "Remove app pairs when their member apps are uninstalled" into main 2024-01-22 20:28:23 +00:00
Jagrut Desai d176477b7f Merge "Fixing folder drawLeaveBehind() with Taskbar Pinning enabled" into main 2024-01-22 19:40:58 +00:00
Federico Baron dc2f747213 Merge "Fix nested scrolling in two pane picker left pane" into main 2024-01-22 19:38:46 +00:00
Mady Mellor befb26ca11 Add Ats and Liran as owners to taskbar bubbles
Flag: N/A
Test: treehugger
Bug: none
Change-Id: I16c3c45c109d0bcc4f536dfebc5d40c8ea3d2f31
2024-01-22 11:28:47 -08:00
Sunny Goyal 7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Anushree Ganjam e6760e6855 Merge "Pause the prediction update until the app launch transition ends." into main 2024-01-22 19:05:36 +00:00
Jagrut Desai f5a27ac0c5 Fixing folder drawLeaveBehind() with Taskbar Pinning enabled
Test: Manual
Bug: 320579559
Flag: NONE
Change-Id: If0c7cb7cf8deb89868cb34c310c91fd0cf028643
2024-01-22 10:08:09 -08:00
Anushree Ganjam b3bf0276e4 Pause the prediction update until the app launch transition ends.
b/319162661 issue is similar to hotseat updates on app click : b/148800229 and ag/10235572

So we will pause the prediction updates until the app launch transition is complete.

See https://b.corp.google.com/issues/319162661#comment9 and https://b.corp.google.com/issues/319162661#comment10 for bug report
analysis.

Before fix: https://b.corp.google.com/issues/319162661#comment11

After fix: https://b.corp.google.com/issues/319162661#comment12

Bug: 319162661
Test: Manual
Flag: NA
Change-Id: I797ce982569c7950628368b854fb3b6766f0fc28
2024-01-22 09:51:05 -08:00
Rohit Goyal f97d8ac08f Prefix PromiseIconUiTest with Tapl in AndroidManifest.xml for archiving.
* Archiving test for promise icons use a broadcast receiver.
* Due to recent class identifier change, manifest entry for the receiver was invalidated. This cl attempts to fix the breakage.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I061278d6cc3f49c579575a1af49ffe53770fd790
2024-01-22 17:26:24 +00:00
fbaron db1e3d53e3 Fix nested scrolling in two pane picker left pane
Fix: 319151078
Test: Verify there's no nested scrolling
Flag: NONE
Change-Id: Ic974c85e1845f45aa0646a1ebf29696f75c9ab90
2024-01-22 09:00:57 -08:00
Sam Cackett 77a7bf2ac7 Merge "Use app short name in Overview IconAppChipView" into main 2024-01-22 14:46:00 +00:00
Jeremy Sim 48467438da Remove app pairs when their member apps are uninstalled
This patch modifies PackageUpdatedTask.execute() to also remove app pairs when their member apps are uninstalled.

Fixes: 316050282
Test: Install App A, create an app pair containing App A, uninstall App A.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I8487a2dfcfc6d29bd55e88003d1950078c6e2e31
2024-01-22 17:50:12 +08:00
Sebastián Franco 82d88d3fdc Merge "Updating launcher settings so that they become split-screen" into main 2024-01-22 04:58:09 +00:00
Jeremy Sim d9c91a45e8 Implement bounce animation for invalid split target
When the user selects an app pair as a split target, the split instructions view will now bounce up and down to prompt the user to select something else.

Fixes: 315529271
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I1ff194449db2263b266404f42a75ebc35ee6077c
2024-01-22 12:23:58 +08:00