Commit Graph

18817 Commits

Author SHA1 Message Date
Vadim Tryshev dfa4eef602 Merge "Annotating DigitalWellBeingToastTest so that it actually runs in lab :)" into ub-launcher3-qt-dev
am: f099fb45b8

Change-Id: I58ca58b453e9ee281bd7269bd3e9848d9d9a44e9
2019-04-25 18:00:31 -07:00
Vadim Tryshev f099fb45b8 Merge "Annotating DigitalWellBeingToastTest so that it actually runs in lab :)" into ub-launcher3-qt-dev 2019-04-26 00:44:04 +00:00
vadimt 55fa21eb95 Annotating DigitalWellBeingToastTest so that it actually runs in lab :)
And starting a test app :)))))

Change-Id: I3b326a40651b0e4293dee26e4ef5f991cd7b7d0d
2019-04-25 17:34:23 -07:00
Tony Wickham 216c0eedeb Merge "Decouple recents view from window while swiping up" into ub-launcher3-qt-dev
am: 0cc53e7f6a

Change-Id: I35b6985c50af31debac49fcc5c4714216acd9786
2019-04-25 17:20:19 -07:00
Tony Wickham 0cc53e7f6a Merge "Decouple recents view from window while swiping up" into ub-launcher3-qt-dev 2019-04-26 00:10:34 +00:00
Matthew Ng 4f5503e13c Merge "Remove interaction flag code replaced by QuickStepContract (1/2)" into ub-launcher3-qt-dev
am: 529bff9a66

Change-Id: I44162de4803b536dc2c95bbc24987b19347ba465
2019-04-25 16:50:14 -07:00
TreeHugger Robot 529bff9a66 Merge "Remove interaction flag code replaced by QuickStepContract (1/2)" into ub-launcher3-qt-dev 2019-04-25 23:36:23 +00:00
Hyunyoung Song a0cc03a9a4 Merge "Cleanup unnecessary override dump method" into ub-launcher3-qt-dev
am: 3c007368a7

Change-Id: I80b98e74eb4aea7f575d43a54c3a1b3bbba765a4
2019-04-25 16:35:06 -07:00
TreeHugger Robot 3c007368a7 Merge "Cleanup unnecessary override dump method" into ub-launcher3-qt-dev 2019-04-25 23:22:04 +00:00
Hyunyoung Song 9e7d2acc22 Cleanup unnecessary override dump method
Change-Id: Ic2909a4d382362ddec9bcc2c738d13120e792fd8
2019-04-25 16:08:52 -07:00
Matthew Ng b60dce7268 Remove interaction flag code replaced by QuickStepContract (1/2)
Test: manual
Bug: 112934365
Fixes: 129497226
Change-Id: Id128eee4eaa620f0b9c461ef5adf0a16e9ea9a2c
2019-04-25 23:01:12 +00:00
Hyunyoung Song 8342eb35a6 Merge "Add important dump logging Bug: 130851537 Bug: 119992316" into ub-launcher3-qt-dev
am: efe8475093

Change-Id: I155b968bc54120b3c1d8d3f0c33c07c31cb51d5c
2019-04-25 15:40:18 -07:00
Tony Wickham a2c48efb50 Log undo button click
am: 03f27013bf

Change-Id: I1a47c8177a3cd7d6f661c85ba0dc0e3a6f4d56d7
2019-04-25 15:39:47 -07:00
Hyunyoung Song efe8475093 Merge "Add important dump logging Bug: 130851537 Bug: 119992316" into ub-launcher3-qt-dev 2019-04-25 22:33:31 +00:00
Hyunyoung Song a310a80c7b Add important dump logging
Bug: 130851537
Bug: 119992316

Change-Id: I3de7c1d910d1aecd80b47a85284565c79fe0e2cc
2019-04-25 15:14:44 -07:00
Tony Wickham 03f27013bf Log undo button click
Also fix a bug where we logged workspace swipe upon clicking undo, since
rebinding the pages causes us to reset mCurrentPage = 0 followed by
setCurrentPage(pageBoundFirst). Since the page isn't actually visibly
changing, we shouldn't log in that case.

Bug: 118758133
Change-Id: Ie87164a8c7c278680f67dee75657210bd33408a4
2019-04-25 14:22:54 -07:00
Hyunyoung Song 12422734dd Merge "Add logging for Task Icon interaction" into ub-launcher3-qt-dev
am: 1e4a43ac67

Change-Id: Ieb25694fa387e7947141d735c769b62bc51829bc
2019-04-25 13:36:27 -07:00
Kevin 866eaa26ad Merge "Don't layout empty tasks in layout anim if we have the actual content." into ub-launcher3-qt-dev
am: db4e713c18

Change-Id: I1229c6d8c4c3bc6b5918bc4c98f849d0aed9110d
2019-04-25 13:31:26 -07:00
Hyunyoung Song 1e4a43ac67 Merge "Add logging for Task Icon interaction" into ub-launcher3-qt-dev 2019-04-25 20:30:43 +00:00
TreeHugger Robot db4e713c18 Merge "Don't layout empty tasks in layout anim if we have the actual content." into ub-launcher3-qt-dev 2019-04-25 20:22:08 +00:00
Kevin 1335c36c15 Don't layout empty tasks in layout anim if we have the actual content.
When we load the task content (icons, snapshots, etc), oftentimes, we
are still in the middle of the layout animation where items are fading
in from bottom to top. At this point, we start a second content-fill
animation from bottom to top that fades from empty => filled after the
first animation.  However, we can improve this so that empty views
aren't shown for a split second for some of the later laid out views.

If the first animation has not finished and we would animate a content
change from empty => filled but the view is currently still not visible,
we should just complete the content transition on the spot so that the
layout animation lays out the filled version instead.

Bug: 131339235
Test: Go to recents, observe lay out animation does not continue to lay
out the empty view first

Change-Id: I936a81e6cf8b3552cdee90c183fc841f50ec9ea8
2019-04-25 12:53:20 -07:00
Vadim Tryshev d30e0d3d43 Merge "Enable testStressSwipeToOverview()" into ub-launcher3-qt-dev
am: a5ed906db8

Change-Id: I964f4af9e106835b11d47a142f0ed3ab73938832
2019-04-25 12:18:26 -07:00
Vadim Tryshev a5ed906db8 Merge "Enable testStressSwipeToOverview()" into ub-launcher3-qt-dev 2019-04-25 19:11:26 +00:00
Tony Wickham 0851895b86 Merge "Use AccessibilityManager#getRecommendedTimeoutMillis for Snackbar" into ub-launcher3-qt-dev
am: 4fd2dff408

Change-Id: I55271db44b9d3cb61793d7234b477900ffb876ad
2019-04-25 12:04:00 -07:00
Tony Wickham 74bf8d262a Merge "Call initTransitionEndpoints in constructor" into ub-launcher3-qt-dev
am: 2a3c936440

Change-Id: Iae8f41eed3003060f9c29cde7ca3d46ebbd408cc
2019-04-25 12:03:22 -07:00
TreeHugger Robot 4fd2dff408 Merge "Use AccessibilityManager#getRecommendedTimeoutMillis for Snackbar" into ub-launcher3-qt-dev 2019-04-25 18:58:39 +00:00
vadimt ab03a7eb19 Enable testStressSwipeToOverview()
Underlying issue has been fixed.

Bug: 129723135
Change-Id: I336de8bb38360ee83023caa17bc90a601db3b9e2
2019-04-25 11:57:41 -07:00
Hyunyoung Song fd94cd5498 Add logging for Task Icon interaction
Bug: 129279637
Change-Id: I135bad16015129b3b60bb13e86783d623e504b1b
2019-04-25 11:56:04 -07:00
Tony Wickham 5519a0f6a8 Use AccessibilityManager#getRecommendedTimeoutMillis for Snackbar
Bug: 129806241
Change-Id: I4aabc3ee33560960f3117d82f9873fce60f1278a
2019-04-25 11:47:22 -07:00
Tony Wickham 2a3c936440 Merge "Call initTransitionEndpoints in constructor" into ub-launcher3-qt-dev 2019-04-25 18:46:45 +00:00
Sunny Goyal 4a4f0a1613 Merge "Filling in content values on the worker thread" into ub-launcher3-qt-dev
am: 587421adbf

Change-Id: I4854343932b386d74e7b516032f8b36e5ffd185e
2019-04-25 10:53:05 -07:00
Sunny Goyal 587421adbf Merge "Filling in content values on the worker thread" into ub-launcher3-qt-dev 2019-04-25 17:38:13 +00:00
Sunny Goyal 2e4477accb Filling in content values on the worker thread
Writing to disk hapens on the worker thread, so if we create content values on
UI thread, some values can change before it is written to disk.
This happens in case of shortcuts, where the badge is applied after the icon is queued,
but before it is written

Bug: 131303610
Change-Id: Ic35b17071d4ed3e5c5fee9f003a225e4ffdc74f3
2019-04-25 07:08:15 -07:00
vadimt 9eddc4c7ec Merge "Re-adding clear-all button logging" into ub-launcher3-qt-dev
am: 1c9d3974b5

Change-Id: Id6624472e82e5c0e3cada7cef9789985885d2545
2019-04-24 18:58:43 -07:00
TreeHugger Robot 1c9d3974b5 Merge "Re-adding clear-all button logging" into ub-launcher3-qt-dev 2019-04-25 01:50:42 +00:00
Tony Wickham 7efbc7f74c Merge "Pass correct value to updatePaused() in setDisallowPause()" into ub-launcher3-qt-dev
am: 56511361ba

Change-Id: I40a35953f6aeb47aa35f6aaf37e32360ba0d3c8e
2019-04-24 18:48:39 -07:00
Tony Wickham 56511361ba Merge "Pass correct value to updatePaused() in setDisallowPause()" into ub-launcher3-qt-dev 2019-04-25 01:34:22 +00:00
Kevin f184325121 Merge "Fix overview cmd launching wrong task in landscape" into ub-launcher3-qt-dev
am: c2b14d9fc8

Change-Id: I32973ca13347f64f768860ec11fb9597f1ece4ea
2019-04-24 18:24:37 -07:00
Tony Wickham 4f24370f72 Pass correct value to updatePaused() in setDisallowPause()
Change-Id: Iabc3a3aac85bcf426ab18437e006cc95fa89fbc0
2019-04-24 18:20:23 -07:00
TreeHugger Robot c2b14d9fc8 Merge "Fix overview cmd launching wrong task in landscape" into ub-launcher3-qt-dev 2019-04-25 01:17:06 +00:00
Kevin 71d3e30fd1 Fix overview cmd launching wrong task in landscape
Previously we used the bottom most view in recents list to launch the
recent task when the user pressed the overview button. However, if
the user is in landscape and scrolls up so the bottom view is not
attached, pressing overview command will launch whatever the bottom task
is visually which is incorrect. Instead, we get the actual task from the
model to launch and only use the "view => app" animation if the view for
that task is attached. If it isn't, we use the basic animation.

Bug: 130735711
Test: Go to landscape, scroll up, hit command, launches correct task
Change-Id: Idff88054443259e917bbec1b47d78efbb1544283
2019-04-24 18:01:08 -07:00
vadimt 325a48b01a Re-adding clear-all button logging
Bug: 131250710
Change-Id: If31a84bf6db37b295fc0e2c4d8db8ed4b7baa037
2019-04-24 17:50:29 -07:00
Tony Wickham d8a3646068 Merge "Move logic that overrides MotionPauseDetector to callers" into ub-launcher3-qt-dev
am: d0d39f1769

Change-Id: If582b08b469c596572ed5c39f5de1c9156e9d617
2019-04-24 17:44:32 -07:00
Tony 5c13972e11 Decouple recents view from window while swiping up
Add setRecentsAttachedToWindow(boolean attached, boolean animate) with
the following conditions:

Conditions for attached
- Motion is paused and shelf is peeking
- xDisplacement > yDisplacement (to ensure seamless quick switch)
- We are continuing the previous quick switch gesture
- Gesture has ended and endTarget is RECENTS or NEW_TASK

Conditions for animate
- Recents is visible. Since the running task is invisible, this is
  true if either an adjacent TaskView is visible, or if we’re
  continuing the previous gesture

Currently the attach/detatch animation is just fading recents in/out.

Test:
- Swipe up to go home does not show the recents list at all. Instead,
  all the visuals/motion focus on the app window animating into the
  home screen.
- Recents appears when swiping and holding, to indicate that letting
  go will land in recents. The shelf also appears with haptic feedback
  in this case to reinforce this.
- The next task is immediately visible when quick switching (swiping
  left to right on the nav bar).

Bug: 129985827
Change-Id: Ib0c16f583bfd5b02d2f9f68c9688edc980a39d75
2019-04-24 17:36:42 -07:00
Tony Wickham d0d39f1769 Merge "Move logic that overrides MotionPauseDetector to callers" into ub-launcher3-qt-dev 2019-04-25 00:34:47 +00:00
Tony Wickham 8ddff450b9 Merge "Hide Clear all button during quick switch" into ub-launcher3-qt-dev
am: 23060080fe

Change-Id: Ibda7f571460651149f84f412b7725789b2732135
2019-04-24 17:34:30 -07:00
TreeHugger Robot 23060080fe Merge "Hide Clear all button during quick switch" into ub-launcher3-qt-dev 2019-04-25 00:19:34 +00:00
Tony Wickham 5e58b447b0 Call initTransitionEndpoints in constructor
Before, the soonest we initTransitionEndpoints() is in
onRecentsAnimationStart(), which might be too late if launcher was
killed. (In that case, the gesture might end before we ever get
onRecentsAnimationStart(), and thus will never consider the distance
traveled great enough to trigger recents since we don't have endpoints.)

Bug: 129723135
Change-Id: I349f62244aaba8369926b14f90acd994fd40a93a
2019-04-24 17:19:07 -07:00
Tony Wickham 66d1c2fada Hide Clear all button during quick switch
- Add support for mMinScrollX to PagedView
- Add RECENTS_CLEAR_ALL_BUTTON as a state-specified visible element
- In BackgroundAppState, set Clear all invisible and bound RecentsView
  scroll to the last task

Test:
- Open an app, quick switch until reaching the end, ensure Clear all
  does not show up and an overscroll effect is performed
- Enter overview, scroll to the end and ensure Clear all shows up
- Same tests in RTL and 3rd party launcher

Bug: 130160876
Change-Id: I5fb958744d0055b83ced1f8b0d7face0e06a0cc5
2019-04-24 17:09:34 -07:00
Hyunyoung Song 245d7d4f89 Merge "Fix NPE / add downX,Y location for all swipes/ add extra debugging info Bug: 122700646 Bug: 127840207" into ub-launcher3-qt-dev
am: a6f1969981

Change-Id: I8efd9fc45d03e40056dab866ecba88ea52d0c267
2019-04-24 16:52:08 -07:00