Commit Graph

49755 Commits

Author SHA1 Message Date
Alex Chau 90abf51d5b Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev am: ed2e7719cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19015866

Change-Id: I42777fcd655a85f9914ced5101960eeefb4084fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 12:22:54 +00:00
Alex Chau ed2e7719cb Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev 2022-06-22 11:59:31 +00:00
Sunny Goyal 506165689f Revert "Finish recents animation on activity destroyed."
This reverts commit 0fd3b13d01.

Reason for revert: b/236514960
Bug: 228137694
Bug: 230373809

Change-Id: Ifed5f2a13fda4409982d548e3212bd16c81b63bc
2022-06-22 11:59:13 +00:00
wilsonshih 9840bdaa13 [Shell Transition]Fix live tile be hidden by wallpaper leash.
A generic fix to specific layers for live tiles/wallpaper.
Because there cannot sure the absolutely z-order of recents surface, we
can always set wallpaper layer to bottom, and set the z-order of live
tiles to either MAX or MIN + 1, so live tile can always above wallpaper,
also the live tile can be show above/below recents surface based on
mDrawsBelowRecents.

Test: enable shell transition, open app then entering recents, verify
the live tile stay visible when entering recents. And the shared
indicators visible when state transition complete.
Test: also verify above test for legacy transition.
Bug: 236410500

Change-Id: I0f86d7617af1d96c28783320248af64f576bd570
2022-06-22 15:21:49 +08:00
TreeHugger Robot 5069964ea2 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev 2022-06-22 03:23:07 +00:00
vadimt a18e9f2637 Reducing max timeout in TAPL
Lab presubmits now have a limit 60 sec per test, so failing to find an expected view will result in a cryptic "Test did not run due to instrumentation issue. Run level error reported reason: 'Instrumentation did not output anything for the configured timeout. ddmlib reported error: Failed to receive adb shell test output within 600000 ms. Test may have timed out, or adb connection to device became unresponsive.'"

Reducing the timeout to get better messages.

Bug: 236308045
Test: presubmit
Change-Id: I09e7fa02a12f4e2d0900d29b0029686337a381b0
2022-06-21 20:14:08 +00:00
Alex Chau bd8111a049 Merge "Only check dbFile to decide if grid migration is needed" into tm-qpr-dev 2022-06-21 20:08:53 +00:00
Sunny Goyal 20b4457319 Removing non-launcher engineers from the Launcher OWNERS file
Bug: 236736620
Test: n/a
Change-Id: I59e80d93a3b272cf2f82efa4b36824a469845874
2022-06-21 12:48:45 -07:00
Schneider Victor-tulias 6c71fe71bd Merge "Fix taskbar unstash animation delay when launching a split task." into tm-qpr-dev 2022-06-21 19:38:46 +00:00
Schneider Victor-tulias bfde6b2e5d Fix a potential null-pointer onActivityDestroyed
Fixes: 234082544
Test: started recents from a large screen and phone
Change-Id: I54ee93793ec146d1b0b0f00f23256aaca5975bc0
2022-06-21 12:34:02 -07:00
Alex Chau 61c6b580ad Merge "Revert "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev 2022-06-21 18:10:28 +00:00
Alex Chau 49dcd16b26 Only check dbFile to decide if grid migration is needed
Fix: 234847755
Test: With a modified local build, when changing display config to swap between same grid:
- When dbFile is same but device type is different, no migration is performed
- When both dbFile and device type are different, migration is performed properly
Test: Grid migration through Wallpaper & Styles still works properly

Change-Id: Ie7429a7d59c135ba47061cae21c40b8d8af7188a
2022-06-21 12:36:50 +00:00
TreeHugger Robot fbc3f597dc Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-06-20 12:13:14 +00:00
Bill Yi c8aafdfc63 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: dd44423c3f -s ours am: ccd3f9b40a -s ours am: d0ee81b797 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18983984

Change-Id: I38a3e2a1cc44c1f6e76eebbb2448980289c1a613
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:33:53 +00:00
Bill Yi d0ee81b797 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: dd44423c3f -s ours am: ccd3f9b40a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18983984

Change-Id: I2143c6c351e07ebe7aaa85d9770ab13c7f761ea3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:24:04 +00:00
Bill Yi f17a97540c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: fa9f6501e9 -s ours am: b52e94bb84 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18987633

Change-Id: I8e88915237f310c71013165edac27f82b77b0002
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:11:03 +00:00
Schneider Victor-tulias dfadafe45b Fix All set activity not drawing on initial swipe. am: 4d18da78c0 am: 3a126d78a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18930603

Change-Id: Ie74ad15bc52082615cabced4f86c33e69de9560c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:10:49 +00:00
Bill Yi ccd3f9b40a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: dd44423c3f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18983984

Change-Id: I70d37f35351f8ae3d26018d5458162f878fdbc2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:04:28 +00:00
Bill Yi b52e94bb84 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: fa9f6501e9 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18987633

Change-Id: I889ef5d9b0d9853a6bd0e56de42a0af1c7277f92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 07:34:14 +00:00
Schneider Victor-tulias 3a126d78a9 Fix All set activity not drawing on initial swipe. am: 4d18da78c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18930603

Change-Id: I71eea3ff4b66ec094a7eb451d1a0afe3cd3a7227
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 07:34:03 +00:00
Bill Yi d6ac82b18c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 9f3de2bbb2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18987635

Change-Id: I6e567a6e3220d934a3df6cc1745a4008240caac4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 07:24:19 +00:00
Bill Yi 9f3de2bbb2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3fa536c9f10b1648155ed3ef01cfb5d95e20fb34
2022-06-19 09:05:18 -07:00
Bill Yi cba7d722c4 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibf3c81237de9f9fe20f590d01483dc9283313fb6
2022-06-19 09:04:33 -07:00
Bill Yi fa9f6501e9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I010fafdf9fc78b15763a183684aa0ab77ee66281
2022-06-19 09:03:48 -07:00
Bill Yi dd44423c3f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5d8815a46e2981f5ad1bf173c3903764062cf4f4
2022-06-18 22:35:57 -07:00
Alex Chau b065b4b05a Revert "Add logs for InvariantDeviceProfile.getDeviceProfile"
This reverts commit d3e8cc40b4.

Reason for revert: b/231312158 is fixed, log is no longer needed
Fix: 231851651

Change-Id: I3ea8b9d14e7eb6f8f9c794c5d15cdfc94153d392
2022-06-17 09:36:00 +00:00
Sunny Goyal bbad97e273 Unifying scroll calculation logic for both widgets and apps recycler view
Also using itemType instead of item object for widget size cache

Bug: 234008165
Test: Verified on device
Change-Id: Ia4b4a00a11627c0c454e4a699570e8ab1667a390
2022-06-16 16:03:37 -07:00
Schneider Victor-tulias 4d18da78c0 Fix All set activity not drawing on initial swipe.
The launcher was not properly preloading upon launching the All Set Activity. The Launcher would only start loading once the user started swiping up. This would stop the all set activity from drawing.

Test: Factory reset with a restore and tested the all set page.
Fixes: 234536107
Change-Id: I6bcb805ea6c43fb993f2b57499444ea62bcc37e1
2022-06-16 20:38:24 +00:00
Sebastián Franco 2545f45a1f Merge "Adding a case when there is only 1 system shortcut on the Popup Container" into tm-qpr-dev 2022-06-16 17:01:10 +00:00
Luca Zuccarini c703f3a3e0 Unify the source of truth for NORMAL <> ALL_APPS transitions.
Bug: 231682175
Bug: 234812580
Test: manual
Change-Id: I5b66735474915d7a59bda337f67df37ff397908a
2022-06-16 16:40:26 +00:00
Tony Wickham d100f6825f Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev am: 9d5f64adf1 am: 1cba5f9d47
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18914942

Change-Id: Ib76e6458f71282ebb7753db8c4ea9b671fb0fa19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 15:28:03 +00:00
Tony Wickham 1cba5f9d47 Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev am: 9d5f64adf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18914942

Change-Id: I4c55e85b233eec4a6bca1d46590270b71ecbc4a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 15:10:12 +00:00
Tony Wickham 9d5f64adf1 Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev 2022-06-16 14:55:48 +00:00
Alex Chau ccc55f1668 Merge "Detect force visible nav bar based on kids mode." into tm-qpr-dev 2022-06-16 13:55:14 +00:00
Thales Lima 85e52e2f9d Merge "Fix QSB alignment" into tm-qpr-dev 2022-06-16 12:19:45 +00:00
Alex Chau a5ae4c2e57 Merge "Animate inline QSB between home and apps" into tm-qpr-dev 2022-06-16 08:00:51 +00:00
Ling WO 9a8964b122 Cherrypick needed for merge conflict with ag/18875278
Support move to a specific location on workspace for all workspaceDragSource, so other workspaceDragSource such as HomeAppIconMenuItem can be moved to a fixed location during testing to avoid ui-diff flakiess

Design doc:
https://docs.google.com/document/d/1tZWbfsv86O6UAKtHJrDBGecu-x3ac51qmWvARDg057M

Test: atest
Bug: 216189838

Change-Id: Ia6ef7338beb257d0313be17a53a9fc59ae39fdb6
(cherry picked from commit fe8fb4d137)
2022-06-15 22:38:04 +00:00
Brandon Dayauon 111473315d Merge "Fix work toggle button to be placed where it should be." into tm-qpr-dev 2022-06-15 22:05:49 +00:00
Schneider Victor-tulias e164995f9e Fix taskbar unstash animation delay when launching a split task.
Fixes: 232033354
Test: switched between split and unsplit tasks using 3 button nav and gesture nav
Change-Id: I9a4e2eb08e9970540093e3dc60b64a372be2052f
2022-06-15 14:55:37 -07:00
TreeHugger Robot 34958f4bdf Merge "Fix folder preview animation when adding or removing icons." into tm-qpr-dev 2022-06-15 21:20:55 +00:00
Alex Chau c1d26448c5 Animate inline QSB between home and apps
- Added a QSB to taskbar to be animated between inline QSB and taskbar
- Passed endValue of taskbar animator to TaskbarController to have aniamtion variation between home -> app and app -> home
- Tuned duartion of taskbar animation and also stagger animation when taskbar is present
- Disabled scaling down of taskbar and inline QSB for home -> app
- Disabled stagger animation of taskbar and inline QSB for app -> home

Bug: 220733187
Test: manual
Change-Id: I4aac0bbc343b992a0472298595770e2bf2a55990
2022-06-15 22:12:29 +01:00
Vinit Nayak d18304ca15 Close all open views for 1P and 3P launchers
* Previously TaskView was closing task menu view, but
that got removed since launcher was doing that on
state transition.
* Only 1P launcher was doing that and not 3P launcher,
moved call to remove open views to parent class

Test: Invoking split on 3P launcher doesn't result in a crash
Bug: 199342537
Change-Id: I6afbe7640ede362a677e15a33409a7cabdb8cca9
2022-06-15 14:09:49 -07:00
Pinyao Ting e5dbb75acd Cache and reuses LauncherAppWidgetHostView when launcher resumes
Currently by design when launcher enters the background, it stops
listening to updates in widgets. This eventually causes the dilemma
for launcher when it resumes, before the update can be returned from
the system process via IPC, launcher could do one of the following
to fill the gap:
1. show a deferred widget view -- a placeholder that renders the shape
   of the widget -- to let the user know widget is being reloaded.
2. show whichever widget view that was previously displayed to the
   user that may now contain stale content.

There is a descrepancy here since in some edge cases we are showing the
former while in most other cases we are showing the later. This CL added
a short-term fix to address the descrepancy and favors the later where
possible.

Bug: 218067434
Test: manual
Change-Id: I6cd2cd704186267227e2ec47f2581843fd526fa0
2022-06-15 13:23:31 -07:00
Tony Wickham bed0d636fe Proper fix for gesture nav flicker using runOnPageScrollsInitialized()
I root caused the two areas causing the flicker:
A. If page scrolls aren't initialized when we get onActivityInit(), the first scroll even after linkRecentsViewScroll() will jump based on min scroll (due to Clear all button). Fix is to defer linking until page scrolls are initialized.
B. If page scrolls aren't initialized when the gesture starts, RecentsView can jump to the min scroll when calling showCurrentTask(), since that calls setCurrentPage(getRunningTaskIndex()) which might be out of bounds. Fix is to defer that setCurrentPage() until page scrolls are initialized.

Test: open a random app that hasn't been opened in a while, touch down
on nav handle and see if RecentsView scrolls partially or fully
offscreen; repeat 20 times to be sure
Fixes: 233112195

Change-Id: I000960775f8735920d97c87942065a430c9dce0c
2022-06-15 19:08:32 +00:00
Tony Wickham a379435d04 Clear MotionPauseDetector onRecentsAnimationCanceled()
Fixes: 234022857
Test: Open ImCapture and swipe up to home; repeat 20 times and ensure never see empty overview tasks over launcher
Change-Id: Icef6d7a54000e1e21453feeae7e207679077b772
2022-06-15 11:59:59 -07:00
Pat Manning c773d7cdc8 Detect force visible nav bar based on kids mode.
WM was changed to use NAV_BAR_KIDS_MODE instead of NAV_BAR_FORCE_VISIBLE, this needs to update to match.

Fix: 229580780
Test: manual.
Change-Id: I38fb23dcc85676593a3f8f0851676bc526802d2e
2022-06-15 15:03:52 +01:00
Thales Lima 616e0102a4 Fix QSB alignment
Fix: 232908328
Test: manual
Change-Id: If5516be6b8f7142577257f5ec5b5dfa8feca445d
2022-06-15 11:40:58 +01:00
Hyunyoung Song b751033f30 Merge "Remove hideKeyboard exception in the log" into tm-dev am: 5d57e3d651 am: 76e688b7c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18869544

Change-Id: I2131e1676c613f0df96d9989876632d5fa282e4b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 06:39:06 +00:00
Hyunyoung Song 76e688b7c1 Merge "Remove hideKeyboard exception in the log" into tm-dev am: 5d57e3d651
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18869544

Change-Id: I8c89746b3ee084b68664c0153dd6351c3f4fad75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 06:18:10 +00:00
Hyunyoung Song 5d57e3d651 Merge "Remove hideKeyboard exception in the log" into tm-dev 2022-06-15 05:38:16 +00:00