Commit Graph

49755 Commits

Author SHA1 Message Date
Pinyao Ting 6c7361fb46 Merge "Cache and reuses LauncherAppWidgetHostView when launcher resumes" into tm-qpr-dev 2022-06-27 20:51:22 +00:00
Sunny Goyal 977838b568 Fixing nullpointer exception when accessing StatsLogger before initialization
Bug: 236227523
Test: Manual
Change-Id: I2caaa143ab2ddd4442d5c56152c7b4a7c723b92b
2022-06-27 13:16:19 -07:00
Hongwei Wang 56911984e4 Scale the surface by progress when auto enter PiP
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/coTRupQrNjoSwGDzMhA4X7
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/fDqPTOPwyxHaZ4HLZDF7di
Bug: 235268241
Test: Verify the auto enter PiP animation for YouTube in \
      both folded and unfolded state. See also videos.
Change-Id: I6fc10d6a733b8bdd3587994e8e27c4d6ab7e4f39
2022-06-27 11:32:15 -07:00
Sunny Goyal 008238ef43 Fixing widget size cache loop end-boundary
Bug: 236961658
Test: Verified on device
Change-Id: Ied629cd875a01abc45a7d055edfde5e156de53ea
2022-06-27 11:25:57 -07:00
Tony Wickham c4405218ca Merge "Log when MotionPauseDetector detects onMotionPauseChanged" into tm-qpr-dev 2022-06-27 17:28:17 +00:00
Vaibhav Devmurari 207e374413 Allow taskbar and taskbar all apps window to receive split touches
Adding feature to allow UI interaction during Drag and drop.
To allow user to interact with taskbar UI during D&D, the window
should support FLAG_SPLIT_TOUCH to receive touch events while user
using D&D.
DD: go/global_drag_and_drop

Test: manual
Bug: 220109830
Change-Id: Icd549aa272c140d865d89eeb9f5619b5ab13c015
(cherry picked from commit 0074baa82e)
2022-06-27 10:11:58 +00:00
Alex Chau f52a13e424 Merge "Add test to dismiss AllApps bottom sheet" into tm-qpr-dev 2022-06-27 09:56:58 +00:00
Alex Chau 7cbe51c22f Merge "In AllApps search mode, only consume touch over visible container" into tm-qpr-dev 2022-06-27 09:56:42 +00:00
Chilun Huang 7662dae663 Add TAPL API for adding app icon to hotseat
Please refer to go/tapl-add-icon-to-hotseat for more details.

Bug: 231400119
Test: atest NexusLauncherTests:TaplTestsQuickstep#testAddDeleteShortcutOnHotseat
Change-Id: I8cadecbe742413e3ce35ff269c0f78057331532c
Merged-In: I8cadecbe742413e3ce35ff269c0f78057331532c
2022-06-27 11:10:21 +08:00
Tracy Zhou 015adda83c Stash task bar when ime switcher is showing
Bug: 226489759
Test: connect to physical keyboard and select a typable field, and make sure the task bar is stashed
Change-Id: Ie1cf753f793dc9cb350e57e9448c2913260992ca
2022-06-25 16:26:13 -07:00
Tracy Zhou 849a0c4e81 Show IME switcher only when physical keyboard is connected in 3 button nav (instead of also when virtual keyboard is visible)
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows; and doesn't show with virtual keyboard
Change-Id: Ib9a5880eb1bd6d5b877a9f3789ce858f399c4910
2022-06-24 23:40:41 -07:00
Tracy Zhou f9fafe7a92 Merge "Fix ime switcher not showing for 3-button nav" into tm-qpr-dev 2022-06-25 06:36:39 +00:00
TreeHugger Robot ce12869fad Merge "Treat all apps predictions as all app icons when animating icons to their original position" into tm-qpr-dev 2022-06-25 06:33:16 +00:00
Vadim Tryshev 630fd0b09f Merge "Ignoring failing test" into tm-qpr-dev 2022-06-25 01:44:45 +00:00
TreeHugger Robot adf526ab74 Merge "Not using calculator from test" into tm-qpr-dev 2022-06-24 21:07:10 +00:00
Vadim Tryshev 542d3cf4f2 Ignoring failing test
Bug: 233075289
Change-Id: I4f270127b72255037dd5aaccdc375dfebb6b1dc4
Test: presubmit
2022-06-24 20:50:42 +00:00
Sunny Goyal 46e368f755 Removing tabWidth calculation and using DeviceProfile directly
This removes some dependency on FloatingHeaderView, making it
easier to replace

Bug: 234008165
Test: Verified that the UI does not change
Change-Id: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
2022-06-24 13:32:42 -07:00
Schneider Victor-tulias a36e5f13c0 Treat all apps predictions as all app icons when animating icons to their original position
Taskbar all apps predictions were being ignored when animating a cancelled drag to their original position. This was causing a null pointer since they no longer had a view parent that could be used. These icons will now animated to the taskbar all apps icon.

Fixes: 236669335
Test: cancelled drags of taskbar icons, predicted taskbar icons, taskbar all apps icons and taskbar all apps prediction icons
Change-Id: I2a9a1ed4120927a08b8c8341ad36dfdb95fef608
2022-06-24 12:22:04 -07:00
Tracy Zhou 804feb76e7 Fix ime switcher not showing for 3-button nav
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows
Change-Id: Iabde149e8bcd1edacff8e039f956628c69341ecb
2022-06-24 11:17:40 -07:00
Alex Chau d936273b1f Add test to dismiss AllApps bottom sheet
- http://docs/document/d/1ITZDMchoMndfa0nMuOTXbhKhK2aMDz0AT9dgusgxEro

Bug: 236360930
Test: TaplTestsLauncher3.testAllAppsDeadzoneForTablet
Test: TaplTestsNexus.testSearchDeadzoneForTablet
Change-Id: I62adb1d6ef237f9bca3812b8cdce9e5a8383158f
2022-06-24 18:29:43 +01:00
Alex Chau a3070ea61d In AllApps search mode, only consume touch over visible container
Bug: 236360930
Test: Tap on deadzone to dismiss AllApps in search mode
Test: touch outside recycler view inside container, doesn't swipe left/right
Change-Id: I18498ea50f217231c3bb4489d6d9e95fc0e7da53
2022-06-24 11:51:11 +01:00
Luca Zuccarini 4a0129fa5f Merge "Unify the source of truth for NORMAL <> ALL_APPS transitions." into tm-qpr-dev 2022-06-24 10:25:49 +00:00
Alex Chau f7526085a9 Merge "Check null before getting DeviceProfile in AbsSwipeUpHandler" into tm-qpr-dev 2022-06-24 10:05:27 +00:00
Alex Chau f6674c27f7 Merge "Disable header protection on tablets" into tm-qpr-dev 2022-06-24 10:02:51 +00:00
Sebastián Franco 578fbee848 Merge "Make Talkback anounce which page is the icon being move on." into tm-qpr-dev 2022-06-24 04:54:31 +00:00
Sunny Goyal 1f5cc67c13 Merge "Moving widget padding to drawable instead of using itemDecorator" into tm-qpr-dev 2022-06-24 04:39:23 +00:00
Vadim Tryshev 0bc6491ee7 Merge "Remove unused tracing; it confuses investigators" into tm-qpr-dev 2022-06-24 02:05:16 +00:00
Sebastián Franco 1e2454eb85 Merge "Added a content call to emulate the other devices displays" into tm-qpr-dev 2022-06-23 23:41:28 +00:00
Sunny Goyal c3a5c4b16e Merge "Fixing wrong flags used by AllAppsController in SystemUiController" into tm-qpr-dev 2022-06-23 22:52:11 +00:00
Tony Wickham c214335eba Log when MotionPauseDetector detects onMotionPauseChanged
Test: verified logging locally
Bug: 232548865
Change-Id: I587481a380148127f715c5b1b59436b2cbc1533e
2022-06-23 15:05:42 -07:00
Sebastián Franco 9ffbbf8f2c Merge "Cherrypick needed for merge conflict with ag/18875278" into tm-qpr-dev 2022-06-23 21:54:13 +00:00
vadimt 5a5cb9a0c5 Not using calculator from test
Bug: 236869616
Test: presubmit
Change-Id: Ib9ed19d2415d41d8205b10f4fa740510b26b424d
2022-06-23 21:54:06 +00:00
Brandon Dayauon 0130315860 Merge "Fix work toggle button that gets blocked by threeButton nav bar on TABLETS" into tm-qpr-dev 2022-06-23 21:45:12 +00:00
Sunny Goyal ed681548fc Moving widget padding to drawable instead of using itemDecorator
ItemDecorator uses item position which is not stable during animations.
Moving it to the background allows the padding to be stable

Bug: 236961658
Test: Verified that the app doesn't crash.
Change-Id: Ied12077de4097e827c5c4157f5196346a301f185
2022-06-23 14:37:17 -07:00
Tracy Zhou 0a0fcb809c Perform haptic feedback on nav button key press
Fixes: 203614307
Test: manual
Change-Id: Icaea3f5e436522f23202c20fcc7f7c5dbe309372
2022-06-23 14:29:34 -07:00
Schneider Victor-tulias 2df19a2345 Merge "Fix a potential null-pointer onActivityDestroyed" into tm-qpr-dev 2022-06-23 18:29:09 +00:00
TreeHugger Robot a5152338ea Merge "Reducing max timeout in TAPL" into tm-qpr-dev 2022-06-23 17:44:22 +00:00
Alex Chau 7ba6cadf27 Check null before getting DeviceProfile in AbsSwipeUpHandler
Fix: 236677962
Test: manual
Change-Id: Ibf3dbc6db509a54c87dc4bd64a7c7ea213870708
2022-06-23 12:05:42 +01:00
Sebastian Franco 930531f669 Make Talkback anounce which page is the icon being move on.
Adding a third argument for the talkback string.

Fix: 230593493
Test: Move an item using Talkback and it should mention the row,
column and page where you can drop the item.

Change-Id: Id3d4435e9ef3348278643e6e2a1cd1e8bf5157b7
2022-06-22 17:17:38 -07:00
Pat Manning 5ecc826e5a Detect force visible nav bar based on kids mode. am: 6d17a71d19 am: ac7f012ba0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19038728

Change-Id: Ie4c215ae488106822ac8b1959ec58514afc7a0d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 23:24:34 +00:00
Pat Manning ac7f012ba0 Detect force visible nav bar based on kids mode. am: 6d17a71d19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19038728

Change-Id: If652dd2dc98687e6ff3106f477c23487c91e07fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 23:08:26 +00:00
Pat Manning 6d17a71d19 Detect force visible nav bar based on kids mode.
WM was changed to use NAV_BAR_KIDS_MODE instead of NAV_BAR_FORCE_VISIBLE, this needs to update to match.

Fix: 229580780
Test: manual.
Change-Id: I38fb23dcc85676593a3f8f0851676bc526802d2e
(cherry picked from commit c773d7cdc8)
2022-06-22 21:27:27 +00:00
Sihua Ma ecc272447c Fill the fade-in ImageView with its content for the cross fade animation
The cross fade function of DragView tries to match the shapes of the fade-in and fade-out views. However, ImageView (the fade-in view) by default only tries to match at least one axis between the content (the final view) and the bound (the ImageView bounding box). We need to make sure that the content fully fills the bound to exactly match the shapes.

Test: Manual
Fix: 221496442
Change-Id: I7c142d52b7bfbd0e266a917c27cbd40691fbf3c2
2022-06-22 20:59:32 +00:00
Brandon Dayauon 65590cb071 Fix work toggle button that gets blocked by threeButton nav bar on TABLETS
Ex) for tablets.. the nav bar height is really the height of the taskbar.
	Thats why we add the current padding of the work toggle button to the
	taskbar size.

As of patchset 3.. I reverted mDevice.getInsets().bottom because it caused
the button to be higher than it should be on landscape.
Bug: 235053326
Test: Manual (pictures in  bug thread)

Change-Id: I2f77d759ae060311d049182e8347dede590cd0b0
2022-06-22 13:21:25 -07:00
Sunny Goyal 24b441051e Fixing wrong flags used by AllAppsController in SystemUiController
Bug: 236857339
Test: Verified the UI manually
Change-Id: I2773837932ed50a59ebc9d2810f9e7ee501b6f6b
2022-06-22 12:09:22 -07:00
Sunny Goyal 80179921f3 Merge "Removing non-launcher engineers from the Launcher OWNERS file" into tm-qpr-dev 2022-06-22 18:16:20 +00:00
vadimt 020c9e4b22 Remove unused tracing; it confuses investigators
Bug: 196820244
Test: presubmit
Change-Id: If403f475f393fc95e5efd098ae63c8e8bb199ddc
2022-06-22 17:10:08 +00:00
Alex Chau 05e6d084ec Disable header protection on tablets
- Also listen for config chagne in FloatingHeaderView

Fix: 218500759
Test: Change screen size between phone and tablet, header protection is only enabled for phone
Change-Id: I65120080641ea75ae58c010c4a27fe2b1539e0b5
2022-06-22 18:09:35 +01:00
Sebastian Franco 9097d7d09f Added a content call to emulate the other devices displays
Running the following commands should change your connected
device display:

  adb root
  adb shell setprop ro.test_harness 1
  adb shell pm enable --user 0 com.google.android.apps.nexuslauncher/com.android.launcher3.testing.TestInformationProvider
  adb shell content call --uri content://com.google.android.apps.nexuslauncher.TestInfo --method emulate-display --extra device:s:pixel5 --extra grid:s:crazy_big
  adb shell setprop ro.test_harness 0

Alternative method for this is using
  ./display_emulator.py emulate --device pixel5

I hooked up the existing DisplayEmulator into a content
provider. Doing this has a couple advantages to the previous method
of calling the emulator inside of a test. The biggest one is
that running the emulation doesn't restarts the Launcher3,
and because of that the previous method could leave the user in a
fake emulation where it looks like the device is being emulated but
is not 100% accurate.

Test: Run the command lines described above.
Fix: 229666646
Change-Id: Ia039fbaf4c7330d6bdf469633127f58d2466a1bf
2022-06-22 09:36:52 -07:00
Alex Chau 7356c13760 Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev am: ed2e7719cb am: 90abf51d5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19015866

Change-Id: I3d68a995880a27c953164e2d4767f63ab38b0bfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 12:39:41 +00:00