Commit Graph

6667 Commits

Author SHA1 Message Date
Lucas Dupin b259a896f5 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
2021-08-13 15:57:41 -07:00
Dave Mankoff 78f9648aec Merge "Changes to the signature of PluginManagerImpl." into sc-v2-dev 2021-08-13 21:12:40 +00:00
Jon Spivack bb7553017c Add callback to ImageActionUtils for unresolved intents
Adding an optional callback to ImageActionUtils.persistBitmapAndStartActivity allows for external handling of the case in which the given intent cannot be resolved. The main use case is for NIU Actions when the user has chosen an assistant that does not support the feature. TaskOverlayFactoryGo provides a callback that shows a dialog in this case.

Various parts of TaskOverlayFactoryGo were also made public for better testability.

Bug: 196125662
Bug: 192406446
Bug: 195681795
Test: m -j RunLauncherGoGoogleRoboTests ROBOTEST_FILTER=TaskOverlayFactoryGoTest
Change-Id: I64f3a1274bc942a64e964dca20bd4245e336ad9d
2021-08-13 13:30:22 -07:00
Dave Mankoff 3258a9f790 Remove #handleWtfs from PluginInitializer.
This method was empty anyways.

Bug: 194781951
Test: manual
Change-Id: I404704090dc360e05b1db04815d394d47d63af28
2021-08-13 14:56:30 -04:00
Dave Mankoff 24e77c563c Remove PluginInitializer.
Bug: 194781951
Test: manual
Change-Id: I38b90ac7f310e4c2374d60a42f493e723c90401a
2021-08-13 14:56:30 -04:00
Dave Mankoff a6646be349 Remove #getPrivilegedPlugins from PluginInitializer.
Bug: 194781951
Test: manual
Change-Id: I61bcbdd92bdf7295060f00dac9b657b1a67b7f01
2021-08-13 14:56:26 -04:00
Dave Mankoff 08d1a77825 Rename PluginInstanceManager to PluginActionManager.
New PluginInstance class.

Bug: 194781951
Test: manual
Change-Id: I5274b6380acaad8bb2e900cfdce772b71add9483
2021-08-13 10:50:32 -04:00
Dave Mankoff 1095a50dfa Updates to constructor of PluginInstanceManager.Factory
Bug: 194781951
Test: manual

Change-Id: I510dcd3b405988320052944b412e1d18360144ef
2021-08-13 10:50:21 -04:00
Dave Mankoff 630ae94833 Pass main executor to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I1667023887e0c8d1dc86fce1717a3032b6721684
2021-08-13 10:18:01 -04:00
Dave Mankoff 1d5e1dc8d1 Pass Executor to to PluginInstanceManager.Factory.
Bug: 194781951
Test: manual
Change-Id: I6dc699869d041aab8f5d1e7a128b4f67adfd78dc
2021-08-13 10:16:09 -04:00
Dave Mankoff 13f50b9898 Changes to the signature of PluginManagerImpl.
Bug: 194781951
Test: manual
Change-Id: Iafc5232dfdb1cc1c554de925c2f0d2ad5f6439e2
2021-08-13 10:01:42 -04:00
Ben Lin 15181b54b0 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev am: 99b5d13952 am: c3d09d22c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524184

Change-Id: I4025427c229838a0104625a266100fcfc184c066
2021-08-13 10:08:32 +00:00
Ben Lin 99b5d13952 Merge "Do not set user active hints when Shell Transition is on." into sc-v2-dev 2021-08-13 01:09:19 +00:00
Ben Lin 1e49216401 Do not set user active hints when Shell Transition is on.
Previously, we hint at user active in order to let the launcher know at
an earlier time that the user is about to go home, to provide PiP a
shelf offset. However with Shell Transitions, this is now being done
instantly as the launcher activity is resumed right as user touches down
on the gesture pill. We then no longer need this for shell transitions.

Bug: 165793917
Test: Enable Shell Transitions, go home to enter PIP, and open another
app - see that PIP auto moves downward now that shelf height has changed

Change-Id: I347c885425ce820a42ebfcc15082862d04aa1a7d
2021-08-12 15:17:31 -07:00
TreeHugger Robot 4e9ea58712 Merge "Clean up test logging and ScreenRecord" into sc-v2-dev am: 662af98956 am: 3c7c23aa02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15542317

Change-Id: I98e7524b37523af64d992768ee073293e748eb71
2021-08-12 18:35:46 +00:00
Alex Chau 2886a13d7a Clean up test logging and ScreenRecord
Bug: 194114179
Bug: 193125090
Test: manual
Change-Id: I086d011a39b74a24d5629d43dc74b741fcf5994e
2021-08-12 11:34:27 +01:00
TreeHugger Robot 3be0173b14 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: Id2a24af3aed6fa4819a2fc46c8a305b06ff31d84
2021-08-12 00:31:19 +00:00
Nick Chameyev 41bbb285a7 Merge "Add unfold animation to launcher icons and widgets" into sc-v2-dev am: 02c0c924a6 am: 79690a5b74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15390834

Change-Id: I28062ec9243c25e44ae496647475d13da74fe239
2021-08-11 18:30:29 +00:00
Nick Chameyev 02c0c924a6 Merge "Add unfold animation to launcher icons and widgets" into sc-v2-dev 2021-08-11 18:04:03 +00:00
Lucas Dupin 3f6a4e6bf5 Adjust all apps zoom level
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.

Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
(cherry picked from commit f168bb7aaf)
2021-08-11 15:55:04 +00:00
Nick Chameyev 5e8dbe77e8 Add unfold animation to launcher icons and widgets
Adds unfold animation to launcher which translates
icons and widgets from the center to the sides on
foldable devices.

Bug: 193794541
Test: manual
Change-Id: I9d6e018a0451d342f02dddea47bc180781c31d43
2021-08-11 16:10:18 +01:00
Thales Lima 931bc2a38e navigation: don't run gesture animation if gestures are not enabled
Makes the animation when using 3 button navigation be closer to what we
have in non fallback mode, also fixing the problem when fallback recents
just started and don't have any views.

Fix 194487871
Test: manual with gestures, 2 button and 3 button nav

Change-Id: If3925d6bef1d14f51b86169d06607786972f5f1f
(cherry picked from commit 8d49c4bb29)
2021-08-11 10:26:22 +00:00
Tracy Zhou c84a005e8c Merge "Taskbar should animate immediately when tapping a live tile" into sc-v2-dev am: 255887ccdc am: 490ca1926d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15467635

Change-Id: I94e8157686cadc71556c6307770b19b593fc5421
2021-08-11 04:45:26 +00:00
Tracy Zhou 255887ccdc Merge "Taskbar should animate immediately when tapping a live tile" into sc-v2-dev 2021-08-11 04:24:12 +00:00
Lucas Dupin d7780bfc1b Merge "Act on scrim visibility" into sc-v2-dev am: f006d37acf am: 5cb3be6139
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15506183

Change-Id: I3093cf40a13fcafe3188edd9f5b4bd61f3cb3132
2021-08-11 03:27:53 +00:00
Lucas Dupin f006d37acf Merge "Act on scrim visibility" into sc-v2-dev 2021-08-11 02:59:05 +00:00
Tracy Zhou ae0c16dd0c Taskbar should animate immediately when tapping a live tile
Fixes: 194728948
Test: manual
Change-Id: Ia2bf9e4d050367ac08e3308a308f19f04577c49e
2021-08-10 16:30:29 -07:00
Tony Wickham 0b3b2921c3 Don't recreate touch controllers when ending gesture
Test: swipe up to overview from an app and swipe up to dismiss it during the transition
Bug: 189700453
Change-Id: I303696f90dbb236ea93e06d94a3c92d783850fa4
(cherry picked from commit 0e9ecaeea8)
2021-08-10 23:26:33 +00:00
Lucas Dupin e4a9469156 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
2021-08-10 14:18:50 -07:00
TreeHugger Robot 69aa055900 Merge "Tune swipe up resistance" into sc-v2-dev am: 49ee541bc5 am: a1e73e039d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15479547

Change-Id: I450691305a9531bd171dbea01cb376765c84b7ff
2021-08-10 17:22:22 +00:00
TreeHugger Robot 4596fc4eff Merge "Don't call TaskView.onRecycle when moving focused task to front" into sc-v2-dev am: 874d9aff0e am: 8911425fdd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15502872

Change-Id: I29e5058092c2d686fa7c44bbb22c9e2127e1b7c3
2021-08-10 17:22:15 +00:00
TreeHugger Robot 49ee541bc5 Merge "Tune swipe up resistance" into sc-v2-dev 2021-08-10 17:09:56 +00:00
TreeHugger Robot 874d9aff0e Merge "Don't call TaskView.onRecycle when moving focused task to front" into sc-v2-dev 2021-08-10 16:53:51 +00:00
Lucas Dupin ebb72046b4 Merge "Adjust all apps zoom level" into sc-v2-dev am: 830b12efad am: 0766953697
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15506188

Change-Id: Id182848158e9e3aa1d7c28cbbe960b60be7a03d1
2021-08-10 15:45:46 +00:00
Lucas Dupin 830b12efad Merge "Adjust all apps zoom level" into sc-v2-dev 2021-08-10 15:21:10 +00:00
Lucas Dupin f168bb7aaf Adjust all apps zoom level
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.

Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
2021-08-09 17:45:22 -07:00
TreeHugger Robot 273ccb1452 Merge "Add logs when runningTaskView after re-binding tasks is null." into sc-v2-dev am: 264f6a4b69 am: 7342783ba5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15463436

Change-Id: I328dcbc7d9fb80140fbdd554f7f17744d94a10dc
2021-08-09 22:31:58 +00:00
Vinit Nayak 1a8f7120c1 Add logs when runningTaskView after re-binding tasks is null.
Bug: 195430732
Change-Id: If776c834bc2b06000230d853aeff58094e1fe88c
2021-08-09 13:42:40 -07:00
Alex Chau be767c9108 Don't call TaskView.onRecycle when moving focused task to front
- onRecycle removes the icon cache resulting on icon disappearing when entering overview
- only call necessary view transform reset in moveFocusedTaskToFront

Bug: 195415765
Test: quick switch, launch app then swipe up
Change-Id: Iadb7287ea307a3a4aa0acce2e37837142aeb90db
2021-08-09 19:06:01 +01:00
TreeHugger Robot 0124f54c9c Merge "Add logs to MotionPauseDetector" into sc-v2-dev am: e649047f05 am: 27c8f0fa42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15479531

Change-Id: I0191e17de9a6de29612825ee13522c5f63b0505e
2021-08-09 17:38:58 +00:00
Alex Chau 1338dd7e71 Add logs to MotionPauseDetector
- Add logs to MotionPauseDetector to confirm if the current 700ms timeout is enough for tests

Bug: 194114179
Test: atest NexusLauncherOutOfProcTests:com.android.launcher3.memory.MemoryTests#testAppLaunchFromWorkspace
Change-Id: Ifc3e8a24c245b1877e3fae5d2cb96636c34e8e4b
2021-08-09 15:56:11 +01:00
Alex Chau 26a5f7f8cb Tune swipe up resistance
- Make TaskView only scale between startResist scale and until maxResist scale's TaskView top touches 100% scale's TaskView top (https://drive.google.com/file/d/1r0qdP9TOTYw2upkJ-jEP8BAfLsrv8EOa/view)
- Tuned the scaling parameter for tablet

Bug: 194190263
Test: manual
Change-Id: Ibc3e82744c5a6a8ce4207dff30d80889c66aa038
2021-08-09 15:52:52 +01:00
Alex Chau 41d913a90f Merge "Only refresh DISABLED_NO_THUMBNAIL when thumbnail changes" into sc-v2-dev am: 55861dc50b am: 23af5955e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15455164

Change-Id: I9d7b00eb56bdb1760443f7805569dcb219fdbc57
2021-08-06 18:08:48 +00:00
Alex Chau 55861dc50b Merge "Only refresh DISABLED_NO_THUMBNAIL when thumbnail changes" into sc-v2-dev 2021-08-06 17:41:11 +00:00
TreeHugger Robot af42b54626 Merge "Prevent NPE when resetting divider bar visibility" into sc-v2-dev am: 5a25696bfd am: 541a1a6da5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472699

Change-Id: I62a970d75b5be3c9a48605e8b343305d2b0fe4ec
2021-08-06 05:34:43 +00:00
TreeHugger Robot 5a25696bfd Merge "Prevent NPE when resetting divider bar visibility" into sc-v2-dev 2021-08-06 05:06:54 +00:00
Jerry Chang 6368746a3c Prevent NPE when resetting divider bar visibility
Fix: 195325902
Test: atest
com.android.launcher3.memory.MemoryTests#testActivityRecreation
--rerun-until-failure

Change-Id: I12c48fe2834a225c5f7d042be632ddd29135b7c5
2021-08-06 09:59:31 +08:00
TreeHugger Robot b30a2798f9 Merge "Invoke home via recents for fallback recents" into sc-v2-dev am: 9b762e9778 am: e10975e88e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15430812

Change-Id: I1a92f87d03c59f53212d8edc27ddce42456f5b9c
2021-08-05 22:34:30 +00:00
TreeHugger Robot 9b762e9778 Merge "Invoke home via recents for fallback recents" into sc-v2-dev 2021-08-05 22:11:13 +00:00
Vinit Nayak 8d51468426 Invoke home via recents for fallback recents
Fixes: 194286702
Test: Go home from app and overview for
3P and normal launcher (test via separate recents activity
in debug menu)

Change-Id: Ifac4afbfa549265a80448ee460a780bf0984f9e1
2021-08-05 11:52:25 -07:00