Commit Graph

6667 Commits

Author SHA1 Message Date
Lucas Dupin 0c70dbdc5e Synchronize surface transaction
Until now the SurfaceControl transaction was being applied
asynchronously, which could lead to it being executed out of sync with
launcher drawing.
This became an issue at higher refresh rates, where frames are produced
at a much faster pace.

In order to fix this issue, we can use BLAST transactions, which are
annotated with a frame number.

Test: record video, go through it manually
Fixes: 194320152
Change-Id: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
2021-08-24 14:17:59 -07:00
Vinit Nayak 46e0999612 Merge "Rely on presense of divider target to determine split screen state" into sc-v2-dev 2021-08-24 21:17:07 +00:00
Andy Wickham e79958a27f Merge "Adds additional pages to Taskbar Edu." into sc-v2-dev am: 7b65460e9a am: a3c9a23aa0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15618164

Change-Id: I7110aac2d8dee5cd1ee92c52b881807093350032
2021-08-24 19:26:12 +00:00
Andy Wickham 7b65460e9a Merge "Adds additional pages to Taskbar Edu." into sc-v2-dev 2021-08-24 18:37:17 +00:00
Alex Chau 58563314f9 Avoid unnecessary onLayout if gesture is going to state without overview panel am: 96ffcbcd2d am: 1692ad67b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15667340

Change-Id: Iabedca525966b0911a068a4047a84fdfe6789678
2021-08-24 16:40:06 +00:00
Alex Chau 96ffcbcd2d Avoid unnecessary onLayout if gesture is going to state without overview panel
Fixes: 186508379
Test: swipe up to carousel, then to home
Test: quick switch, immediately swipe up to overview, then to home
Change-Id: I0b28e163cbb289a636a89bc52c43a1977a59d86f
2021-08-24 12:43:56 +01:00
Alex Chau df2b9e14d6 Fix animation problem when swipeing up app to screen edge and release
- Consider scroll diff between currentPage and primary scroll when calculating adjacent page offset
- Removed setEnableFreeScroll call in onPrepareGestureAnimation that calls setCurrentPage and causes jumping

Fixes: 197012570
Fixes: 195740577
Test: Swipe up from app to end of screen, adjacent task should come from screen edge, and app should snap smoothly to position
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Test: Swipe up immediately after quick switch, task thumbnails are loaded
Change-Id: Id88266634183dfcb18d5ba8a803883b7d6f50ab4
Merged-In: I1964b8c3bd82b22396340d2352833b2aee73a6fc
(cherry picked from commit 8ebd11af14)
2021-08-24 10:11:41 +00:00
TreeHugger Robot a9c8856f0c Merge "More logging for for Nexus home activity appearing after to-home gesture in L3" into sc-v2-dev am: 19a616f268 am: 1dda3da8f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15661934

Change-Id: If38fbc1c534d3e9ec313f90dbedf720ae324aef0
2021-08-24 09:45:27 +00:00
TreeHugger Robot 19a616f268 Merge "More logging for for Nexus home activity appearing after to-home gesture in L3" into sc-v2-dev 2021-08-24 09:04:12 +00:00
TreeHugger Robot 71a546e470 Merge "Revert "Move/Launch task on the TaskView's display."" into sc-v2-dev am: 02fe560dc8 am: 93b4db052d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15659824

Change-Id: I5e209768abd86a38d721340ebbd46cb2af8afc28
2021-08-24 07:45:22 +00:00
TreeHugger Robot 02fe560dc8 Merge "Revert "Move/Launch task on the TaskView's display."" into sc-v2-dev 2021-08-24 07:14:31 +00:00
Jerry Chang 6ca6de89c0 Revert "Move/Launch task on the TaskView's display."
This reverts commit 2cdc359b84.

Reason for revert: this brokes split screen and result to device reboot.
Bug: 197293995

Change-Id: I154287230fa3849cad1c0e337e3bf3fd826257a4
2021-08-24 04:54:49 +00:00
Andy Wickham a0cc0903e8 Adds additional pages to Taskbar Edu.
Currently there are pages for the following:
 - Splitscreen
 - Customize (add apps/predicted apps)
 - Docking (long press to hide)

At the moment they all use the same placeholder
image from before.

Button states:
 Page 1: Close and Next
 Page 2: Back and Next
 Page 3: Back and Done

You can also swipe left and right between the pages.

Demo: https://drive.google.com/file/d/1_D3i-jZxCRRVHV92p6hG5cm3VGcJ_bhK/view?usp=sharing&resourcekey=0-KHLHTTx67JlmVv-UZoAUAw

Bug: 180605356
Test: Manual
Change-Id: Ibbb81610a611f6ca412e53ed90dc1c67764f417e
2021-08-23 15:12:39 -10:00
TreeHugger Robot 73d197222b Merge "Draw rounded corners above the taskbar" into sc-v2-dev am: 83e6d67e37 am: a2d2886007
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15662818

Change-Id: I71835d0183970e86df73675bcefd23f79d13af06
2021-08-24 00:47:02 +00:00
TreeHugger Robot 83e6d67e37 Merge "Draw rounded corners above the taskbar" into sc-v2-dev 2021-08-24 00:18:34 +00:00
Vinit Nayak 98314d0d4b Rely on presense of divider target to determine split screen state
* Don't rely on the number of leashes, since an app with
assistant invoked returns multiple remote app targets
even though the device isn't in split screen

Fixes: 197293347
Test: Repro steps in bug don't cause crash.
Less fatal bugs need to be addressed,
TODO(b/197568823)

Change-Id: I3432e3d8c54a433dd38d297db73ea3d46bad7ba9
2021-08-23 16:30:56 -07:00
Tony Wickham dd7a418335 Draw rounded corners above the taskbar
- Increase height of taskbar window, but not contentInsets
- Draw the inverted corners as part of TaskbarDragLayer#dispatchDraw() (which handles the background already)

Test: visual

Bug: 196257194
Fixes: 197129604
Change-Id: I517949a4c2b97c92e3bb43408776db6deb1379b4
2021-08-23 15:33:43 -07:00
Lucas Dupin f52fb6f632 Act on scrim visibility am: a8382dc052
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15655786

Change-Id: I40626071bdaadd997cc1479118224847b78229d3
2021-08-23 21:34:23 +00:00
vadimt bea7e2ee6e More logging for for Nexus home activity appearing after to-home gesture in L3
Bug: 192018189
Test: presubmit
Change-Id: I92cfa9e40f71773e636c700ab7f84df1d9feac19
2021-08-23 13:57:51 -07:00
Vinit Nayak e07bab8c7f Null out RemoteTargetHandles as soon as finishing recents is requested
* Instead of waiting for recents animation to be complete
before we stop manipulating remote leashes, stop it as soon
as RecentsView gets the request.

Bug: 197232424
Change-Id: I7f3cb6d2fc389d502e57054f60f28e7967212194
2021-08-23 13:56:30 -07:00
Schneider Victor-tulias 33277fcf8a Merge changes I3e7d3c61,I1cba811c into sc-v2-dev am: f4f6c0fd4f am: 8cb3df4896
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15394096

Change-Id: Ida8739d4e792f82ce9c64772756d1e21f4449df9
2021-08-23 20:17:37 +00:00
Schneider Victor-tulias f4f6c0fd4f Merge changes I3e7d3c61,I1cba811c into sc-v2-dev
* changes:
  Convert gesture navigation feedback videos to animations with real callbacks.
  Convert gesture navigation tutorial still image vector drawables to layout files
2021-08-23 19:49:30 +00:00
Lucas Dupin a8382dc052 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
2021-08-23 19:22:02 +00:00
Schneider Victor-tulias 69c4b54dce Convert gesture navigation feedback videos to animations with real callbacks.
Fixes: 192939067
Test: manual, started full tutorial, started home, back and overview individually, locked and unlocked phone mid-tutorial step.
Change-Id: I3e7d3c6153eeff6273e4b7ebc8cdb8328df7facc
2021-08-23 11:14:53 -07:00
Schneider Victor-tulias ff322310a3 Convert gesture navigation tutorial still image vector drawables to layout files
Bug: 192939067
Test: manual, started full tutorial, started home, back and overview individually, locked and unlocked phone mid-tutorial step.
Change-Id: I1cba811c556139bc9ba52459f1b27f21eb156ac0
2021-08-23 11:14:04 -07:00
Alex Chau 6f67e076bf Merge "Fix animation problem when swipeing up app to screen edge and release" into sc-v2-dev am: c8295216d5 am: 56a328c6ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15612008

Change-Id: I1964b8c3bd82b22396340d2352833b2aee73a6fc
2021-08-23 11:46:49 +00:00
Alex Chau c8295216d5 Merge "Fix animation problem when swipeing up app to screen edge and release" into sc-v2-dev 2021-08-23 11:18:49 +00:00
TreeHugger Robot e46e09469e Merge "Allow clipping individual direction of TaskView" into sc-v2-dev am: 47fde77687 am: 05e80c0b43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15602537

Change-Id: If87770f3b136e8874fcba50bd1916d450eee1c53
2021-08-20 19:49:51 +00:00
TreeHugger Robot 47fde77687 Merge "Allow clipping individual direction of TaskView" into sc-v2-dev 2021-08-20 19:22:19 +00:00
TreeHugger Robot 7fc8bf586d Merge "Snap to current page's relative position after dismissal." into sc-v2-dev am: 35e09fe019 am: c762676cfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15596523

Change-Id: Ic9c0551bc65df436009295ec1980b38eab9992fc
2021-08-20 13:19:26 +00:00
TreeHugger Robot 35e09fe019 Merge "Snap to current page's relative position after dismissal." into sc-v2-dev 2021-08-20 12:54:10 +00:00
Alex Chau 8ebd11af14 Fix animation problem when swipeing up app to screen edge and release
- Consider scroll diff between currentPage and primary scroll when calculating adjacent page offset
- Removed setEnableFreeScroll call in onPrepareGestureAnimation that calls setCurrentPage and causes jumping

Fixes: 197012570
Fixes: 195740577
Test: Swipe up from app to end of screen, adjacent task should come from screen edge, and app should snap smoothly to position
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Test: Swipe up immediately after quick switch, task thumbnails are loaded
Change-Id: Id88266634183dfcb18d5ba8a803883b7d6f50ab4
2021-08-20 12:07:08 +00:00
Pat Manning 0abfe4e7be Snap to current page's relative position after dismissal.
Test: manual
Fix: 196200215
Change-Id: Ic65313e2082ca2248e5860b77c438615c62b5581
2021-08-20 11:10:26 +00:00
shawnlin 7b4ab1213e Update QuickStepContract.getWindowCornerRadius API
Update from getWindowCornerRadius(Resources) to
getWindowCornerRadius(Context)

Bug: 131221697
Test: make
Change-Id: Ia5f10e9292e205dab7e69d97dfc82d17690816fb
2021-08-20 05:50:41 +00:00
Sunny Goyal 39aa2e0f1d Moving OrientationTouchTransformerTest to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: Ifb0b00f789214a8dde246ab13703211d536364af
2021-08-19 12:03:26 -07:00
TreeHugger Robot 2d19e0e0a3 Merge "Null out reference to RemoteAnimationTargets when animation finishes" into sc-v2-dev am: a35786c9c5 am: 7c90a47f5e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15616976

Change-Id: I5fb894f8a356ef51528c6c291371e7ef0fb95b5f
2021-08-19 18:12:24 +00:00
TreeHugger Robot a35786c9c5 Merge "Null out reference to RemoteAnimationTargets when animation finishes" into sc-v2-dev 2021-08-19 17:39:17 +00:00
Prabir Pradhan 4fbd2f2252 Revert^2 "Enable input window rotation flag"
Reland the per-window-input-rotation flag. It was reverted because it
broke touch on foldables. The issue is now fix, so attempt to reland
this.

312a44adba

Bug: 179274888
Test: presubmit
Test: manual using foldable

Change-Id: Icb18baf81875e32535e277f9c4246be669013a03
2021-08-19 15:00:40 +00:00
Nick Chameyev 7791e400ff Merge "Update unfold transition package name" into sc-v2-dev am: 88cd9aaa6b am: 3ed2933399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15612007

Change-Id: I9ce14d7b70ebf61757aa145925ce339cdfdf98b5
2021-08-19 11:15:08 +00:00
Nick Chameyev 88cd9aaa6b Merge "Update unfold transition package name" into sc-v2-dev 2021-08-19 10:53:44 +00:00
IRIS YANG 543cf3ea95 Merge "Move/Launch task on the TaskView's display." into sc-v2-dev am: 829264a650 am: 2be95b5759
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15604010

Change-Id: Ia325cd8c74103d2d950a5fd359325fd5b1cf3316
2021-08-19 09:19:18 +00:00
IRIS YANG 829264a650 Merge "Move/Launch task on the TaskView's display." into sc-v2-dev 2021-08-19 08:58:13 +00:00
shawnlin 4e15fe0726 [DO NOT MERGE] Update QuickStepContract.getWindowCornerRadius API
Update from getWindowCornerRadius(Resources) to
getWindowCornerRadius(Context)

Bug: 131221697
Test: make
Change-Id: Ia5f10e9292e205dab7e69d97dfc82d17690816fb
2021-08-19 15:52:10 +08:00
TreeHugger Robot 4535d2bd79 Merge "New app animation specs." into sc-qpr1-dev am: 686d42a1d4 am: 7e5f1003bd am: d4e7420c52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15587964

Change-Id: I811c983b2eab6ace95057f894e37cacd3b320bab
2021-08-19 01:24:36 +00:00
TreeHugger Robot d4e7420c52 Merge "New app animation specs." into sc-qpr1-dev am: 686d42a1d4 am: 7e5f1003bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15587964

Change-Id: I9cc84e593c3a4520468a29d0196d29e635704ea6
2021-08-19 01:11:41 +00:00
TreeHugger Robot fe5ce7334a Merge "New app animation specs." into sc-qpr1-dev am: 686d42a1d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15587964

Change-Id: If21b096b1d5ac025ffb4116c805d31acba6cc662
2021-08-19 00:57:46 +00:00
TreeHugger Robot 686d42a1d4 Merge "New app animation specs." into sc-qpr1-dev 2021-08-19 00:45:05 +00:00
Vinit Nayak b5a4e05e2a Null out reference to RemoteAnimationTargets when animation finishes
Bug: 195430732
Test: Re-ran FallbackRecentsTest#testOverview, passes
Change-Id: If9be3429516caface998561fbcc8223e256d0fdf
2021-08-18 16:37:14 -07:00
Vinit Nayak 9c8bf15e17 Merge "Respect StatusBarManager back/home disable flags" into sc-v2-dev am: f8d55e0e2a am: 2b79ee7200
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15590495

Change-Id: I858d68cb3d5367fb6add19e419b9869acb220666
2021-08-18 23:36:20 +00:00
Bryce Lee 1c907a3fdc Merge "Revert "Draw rounded corners above the taskbar"" into sc-v2-dev am: 6e2d149ac7 am: 1815efeaa8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15614359

Change-Id: I4a33c6c7a97cb58b906b563e5b453d86e4c62933
2021-08-18 21:30:41 +00:00