Commit Graph

6667 Commits

Author SHA1 Message Date
Vinit Nayak d1a70eeb75 Slight polish for split screen gesture animation
* Divider bar dimensions manually calculated since
the leash that is provided has bounds larger than
the space that is visually shown between the two split
apps

Bug: 181704764
Test: Swipe up on large and normal screen,
w/ and w/o home rotation enabled

Change-Id: I1fde053151d47c6ce3e11f16f8ae4a153d273871
2021-09-08 17:39:49 -07:00
Vinit Nayak fc119626fe Merge "Refactor TaskViewUtils to launch adjacent GroupedViewTaskView" into sc-v2-dev am: 9d4966d0ca am: bd1f937198
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15619054

Change-Id: I83321ecd9c278495af6cc2333e69a4f7cbb71a95
2021-09-08 23:43:12 +00:00
Vinit Nayak 9d4966d0ca Merge "Refactor TaskViewUtils to launch adjacent GroupedViewTaskView" into sc-v2-dev 2021-09-08 23:18:25 +00:00
Vinit Nayak 1409d29773 Refactor TaskViewUtils to launch adjacent GroupedViewTaskView
* TaskViewUtils only used one TVS, now it can use
multiple necessary for staged split.
* Consolidate creating RemoteAnimationTargets into
TaskViewSimulators/TransformParams into RemoteTargetGluer

Test: Swipe to overview, tap on running task.
Swipe to overview, tap on adjacent task (single + split)
Bug: 195675206

Change-Id: I31e4aece60e2eaf94ce87ffc736b33fe7e0e5804
2021-09-08 23:18:11 +00:00
Vinit Nayak 95f4acc95a Merge "Show all nav buttons when IME showing" into sc-v2-dev am: fd5e2ff933 am: 032ea8af12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15780327

Change-Id: Idc6cc4804c5ce9fe94973e1ec82aaba513095f1b
2021-09-08 22:03:11 +00:00
Vinit Nayak fd5e2ff933 Merge "Show all nav buttons when IME showing" into sc-v2-dev 2021-09-08 21:44:01 +00:00
Vinit Nayak 84511f2997 Call exitSplitScreen() when user leaves split tasks
* Also call it when user swipes to home

Fixes: 198310766
Test: Tested QS'ing split to fullscreen,
full to split, swipe to home from split and fullscreen

Change-Id: I6a465ead7fcd68dc85e0ab401789f4a5c3feb0d1
2021-09-08 13:02:29 -07:00
TreeHugger Robot 8b91fdfffb Merge "Moving roboelectic tests to instrumentation tests" into sc-v2-dev am: b44b73ee3a am: 9f17e2e6c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15778398

Change-Id: I851ad5485e6cbff4d6207112b1420df165a311b1
2021-09-08 19:19:32 +00:00
TreeHugger Robot 41e171143b Merge "isable taskbar edu for tests" into sc-v2-dev am: f87a7409b2 am: 399a391857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15779384

Change-Id: I03a1fe2e9960437b6f524948f1b528f76bca2e60
2021-09-08 19:19:20 +00:00
TreeHugger Robot b44b73ee3a Merge "Moving roboelectic tests to instrumentation tests" into sc-v2-dev 2021-09-08 18:40:37 +00:00
TreeHugger Robot f87a7409b2 Merge "isable taskbar edu for tests" into sc-v2-dev 2021-09-08 18:36:08 +00:00
Tony Wickham 800336ecad Merge "Update taskbar color in onConfigurationChanged()" into sc-v2-dev am: 238bf4f30d am: ad42bf08d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15779380

Change-Id: Iae43b524b98fd34824e62554130dcd66cd5a706c
2021-09-08 15:40:07 +00:00
Nick Chameyev 9e0d0ed0de [Taskbar icons unfold animation issue] Do not take into account initial translation
Removes taking into account initial translation in
move from center animation. Initially it was done
because in StatusBar items are aligned using translations
but we decided to use different approach there so it is
not necessary anymore.

Now move from center animator can only set translations
from positive/negative value when progress is 0 and sets
it to 0 when progress is 1 (previously it was 'capturing'
the initial translation and animated the translation to
its original value).

Taskbar icons are pre-aligned using translations when
user is on launcher. After several folds/unfolds these
translations were accumulating that led to incorrect
positioning of the icons.

Found one more issue that we didn't clear the animated
views list after finishing the animation in taskbar unfold
animation controller but it didn't affect the animation
itself.

Test: atest com.android.systemui.shared.animation.UnfoldMoveFromCenterAnimatorTest
Test: unfold on launcher and use gesture nav to swipe to an app
Fixes: 199126683
Change-Id: Icfb29d79fdd8f04eb5a9a369a3d01c15fd321c75
2021-09-08 16:39:15 +01:00
Tony Wickham f8a064f347 isable taskbar edu for tests
Test: clear TASKBAR_EDU_SEEN pref, ensure edu shows during normal usage
Bug: 199100151
Change-Id: I8e59cfa22ccba77c588a0902d46021dd72c6e77d
2021-09-08 08:10:16 -07:00
Tony Wickham 238bf4f30d Merge "Update taskbar color in onConfigurationChanged()" into sc-v2-dev 2021-09-08 15:08:36 +00:00
Sunny Goyal 3e9a29c4d6 Moving roboelectic tests to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: I197bc47181308bb0b79f3815a892b733abbcd1fd
2021-09-08 10:23:30 -04:00
Tony Wickham abaa481bfb Update taskbar color in onConfigurationChanged()
Test: Change wallpaper, ensure taskbar updates to match
Fixes: 199045474
Change-Id: I7ec8bbec8e31d2d03c09bf487ab55c86b95917e7
2021-09-07 15:39:53 -07:00
Samuel Fufa b5a33b2d34 Merge "Remove HotseatEduActivity from AOSP" into sc-qpr1-dev 2021-09-07 21:55:23 +00:00
Vinit Nayak 7f4f499515 Show all nav buttons when IME showing
* Keep home and recents button, and rotate back button
to be down when IME shows in 3 button task bar.
* Move IME switcher to left side of taskbar for 3 button,
keep on right side for gesture nav.

Bug: 191399224
Test: Tested RTL and LTR, gesture + button nav
with and w/o IME.

Change-Id: I7959d26986e546596e2436b8b5eb7668f44b55cf
2021-09-07 14:43:17 -07:00
TreeHugger Robot cf8dc2b3d1 Merge "Always reset focusedTask to -1 on reset" into sc-v2-dev am: 915f6a0995 am: f598f6d3de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15757128

Change-Id: I6d9941df048e380a80abd8e166365ef5d9314968
2021-09-07 20:41:41 +00:00
Alex Chau 32d872b840 Merge "Only call setCurrentPage in applyLoadPlan if mCurrentPage is outdated" into sc-dev am: 464fc41df7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15742147

Change-Id: I13e5176c8f53e176d8e94f418828452019deb8ff
2021-09-07 17:44:44 +00:00
Alex Chau a8da6905a9 Always reset focusedTask to -1 on reset
- Keep old focused task causes old focused task to be restored after applyLoadPlan: http://cs/android/packages/apps/Launcher3/quickstep/src/com/android/quickstep/views/RecentsView.java?l=1365
- This caused the nth task to be focused rather than the first task
- The fix is to reset focusedTask in reset when exiting overview, focused task will be set properly next time through applyLoadPlan when overview is relaunched

Fix: 199150523
Fix: 198420226
Test: TaplTestsNexus.testOverviewActions
Test: Quick switch > launch app > swipe home > swipe up to overview > snap to focused task
Test: split screen > swipe home > swipe up to overview > snap to focused task
Change-Id: I06399626ed3ee033345bd67296d79d59a98a507f
2021-09-07 18:42:39 +01:00
TreeHugger Robot 663ebae20c Merge "Snap to task from other grid row if dismissing non-snapped focused task and not enough tasks remain in current grid row to snap to." into sc-v2-dev am: 13e121e35a am: ea25f8f6e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15771038

Change-Id: I9ad7a3a19ed7766753f7cb30714cbb2e81bc69a8
2021-09-06 16:37:55 +00:00
TreeHugger Robot 13e121e35a Merge "Snap to task from other grid row if dismissing non-snapped focused task and not enough tasks remain in current grid row to snap to." into sc-v2-dev 2021-09-06 16:16:00 +00:00
Alex Chau 4c946107ea Merge "Hide overview actions when focused task is not snapped" into sc-v2-dev am: 48621c86ab am: fe7c903c20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15771567

Change-Id: Ic32c6ddf4879a6f6ca9994c2cb75c567445adcd6
2021-09-06 15:23:05 +00:00
Pat Manning 017dbbe715 Snap to task from other grid row if dismissing non-snapped focused task
and not enough tasks remain in current grid row to snap to.

Test: manual
Fix: 196200215
Change-Id: I611ffc457769d57ac0d13657fafa73a4a741f877
2021-09-06 14:53:00 +00:00
Alex Chau 61cb7c0310 Hide overview actions when focused task is not snapped
- Overview actions is still click able when focused task is slightly off snap position and the alpha is between 0 and 1
- This is not desired and we should simply hide the actions when focused task is not snapped

Bug: 199040817
Test: manual non grid and non-grid
Change-Id: Ifda800fc4169a05c8128e7b3802d2ab4a5af4ae8
2021-09-06 13:05:35 +01:00
TreeHugger Robot f5d425f085 Merge "Select remote apps based on stagePosition instead of hardcoded values" into sc-v2-dev am: 1e86bd0ec6 am: a0de13e939
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15758691

Change-Id: Ia888167d0d5646ff33f18dcaf8c50beec373e23f
2021-09-04 05:02:55 +00:00
TreeHugger Robot 1e86bd0ec6 Merge "Select remote apps based on stagePosition instead of hardcoded values" into sc-v2-dev 2021-09-04 04:32:10 +00:00
Vinit Nayak 58dd901bc1 Select remote apps based on stagePosition instead of hardcoded values
* LauncherSplitScreenListener returns taskIds guaranteeing index 0
to be leftTop task and index 1 to be rightBottom. Use that
instead of assuming remote target index 0 will be leftTop and
index 1 is right bottom as provided

Bug: 181704764

Change-Id: I2bc358ff3c2f2d127b81e10824e2c13f3ad718df
2021-09-04 04:31:56 +00:00
Tony Wickham a440b1cfdc Call onUserUnlocked() before adding callbacks am: 5a36b919b5 am: eaca6fd847 am: c5bb728a00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15756866

Change-Id: Ic6b4d345180ec65d8ad707e16eb0493cb72dfe50
2021-09-04 03:34:28 +00:00
Tony Wickham c5bb728a00 Call onUserUnlocked() before adding callbacks am: 5a36b919b5 am: eaca6fd847
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15756866

Change-Id: I4b473f821c3ac1ef2c09704574c02fa7fb43d293
2021-09-04 03:22:38 +00:00
Tony Wickham 79ff586c10 Call onUserUnlocked() before adding callbacks am: 5a36b919b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15756866

Change-Id: I03e5411032285015489f4b8bceb8b023e9c12909
2021-09-04 03:13:40 +00:00
Winson Chung 1a236176f7 Merge "Provide internal IME insets" into sc-v2-dev am: 507e976690 am: 95e8108771
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741860

Change-Id: I5f1d51a914084be5d97e0a8d5d51209868c7e92e
2021-09-04 00:16:11 +00:00
Winson Chung 507e976690 Merge "Provide internal IME insets" into sc-v2-dev 2021-09-03 23:46:16 +00:00
TreeHugger Robot 317e7ac796 Merge "Disable FolderNameEditText on Taskbar" into sc-v2-dev am: eb5f5f7807 am: de88f56fc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15756862

Change-Id: I38831495981999a8a0676b7c900377dfe1db248c
2021-09-03 23:24:08 +00:00
Tracy Zhou e23f4ea774 Merge "Stash/unstash the task bar based on states" into sc-v2-dev am: 2ccfa02fde am: 2d0ac589fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15751127

Change-Id: If6b7d39ed2540b00aed606bc2ffb405608124dbb
2021-09-03 23:23:48 +00:00
TreeHugger Robot eb5f5f7807 Merge "Disable FolderNameEditText on Taskbar" into sc-v2-dev 2021-09-03 23:00:33 +00:00
Tracy Zhou 2ccfa02fde Merge "Stash/unstash the task bar based on states" into sc-v2-dev 2021-09-03 22:49:07 +00:00
Tony Wickham 5a36b919b5 Call onUserUnlocked() before adding callbacks
This gives us a chance to initialize things in onUserUnlocked() if we're already unlocked, before doing any other logic that might use those variables.

Test: None (unable to reproduce)
Fixes: 184773649
Change-Id: I72ed91ae6202ec816f9bdceb4d9fd03b9a002816
2021-09-03 22:07:18 +00:00
Hongwei Wang 00c6ce5167 Do not trigger PiP on tapping on TaskView am: bfec974f59 am: 4072b74441
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15749049

Change-Id: Ie51b3ae1acd98dd4b18c821e0c3628675ce8866f
2021-09-03 20:55:22 +00:00
Evan Rosky 80ca459e7d Provide app-process tokens to remote transitions so they can be boosted
The app process token is required for shell to request delegated
transition animators to be boosted.

Bug: 183993977
Test: add logging in WPC.setRunningRemoteAnimation and verify calls
      during transitions
Change-Id: Ide2dd3e77714cca8e85e409c8d88c69c20122827
2021-09-03 13:38:00 -07:00
Tony Wickham d345751849 Disable FolderNameEditText on Taskbar
Test: Can rename folder on home screen, but tapping folder name in taskbar does nothing
Bug: 180051157
Change-Id: Ief19805683f754995baf24d7f41f3979841d5bd3
2021-09-03 12:50:15 -07:00
Tracy Zhou 527b39cd28 Stash/unstash the task bar based on states
Bug: 193938970
Test: go to any app, stash/unstash, and make sure the states are preserved
Change-Id: I3adf826407e90275687ecea8302abf7a004f1df7
2021-09-03 12:43:04 -07:00
Hongwei Wang bfec974f59 Do not trigger PiP on tapping on TaskView
Regression from ag/15158868, we should not send onUserLeaveHint on
tapping on the app icon in Recents / Overview.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/fr0fdecPEned7rMjgdWhCQ
Bug: 198682451
Test: manual, tap on app icon in Recents, see video
Change-Id: I66888a75eec30d7e8ba7e09059399381516812ac
2021-09-03 11:10:05 -07:00
Winson Chung 543c226ffa Provide internal IME insets
Bug: 197727397
Test: Collapse taskbar, open IME
Change-Id: Ia251be1d5892a58b062f241bdafc5dbfc223e4c3
2021-09-03 10:22:56 -07:00
TreeHugger Robot 099514f476 Merge "Animate scrolling grid into place when there is a gap between last tasks and clear all." into sc-v2-dev am: fb0eaf2bee am: 232acae2bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15478152

Change-Id: I607e7ab11956999f60deb6fb4509fd684d385d42
2021-09-03 12:57:57 +00:00
TreeHugger Robot fb0eaf2bee Merge "Animate scrolling grid into place when there is a gap between last tasks and clear all." into sc-v2-dev 2021-09-03 12:23:06 +00:00
Nick Chameyev d36b9916af Merge "Add taskbar icons unfold animation" into sc-v2-dev am: 6b53e3101e am: 4ba84e5343
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15685200

Change-Id: I3b9b38342884e5623c320496496717f5510f3ae0
2021-09-03 11:53:06 +00:00
Nick Chameyev 6b53e3101e Merge "Add taskbar icons unfold animation" into sc-v2-dev 2021-09-03 11:19:22 +00:00