Commit Graph

6667 Commits

Author SHA1 Message Date
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
Vinit Nayak b0ca4b3070 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad am: 0ada7824c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I5fd527ce8f4d20a4c915fc6a15e6f1ee00d5d8e6
2021-09-21 17:56:14 +00:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 346af60111 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd am: 8bc27a7ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I412985630ce32cd2f544db3b5b50885405983afb
2021-09-21 17:07:01 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
sfufa@google.com 5b38ff6d16 [Hotseat] Fix hotseat edu flicker
When edu view animation is not started in closed state, it results in a single frame showing right before the animation begins.

Bug: 184610272
Test: visual
Change-Id: I675dbe9927771f4b64d1d81c637f19621037b415
2021-09-21 01:50:41 -07:00
Samuel Fufa 6ebbe4206e Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev am: e4057e628c am: 8998a393b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15864327

Change-Id: Ib5945c7fb5c3c3780a244435526bdb62ddab6752
2021-09-21 07:01:56 +00:00
Samuel Fufa a4c1891723 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev am: cf175820c4 am: fb0bd63b32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862162

Change-Id: I5f465b7078b4ae35521678b88fff0613c80b3ba7
2021-09-21 07:01:37 +00:00
Samuel Fufa e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa cf175820c4 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev 2021-09-21 06:24:37 +00:00
Evan Rosky 218b8cff1d Merge "Register remote transitions on activity start" into sc-v2-dev am: 26c596b813 am: 5684dffff6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15847881

Change-Id: I1554e3c24019525dc07b58a35307a4475d81ba1e
2021-09-20 22:56:27 +00:00
Evan Rosky 26c596b813 Merge "Register remote transitions on activity start" into sc-v2-dev 2021-09-20 22:29:57 +00:00
Samuel Fufa f2a8ead524 Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev am: 7f693253c8 am: 700858930d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862035

Change-Id: I34420cc5c0d4a1ac6cd5037b50e915ea1f5bf44a
2021-09-20 21:38:05 +00:00
Samuel Fufa 8ab7a2eb28 Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev am: 091d91a84b am: de409fc30a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862161

Change-Id: I616fb524b3f8b95cedb450889e32e9778c56617c
2021-09-20 21:37:46 +00:00
sfufa@google.com 0828fec3d2 [Hotseat] Show edu tip within screen bounds
Screenshot: https://screenshot.googleplex.com/8grkbkYQu5jQhU8
Bug: 163162675
Test: enable hotseat predictions while in landscape mode, dismiss hotseat edu dialog and verify toolTip is shown properly.
Change-Id: Ia6daa7412d728be702e30972136f4c849315793d
2021-09-20 14:22:25 -07:00
sfufa@google.com d0a332371d [Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app
Bug: 182937704
Test: Add direct call widget from widget tray on a predicted spot. verify prediction clears space and no overlap.
Change-Id: Ie4977ca71ec0b7c2297ffe1454cb4a1e78518a75
2021-09-20 14:22:25 -07:00
sfufa@google.com ef5ee36e90 [Hotseat] Fix hotseat migration in landscape mode
Bug: 189860214
Test: performed migration in landspace and verified items are moved properly. change is persisted when device is rotated or launcher is restarted.
Change-Id: Ice088e5524a1405dbfa20c21b4edc597f23da07e
2021-09-20 14:22:24 -07:00
Samuel Fufa 7f693253c8 Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev 2021-09-20 21:19:00 +00:00
Samuel Fufa 091d91a84b Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev 2021-09-20 21:16:49 +00:00
Evan Rosky cab41ed670 Register remote transitions on activity start
Was only registering once, but launcher can stop/start
its activity (eg when changing gesture modes), so we
need to try and re-register every time

Bug: 200213691
Test: atest CloseAppHomeButtonTest
      change gesture mode and observe functional animations
Change-Id: I29f1eb647c2168d753e37f57657906979c5518be
2021-09-20 13:41:01 -07:00
Vinit Nayak b7c91b9d2e Prevent focusing next task if focused task part of split select
* Also ensure that in tablet portrait we shift
thumbnails to prevent overlap with the placeholder
view. I'm guessing the time that was written maybe
the grid was taking up a smaller space?

Fixes: 199898622
Test: Go into split selection with focused task,
next task doesn't take focus. Grid shifts down
to not overlap with placeholder view.

Change-Id: I4ed37b1d28287685ad01885331dffd764c7ddfc9
2021-09-20 11:28:55 -07:00
Thales Lima 558ff50698 Merge "launcher: fix animation for quick switch + recents" into sc-v2-dev am: 3b151d630c am: deb17f413b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15853747

Change-Id: Ic7746f14e6f86d554860f38ec11a62cdcafeb599
2021-09-20 14:53:11 +00:00
Vinit Nayak 25c913f7fe Merge "Show multiple icons for GroupedTaskView" into sc-v2-dev am: 03c13ad130 am: f94d7ca492
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15847979

Change-Id: Ib2b29b92516c6922a8cfa6f260ca280ac0f2941e
2021-09-20 12:32:44 +00:00
Tracy Zhou f32330c8a5 Merge "Stash the bar after settling in Overview" into sc-v2-dev am: 088ec093e5 am: d05a3d2040
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15801649

Change-Id: I8b162508cceb90e9c872e1c24afc40fa0b37f23f
2021-09-20 12:29:27 +00:00
Thales Lima f2d44e8756 launcher: fix animation for quick switch + recents
We need to account for the fact that the running task is outside the
screen in this case, so we need to add that amount to the grid
translation.

Bug: 199265499
Test: manual, check the bug
Change-Id: I8c6ca28c5486ce9769bd6fa8fbb3d70eb9619dc6
2021-09-20 12:14:56 +01:00
sfufa@google.com a46da7390c [AllApps] Fix ConcurrentModificationException in AppPredictionRow
Bug: 190574986
Test: presubmit
Change-Id: Ic74d1d466e8c7b0ecb870dd5ab47dc91ba71a01e
2021-09-19 22:55:43 -07:00
sfufa@google.com b39cf0bb33 [Hotseat] Remove stale predictions when AppIcon is removed
Bug: 200088725
Test: Install work profile clock app, verify it is visible in the hotseat, launch (which should remove the icon from AllApps). Go home and verify icon is removed from the hotseat.
Change-Id: I5915f5469fd4f90da0471dc177ef0965e99d07c7
2021-09-19 12:41:23 -07:00
Vinit Nayak 03c13ad130 Merge "Show multiple icons for GroupedTaskView" into sc-v2-dev 2021-09-17 21:27:18 +00:00
Tracy Zhou 3d458313de Hide task bar icons when notification shade is expanded
Fixes: 199163951
Test: manual
Change-Id: Id2556aa5f08db55059c95d8c13cdc4d46b7d8c55
2021-09-17 12:11:25 -07:00
Vinit Nayak af6b85e3bc Show multiple icons for GroupedTaskView
* Hide all overview actions for GroupedTaskView
* Move some logic from TaskView into respective
PagedOrientationHandlers
* Remove unused methods from PagedOrientationHandler
* NOTE this is just visual changes. Properly showing
task menu's is still in-progress

Bug: 181704764
Test: Tested GroupedTaskView in portrait/landscape,
fake landscape in small screen, and real portrait/landscape
in large screen

Change-Id: I9c13ca114024db0a8e3fa5d295951696adb8516f
2021-09-17 10:16:56 -07:00
Tracy Zhou 308851d866 Stash the bar after settling in Overview
Test: https://recall.googleplex.com/projects/81822932-8526-4ee7-b5f7-4ef6d6603f1d/sessions/f0f7a3db-76b6-4f60-87e8-8918bd6cf180
Bug: 193938970
Change-Id: Ic08d3156f5c78a34f353783b760d5cf098e442e8
2021-09-16 00:06:47 -07:00
Vinit Nayak 0169fa3f34 Show all TaskViews when doing seamless overview rotation am: 6434f8eae5 am: ddd5a6ec3c am: e628b82b89
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15838849

Change-Id: I1452c39bb1e053c24ad60f5264fff63cbdfe1cc8
2021-09-16 00:04:48 +00:00
Vinit Nayak e628b82b89 Show all TaskViews when doing seamless overview rotation am: 6434f8eae5 am: ddd5a6ec3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15838849

Change-Id: Ibfd55da6b502b6e7bff9f840659327f70b5dcf35
2021-09-15 23:50:50 +00:00
Vinit Nayak 104ed0b9a8 Show all TaskViews when doing seamless overview rotation am: 6434f8eae5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15838849

Change-Id: Id57edd739e61c9703449058f439c0526b6ef2e8c
2021-09-15 23:39:22 +00:00
TreeHugger Robot 1b16b5ada6 Merge "Removing unused tracing" into sc-v2-dev am: da76a1defd am: d2280210f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15826736

Change-Id: If2c353af3a0a68913d0e42bd090e9441dc5e0242
2021-09-15 20:58:53 +00:00
TreeHugger Robot da76a1defd Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 20:26:49 +00:00
Vinit Nayak 6434f8eae5 Show all TaskViews when doing seamless overview rotation
* If user is scrolling and rotates overview in fake
landscape, we wouldn't change the alpha to show if it
was hidden previously.
Now we only skip changing the alpha if it's already visible.

Bug: 194715506
Test: Scroll overview in fake landscape and rotate.
No more invisible task.

Change-Id: Idb519125fbb5ec7be33e0d7b6dd313fb4df684db
2021-09-15 19:17:54 +00:00
Tony Wickham 3586cacf6a Merge "Don't set Taskbar window to non-fullscreen while folder animates closed" into sc-v2-dev am: 3d0fca7e0d am: c09201a91b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15832181

Change-Id: Ib42c5dc8102ffa72b35e7ebca046d554d2afa009
2021-09-15 18:25:07 +00:00
Tony Wickham 3d0fca7e0d Merge "Don't set Taskbar window to non-fullscreen while folder animates closed" into sc-v2-dev 2021-09-15 17:47:46 +00:00
Tony Wickham 458a10cb95 Merge changes from topics "TaskbarLogging", "taskbar-log" into sc-v2-dev am: 2908eb70fc am: d99cff7aee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15720731

Change-Id: Iaf43948a6774b348f55cf5fbc707ddb1cdd2ec98
2021-09-15 16:50:13 +00:00
Tony Wickham 2908eb70fc Merge changes from topics "TaskbarLogging", "taskbar-log" into sc-v2-dev
* changes:
  Add logs for taskbar and overview split action
  Add TaskBarContainer to launcher_atom.proto
2021-09-15 16:28:45 +00:00
TreeHugger Robot 90b94185e1 Merge "Don't move taskbar window when it resizes" into sc-v2-dev am: a2f04dd7d4 am: 8832cb8e26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15829006

Change-Id: I99863077489f4876e95a43b1ceac23864181de96
2021-09-15 07:53:10 +00:00
TreeHugger Robot a2f04dd7d4 Merge "Don't move taskbar window when it resizes" into sc-v2-dev 2021-09-15 07:26:28 +00:00
Tony Wickham d5e116a750 Don't set Taskbar window to non-fullscreen while folder animates closed
Test: Open an app, open a folder in taskbar, and drag an app from the folder. Ensure the folder close animation plays completely.
Fixes: 199954907
Change-Id: I1caec4ef24b5325724d74f10ddbeae6ef8f9e959
2021-09-14 17:48:14 -07:00
TreeHugger Robot e7ca091d6e Merge "Rebind TISBinder if service killed during connection" into sc-v2-dev am: 25a1e0b913 am: 5fffa1df0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15828615

Change-Id: Ia30a61ba68621f2532ed395498205aab783703d6
2021-09-15 00:43:43 +00:00
Tony Wickham 48d91ce7ac Reset RecentsView#mNextPage when swiping to home am: d552132d0b am: 46192d288a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15828992

Change-Id: Icd5e85956959c120744b81d7ba57ff586ef0adad
2021-09-15 00:43:30 +00:00
TreeHugger Robot 25a1e0b913 Merge "Rebind TISBinder if service killed during connection" into sc-v2-dev 2021-09-15 00:31:23 +00:00
vadimt 155ce05218 Removing unused tracing
Test: presubmit
Bug: 192018189
Change-Id: I31e6fd8410e879aeda0249d89f650e1a41de6030
2021-09-14 16:42:59 -07:00
Tony Wickham ed16fb4739 Don't move taskbar window when it resizes
Test: enter split screen, open folder or drag an app icon and ensure the
taskbar doesn't jump briefly to the top of the screen
Fixes: 199386357

Change-Id: I9a4787931a764db0bc036725a58984823a8d5467
2021-09-14 15:31:26 -07:00
Tony Wickham d552132d0b Reset RecentsView#mNextPage when swiping to home
This ensures that we don't inadvertently update mCurrentPage to be
mNextPage in computeScrollHelper(), which would in turn mess up
calculations such as RecentsView#getHorizontalOffsetSize().

Also removed resetNextPage parameter from forceFinishScroller(), as
resetNextPage was always passed as true anyway.

Test: Swipe up and to the right to home, ensure adjacent page goes all
the way off screen
Fixes: 199927699

Change-Id: Iee1ffac10e5195f0c3a124a23b06d5411ecd7ba2
2021-09-14 14:38:15 -07:00