Commit Graph

72986 Commits

Author SHA1 Message Date
Vadim Tryshev dc7de0d9fb Merge "Waiting for Launcher activity to stop when starting an overview task" into main 2023-12-04 21:47:09 +00:00
Schneider Victor-tulias a74612611d Merge "Update isLauncherInitialized check to wait until Launcher has stopped binding items" into main 2023-12-04 20:02:10 +00:00
Sunny Goyal 21eeda4cc3 Merge "Revert^2 "Changing SystemUiProxy to kotlin"" into main 2023-12-04 19:30:37 +00:00
Vadim Tryshev 7b78d4093b Merge "Not diagnosing taskbar as <Launcher in invalid state>" into main 2023-12-04 19:21:17 +00:00
Sunny Goyal b1e430bcb9 Revert^2 "Changing SystemUiProxy to kotlin"
49997a7cf9

Change-Id: Ieed3f7ad7c9d36ee1c2fc53e0c03df34698c256d
2023-12-04 17:21:22 +00:00
Pat Manning f9e64bc0ce Merge "Revert^2 "Update cell drop visualizer radius"" into main 2023-12-04 11:06:00 +00:00
Pat Manning 5004d4dd3b Merge "Update focus indicator radius to match workspace drag indicator radius." into main 2023-12-04 11:06:00 +00:00
Himanshu Gupta b6ebbb019c Fixing dangling PS container on profile addition.
When Work profile state is changed, the all apps container is redrawn
Eventually `PrivateProfileManager.reset()` is also called but PS decorator
is not added as there is no change in PS state.
https://photos.app.goo.gl/V2bmZWfzBzcRP97C8
To fix this, we allow decorator addition on reset, but only
apply the same when its not already present in the recycler view.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 313498792
Test: PrivateProfileManagerTest
Change-Id: I4c9a89d84e670ed45bf53a2d2e2c4922b165463e
2023-12-03 23:34:19 +00:00
Himanshu Gupta f63c645d8c Merge "Fixing work widgets tab in WidgetsFullSheet." into main 2023-12-03 23:33:42 +00:00
Himanshu Gupta c2a2b86e76 Fixing work widgets tab in WidgetsFullSheet.
Currently the work widget matcher matches against all
non-foreground user profiles, due to which the work
tab is incorrectly shown in widgets full screen, when
PS is present.
This was missed in ag/25129268 where a bunch of work
matcher fixes were done.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 312900122
Test: Launcher3 tests
Change-Id: I80d33e851ea3366dc3897bb1f5cc17fcd6b34520
2023-12-03 21:23:44 +00:00
Andreas Agvard 4b9a14cd8b Merge changes I9c92d3cb,I98e2dea9 into main
* changes:
  Increase slider for haptic hint iterations
  Enables ENABLE_SEARCH_HAPTIC_COMMIT
2023-12-02 08:55:57 +00:00
Vadim Tryshev caf5958e57 Waiting for Launcher activity to stop when starting an overview task
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ie72853a9d289b2688fdfbdf5220ce86808ac2da1
2023-12-01 16:15:45 -08:00
Sebastián Franco b70b7fde7a Merge "Moving the remainder of reorder logic to ReorderAlgorithm" into main 2023-12-01 21:32:50 +00:00
Federico Baron 5f46067417 Merge "Fix flicker for widget picker" into main 2023-12-01 21:01:38 +00:00
Andreas Agvard 23de925836 Increase slider for haptic hint iterations
The haptic hint can now be made up to 200 itertions long (2.4 seconds)

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Change-Id: I9c92d3cb24fabfa3b0d318a77d312423501737a6
2023-12-01 21:16:14 +01:00
Andreas Agvard fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00
Andreas Agvard ffa44902d4 Merge "Adds support for shrinking nav handle on press" into main 2023-12-01 20:14:03 +00:00
Vinit Nayak 717c4f51ff Merge "Remove unused animation of splitInstructionsView text" into main 2023-12-01 20:00:27 +00:00
fbaron eca18c0bd1 Fix flicker for widget picker
Fix: 312159033
Flag: NONE
Test: verified on device
Change-Id: I69e39c9041ff2d0a2ac3a6459a4c85c131a1b785
2023-12-01 10:52:39 -08:00
Sebastian Franco dcf6bf2311 Moving the remainder of reorder logic to ReorderAlgorithm
This is a no-op thoroughly tested by ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I7203444df289cd3b67794fc570a2cd46e64549a2
2023-12-01 12:50:13 -06:00
Vadim Tryshev 6edb70f749 Merge "Waiting for Launcher to stop after quick-starting test apps" into main 2023-12-01 18:47:33 +00:00
Vadim Tryshev 0ad6d9bcee Waiting for Launcher to stop after quick-starting test apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I795571ec191b01929bb871fd021d8653449bb608
2023-12-01 18:22:04 +00:00
Sebastián Franco f601447877 Merge "Moving bindAppsAdded and setIsFirstPagePinnedItemEnabled to ModelCallbacks" into main 2023-12-01 17:58:11 +00:00
Andreas Agvard 1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
randypfohl 1338dc41df Fixing regression where icon view became focusable
Description: in ag/24721149 we stopped inflating IconView
from Task.xml and instead used a viewstub. When creating
files to fill the viewstub, we forgot to place the correct
attributes on Icon_view.xml. We did place them correctly
elsewhere. Anyways this is why we were seeing focusable
icons.

Flag: None

Test: Built locally, will follow up with automation

Bug: 307461880

Change-Id: I45f895c8545a80f80c79709180f2878476d10221
2023-12-01 14:35:48 +00:00
Pat Manning e06a23ed29 Update focus indicator radius to match workspace drag indicator radius.
Also decouple focus indicator radius from ENABLE_DEVICE_SEARCH feature flag, as it is used on home screen as well as all apps.

Bug: 313665319
Test: Manual.
Flag: N/A.
Change-Id: I629c1180b1b1b6797e2c3ba6ca13da04e8fa392b
2023-12-01 14:24:05 +00:00
Pat Manning 27efab01f3 Revert^2 "Update cell drop visualizer radius"
This reverts commit 311afc6987.

Reason for revert: Resubmitting with updated screenshots

Change-Id: Ieb114c06376cf46b90b140490a54cbae592c8f5a
2023-12-01 13:56:26 +00:00
Pat Manning bf6905c069 Merge "Navigate grid overview via arrows and tab properly." into main 2023-12-01 12:23:21 +00:00
Serdar Kocdemir 063858b510 Merge "Revert "Changing SystemUiProxy to kotlin"" into main 2023-12-01 12:04:59 +00:00
Pat Manning e683c4c549 Navigate grid overview via arrows and tab properly.
Fix: 311646336
Fix: 281021558
Test: TaskGridNavHelperTest
Flag: N/A
Change-Id: Iad5a2eec22f8fa4519a6a1f7bcde097e00d6b142
2023-12-01 11:06:41 +00:00
Uwais Ashraf 205d707579 Merge "Revert "Update cell drop visualizer radius"" into main 2023-12-01 10:16:29 +00:00
Uwais Ashraf 311afc6987 Revert "Update cell drop visualizer radius"
This reverts commit 77e0faa670.

Reason for revert: Causes a 100% failing test see b/314206230

Change-Id: Icfc5bb4bace17b630bfd74a1460f6d1748d8d9d3
2023-12-01 10:14:54 +00:00
Surajit Chandra 49997a7cf9 Revert "Changing SystemUiProxy to kotlin"
Revert submission 25509210-proxy-kotlin

Reason for revert: test revert b/314219394
Reverted changes: /q/submissionid:25509210-proxy-kotlin

Change-Id: I3ada33461886ba2428b6b768cacc0d5454d543a3
2023-12-01 08:27:16 +00:00
Vadim Tryshev 1ccdc411e5 Not diagnosing taskbar as <Launcher in invalid state>
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib73785d7421ebc0fb899cb02ae8c29b6bbad968e
2023-11-30 17:20:32 -08:00
Treehugger Robot 0cfbca60ab Merge "Move logic only used on the reorder from the cellLayout to ReorderAlgorithm" into main 2023-12-01 00:57:37 +00:00
Vinit Nayak 440cdc4a4a Merge "Revert "Add logs for move pointer"" into main 2023-12-01 00:49:23 +00:00
Sunny Goyal 6f04a32b21 Merge "Revert "Removing unnecessary iconFactory class when generating b..."" into main 2023-11-30 23:55:59 +00:00
Sunny Goyal 01f8bc59c6 Merge "Changing SystemUiProxy to kotlin" into main 2023-11-30 23:55:15 +00:00
Sebastián Franco 758b01defc Merge "Adding the Launcher workspace team to the OWNERS file" into main 2023-11-30 23:51:55 +00:00
Schneider Victor-tulias 55bdb474c2 Merge "Fix ANR in TouchInteractionService" into main 2023-11-30 23:27:39 +00:00
Stefan Andonian df7ea42299 Merge "Revert "Update launcher preview icons on themed icon update"" into main 2023-11-30 23:01:22 +00:00
Sebastian Franco 9a35d45904 Adding the Launcher workspace team to the OWNERS file
Flag: NA
Bug: 314190226
Test: this LDAPs should apear as owners
Change-Id: Ia1e84fa3e3eeb2b94be256ad34833b330d469bd5
2023-11-30 22:28:09 +00:00
Sebastián Franco dc3cb09765 Merge "Move expectFail to TestUtil" into main 2023-11-30 21:46:56 +00:00
Andy Wickham faa97d6224 Merge "Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag." into main 2023-11-30 20:17:42 +00:00
Stefan Andonian dd088daead Revert "Update launcher preview icons on themed icon update"
Revert submission 25242534-launcher-preview-update-themed-icon

Reason for revert: This change potentially breaks the launcher's database.

Reverted changes: /q/submissionid:25242534-launcher-preview-update-themed-icon

Change-Id: I90fd55695b24529752a82cb6bf001935204a53f7
2023-11-30 20:12:40 +00:00
Schneider Victor-tulias 7ab2c874c9 Update isLauncherInitialized check to wait until Launcher has stopped binding items
The current implementation of isLauncherInitialized allows TAPL tests to run while LoaderTask is still binding items. This can lead to interactions on a launcher that is not yet drawn/responsive.

Flag: N/A
Fixes: 313043156
Test: TaplAppIconMenuTest#testLaunchMenuItem
Change-Id: I4cb9276eb3852653517faa45be8517e659f39c00
2023-11-30 15:11:33 -05:00
Saumya Prakash 89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Federico Baron b89fde7a9a Merge "Update cell drop visualizer radius" into main 2023-11-30 20:07:47 +00:00
Vinit Nayak a2bf68fee2 Revert "Add logs for move pointer"
This reverts commit b39abc99cd.

Reason for revert: Test no longer failing

Change-Id: I461d91c88290b820a75bbb4771663558162692ab
2023-11-30 20:07:01 +00:00
Sunny Goyal b18392cbe9 Changing SystemUiProxy to kotlin
> Simplifying some try-catch stamtements
> Removing unnecessary interface implementation
> Using kotlin native null check, which also prevents NullpointExeception
  when using calling methods from a non-main thread

Bug: 314010650
Flag: N/A
Test: Presubmit
Change-Id: I435ace5df8d7a19a8bba4099408f6cc7257d1f1f
2023-11-30 12:05:28 -08:00