Commit Graph

60603 Commits

Author SHA1 Message Date
Jagrut Desai dc22d38d4b Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev am: 64b79a9fad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22519946

Change-Id: I1afdf6544379983d854722c3729e2816c110c718
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 16:57:39 +00:00
Jagrut Desai 64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00
Kateryna Ivanova ccd6e9194f Introduce library for public animation APIs am: 2d6a8e3a87
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22739941

Change-Id: I16eb20c3534717e76813011ae0f2039e9a556190
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 14:32:20 +00:00
Kateryna Ivanova 2d6a8e3a87 Introduce library for public animation APIs
* Add a public library
* Pull Interpolators implementation from systemui animation library
* migrate existing usages of Interpolators

Test: n/a
Bug: 271850966
Change-Id: I3f941423b76f555b2c1e7205e23d5ff9ad95d413
2023-04-21 08:06:47 +00:00
Andreas Agvard 419887acf7 Merge "Rename notifyGestureStartedAsync to notifyGestureStarted" into udc-dev am: 43327eb082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22738281

Change-Id: Ic9c575a6fa800b3226d25a6d00336f4f84492155
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 07:10:54 +00:00
Andreas Agvard 43327eb082 Merge "Rename notifyGestureStartedAsync to notifyGestureStarted" into udc-dev 2023-04-21 06:36:09 +00:00
Wei Sheng Shih 60a875a409 Merge "Polish reveal animation after onTasksAppeared." into udc-dev am: 8b71205fa9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22606971

Change-Id: I6730448bc1258b570497e86573777e05f11445b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 05:04:47 +00:00
Jagrut Desai c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
Wei Sheng Shih 8b71205fa9 Merge "Polish reveal animation after onTasksAppeared." into udc-dev 2023-04-21 04:44:56 +00:00
Jon Miranda 186cae0ba1 Merge "Clear Accessibility Focus from icon after Shorcut Menu invoked" into tm-qpr-dev am: 83271bbc7b am: 18110b9737 am: d84fe2d022
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: I159f21598e8be0c92d87019963f17c4eb98207c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 04:42:51 +00:00
Presubmit Automerger Backend 641897ace5 [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3 am: 5ab41346d8 am: cc471ee2ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: Id05e1fcded5845bf4ffc64a90b7bc3b88aab7e88
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 04:42:41 +00:00
Jon Miranda d84fe2d022 Merge "Clear Accessibility Focus from icon after Shorcut Menu invoked" into tm-qpr-dev am: 83271bbc7b am: 18110b9737
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: Ib5c3392b9afe931110f963ad1c6cc018b9251feb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 04:18:09 +00:00
Jon Miranda 18110b9737 Merge "Clear Accessibility Focus from icon after Shorcut Menu invoked" into tm-qpr-dev am: 83271bbc7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: I60475ab1588406e37c2038b21649f8dad1d843fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 03:57:26 +00:00
Presubmit Automerger Backend cc471ee2ee [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3 am: 5ab41346d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: I16a861cfa872f928c5e4414a9f0ecdceacf1f325
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 03:57:05 +00:00
Jon Miranda 83271bbc7b Merge "Clear Accessibility Focus from icon after Shorcut Menu invoked" into tm-qpr-dev 2023-04-21 03:20:30 +00:00
Vadim Tryshev 6b803ea8a2 Merge "Better diagnose Launcher state when there is an open folder." into udc-dev am: 2b24e53531
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22774276

Change-Id: I155239f762365a323a11ec64d8fff8024ea6f2d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 01:16:30 +00:00
Vadim Tryshev 2b24e53531 Merge "Better diagnose Launcher state when there is an open folder." into udc-dev 2023-04-21 00:39:15 +00:00
Andrew Cole dc94b9fbe6 Merge "Unit testing ButtonDropTarget" into udc-dev am: 0d775d3508
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22532504

Change-Id: I428bac6cdf74d281773e675fd8b53054c250ec9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 00:11:19 +00:00
Andrew Cole 0d775d3508 Merge "Unit testing ButtonDropTarget" into udc-dev 2023-04-20 23:35:49 +00:00
Presubmit Automerger Backend 5ab41346d8 [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: Ib5981d226c7cabe8e302c108b198c3fb657f3812
2023-04-20 23:21:40 +00:00
Jon Miranda cb582591b3 Clear Accessibility Focus from icon after Shorcut Menu invoked
Similar to I2726504094af2abacf1c41089c7bcd4efb588099

Fixes: 267695526
Test: have talkback on
      open all apps
      open long press menu
      ensure focus stays on pop up menu

Change-Id: I38f78df3855495c53a5ae8966e9a996e4679e95b
2023-04-20 16:21:02 -07:00
Tracy Zhou 8d35c2c578 Merge "Support 3-finger swipe to pull down notifications from app" into udc-dev am: 7c49cb3ac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22725560

Change-Id: I3774ff9a132b2e8e0c37c298f03c48c87524cd48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 22:48:15 +00:00
Tracy Zhou 7c49cb3ac2 Merge "Support 3-finger swipe to pull down notifications from app" into udc-dev 2023-04-20 22:19:03 +00:00
Schneider Victor-tulias a186a3592b Merge "Update the BorderAnimator" into udc-dev am: 7da60438a3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22515873

Change-Id: Iabc82349c41fde8196cecc290bcb0b512135cb56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 21:07:16 +00:00
vadimt 9f49e5f33f Better diagnose Launcher state when there is an open folder.
Without this change, the diag is:
visible state is LaunchedApp (active app: com.google.android.apps.nexuslauncher)

https://android-build.corp.google.com/test_investigate/?testResultId=TR37728586113816784&invocationId=I13000010147719553&tab=trace

Test: presubmit
Bug: 187761685
Change-Id: Ia2425a09408d7e1a9c22d0a65fc4ab31cc793a46
2023-04-20 13:59:39 -07:00
Schneider Victor-tulias 7da60438a3 Merge "Update the BorderAnimator" into udc-dev 2023-04-20 19:59:44 +00:00
Schneider Victor-tulias ca14e95e91 Merge "Sort FeatureFlags by assigne LDAP" into udc-dev am: 1f587dec84
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22720411

Change-Id: Ief00a2542ee1d9002b136e20ecc598aa0d1c22b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 19:41:45 +00:00
Andrew Cole 44898c3db4 Unit testing ButtonDropTarget
Originally there was a bug in a method (isTextClippedVertically) in ButtonDropTarget. While attempting to write a unit test it became necessary to refactor ButtonDropTarget and DeleteDropTarget to decouple them from their dependency on launcher in order to allow for a unit test to be written

The pattern we are introducing here is to decouple Launcher from a controller, in order to facilitate easier testing.
Instead of calling Launcher.getLauncher() we call the method through ActivityContext, which has a testing wrapper already defined. Here is a diagram that explains the old and new pattern

Design Pattern: https://screenshot.googleplex.com/7apiE2DaGDrFzy9.png

Test: isTextClippedVerticallyTest
Bug: b/274402490

Change-Id: I1f3003d0b62dddbceb6e492b15aa5d7352d3a293
2023-04-20 11:22:27 -07:00
Brandon Dayauon 91dc219f57 Merge "Fix two line item of app-title only in A-Z list and not predicted app row" into udc-dev am: e16a595626
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22440092

Change-Id: I977f15200d558fb645630cdefb345c5c3959d5ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 18:21:43 +00:00
Schneider Victor-tulias 1f587dec84 Merge "Sort FeatureFlags by assigne LDAP" into udc-dev 2023-04-20 17:30:46 +00:00
Brandon Dayauon e16a595626 Merge "Fix two line item of app-title only in A-Z list and not predicted app row" into udc-dev 2023-04-20 16:59:10 +00:00
Andreas Agvard 167a7ba13b Rename notifyGestureStartedAsync to notifyGestureStarted
Since there is nothing async about it's implementation.

Test: Since it's a name change compilation is the only test needed.
Bug: 278976890
Change-Id: I0057be3c25c3ec80054d3830fe706ec8f9995ea7
2023-04-20 09:52:06 +02:00
wilsonshih 146e81b8c2 Polish reveal animation after onTasksAppeared.
Showing the animation leash of appearedTaskTargets if there need to
play the reveal animation behind splash screen view.
Pausing applyDepthAndBlur while playing splash screen exit animation
from launcher side, otherwise the app window would be blurred.

Bug: 277704255
Test: manual, do quickswitch to start the app behind splash screen
view, verify no flicker or blur happen when playing reveal animation.

Change-Id: I83604ceeaeb54ab2100fdabf45a1624644b85e37
2023-04-20 14:47:51 +08:00
Tracy Zhou 75b534e9c9 Support 3-finger swipe to pull down notifications from app
Fixes: 270211015
Test: 3-finger swipe down to bring down notifications. 3-finger swipe up to go home / to Overview

Change-Id: Id0f8ad95d9a4a1f8ecf1632ea28efb0c790c291b
2023-04-19 23:37:37 -07:00
Winson Chung c77b8a5714 Merge "Add a synchronous path when finishing a pre-existing recents animation" into udc-dev am: fb0a7a07da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22736250

Change-Id: I4a5c54d7d715810af363a881311f3494e5d0c56e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 01:20:46 +00:00
Winson Chung fb0a7a07da Merge "Add a synchronous path when finishing a pre-existing recents animation" into udc-dev 2023-04-20 00:44:32 +00:00
Sebastián Franco b0ce5b7fa1 Merge "Make functions private to keep TAPL design consistent" into udc-dev am: 051a1e35c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22722168

Change-Id: If7354b7305e46bcf2cb4393c7cd13ca1f7704289
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 00:17:15 +00:00
Federico Baron 800d31d0be Merge "Update colors for widget picker" into udc-dev am: 67f72bfdd1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22640806

Change-Id: I06558b0258a01207b38e10ffb842613ef648f8a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-20 00:03:18 +00:00
Sebastián Franco 051a1e35c8 Merge "Make functions private to keep TAPL design consistent" into udc-dev 2023-04-19 23:45:14 +00:00
Federico Baron 67f72bfdd1 Merge "Update colors for widget picker" into udc-dev 2023-04-19 22:58:41 +00:00
Winson Chung 9f3ce10ece Add a synchronous path when finishing a pre-existing recents animation
- If launcher repeatedly starts the recents animation, we try to finish
  the existing animation before starting the new one, but due to some
  ordering issues (see b/275561141) the subsequent starts can orphan
  the previous animation runner, which can result in no animation callbacks
  for either the previous animation (to cancel) or the new animation
  (to start).

  This change only attempts to reduce the likelihood of a second no-op
  transition by synchronously finishing the existing recents animation
  on the launcher side prior to starting the next animation.

  There is one case this doesn't handle, where if the previous
  onAnimationStart() has not been called back, then we can't directly
  call the controller to finish, and need to rely on the no-op handling
  on the shell transition side to handle the gesture.

Bug: 275561141
Test: Quickswitch and swipe up repeatedly
Change-Id: I820e26dc20fb1851ee0102ed8c114ce998d44999
2023-04-19 22:19:56 +00:00
Brandon Dayauon 7d67331c72 Fix two line item of app-title only in A-Z list and not predicted app row
Create protected method that would be overidden if two lines should be supported

bug: 274686392
test: manual
Change-Id: I34bbd9980aee70397ee75744bedfa61c340a2741
2023-04-19 15:15:16 -07:00
Jon Miranda 2bd1f09092 Merge "Remove ActivityInfo.CONFIG_SCREEN_SIZE if orientation is still the same." into udc-dev am: 5c18fa35b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22709055

Change-Id: I3bb9cc22b778513da1c903df77919983a2a3ba22
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 18:22:38 +00:00
Jon Miranda 5c18fa35b2 Merge "Remove ActivityInfo.CONFIG_SCREEN_SIZE if orientation is still the same." into udc-dev 2023-04-19 18:04:27 +00:00
Schneider Victor-tulias ecaba5abf1 Sort FeatureFlags by assigne LDAP
Sorted FeatureFlgags by assigne LDAP to help prevent future merge conflicts.

Flag: not needed
Bug: 278771275
Test: ran launcher
Change-Id: Ib7f5276e8b943cf50c438c49e019cd31deea6674
2023-04-19 10:02:30 -07:00
Mady Mellor 9be2eef391 Merge "Creates BubbleStashController & BubbleStashedHandleViewController" into udc-dev am: 98add1c524
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22691161

Change-Id: I88831f84a126be2cc2817278a6c73909ac4c3335
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 16:50:24 +00:00
Omar Miatello c8e055c5a3 Merge "resetPositionAnimated should be called when onBackCancelled ends" into udc-dev am: c1b562ec58
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21508011

Change-Id: Ic7c77a1c2969bd1275f02d476b653621e1962c24
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 16:48:04 +00:00
Mady Mellor 98add1c524 Merge "Creates BubbleStashController & BubbleStashedHandleViewController" into udc-dev 2023-04-19 16:31:37 +00:00
Omar Miatello c1b562ec58 Merge "resetPositionAnimated should be called when onBackCancelled ends" into udc-dev 2023-04-19 16:23:21 +00:00
Brian Isganitis 21d3e1c680 Merge "Properly compute scroll for Taskbar All Apps." into udc-dev am: 91b0e2d6d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22682881

Change-Id: I3395b320d762f029248282e48398920d90726a57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 15:39:54 +00:00