Commit Graph

76525 Commits

Author SHA1 Message Date
Jeremy Sim dafbaa5f1b Merge "Fix flaky test" into main 2024-06-11 04:12:58 +00:00
Treehugger Robot 9aafa6bd76 Merge changes I8411fb83,I5b757558 into main
* changes:
  Move Desktop running apps support into TaskbarRecentAppsController
  Add flag for Recents in Taskbar
2024-06-11 02:16:56 +00:00
Winson Chung 0101ae5062 [automerger skipped] Add max width to the screen instructions view text am: 3fa291e1a7 -s ours
am skip reason: Merged-In I73e889372a5c482277b0e4b61fb834304304c0a6 with SHA-1 73cf3bc3a1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27773016

Change-Id: Id6c5fc20268b0f17c8a9558da6a72ee59c94ce9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-11 01:31:02 +00:00
Tony Wickham a2b510dc23 Move Desktop running apps support into TaskbarRecentAppsController
- Merged DesktopTaskbarRunningAppsController up into
  TaskbarRecentAppsController, which is now initialized directly
- The old TaskbarRecentAppsController was effectively a no-op
  that was always overridden, so merging the one subclass up makes
  things simpler (especially for the follow up CLs which will add
  support for switching between Running and Recent tasks using
  the same underlying data).

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I8411fb832e5dd3d76201d2694dec0b11bd70bbf9
2024-06-11 00:18:23 +00:00
Liran Binyamin f461eab5ca Merge "Fix state after dragging bubble to dismiss" into main 2024-06-10 23:42:00 +00:00
Treehugger Robot cf68e59c02 Merge "Finish the running recents animation when the user locks their device mid-animation." into main 2024-06-10 22:31:19 +00:00
Jeremy Sim c1470021c8 Fix flaky test
Attempts to fix a flaky test by ensuring that recents is always cleared before creating a split pair (so the split pair under test is always the same).

Bug: 340935208
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair(), testSplitTaskTapBothIconMenus()
Flag: TEST_ONLY
Change-Id: Ibc81b90fac531f0e78e93a494ff59073ab5e52cf
2024-06-10 14:51:53 -07:00
Winson Chung 3fa291e1a7 Add max width to the screen instructions view text
- This ensures that the instruction wraps if the text is too long

Fixes: 328577545
Fixes: 345128488
Flag: EXEMPT bugfix
Test: Visual inspection of instructions view in different languages/form
      factors
Change-Id: I73e889372a5c482277b0e4b61fb834304304c0a6
Merged-In: I73e889372a5c482277b0e4b61fb834304304c0a6
(cherry picked from commit 73cf3bc3a1)
2024-06-10 21:08:18 +00:00
Sihua Ma c22a8e7495 Merge "Migrate GeneratedPreviewTest to multivalent" into main 2024-06-10 20:57:00 +00:00
Kshitish Vyas d655aa4dab [automerger skipped] Merge "Ensure starting position rect isn't empty in FloatingTaskView" into 24D1-dev am: f309097aa8 -s ours
am skip reason: Merged-In Icb546a05d383d1997a92471fc1de3ffc37d06eca with SHA-1 410681a955 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730882

Change-Id: Ia78fb863745ec0d95c00827b6b7168516eb6e754
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:02:14 +00:00
Vinit Nayak 92deaa9ecc [automerger skipped] Ensure starting position rect isn't empty in FloatingTaskView am: f8efb32379 -s ours
am skip reason: Merged-In Icb546a05d383d1997a92471fc1de3ffc37d06eca with SHA-1 410681a955 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730882

Change-Id: I0758255916837fe91d0f37b884b6c0e8e04f5123
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:02:11 +00:00
Kshitish Vyas 40056d8771 [automerger skipped] Merge "Always report mandatory insets for button nav" into 24D1-dev am: 91dfdc61b8 -s ours
am skip reason: Merged-In I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae with SHA-1 762b3b4685 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730647

Change-Id: I52bc0e5861dac8b5ba667fcd26a2c40d43b3bda5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:01:25 +00:00
Winson Chung adb1bfeded [automerger skipped] Always report mandatory insets for button nav am: 669b9c5c30 -s ours
am skip reason: Merged-In I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae with SHA-1 762b3b4685 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730647

Change-Id: I25df7a02cfa0e9abee107d32a56e01cbee700fca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:01:22 +00:00
Kshitish Vyas f309097aa8 Merge "Ensure starting position rect isn't empty in FloatingTaskView" into 24D1-dev 2024-06-10 18:33:32 +00:00
Kshitish Vyas 91dfdc61b8 Merge "Always report mandatory insets for button nav" into 24D1-dev 2024-06-10 18:32:14 +00:00
Liam Lee Pong Lam df709d9aef Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-06-10 17:40:24 +00:00
Sihua Ma de5ef62967 Migrate GeneratedPreviewTest to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Fix: 325088369
Flag: TEST_ONLY
Change-Id: I2c88a357c8ac5fb0171a70e850be25e8fb11de33
2024-06-10 16:49:47 +00:00
Schneider Victor-tulias e2bdd1568c Finish the running recents animation when the user locks their device mid-animation.
Flag: NONE bug fix
Fixes: 319022192
Test: locked device during home animation and checked temp logs
Change-Id: I884694a4318348259b04c3b6073d3ea37eff98fb
2024-06-10 11:48:34 -04:00
Liran Binyamin ce3bbc7b5e Fix state after dragging bubble to dismiss
After dragging a bubble in the bubble bar to dismiss it,
we remove it from the view and update the width of the bubble bar.

The issue here is that the drag state only gets cleared in
BubbleBarView after the dismiss animation is complete, so when
the width is updated, we don't reposition all the bubbles according
to the new width, and end up in a weird state.

The fix is to clear the drag state in onDragDismiss.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345482103
Test: manual
       - Add multiple bubbles to the bubble bar
       - Drag a bubble to dismiss it
       - Observe bubble bar updates correctly
       - Repeat with other bubbles
Change-Id: Ie94f8ace0f5660466686a261174b42c8d71b3e30
2024-06-10 10:17:13 -04:00
Uwais Ashraf 8e537d1ee5 Merge "Move AppFilterTest to Deviceless" into main 2024-06-10 08:22:00 +00:00
Winson Chung 7994cff896 Merge "Add max width to the screen instructions view text" into main 2024-06-08 05:06:58 +00:00
Federico Baron 4ebc6777cb Merge "Fix folder animation clipping and RTL issue" into main 2024-06-08 00:22:45 +00:00
Shamali Patwa 7902265f77 Merge "Fix the flaky screenshot test" into main 2024-06-07 23:14:15 +00:00
Andrew Cole 8a4af691c8 Move AppFilterTest to Deviceless
Bug: 297950111
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: TEST_ONLY
Change-Id: I9e12a23966017aa2136f92e84eebb216ed8525cf
2024-06-07 15:38:17 -07:00
Brandon Dayauon 14fb9f27f4 Merge "Make private profile header scrollable" into main 2024-06-07 22:16:42 +00:00
fbaron 31d5b01ecf Fix folder animation clipping and RTL issue
Fix: 341433475
Test: NONE
Flag: EXEMPT bugfix
Change-Id: I05c1ca65efea2fdcebb6ff9435fda1f4bbafb9f1
2024-06-07 15:09:30 -07:00
Vadim Tryshev d37d4d8b7d Merge "Removing test class TaplViewInflationDuringSwipeUp" into main 2024-06-07 21:19:04 +00:00
Winson Chung 73cf3bc3a1 Add max width to the screen instructions view text
- This ensures that the instruction wraps if the text is too long

Fixes: 328577545
Fixes: 345128488
Flag: EXEMPT bugfix
Test: Visual inspection of instructions view in different languages/form
      factors
Change-Id: I73e889372a5c482277b0e4b61fb834304304c0a6
2024-06-07 20:59:07 +00:00
Vadim Tryshev e7d59d06c4 Removing test class TaplViewInflationDuringSwipeUp
The bugs for fixing the removed tests are obsolete, and it was decided to not allocate resources for fixing the tests.

Bug: 190618549, 190729479
Test: presubmit
Flag: NONE it's a test
Change-Id: I1ca3c2c054e4b598c65c86913f0ddbbc711d7f6c
2024-06-07 12:16:37 -07:00
Treehugger Robot 272731a157 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 9d5049236f -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27720734

Change-Id: I1c864141ab0f9506a554c5fb589644bf6286c386
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-07 17:32:44 +00:00
Bill Yi 6b52c21b2b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 8a174558c2 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27720734

Change-Id: I5ee597d7bb245a4afd5bdacbbe4140a8c08b107d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-07 17:32:41 +00:00
Bill Yi d716dff02a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ecd70fc3c5 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27720409

Change-Id: Ie0aac6bf838363be068455785da26ef9b8dae99b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-07 17:32:33 +00:00
Mykola Podolian d00bc8a0e7 Merge "Remove scrim view alpha when bubble manage menu is shown." into main 2024-06-07 17:30:57 +00:00
Treehugger Robot d141b3094d Merge "Use animateClose in TaksMenuView even without animation" into main 2024-06-07 17:29:15 +00:00
Treehugger Robot 9d5049236f Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-06-07 17:15:18 +00:00
Treehugger Robot 0b844a0f5b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-07 17:04:35 +00:00
Treehugger Robot f925caee4c Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-07 17:04:35 +00:00
Alex Chau 7656f3c604 Merge "Reserve space for system bars in both orientations in fake orientation" into main 2024-06-07 17:03:03 +00:00
Alex Chau 4a70e1c023 Use animateClose in TaksMenuView even without animation
- animateClose uses ObjectAnimator which is able to skip animation automatically

Fix: 332685379
Test: OverviewMenuImageTest
Test: Remove animations in Settings, open and close the menu in handheld
Flag: EXEMPT bugfix
Change-Id: I5bfe835cffc77ff7f835ff3c41bbd64fc7121ed2
2024-06-07 16:59:31 +01:00
Alex Chau f7c9466c8f Reserve space for system bars in both orientations in fake orientation
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape

Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
2024-06-07 16:28:19 +01:00
Alex Chau 619a290724 Merge "Add test for UserBadgeDrawable alpha handling" into main 2024-06-07 13:29:20 +00:00
Alex Chau 0d934c47e5 Add test for UserBadgeDrawable alpha handling
Fix: 316576459
Test: UserBadgeDrawableTest
Flag: EXEMPT bugfix
Change-Id: I3819855f8cac24176ea734bd6a0ac7bffd17e900
2024-06-07 11:39:21 +01:00
Treehugger Robot 4c0ce55f7c Merge "Fix TaskView.getThumbnailBounds not combining bounds correctly if relativeToDragLayer is true" into main 2024-06-07 10:27:23 +00:00
Alex Chau 3639fe4866 Merge "Handle uiMode changes in QuickstepLauncher" into main 2024-06-07 10:06:48 +00:00
Winson Chung 669b9c5c30 Always report mandatory insets for button nav
Fixes: 340134342
Fixes: 343817842
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Test: Verify mandatory insets vs window bounds in various
      orientations when folded/unfolded
Change-Id: I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae
Merged-In: I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae
(cherry picked from commit 762b3b4685)
2024-06-07 05:18:36 +00:00
Vinit Nayak f8efb32379 Ensure starting position rect isn't empty in FloatingTaskView
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect

Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
Merged-In: Icb546a05d383d1997a92471fc1de3ffc37d06eca
(cherry picked from commit 410681a955)
2024-06-07 03:24:37 +00:00
Treehugger Robot dcbd5e40c5 Merge "Use just the preview for drag and drop in the standalone activity" into main 2024-06-07 01:30:34 +00:00
Treehugger Robot 671d4e5384 Merge "Ensure starting position rect isn't empty in FloatingTaskView" into main 2024-06-07 00:28:31 +00:00
Shamali P 277a4f9d78 Use just the preview for drag and drop in the standalone activity
Bug: N/A
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I62c42b649e720826979123ae2ff6c5e238fe59dc
2024-06-07 00:00:31 +00:00
Shamali Patwa fc4ff35e68 Merge "Ensure widgets from WidgetSections.xml are included in suggestions" into main 2024-06-07 00:00:03 +00:00