Holly Jiuyu Sun
d91ee8f9af
Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395
Change-Id: I677a0e430b79b13a85f955a85421d78c5a166969
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 18:27:19 +00:00
Holly Jiuyu Sun
18e0e1e50a
Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev
2023-06-30 17:56:16 +00:00
Holly Sun
35b9960b63
[a11y] Fix crash when using talkback to add to home screen.
...
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d . It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.
Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
Treehugger Robot
5a56f8f111
Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679
Change-Id: I02604078e3f4dcfc6413916a8c47f7c6cce934bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 00:11:09 +00:00
Treehugger Robot
1b565681fe
Merge "Disable all apps from overview in some cases." into udc-qpr-dev
2023-06-29 23:52:09 +00:00
Brandon Dayauon
69be4ccd17
Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838
Change-Id: I38ea618a57778e567608de1c5ecbc8e76d02030c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 22:38:46 +00:00
Brandon Dayauon
aa9332af88
Merge "Fix prediction row title consistency" into udc-qpr-dev
2023-06-29 21:45:40 +00:00
Hongwei Wang
e359184522
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 am: 263aceeeea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I55f4709943f4373b71a7dff8fbcd7c1f660a9a40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 18:23:48 +00:00
Hongwei Wang
49b9fbd188
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I0a6ef4eee4dfc6244b5ee4a7716c1e625923d4b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 17:58:16 +00:00
Hongwei Wang
263aceeeea
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 17:56:29 +00:00
Hongwei Wang
ca08d75e4a
Merge "Polish home-key from split to pip transition" into udc-dev
2023-06-29 17:17:03 +00:00
Tracy Zhou
afd4eec779
Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev am: 96fc36f614
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835676
Change-Id: Ia4b95d8ace26619a0993eddbdb4139f872035cc1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 02:29:46 +00:00
Tracy Zhou
96fc36f614
Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev
2023-06-29 01:34:00 +00:00
Brandon Dayauon
f2ea399ec6
Fix prediction row title consistency
...
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."
Instead of changing the number of lines after processing, just set a separate display to the prediction app row
bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN
Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
TreeHugger Robot
1a23d2986a
Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev am: c84ecc0f67
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836068
Change-Id: Ibd0f3c7fdbfd3913e4abe7c78b6013ed1888ee92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 20:11:36 +00:00
Schneider Victor-tulias
99e779ad03
Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev am: e2e1b79b06
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835673
Change-Id: I1112987cc848ecaf2c30c383f04843afd6371576
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 20:11:24 +00:00
Schneider Victor-tulias
4864de5700
Merge "Inset the contents of AllSetActivity" into udc-qpr-dev am: 3ce99d1d96
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835670
Change-Id: Ib71e83fe6fb810383595e03fb3c40a4839d12d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 20:11:13 +00:00
TreeHugger Robot
c84ecc0f67
Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev
2023-06-28 20:08:23 +00:00
Schneider Victor-tulias
e2e1b79b06
Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev
2023-06-28 19:59:33 +00:00
Schneider Victor-tulias
3ce99d1d96
Merge "Inset the contents of AllSetActivity" into udc-qpr-dev
2023-06-28 19:59:19 +00:00
Schneider Victor-tulias
ad2279a26e
Handle onFlingFinished onRecentsAnimationStart
...
If the onRecentsAnimationStart callback runs after the user lifts their finger and onFlingFinished runs, then onFlingFinished never has another chance to run, leaving the user trapped in a state where the launcher is not started and the AllSetActivity is still present but invisible. Reverted to allow onFlingFinished to run onRecentsAnimationStart to handle this edge case.
Flag: not needed
Fixes: 285194839
Test: Ran AllSetActivty with a delay in onRecentsAnimationStart
Change-Id: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
2023-06-28 17:43:03 +00:00
Schneider Victor-tulias
ae62216f15
Inset the contents of AllSetActivity
...
Insetting the contents of AllSetActivity to prevent overlapping with the gesture nav handle
Flag: not needed
Fixes: 275018092
Test: launched AllSetActivity in landscape with largest font and display size
Change-Id: Ia82a007e8a69c637a30c56e079d9c77d73885d9f
2023-06-28 10:02:05 -07:00
Winson Chung
470b3e771e
Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b am: b019f371fd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437
Change-Id: Ic034129a9d522c2871f7ea2452007a83a9e61691
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 08:56:48 +00:00
Winson Chung
551cbc4969
Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437
Change-Id: I2a7ebbac3c510d32b70ee57dd8323123800ff09a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 07:52:58 +00:00
Winson Chung
b019f371fd
Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437
Change-Id: Ib095560a1ba305ec4150037852caa2d0d58f9121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-28 07:48:03 +00:00
Winson Chung
0da5208bb3
Merge "Workaround for handling the restart of an already visible task" into udc-dev
2023-06-28 05:51:59 +00:00
Winson Chung
57c2a79e47
Workaround for handling the restart of an already visible task
...
- If a task is already visible, then startActivity is a no-op and the
remote transition that launcher expects to run is not started. As a
workaround (until restarts are an actual transition), listen for
the case where a task is restarted and invoke the end callbacks
Fixes: 286016555
Test: Repro steps on the bug
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-28 05:51:54 +00:00
Jerry Chang
3651051182
Polish home-key from split to pip transition
...
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.
Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-28 02:10:34 +00:00
Tracy Zhou
0b767c91b5
Use DisplayController.Info to determine if it's a tablet
...
Fixes: 286942201
Test: N/A
Change-Id: Iabcceaee45f885f1dd188d3ab9039ffd3a036a0e
2023-06-28 00:20:12 +00:00
TreeHugger Robot
7cccf75c64
Merge "Removing explicit target SDK for launcher" into udc-qpr-dev am: d5b3a0a099
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783071
Change-Id: Id58dbf1f9cd64148cac79bb464ad2752f6ea3de3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 22:34:54 +00:00
TreeHugger Robot
d5b3a0a099
Merge "Removing explicit target SDK for launcher" into udc-qpr-dev
2023-06-27 22:34:40 +00:00
Vadim Tryshev
2ba42ef94d
Removing ViewCaptureAnalysisRule
...
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I0123ed3892bbfd6d0e880141ace878b6204dbd81
2023-06-27 22:12:45 +00:00
Andy Wickham
5555ce326d
Disable all apps from overview in some cases.
...
Specifically, whenever floating search bar would not show in
Overview, we also disable this all apps gesture. This covers
cases such as:
- Landscape on phones
- Tablets where taskbar shows in Overview
Note this does not depend on ENABLE_FLOATING_SEARCH flag state.
Just reuses the same LauncherState logic used for that.
Bug: 275132633
Test: Manual on tablet, phone, foldable
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: I6d6cc404a7dfef7c78b45ac830878032027156d8
2023-06-27 14:53:19 -07:00
Jerry Chang
84d1f66990
Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1 am: 8017561997
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388
Change-Id: Ie842fb4759b7c9d5c8955446649c9827c4d33fbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 19:57:14 +00:00
Jerry Chang
c2bac08fac
Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388
Change-Id: If3b1a1a4bef71e51c70d072f9f4c5c6a03ea78ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 19:10:19 +00:00
Jerry Chang
8017561997
Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388
Change-Id: I1353ee8448b455e905cab194ea9070d42a72af5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 19:08:17 +00:00
Mady Mellor
637148f7c1
Merge changes Iaee9aeb0,I76587cf6 into udc-qpr-dev am: d8cb90f010
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23709211
Change-Id: I1b9adea75976af4ef9c186ec69277bf51b5dfa31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 17:43:35 +00:00
Jerry Chang
26d5493e69
Merge "Prevent exception when quick switching between two split pairs" into udc-dev
2023-06-27 17:42:42 +00:00
Mady Mellor
d8cb90f010
Merge changes Iaee9aeb0,I76587cf6 into udc-qpr-dev
...
* changes:
Fade the bubble bar arrow in and out when the bubble bar expands and collapses.
Animate the bubble bar width and the bubbles within it as it expands and collapses.
2023-06-27 17:35:58 +00:00
Anvesh Renikindi
d8af5abcfd
Merge "Update renamed util function M3HCTToColor in launcher code" into udc-dev-plus-aosp
2023-06-27 14:54:49 +00:00
TreeHugger Robot
bb96bfdcfa
Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b am: 7733c11623 am: 796c3bbd02
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397
Change-Id: I5271737bd92ddabdf19dcc8d48e769f84f715b9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 04:42:53 +00:00
TreeHugger Robot
796c3bbd02
Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b am: 7733c11623
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397
Change-Id: I5f485e204fa56b319f250a467eb448622be9f01f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 03:54:56 +00:00
TreeHugger Robot
0093120979
Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397
Change-Id: Ibc13e029b1d318f501e1cc787f2ee7724b686538
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 03:05:09 +00:00
TreeHugger Robot
1f3c56af5b
Merge "Restore strong reference to animation runner" into udc-dev
2023-06-27 02:13:00 +00:00
Randy Pfohl
72c638fb9c
Merge "Updating content description for accessibility no matter the state" into udc-qpr-dev am: 2310a890c2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815319
Change-Id: I94f66b0347354edde1ac42218faa72ae3b6c5b13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-27 01:57:23 +00:00
Randy Pfohl
2310a890c2
Merge "Updating content description for accessibility no matter the state" into udc-qpr-dev
2023-06-27 01:13:53 +00:00
Winson Chung
6cfe2e6cbe
Restore strong reference to animation runner
...
- The remote animation factory needs to be strongly referenced since
the only other reference is a weakly held one from
LauncherAnimationRunner, and if a gc happens in between starting
the animation and the onAnimationStart() callback, then the
animation will not play.
Fixes: 284106887
Test: Force a gc after creating a remote app launch animation and ensure
that the runner still exists when the animation starts
Change-Id: I5f584451b41c666916801b8ea0cb470c7ab9fc51
2023-06-26 23:55:23 +00:00
randypfohl
442b93c9c9
Updating content description for accessibility no matter the state
...
Test: built and tested locally by opening apps and then turning on talkback to verify content description is set
Bug:280908761
Change-Id: I9ed015bdd375e2cedf5e068a77bd4b4dcb5f9488
2023-06-26 13:24:58 -07:00
Winson Chung
cec8dcaa5c
Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37 am: b578dac96e am: bb4c513353
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649
Change-Id: I008ca0f7b6ef75730e3666f7eff2b79d70d4795a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-26 20:20:42 +00:00
fbaron
ed79206e4b
Update renamed util function M3HCTToColor in launcher code
...
Bug: 288120001
Test: none
Change-Id: If4c6783472d7fa05a1162e2f176a613d28f7bec3
Merged-In: If4c6783472d7fa05a1162e2f176a613d28f7bec3
(cherry picked from commit 911be164b3 )
2023-06-26 20:17:17 +00:00