Commit Graph

64874 Commits

Author SHA1 Message Date
Holly Jiuyu Sun d91ee8f9af Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395

Change-Id: I677a0e430b79b13a85f955a85421d78c5a166969
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 18:27:19 +00:00
Holly Jiuyu Sun 18e0e1e50a Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev 2023-06-30 17:56:16 +00:00
Schneider Victor-tulias 045f9cf583 Merge "Update TestProtocol.REQUEST_CLEAR_DATA to properly clear the workspace" into udc-qpr-dev am: 720d0cf4c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835672

Change-Id: I392b76e7b4263d1ca33fc33dac3ecf20660795d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 17:23:21 +00:00
Schneider Victor-tulias 720d0cf4c4 Merge "Update TestProtocol.REQUEST_CLEAR_DATA to properly clear the workspace" into udc-qpr-dev 2023-06-30 16:54:30 +00:00
Holly Sun 35b9960b63 [a11y] Fix crash when using talkback to add to home screen.
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
Federico Baron 445d7d266e Merge "Add WidgetPicker screenshot tests" into udc-qpr-dev am: 25f5fc2470
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23437865

Change-Id: Ia196afbb17f9ac81ff19e82c786f38d24a6b4aba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 02:52:14 +00:00
Treehugger Robot 8d4543f8fd Merge "Fix ReorderAlgorithmUnitTest not restoring numRows properly" into udc-qpr-dev am: c243875235
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23843686

Change-Id: Ia47e67a10a1c8e3c20b82a2dba25fcc2c7521039
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 02:51:57 +00:00
Treehugger Robot 23b5527ade Merge "Small tweak to floating search on phone." into udc-qpr-dev am: 4c4f9b67a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23670474

Change-Id: I75f6c2a5b7fb863a3226c3ff7c53dc0014ea8264
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 02:51:18 +00:00
Federico Baron 25f5fc2470 Merge "Add WidgetPicker screenshot tests" into udc-qpr-dev 2023-06-30 02:34:30 +00:00
Treehugger Robot c243875235 Merge "Fix ReorderAlgorithmUnitTest not restoring numRows properly" into udc-qpr-dev 2023-06-30 02:15:34 +00:00
Treehugger Robot 4c4f9b67a7 Merge "Small tweak to floating search on phone." into udc-qpr-dev 2023-06-30 01:53:38 +00:00
Treehugger Robot 83d0a33185 Merge "Make 1.8 the default threshold for overview -> all apps." into udc-qpr-dev am: b1f4670843
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836391

Change-Id: I0cf240abb7c6eaad20b0e0b9abb4f7d17102b7fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 00:11:19 +00:00
Treehugger Robot 5a56f8f111 Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679

Change-Id: I02604078e3f4dcfc6413916a8c47f7c6cce934bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 00:11:09 +00:00
Treehugger Robot b1f4670843 Merge "Make 1.8 the default threshold for overview -> all apps." into udc-qpr-dev 2023-06-29 23:52:24 +00:00
Treehugger Robot 1b565681fe Merge "Disable all apps from overview in some cases." into udc-qpr-dev 2023-06-29 23:52:09 +00:00
Brandon Dayauon e1b99fcf61 Merge "Fix custom buttons with translated string" into udc-d1-dev am: 206821cee6 am: 6e56b2247e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849389

Change-Id: I7edca77b58aa6364687c9bb1939f28a372aa031a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 23:49:51 +00:00
Brandon Dayauon 3a255c070f Merge "Fix custom buttons with translated string" into udc-d1-dev am: 206821cee6 am: 8469cfab71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849389

Change-Id: I6728c8673a65aee7ea525f9801c250323a3578cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 23:43:55 +00:00
Andy Wickham 3d0661292c Make 1.8 the default threshold for overview -> all apps.
Bug: 275132633
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW (disabled by default)
Test: Clear launcher data and enable flag; verify default value
Change-Id: I005dde743e445287e03f4f92b511e5fe1c023d6f
2023-06-29 23:33:21 +00:00
Brandon Dayauon 6e56b2247e Merge "Fix custom buttons with translated string" into udc-d1-dev am: 206821cee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849389

Change-Id: I926d6087d90dc64a0f5d7b7c0291fbc1b465f63b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:58:30 +00:00
Brandon Dayauon 8469cfab71 Merge "Fix custom buttons with translated string" into udc-d1-dev am: 206821cee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849389

Change-Id: Ic819b40f9bd901de4823d36c2693b2bf96436581
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:56:08 +00:00
Brandon Dayauon 69be4ccd17 Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838

Change-Id: I38ea618a57778e567608de1c5ecbc8e76d02030c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:38:46 +00:00
Jordan Silva 7669cc5ebc Merge "Decrease icon size by steps for folders" into udc-qpr-dev am: b704c1d458
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792289

Change-Id: I9fd7d7b0d4ed0f7a9295b4401b240ce0d0f3aef1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:17:23 +00:00
Brandon Dayauon 206821cee6 Merge "Fix custom buttons with translated string" into udc-d1-dev 2023-06-29 22:15:38 +00:00
Brandon Dayauon aa9332af88 Merge "Fix prediction row title consistency" into udc-qpr-dev 2023-06-29 21:45:40 +00:00
Jordan Silva b704c1d458 Merge "Decrease icon size by steps for folders" into udc-qpr-dev 2023-06-29 21:38:15 +00:00
Mateusz Cicheński 6168ad04d7 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4 am: 865b576cf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I69cd3339388ab0c13654a9c34ce11b2b366a5975
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:55:29 +00:00
Mateusz Cicheński d9602f142e Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 8bc482c25e am: a118efdd61
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I4aafe6456944e3c8348ac3fc3eaa1d7a4d289329
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:53:32 +00:00
Mateusz Cicheński 710b4c44e1 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4 am: ea4fb36690
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I8b0a0951a8e4e6e1322274cd8c3612f843347418
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:52:10 +00:00
Mateusz Cicheński a118efdd61 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 8bc482c25e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I1a2036123af24af25f1cfb2662ad1b73e9410a1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:05:14 +00:00
Mateusz Cicheński 865b576cf4 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I65ba5c1fbd64c88ff4e67534e42e453320d45a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:05:12 +00:00
Mateusz Cicheński ea4fb36690 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I50b0b0ca9e82dd33d5c64dec1352fc4b86db1665
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:02:51 +00:00
Hongwei Wang 173cfed71c Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 am: 49b9fbd188
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I39b7427f3190c635118c317f3e9b0871134a7666
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:26:51 +00:00
Hongwei Wang d4041cad18 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 858a3c1659 am: c1749851f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: Ic343ec29b01999e8b7b99e302af7e925e4638017
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:25:12 +00:00
Hongwei Wang e359184522 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 am: 263aceeeea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I55f4709943f4373b71a7dff8fbcd7c1f660a9a40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:23:48 +00:00
Mateusz Cicheński 1f113855f4 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I64cf41db2c47a69dd941a889f726604f669dd515
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:20:14 +00:00
Mateusz Cicheński 8bc482c25e Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I820931e5b5ccc0487dc9d8046c26579d762185e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:20:12 +00:00
Hongwei Wang c1749851f2 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 858a3c1659
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: Ib800e1e635df5146c380816970d2c01850c76baa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:58:25 +00:00
Hongwei Wang 49b9fbd188 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I0a6ef4eee4dfc6244b5ee4a7716c1e625923d4b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:58:16 +00:00
Hongwei Wang 263aceeeea Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:56:29 +00:00
Mateusz Cicheński 665524cc37 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev 2023-06-29 17:55:57 +00:00
Hongwei Wang 93551e9496 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I4074f76d60524d37c28408ea5744bde8bb790cbe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:36:12 +00:00
Hongwei Wang 858a3c1659 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I4e379dab3bfd5096bb2550a226e1d2b5b84c7bcf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:35:55 +00:00
Hongwei Wang ca08d75e4a Merge "Polish home-key from split to pip transition" into udc-dev 2023-06-29 17:17:03 +00:00
Tracy Zhou afd4eec779 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev am: 96fc36f614
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835676

Change-Id: Ia4b95d8ace26619a0993eddbdb4139f872035cc1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 02:29:46 +00:00
Tracy Zhou 96fc36f614 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev 2023-06-29 01:34:00 +00:00
Brandon Dayauon dba7359d23 Fix custom buttons with translated string
The reason why the buttons aren't being updated with the translated string is because the cache the views get the string from is not updated/loaded with the new language.
Rather, the update happens after the view has been inflated. With this change, when the string cache updates in bindStringCache(), we update the UI right then.

bug: 280958663
bug: 288442609
test: Manual
Change-Id: I7a49ee401d5a5f3268cfaef1abee8153e913a8ce
(cherry picked from commit 076dcdfd54)
2023-06-28 21:49:25 +00:00
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
TreeHugger Robot 1a23d2986a Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev am: c84ecc0f67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836068

Change-Id: Ibd0f3c7fdbfd3913e4abe7c78b6013ed1888ee92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:36 +00:00
Schneider Victor-tulias 99e779ad03 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev am: e2e1b79b06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835673

Change-Id: I1112987cc848ecaf2c30c383f04843afd6371576
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:24 +00:00
Schneider Victor-tulias 4864de5700 Merge "Inset the contents of AllSetActivity" into udc-qpr-dev am: 3ce99d1d96
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835670

Change-Id: Ib71e83fe6fb810383595e03fb3c40a4839d12d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:13 +00:00