Commit Graph

74483 Commits

Author SHA1 Message Date
Liana Kazanova d8d4fb4375 Revert "Add CUJ Jank interactions for App Pair saving and launching"
Revert submission 26567492-appPairsCUJ

Reason for revert: http://b/330185095

Reverted changes: /q/submissionid:26567492-appPairsCUJ

Change-Id: I73d29fe3618a55622e0daa22c9960e3c5783c275
2024-03-18 18:35:02 +00:00
Vinit Nayak 7ce42078da Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
2024-03-15 14:10:36 -07:00
Uwais Ashraf 21393f4651 Merge "Add required setup for quickstep tests to be run devicelessly" into main 2024-03-06 23:32:14 +00:00
Himanshu Gupta 189f3f8621 Merge "Fixing Layout height for Private Space container" into main 2024-03-06 21:56:45 +00:00
Jeremy Sim 46aa4a58f8 Merge "Fix bug with app pairs appearing in wrong orientation in pinned Taskbar" into main 2024-03-06 21:56:34 +00:00
Anushree Ganjam a61e05ebab [automerger skipped] [DO NOT MERGE] Enable omnient flags in P8a branch. am: 0d3016943c -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26418344

Change-Id: I95903f796710719885d396e0d91379cb9dfad3f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-06 18:53:44 +00:00
Vinit Nayak d1fb97ae64 Merge "On disabled app pairs, set color tint instead of changing alpha" into main 2024-03-06 18:39:19 +00:00
Brandon Dayauon b2f5bb00f4 Merge "Update icon background color of the private space widget tile" into main 2024-03-06 18:07:03 +00:00
Catherine Liang d56332892d Merge "Fix Launcher preview crash" into main 2024-03-06 16:57:16 +00:00
Anushree Ganjam 0d3016943c [DO NOT MERGE] Enable omnient flags in P8a branch.
Bug: 327638681
Test: NA
Flag: legacy ENABLE_LONG_PRESS_NAV_HANDLE_MPR ENABLED
Change-Id: Ic2565c5c67f6877b88138f527e09a63dfcda47bf
2024-03-06 16:45:19 +00:00
Uwais Ashraf 45cd460cef Add required setup for quickstep tests to be run devicelessly
Fix: 325090628
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest NexusLauncherRoboTests
Test: presubmits passing
Change-Id: I9ef80d4bf03e9bdb6c23d776df621a32248e6b0d
2024-03-06 14:01:21 +00:00
Andreas Agvard d632f22258 Merge "Adds new AssistStateManager settings" into main 2024-03-06 09:37:17 +00:00
Jeremy Sim 999ab5215a Fix bug with app pairs appearing in wrong orientation in pinned Taskbar
This CL makes it so that app pairs do an orientation check in dispatchDraw() instead of only on init().

Previously we only checked orientation on AppPairIcon.inflateIcon(), and the issue was that orientation was not re-checked when pinned Taskbar was rotated to different sides of the screen. Added a DeviceProfileListener to update orientation when DP changes.

Fixes: 323288812
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, app pair icon always has correct otientation on pinned taskbar
Change-Id: If2de1a4c7334fef1ba4c2edcca09bef9338bc73f
2024-03-05 22:32:36 -08:00
Jeremy Sim 09fe96b95a On disabled app pairs, set color tint instead of changing alpha
This CL changes the way disabled app pair icons are drawn: instead of setting alpha, it sets a color filter to indicate disabled status. This brings it in line with other apps icons and V's design specs.

Fixes: 326665140
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
2024-03-05 21:45:00 -08:00
Fengjiang Li 7dea7f0b42 Merge "[2/n] Avoid flicker to drop a widget that needs a config activity" into main 2024-03-06 02:03:48 +00:00
Fengjiang Li f114ec5b26 Merge changes Iab1de455,I0c6585e6,I125670d1 into main
* changes:
  [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
  [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
  [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
2024-03-06 01:32:17 +00:00
Fengjiang Li fb16517fea [2/n] Avoid flicker to drop a widget that needs a config activity
1. Don't show background in PendingAppWidgetHostView if we are showing preview bitmap
2. Extract bitmap from DropView instead of LauncherAppHostView
3. Letterbox bitmap into PendingAppWidgetHostView's canvas if canvas has different aspect ratio

Fix: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: I76de215186b96ffe65c909b28155fb19ac90d4f1
2024-03-05 14:49:09 -08:00
Federico Baron 944ed16981 Merge "Page resets when scrolling slowly fix" into main 2024-03-05 22:43:01 +00:00
Fengjiang Li cc1c582d89 [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
Fix: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: Iab1de455bf23d73b34f4a0d60f7e7a143bd028d1
2024-03-05 14:02:53 -08:00
Fengjiang Li 9280a68bbd [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I0c6585e6374db9412c8399ce3fdaf57348043d36
2024-03-05 14:02:53 -08:00
Fengjiang Li cad1f13d27 [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
For taskbar all apps, the background scrim is child view of AbstractSlideInView, thus scaling AbstracSlideInView during PB swipe will scale down background scrim. There is no need to re-apply scale effect on background scrim separately.

Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I125670d14bc788664a1371008589e4106496ae2e
2024-03-05 14:02:45 -08:00
Brandon Dayauon 40ea056886 Update icon background color of the private space widget tile
This icon background should be the same as the web icon backgrounds in Toast which is: materialColorSurfaceContainerLowest

bug: 320562455
Test: Manual - photos:
after private space qstile quicklaunchable dark theme: https://drive.google.com/file/d/1UZUxOdyEMEyLmPhnuPWJ085gQHrGgUdC/view?usp=sharing
after private space qstile nonquicklaunchable dark theme: https://drive.google.com/file/d/1UOoR0VHxdIIvMFfvhc_5MwHsg40wURA3/view?usp=sharing
after private space qstile quicklaunchable light theme: https://drive.google.com/file/d/1Ub1Nra_5rMlWuciI_a6yJM48EL6IdEsp/view?usp=sharing
after private space qstile nonquicklaunchable light theme: https://drive.google.com/file/d/1UidMqcHI2rXTtwmwIRXkGiKJkaeP8ubi/view?usp=sharing
Flag: com.google.android.apps.nexuslauncher.enable_inject_private_space_tile

Change-Id: Id118a6cc69d091b216c49b7fe778d8b6c84966b2
2024-03-05 12:00:12 -08:00
Jeremy Sim e874bd603d Merge "Remove finished TODO" into main 2024-03-05 19:59:40 +00:00
Vadim Tryshev c96bfc32bf Merge "Syncing Launcher3 atest XML config with the GCL one" into main 2024-03-05 19:29:36 +00:00
Saumya Prakash af85ef74cc Merge "Increase the delay in between gesture tutorials" into main 2024-03-05 19:25:23 +00:00
Sunny Goyal 28ade08654 Merge "Using fractions in MultiValueUpdateListener instead of absolute durations" into main 2024-03-05 19:07:46 +00:00
fbaron cae498032f Page resets when scrolling slowly fix
Fix: 324071635
Flag: NONE
Test: Verified manually on RTL and non-RTL
Change-Id: Id778a0a01505d30bca4f216322f3ef3b951e63a7
2024-03-05 10:06:14 -08:00
Rohit Goyal d87f02f609 Merge "Bugfix: Remove widgets and deep shortcuts of app which gets archived." into main 2024-03-05 14:49:28 +00:00
Andreas Agvard d78d9bb5e2 Adds new AssistStateManager settings
Flag: NONE
Bug: 326143814
Test: Unit

Change-Id: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
2024-03-05 15:18:18 +01:00
Rohit Goyal bef2930f5a Bugfix: Remove widgets and deep shortcuts of app which gets archived.
* Once app is archived, remove widgets and deep shortcuts corresponding to the app from the home screen.
* However during backup & restore, widgets should not be removed if they are being restored.

Test: verified bugfix locally.
Bug: 326567866
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
2024-03-05 11:25:46 +00:00
Anushree Ganjam 33b8d436d4 Merge "Add InputDispatcherRule to print the key events dispatched from system_server." into main 2024-03-05 08:23:17 +00:00
Vadim Tryshev acfb4f22c6 Syncing Launcher3 atest XML config with the GCL one
Making sure all config settings are identical.

Test: abtd
Flag: N/A
Bug: 271324404
Change-Id: Ife0c27045a2f9cc4e4ba5c8908caf477db7a0f60
2024-03-04 18:28:20 -08:00
Vinit Nayak ed92a14eb9 Merge "Fix split selection for 3P launcher with animations off" into main 2024-03-05 01:58:31 +00:00
Vinit Nayak b0f37b73ff Merge "Revert "Revert "Implements the "Save App Pair" button in Overvie..."" into main 2024-03-05 01:49:25 +00:00
Jeremy Sim aa8b7b9a02 Remove finished TODO
Finished in ag/25945753.

Test: N/A
Flag: N/A
Change-Id: I7d86a62c5a84d7d68b89ef9f2fa6548df21588aa
2024-03-04 16:09:15 -08:00
Saumya Prakash 959dff1220 Increase the delay in between gesture tutorials
The time in between each gesture's finish page and the start of the next
gesture tutorial was too short. We increased the time we spend on the
finish page by 1000 ms based on this feedback.

Fix: 293967263
Test: Run through the gesture tutorial and note the longer pause in
between each gesture
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I2c22e19dff91ac720877e596df90efe7f3cfcd80
2024-03-04 23:51:23 +00:00
Sebastián Franco e4649b0ff4 Merge "Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing" into main 2024-03-04 23:43:12 +00:00
Andy Wickham 929005440e Merge "Add custom extra width to trigger LPNH" into main 2024-03-04 22:46:22 +00:00
Anushree Ganjam be6fff5e6a Add InputDispatcherRule to print the key events dispatched from system_server.
See
https://source.corp.google.com/h/android/platform/superproject/main/+/main:cts/libs/input/src/com/android/cts/input/DebugInputRule.kt

Locally we can execute `adb shell setprop log.tag.InputTransportPublisher DEBUG` to enable the InputDispatcher logs.

I want to debug why "Ctrl+W" DOWN events in not received by TAPL and to which window is the events delivered.

Bug: 325377690
Test: Manual
Flag: NA
Change-Id: I3f55a48ef3ca79fdaff9d1269c55846cb67b2179
2024-03-04 14:01:05 -08:00
Vinit Nayak 91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Sebastian Franco c3ffd41ff0 Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing
No-op change

Bug: 325286145
Flag: NA
Test: compiling
Change-Id: I703c08059b81e20111c17a142dc54335f18a5a87
2024-03-04 13:46:07 -06:00
Andy Wickham e92f25d7cb Add custom extra width to trigger LPNH
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).

You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.

For reference, the navbar width is 108dp and taskbar is 220dp.

Defaults to 0, i.e. you can only invoke within the visible navbar.

Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
2024-03-04 10:56:16 -08:00
Priyanka Advani 2ade8f2050 Merge "Revert "Remove cyclical dependency from LauncherPrefs."" into main 2024-03-04 18:52:18 +00:00
Priyanka Advani 3e64dabb46 Revert "Remove cyclical dependency from LauncherPrefs."
This reverts commit 526f8a0099.

Reason for revert: culprit for b/328063858. Will be running through ABTD for verification and before submitting the revert.

Change-Id: Ie439b2d661617f10bbc31afada187a313dd52af7
2024-03-04 18:07:59 +00:00
Fengjiang Li 95b55116c1 Merge "Fix a bug where PURPOSE_BUGFIX was added to wrong flag" into main 2024-03-04 17:46:21 +00:00
Treehugger Robot 0ff94e631f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-04 17:25:25 +00:00
Treehugger Robot 2be60d98a8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-04 17:25:25 +00:00
Uwais Ashraf d4af12beba Merge "Remove classes related to E2E testing from deviceless test classpath" into main 2024-03-04 17:17:45 +00:00
Sam Cackett ddde91b915 Merge "Translate IconMenu up when the TaskMenu is expanded and moved" into main 2024-03-04 17:17:24 +00:00
Sunny Goyal f584b32811 Using fractions in MultiValueUpdateListener instead of absolute durations
This ensures that any global animation scale applies properly

Bug: 327645429
Flag: NONE
Test: Manual
Change-Id: I12205429dca5a87208fa9964b3307fb718af4fd0
2024-03-04 09:15:11 -08:00