Commit Graph

34599 Commits

Author SHA1 Message Date
TreeHugger Robot d8bbdce598 Merge "Removing unused tracing" into sc-v2-dev 2021-09-16 04:59:38 +00:00
TreeHugger Robot ca1ee7a161 Merge changes from topic "launcher-loading" into sc-v2-dev
* changes:
  Improve workspace loading times.
  Add tracing to help in launcher load time profiling.
2021-09-16 04:24:23 +00:00
Schneider Victor-tulias b988ab77cb Improve workspace loading times.
Updated loadWorkspace to load all required icons in a series of bulk sql queries. This reduces the cost of SQL lookups (up to two lookups per user, rather than one lookup per icon)

Bug: 195674813
Test: Added all icons to workspace, added duplicate icons, added icons for same component name from different users

Change-Id: I56afaa04e7c7701f0d3c86b31c53f578dfa73fe6
2021-09-15 17:09:06 -07:00
Schneider Victor-tulias 927d6dcc6c Add tracing to help in launcher load time profiling.
Bug: 195674813
Test: None
Change-Id: I895a64bbba515ce7b7df8d093d40e0a5b6056d2e
2021-09-15 17:08:53 -07:00
Vinit Nayak 104ed0b9a8 Show all TaskViews when doing seamless overview rotation am: 6434f8eae5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15838849

Change-Id: Id57edd739e61c9703449058f439c0526b6ef2e8c
2021-09-15 23:39:22 +00:00
TreeHugger Robot da76a1defd Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 20:26:49 +00:00
Vinit Nayak 6434f8eae5 Show all TaskViews when doing seamless overview rotation
* If user is scrolling and rotates overview in fake
landscape, we wouldn't change the alpha to show if it
was hidden previously.
Now we only skip changing the alpha if it's already visible.

Bug: 194715506
Test: Scroll overview in fake landscape and rotate.
No more invisible task.

Change-Id: Idb519125fbb5ec7be33e0d7b6dd313fb4df684db
2021-09-15 19:17:54 +00:00
Brian Isganitis 52715bed68 [automerger skipped] Enable widgets in launcher preview flag am: 21faa2a3de -s ours
am skip reason: Merged-In I2d02d7a1328ed9ef5d3dfbec090dc1f9908dd527 with SHA-1 1ce4353359 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15822859

Change-Id: Icaffc1818b602d782d22673843ac592a766066e9
2021-09-15 19:04:50 +00:00
Brian Isganitis 45a72645bb [automerger skipped] Load widgets in wallpaper app launcher preview am: 62a6271d9c -s ours
am skip reason: Merged-In I38569d2ff0b64ba55eb188afa42fba4100aae7ff with SHA-1 c79d577f18 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15829075

Change-Id: Iab7ec7dc1fca9c60a634b36cf24c8cee5489c527
2021-09-15 19:04:49 +00:00
Sunny Goyal 093b864631 [automerger skipped] Fixing widget not laid-out properly in preview am: 828154a2b2 -s ours
am skip reason: Merged-In Ib1ec8a53e4701f6813813b86bf481b837127a909 with SHA-1 5d5085c5c3 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15829074

Change-Id: I2b575309ea29d0f0d1736668c67dd886b407fc2f
2021-09-15 19:04:48 +00:00
Brian Isganitis 2a616a9bbd [automerger skipped] Add flag for widgets in Launcher preview am: d1d6713700 -s ours
am skip reason: Merged-In I74063d0ef29f828f740633ce0dab860672f69d3d with SHA-1 2b81fec450 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15828620

Change-Id: Ide2a5d91609621292b4600fd2c56a5f3bf754d77
2021-09-15 19:04:48 +00:00
Tony Wickham 3d0fca7e0d Merge "Don't set Taskbar window to non-fullscreen while folder animates closed" into sc-v2-dev 2021-09-15 17:47:46 +00:00
Tony Wickham 2908eb70fc Merge changes from topics "TaskbarLogging", "taskbar-log" into sc-v2-dev
* changes:
  Add logs for taskbar and overview split action
  Add TaskBarContainer to launcher_atom.proto
2021-09-15 16:28:45 +00:00
TreeHugger Robot a2f04dd7d4 Merge "Don't move taskbar window when it resizes" into sc-v2-dev 2021-09-15 07:26:28 +00:00
Vadim Tryshev 72da449f8a Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 02:35:04 +00:00
Tony Wickham d5e116a750 Don't set Taskbar window to non-fullscreen while folder animates closed
Test: Open an app, open a folder in taskbar, and drag an app from the folder. Ensure the folder close animation plays completely.
Fixes: 199954907
Change-Id: I1caec4ef24b5325724d74f10ddbeae6ef8f9e959
2021-09-14 17:48:14 -07:00
TreeHugger Robot 25a1e0b913 Merge "Rebind TISBinder if service killed during connection" into sc-v2-dev 2021-09-15 00:31:23 +00:00
vadimt 155ce05218 Removing unused tracing
Test: presubmit
Bug: 192018189
Change-Id: I31e6fd8410e879aeda0249d89f650e1a41de6030
2021-09-14 16:42:59 -07:00
Tony Wickham ed16fb4739 Don't move taskbar window when it resizes
Test: enter split screen, open folder or drag an app icon and ensure the
taskbar doesn't jump briefly to the top of the screen
Fixes: 199386357

Change-Id: I9a4787931a764db0bc036725a58984823a8d5467
2021-09-14 15:31:26 -07:00
Tony Wickham d552132d0b Reset RecentsView#mNextPage when swiping to home
This ensures that we don't inadvertently update mCurrentPage to be
mNextPage in computeScrollHelper(), which would in turn mess up
calculations such as RecentsView#getHorizontalOffsetSize().

Also removed resetNextPage parameter from forceFinishScroller(), as
resetNextPage was always passed as true anyway.

Test: Swipe up and to the right to home, ensure adjacent page goes all
the way off screen
Fixes: 199927699

Change-Id: Iee1ffac10e5195f0c3a124a23b06d5411ecd7ba2
2021-09-14 14:38:15 -07:00
Brian Isganitis 21faa2a3de Enable widgets in launcher preview flag
Test: Widgets fully load in launcher preview with correct size and color
Fix: 185306338, 191499358
Change-Id: I2d02d7a1328ed9ef5d3dfbec090dc1f9908dd527
Merged-In: I2d02d7a1328ed9ef5d3dfbec090dc1f9908dd527
2021-09-14 15:20:41 -04:00
Brian Isganitis 62a6271d9c Load widgets in wallpaper app launcher preview
Test: Widgets in wallpaper app launcher preview rendered
Bug: 185306338
Change-Id: I38569d2ff0b64ba55eb188afa42fba4100aae7ff
Merged-In: I38569d2ff0b64ba55eb188afa42fba4100aae7ff
2021-09-14 15:19:33 -04:00
Sunny Goyal 828154a2b2 Fixing widget not laid-out properly in preview
Bug: 185306338
Test: Manual
Change-Id: Ib1ec8a53e4701f6813813b86bf481b837127a909
Merged-In: Ib1ec8a53e4701f6813813b86bf481b837127a909
2021-09-14 15:14:44 -04:00
Brian Isganitis d1d6713700 Add flag for widgets in Launcher preview
Test: Flag available in developer options (does nothing)
Bug: 185306338
Change-Id: I74063d0ef29f828f740633ce0dab860672f69d3d
Merged-In: I74063d0ef29f828f740633ce0dab860672f69d3d
2021-09-14 15:14:26 -04:00
Vinit Nayak c64c3cf488 Rebind TISBinder if service killed during connection
Fixes: 198845519
Change-Id: I6af79af5591e2dca941ca4428c550169a178479c
2021-09-14 11:26:00 -07:00
Vinit Nayak ca549695aa Merge "Set GroupedTaskView child thumbnails in onMeasure" into sc-v2-dev 2021-09-14 17:34:52 +00:00
TreeHugger Robot e7e282b80b Merge "Adding Winscope Launcher trace artifact" into sc-v2-dev 2021-09-14 06:43:24 +00:00
Vinit Nayak e6abfca7ab Set GroupedTaskView child thumbnails in onMeasure
* Also add indicator if split was originally started
in portrait of landscape, so we know which dimension
of the divider bar to use if user goes to overview
and then rotates device (horizontal divider vs
vertical)

Fixes: 199461137
Test: Swipe to overview with staged split
Rotate device with and without live tile
Doesn't overlap with overview actions

Change-Id: I8b7f104f16d5b7265828f1b3d98ba3426b28d44f
2021-09-13 18:07:09 -07:00
Tony Wickham 2a10e62e92 Add logs for taskbar and overview split action
Log:
- Taskbar app launch (also from foldeR)
- Taskbar app drag (also from folder)
- Taskbar folder open
- Long press to hide taskbar
- Long press to show taskbar
- Overview Split screen action

Also add support for ActivityContext to overwrite/add to LauncherAtom.ItemInfo, which TaskbarActivityContext does to change HotseatContainer and PredictedHotseatContainer to TaskBarContainer

Test: enable logcat locally
Bug: 193009817
Change-Id: Ia82c846a727fecb8cbfd0a069c8af1276083bf83
2021-09-13 17:25:15 -07:00
TreeHugger Robot cd3c385246 Merge "Use FakeTransformParams instead of real ones for gesture tutorial" into sc-v2-dev 2021-09-14 00:07:29 +00:00
Sunny Goyal a0fda9ad65 Fixing ModelPreload cancelling existing load am: 57d4f748b8 am: d73fa1ef92
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15820555

Change-Id: I59ca789a99b4bdd246f4d87f91596dc392766342
2021-09-13 23:42:04 +00:00
Sunny Goyal d73fa1ef92 Fixing ModelPreload cancelling existing load am: 57d4f748b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15820555

Change-Id: Iefe6ef941158a9c5b6eada7c71e8633b96ac4233
2021-09-13 23:24:13 +00:00
Thiru Ramasamy be8b2ad03d Add TaskBarContainer to launcher_atom.proto
Bug: 193009817
Test: Manual
Change-Id: Ib69be2b2405ab38891dff34c4d366105cd2499c1
2021-09-13 16:15:52 -07:00
TreeHugger Robot fb4461e2e7 Merge "Add tmp buffer to rounded corners" into sc-v2-dev 2021-09-13 22:13:20 +00:00
Winson Chung 58030642b0 Add tmp buffer to rounded corners
- Testing if this actually moves the gesture out of the screen decor area

Bug: 197326121
Test: Pre/postsubmit
Change-Id: I3c46ed3860ba6ba1fb605242b4f7242aaabc5672
2021-09-13 20:01:56 +00:00
Vinit Nayak f66f8271cf Use FakeTransformParams instead of real ones for gesture tutorial
* SwipeUpAnimationLogic was ignoring the TransformParams arg
that was being passed in, because for staged split we are
creating/pairing TaskViewSimulators and TransformParams in
SwipeUpAnimationLogic itself.
* Override the remote handle that gets created during the gesture
tutorial (which shouldn't be done in other cases, but because
tutorial is a one-off it should be fine)

Fixes: 199482330
Test: Launched gesture tutorial from launcher home settings
No crash

Change-Id: I346211a422e46981a994bd40e34e46b44f9f5d0e
2021-09-13 12:57:17 -07:00
TreeHugger Robot 14df808f4d Merge "Fix taskbar education not touchable if taskbar is stashed" into sc-v2-dev 2021-09-13 18:05:28 +00:00
Sunny Goyal 57d4f748b8 Fixing ModelPreload cancelling existing load
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.

> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
  empty callbacks

Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
2021-09-13 17:47:29 +00:00
TreeHugger Robot 33df165ca0 Merge "Base split action on focusedTaskView instead of runningTaskView" into sc-v2-dev 2021-09-13 17:38:17 +00:00
Tony Wickham 9c7eda8135 Merge "Destroy taskbar when device is shutting down" into sc-v2-dev 2021-09-13 17:27:43 +00:00
TreeHugger Robot adfcd9daea Merge "Introduce haptic when all apps state transition happens." into sc-v2-dev 2021-09-12 22:53:47 +00:00
Hyunyoung Song 862415a142 Introduce haptic when all apps state transition happens.
Bug: 195679234
Test: manual
Change-Id: Id923f1641bb49579c972e3dbb9de094293d00f93
Merged-In: Id923f1641bb49579c972e3dbb9de094293d00f93
2021-09-12 21:48:52 +00:00
TreeHugger Robot 305d0463b1 Merge "[OneSearch] Update the plugin interface to include more answer data." into sc-v2-dev 2021-09-11 03:08:51 +00:00
TreeHugger Robot 6087951a9f Merge "Dump DepthController internals" into sc-v2-dev 2021-09-11 00:51:22 +00:00
Tony Wickham 4db4ec118b Destroy taskbar when device is shutting down
Test: Shutdown/restart device, ensure taskbar isn't showing
Fixes: 194633599
Change-Id: I8061e515e122c446438975b98527aeda6c59996a
2021-09-10 16:18:20 -07:00
vadimt 1cb868e2f7 Removing unused tracing
Bug: 195319692
Test: presubmit
Change-Id: I035870abff8b0ee1f714bb56a5326e30c0f77fb0
2021-09-10 16:01:17 -07:00
Thiru Ramasamy 8c8dc56495 Merge "Implement LauncherLayoutSnapshot pulled atom callback." into sc-v2-dev 2021-09-10 22:59:00 +00:00
Lucas Dupin 01c362bb6c Dump DepthController internals
Add DepthController to dumpsys, so it's easier to debug any future
issues.

Bug: 198732728
Test: adb shell dumpsys activity com.google.android.apps.nexuslauncher
Change-Id: Ifa7fe1d7fcb375cacc907d0da9524a2ee2a2677d
2021-09-10 22:57:24 +00:00
Vinit Nayak 5702b89b30 Base split action on focusedTaskView instead of runningTaskView
* getRunningTaskView() is null when rotating device,
only valid when swiping up to overview
* focusedTaskView() correctly set in both cases

Fixes: 199461147
Test: Bug doesn't repro
Change-Id: Ib39c1f6f05b3cd5f72c13facc6b8000346896476
2021-09-10 14:07:58 -07:00
TreeHugger Robot f8d4041c84 Merge "Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY in RestoreDbTask" into sc-v2-dev 2021-09-10 20:55:18 +00:00