Commit Graph

74449 Commits

Author SHA1 Message Date
Rohit Goyal d87f02f609 Merge "Bugfix: Remove widgets and deep shortcuts of app which gets archived." into main 2024-03-05 14:49:28 +00:00
Rohit Goyal bef2930f5a Bugfix: Remove widgets and deep shortcuts of app which gets archived.
* Once app is archived, remove widgets and deep shortcuts corresponding to the app from the home screen.
* However during backup & restore, widgets should not be removed if they are being restored.

Test: verified bugfix locally.
Bug: 326567866
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
2024-03-05 11:25:46 +00:00
Anushree Ganjam 33b8d436d4 Merge "Add InputDispatcherRule to print the key events dispatched from system_server." into main 2024-03-05 08:23:17 +00:00
Vinit Nayak ed92a14eb9 Merge "Fix split selection for 3P launcher with animations off" into main 2024-03-05 01:58:31 +00:00
Vinit Nayak b0f37b73ff Merge "Revert "Revert "Implements the "Save App Pair" button in Overvie..."" into main 2024-03-05 01:49:25 +00:00
Sebastián Franco e4649b0ff4 Merge "Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing" into main 2024-03-04 23:43:12 +00:00
Andy Wickham 929005440e Merge "Add custom extra width to trigger LPNH" into main 2024-03-04 22:46:22 +00:00
Anushree Ganjam be6fff5e6a Add InputDispatcherRule to print the key events dispatched from system_server.
See
https://source.corp.google.com/h/android/platform/superproject/main/+/main:cts/libs/input/src/com/android/cts/input/DebugInputRule.kt

Locally we can execute `adb shell setprop log.tag.InputTransportPublisher DEBUG` to enable the InputDispatcher logs.

I want to debug why "Ctrl+W" DOWN events in not received by TAPL and to which window is the events delivered.

Bug: 325377690
Test: Manual
Flag: NA
Change-Id: I3f55a48ef3ca79fdaff9d1269c55846cb67b2179
2024-03-04 14:01:05 -08:00
Vinit Nayak 91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Sebastian Franco c3ffd41ff0 Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing
No-op change

Bug: 325286145
Flag: NA
Test: compiling
Change-Id: I703c08059b81e20111c17a142dc54335f18a5a87
2024-03-04 13:46:07 -06:00
Andy Wickham e92f25d7cb Add custom extra width to trigger LPNH
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).

You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.

For reference, the navbar width is 108dp and taskbar is 220dp.

Defaults to 0, i.e. you can only invoke within the visible navbar.

Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
2024-03-04 10:56:16 -08:00
Priyanka Advani 2ade8f2050 Merge "Revert "Remove cyclical dependency from LauncherPrefs."" into main 2024-03-04 18:52:18 +00:00
Priyanka Advani 3e64dabb46 Revert "Remove cyclical dependency from LauncherPrefs."
This reverts commit 526f8a0099.

Reason for revert: culprit for b/328063858. Will be running through ABTD for verification and before submitting the revert.

Change-Id: Ie439b2d661617f10bbc31afada187a313dd52af7
2024-03-04 18:07:59 +00:00
Fengjiang Li 95b55116c1 Merge "Fix a bug where PURPOSE_BUGFIX was added to wrong flag" into main 2024-03-04 17:46:21 +00:00
Treehugger Robot 0ff94e631f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-04 17:25:25 +00:00
Treehugger Robot 2be60d98a8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-04 17:25:25 +00:00
Uwais Ashraf d4af12beba Merge "Remove classes related to E2E testing from deviceless test classpath" into main 2024-03-04 17:17:45 +00:00
Sam Cackett ddde91b915 Merge "Translate IconMenu up when the TaskMenu is expanded and moved" into main 2024-03-04 17:17:24 +00:00
Stefan Andonian 544e4d510b Merge "Remove cyclical dependency from LauncherPrefs." into main 2024-03-04 15:45:06 +00:00
Uwais Ashraf 9c2f5a4c62 Remove classes related to E2E testing from deviceless test classpath
Fix: 327187136
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Test: presubmits passing
Change-Id: I4f05524bdc55d8473f3b5115cc239eb8cc48a856
2024-03-04 13:45:32 +00:00
samcackett 3a2aa5bc04 Translate IconMenu up when the TaskMenu is expanded and moved
Fixes: 327564916
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I8acd79a21c7ce1d65496e7e6cb8ea0aa8912738d
2024-03-04 11:43:17 +00:00
Jeremy Sim 742f710168 Merge "Fix bug with TalkBack not reading out SplitInstructionsView" into main 2024-03-03 00:18:47 +00:00
Bill Yi 4cc2559564 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9f2e6decb861db72d2ca01385992ac8cd3873d32
2024-03-01 19:33:16 -08:00
Bill Yi 2320d553c7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1e8590b55cd77be368a46668cc8764463a264ebf
2024-03-01 19:32:34 -08:00
Jagrut Desai 02c56e8258 Merge "Fixing taskbar being unstashed after opening to unfolded mode" into main 2024-03-01 21:43:24 +00:00
PODISHETTY KUMAR b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Jeremy Sim d2c28c7ee3 Fix bug with TalkBack not reading out SplitInstructionsView
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.

Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
2024-02-29 21:35:20 -08:00
Jeremy Sim c8c4fd8aeb Merge "Fix disabled state for non-resizeable app pairs" into main 2024-03-01 05:14:48 +00:00
Vinit Nayak 5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Stefan Andonian 526f8a0099 Remove cyclical dependency from LauncherPrefs.
ag/26260351 was a much larger CL that removed more pieces of
LauncherPrefs that were related to this flag and were unused.
Unfortunately, that CL caused a test regression, and so I am publishing
this much smaller change in an effort to resolve the underlying issue in
a timely manner.

Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I10be75a1278fdffe7cc01beecf37b967526c4bc4
2024-03-01 00:37:55 +00:00
Jagrut Desai 3c3bef333a Fixing taskbar being unstashed after opening to unfolded mode
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: I91aa947a707e3fc918e617f207e823b2f1460466
2024-02-29 16:17:24 -08:00
Vinit Nayak b274152194 Fix split selection for 3P launcher with animations off
* When animations were off, the currentState in
FallbackRecentsStateController is incorrect (we didn't need
that check at all)
* Surfaced a bug in MultiValueUpdateListener that is being
fixed in ag/26416537

Test: 1P + 3P launcher all of the following:
starting split from overview with animations and without
rotation
selecting second app before and after rotation
Fixes: 327346105

Change-Id: I4f19119c30a8669bba6ced06e30773f085a78047
2024-02-29 15:50:50 -08:00
Bill Yi 4b12762881 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-29 23:12:58 +00:00
Bill Yi 08fe4d0135 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-29 23:12:58 +00:00
Zak Cohen e3e00c6e26 Merge "Widget Picker - show app icon next to recommended app label." into main 2024-02-29 21:55:37 +00:00
Jeremy Sim 31b934f28f Fix disabled state for non-resizeable app pairs
This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.

This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.

Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
2024-02-29 13:42:43 -08:00
Saumya Prakash 3fb35d3fb8 Merge "Remove the tint from taskbar themed icons for dark mode." into main 2024-02-29 20:05:15 +00:00
Jeremy Sim 164d162ec6 Merge "Update app pair error strings with UXW-approved ones" into main 2024-02-29 19:47:41 +00:00
Jeremy Sim 8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Fengjiang Li ea67949eb0 Fix a bug where PURPOSE_BUGFIX was added to wrong flag
ag/26027892 added `PURPOSE_BUGFIX` to `enable_tablet_two_pane_picker_v2`, instead it should be added to `enable_add_app_widget_via_config_activity_v2`

Flag: aconfig enable_add_app_widget_via_config_activity_v2 DISABLED
Test: NONE
Bug: 284236964
Change-Id: I55ac6ae0f3af7ab1ed239ac11a04dd59eaf95c4a
2024-02-29 11:42:29 -08:00
Vadim Tryshev 0fa523bb32 Merge "Removing logging for verifying internal Launcher state from tests" into main 2024-02-29 19:18:04 +00:00
Tony Wickham 47a85e4607 Merge "Call showCurrentTask again if applyLoadPlan doesn't include running task" into main 2024-02-29 17:19:11 +00:00
Federico Baron 835b9610bc Merge "Update some dimens for portrait edit state" into main 2024-02-29 17:17:19 +00:00
Jakob Schneider a9338897a4 Merge "Add dedicated a11y label for archived apps." into main 2024-02-29 10:54:31 +00:00
Bill Yi 99f1bf8af6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I493a63156b699e6251b4a8c64d50600513969a8e
2024-02-28 21:56:05 -08:00
Bill Yi 70799d4540 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If0d3c974835120248fb17d97fd678ef5921a46a8
2024-02-28 21:55:23 -08:00
Jeremy Sim 41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Vinit Nayak 2b4e99344d Merge "Remove A11y node info for SplitInstructionsView" into main 2024-02-29 03:16:28 +00:00
Federico Baron b68a6e581c Merge "Add ScreenRecord for workTabExists tapl test" into main 2024-02-29 02:56:55 +00:00
Jeremy Sim bdabf0f072 Update app pair error strings with UXW-approved ones
Fixes: 327432662
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: N/A
Change-Id: Ie437a67be7029da404dbb2c8f326a2140ac36138
2024-02-28 18:56:31 -08:00