Commit Graph

17621 Commits

Author SHA1 Message Date
Ryan Lothian d813e79ecc Get Robolectric tests passing
+ Default SDK 28 -> 26, as >26 isn't available for
  unbundled make builds.

+ @Ignore 3 test methods that currently fail with
  resource-related errors.

Test: RunLauncherRoboTests succeeds locally
Bug: 119567714
Change-Id: Id6ea42cef050119d892b5af2b1ba1afc4c4f0b28
2018-11-15 20:17:33 +00:00
Jonathan Miranda a5c67901f8 Merge "Clean up span calculations in LauncherAppWidgetProviderInfo." into ub-launcher3-master 2018-11-15 00:35:55 +00:00
Winson Chung 3386fbf674 Ensure base StatsLogManager can be instantiated
Bug: 119500924
Change-Id: Ia1adfa75147508ff1ff2a119cfba62b034ae4604
2018-11-14 15:11:48 -08:00
Winson Chung 1296cf26f2 Updating shared lib for fw api change.
Change-Id: I42c6c85693d7f1c2b7a38de5f3dd05f43612b504
2018-11-14 10:36:27 -08:00
Tony Wickham c8d1716a9c Merge "Creating a new dismiss animation while one is pending is now valid" into ub-launcher3-master 2018-11-14 02:43:39 +00:00
Tony Wickham 026a5db8fd Merge "Fix quick switch when swiping right on back button" into ub-launcher3-master 2018-11-14 02:43:15 +00:00
Tony Wickham cad49c6721 Creating a new dismiss animation while one is pending is now valid
It used to be an invalid state to create a new dismiss animation while
one was pending, because the only way to do it was to swipe up. However,
now there are a number of places we create the dismiss animation, e.g.:
- When entering split screen
- Clear all
- Uninstalling an app

So now, instead of calling this an illegal state, we simply cancel the
previous pending dismiss if it exists.

Bug: 118880699
Bug: 118400078
Change-Id: I4d073f7e9d50e832ba4ae55391530040a0fac50c
2018-11-13 15:47:29 -08:00
Tony Wickham bdc5f3d9e6 Fix quick switch when swiping right on back button
Deferring the window tracking when touching down on the back button means that
we don't set isQuickSwitch before setting the state to FAST_OVERVIEW, making it
not scale up to be full screen. To fix this, we reapply the state when preparing
QuickScrubController for quick switch.

Change-Id: Ib3dcf300c45a00673ff9337f98d16d4e8cdf1ea0
2018-11-13 15:31:57 -08:00
TreeHugger Robot 9c9625a15f Merge "Moving come tests to Roboelectric" into ub-launcher3-master 2018-11-13 23:22:53 +00:00
TreeHugger Robot 4194f242ae Merge "Fix quick scrub skipping more than one page" into ub-launcher3-master 2018-11-13 18:04:10 +00:00
Tony Wickham 873264c71b Fix quick scrub skipping more than one page
There was a race condition where we were getting onQuickScrubProgress
before onQuickScrubStart. If we got enough of those, we were jumping
some pages before the block is set in onQuickScrubStart (which also adds
its own page jump). Now we don't send any onQuickScrubProgress() to
QuickScrubController until we have sent onQuickScrubStart()

Bug: 118636260
Change-Id: I60084850b0b1baad34112ab5945fce81cc3a3c53
2018-11-13 17:58:31 +00:00
Vadim Tryshev 9d9310ba72 Merge "Fix showing strange Launcher on pressing Home." into ub-launcher3-master 2018-11-13 01:28:24 +00:00
Vadim Tryshev e45e60140e Fix showing strange Launcher on pressing Home.
Bug: 118441555
Test: manual, race condition repro, TaplTests
Change-Id: I8b09895558f8baa72eb3a794724170417fadfda6
2018-11-12 16:11:55 -08:00
Winson Chung 4e362ea0f5 Clear click listener when the icon is removed.
- The click listener should be removed, otherwise, it can still active
  and clickable when the TaskView is bound to a new Task whose icon
  has not yet been loaded, which can cause crash.

Bug: 118834133
Change-Id: Ifd9fd8fe99b6177851d366f0c21f8fad59f1950e
2018-11-12 19:21:31 +00:00
Sunny Goyal 06a07e9748 Moving come tests to Roboelectric
> Fixing resource loading in robo tests

Change-Id: Id5b8a0e4916a2a200da7a41b03f19846834beb1f
2018-11-12 10:49:59 -08:00
Bill Yi f1982fcaae Import translations. DO NOT MERGE
Change-Id: I22579d4f7492047b291e6c6a7f73508ccad3af2d
Auto-generated-cl: translation import
2018-11-10 00:27:25 -08:00
Tony Wickham 4cdf0bd49f Merge "Add ToggleableGlobalSettingsFlag for QUICK_SWITCH" into ub-launcher3-master 2018-11-10 00:48:54 +00:00
Sunny Goyal 202fabfe10 Adding reusable version of IconCache and IconFactory
> Adding resource based allowing projects to control cache behavior
> Fixing missing comments from ag/5470467
> Adding support for no-immemory cache

Bug: 115891474
Change-Id: I691206805430cd93d3be78119bc249cefd79790a
2018-11-09 15:44:07 -08:00
Tony 94c5b83a7e Add ToggleableGlobalSettingsFlag for QUICK_SWITCH
- ToggleableGlobalSettingsFlag saves/loads from Settings.Global rather than
  SharedPrefs, allowing other processes to update the setting as well.
- ToggleableGlobalSettingsFlag#get() reads from storage every time.
- Add the flags' descriptions to the feature flags settings UI.

Change-Id: I9cfc44ddaa5d9e223cf77a9b2475f8d25757d1fb
2018-11-09 15:27:24 -08:00
TreeHugger Robot 7b3c12f90e Merge "Allow overriding flags in Robolectric tests" into ub-launcher3-master 2018-11-09 16:08:29 +00:00
Sunny Goyal 1a9cbd3c88 Moving BaseIconCache to icon lib
Change-Id: I4fb56dcd6231a848d152e690edaf8885efbc995a
2018-11-08 15:18:25 -08:00
Ryan Lothian af0c0e8b0d Allow overriding flags in Robolectric tests
Bug: 117235618
Change-Id: Ibc01a4fe1de6a38d9fc620e4601fdb2282bf03e1
2018-11-08 17:25:23 -05:00
Sunny Goyal 024659c1b0 Fixing wrong layout used to calculate drag-n-drop location
Bug: 119229781
Bug: 119234125
Change-Id: I24425a7754db3dfef803088761fa67c9586d89d9
2018-11-08 11:10:59 -08:00
TreeHugger Robot 160bfcfede Merge "Moving some utility classes to icon lib" into ub-launcher3-master 2018-11-08 07:59:34 +00:00
TreeHugger Robot e74d89be14 Merge "Requiring apps_view on workspace" into ub-launcher3-master 2018-11-08 02:29:39 +00:00
Vadim Tryshev 8effd11e08 Requiring apps_view on workspace
Update TAPL to reflect that apps_view is visible on workspace.

Test: TaplTests
Change-Id: I27e0f43d9200c18571573acd0ddedc1dc064cdc3
2018-11-07 18:07:50 -08:00
Sunny Goyal 9a4c5be23e Moving some utility classes to icon lib
Change-Id: I0cc19ea02fb0732e9e1778a18c0d2c229232d179
2018-11-07 13:16:07 -08:00
TreeHugger Robot 8b8ff994d2 Merge "Removing some Launcher3 dependencies from BaseIconCache" into ub-launcher3-master 2018-11-07 20:16:21 +00:00
Sunny Goyal 65ce2cc990 Fixing androidx preference fragments not being preserved by proguard
Bug: 119122391
Change-Id: Ib41010d4ac5f79a14a2b132ed723ad92580bc405
2018-11-07 10:08:47 -08:00
TreeHugger Robot eba272a562 Merge "Disable AddItemActivity on Android Go devices." into ub-launcher3-master 2018-11-06 23:56:57 +00:00
Rajeev Kumar 4851cf76a3 Disable AddItemActivity on Android Go devices.
Android Go doesn't support adding shortcuts to home screen.
Bug: 112904271
Test: Manual test

Change-Id: I28b20d0d9e5b5e7e91c16ca3ea355bb0c3984c42
2018-11-06 15:16:36 -08:00
TreeHugger Robot 1b34109d6a Merge "Adding an interface to allow adding custom views in FloatingHeaderView" into ub-launcher3-master 2018-11-06 23:00:05 +00:00
Sunny Goyal e62d2bb165 Removing some Launcher3 dependencies from BaseIconCache
Change-Id: Ic80ed4a5cd2fc414cd6c27096d798e7f0b8efc72
2018-11-06 14:51:55 -08:00
Sunny Goyal dcf917b133 Adding an interface to allow adding custom views in FloatingHeaderView
Bug: 109828640
Change-Id: I9bde5d4fab47eb3e5787bbb741b5b9051a15c0c2
2018-11-06 14:50:16 -08:00
Vadim Tryshev b63bcf1113 Merge "Adding animation when opening app usage settings" into ub-launcher3-master 2018-11-06 22:26:38 +00:00
Sunny Goyal 41e8da3cee Removing Launcher3 util class dependency in IconCacheUpdateHandler
Change-Id: I7317c11cd2aa54b4b7647aa5644b23c91a240d19
2018-11-06 12:32:35 -08:00
Sunny Goyal 066ace1b88 Replacing setAlphaComponent with setAlphaComponentBound for better animation interpolation
setAlphaComponent throws expetion for invalid range, which can cause brashes in overshoot
interpolation

Bug: 118390004
Change-Id: Ic9c5ff3d660eba353b982c4c47ccfaf329b3e296
2018-11-06 09:59:03 -08:00
TreeHugger Robot 5bd44153fd Merge "Remove duplicate test" into ub-launcher3-master 2018-11-06 16:14:31 +00:00
Ryan Lothian bb80025ef4 Remove duplicate test
I cloned the existing Instrumentation-based IntSetTest class
to be our first Robolectric test. Now Robolectric is working,
we can delete the Instrumentation test version.

Change-Id: I3adcfc451988a908c002b769b398348cb1782f1d
2018-11-06 10:57:17 -05:00
Sunny Goyal 3ebe28a82b Fixing wrong directory pack for icon lib classes
Change-Id: Ic3690198b1c6204e322ba7b0f46ccef5dfa97181
2018-11-05 22:27:55 -08:00
Rajeev Kumar 97fab14d8f Get rid of unused resources from Launcher3 running on Android Go devices.
Bug: 112904271
Test: Manual test
Change-Id: Ia19e92801f4d1a47b0dab47185d23b10e2412328
2018-11-05 18:27:07 -08:00
TreeHugger Robot ea14a7ac3a Merge "Removing UserManagerCompat wrapper for getting baded label" into ub-launcher3-master 2018-11-06 01:46:37 +00:00
TreeHugger Robot 9b5b417e64 Merge "Disable Shortcuts menu item for Android Go devices." into ub-launcher3-master 2018-11-06 01:41:59 +00:00
Sunny Goyal d7239fcc52 Removing UserManagerCompat wrapper for getting baded label
This removes some crass dependency on Launcher compat implementation
making it easier to move iconCache to a separate library

Change-Id: If5fab0c82d98089cde6f54b6a374fb7bb2db5ae8
2018-11-05 17:33:15 -08:00
Rajeev Kumar 9ed67ddc50 Disable Shortcuts menu item for Android Go devices.
Bug: 112904271
Test: Manual test
Change-Id: I423afd62063babcda52d3907bbd608049238f065
2018-11-05 17:32:16 -08:00
TreeHugger Robot 06bca75d01 Merge "Removing some launcher cross dependency in BaseIconCache so that it can eventually be moved to icon library" into ub-launcher3-master 2018-11-06 01:31:24 +00:00
Sunny Goyal 678f47c0c9 Removing some launcher cross dependency in BaseIconCache
so that it can eventually be moved to icon library

Change-Id: I65e3ad34322a10695c1ba114f5e60c4418747f05
2018-11-05 17:22:09 -08:00
TreeHugger Robot 8ac8d73530 Merge "Split out launcherProtos from sysui_shared.jar" into ub-launcher3-master 2018-11-06 01:14:56 +00:00
Hyunyoung Song 0ae3888ad1 Split out launcherProtos from sysui_shared.jar
Bug: 113043444
Change-Id: I3115cdc7871b0f77601e399df01cdde0dde87c6e
2018-11-05 17:01:54 -08:00
TreeHugger Robot 71170d7b16 Merge "Create a launcher LoaderResults override." into ub-launcher3-master 2018-11-05 23:55:37 +00:00