Commit Graph

12832 Commits

Author SHA1 Message Date
Tony Wickham d80ebdfd9f Intercept touches in DeepShortcutContainer after moving beyond touch slop
Otherwise it's possible for a long press to trigger when swiping
on a shortcut, which causes it to drag far away from the finger.

Bug: 32309824
Change-Id: I40bd5c1daac49d6edb59744083a1e23dcf4f0ce6
2016-10-31 13:32:26 -07:00
Jonathan Miranda 37e4df17cb Merge "Don't add focusables when getDescendantFocusability is FOCUS_BLOCK_DESCENDANTS." into ub-launcher3-master 2016-10-28 00:25:11 +00:00
Tony Wickham ed38a3c515 Merge "Consume touch events in DeepShortcutsContainer" into ub-launcher3-master 2016-10-28 00:17:45 +00:00
Tony Wickham 04a8ec4fc6 Consume touch events in DeepShortcutsContainer
Previously, touches along the horizontal area next to the
deep shortcuts arrow went through to the background, allowing
things like going to overview with the shortcuts still open.

Bug: 32477287
Change-Id: I82d21d3051a13b23dfaac19e93facee120968aaa
2016-10-27 17:01:32 -07:00
Sunny Goyal ec5a42e1ac Merge "Catching OOM during widget preview generation" into ub-launcher3-master 2016-10-27 22:04:51 +00:00
Jon Miranda 6a85817dfc Don't add focusables when getDescendantFocusability is FOCUS_BLOCK_DESCENDANTS.
Bug: 32315286
Change-Id: I6fc6600fc9cbf83f720d9e6e878735076cd52cf1
2016-10-27 14:14:31 -07:00
Tony Wickham 968c283f22 Merge "Restore mDragInfo when deferring onDropComplete() for uninstall." into ub-launcher3-master 2016-10-27 21:05:52 +00:00
Sunny Goyal 3ef8691f82 Fixing wrong cache lookup call
Cache entry was saved using flattenToShortString, but the
lookup was using flattenToString

Change-Id: I4c012d5a90a89121989db059d31d3dd288fa5b8c
2016-10-27 11:40:59 -07:00
Sunny Goyal 2570d107f5 Catching OOM during widget preview generation
Bug: 32365481
Change-Id: Ifc49b033c3ad83213d50793301d94bb6337a412d
2016-10-27 11:39:14 -07:00
Sunny Goyal 9ccafbff26 Removing custom dispatchDraw logic and letting the system handle
selecting appropriate children for drawing.

> System already skips children which are outside the bounds. Originally
this logic was added because workspace layout is larger than the screen, and
we need to selectivly skip more children. But over time we have added many
special conditions and at present workspace actually draws more children than
needed at any given time.
> Fixing bug, where onBeginPageMoving was getting called during folder open

Bug: 12116740
Change-Id: Idee18ee9cd9d348ebc4dfd82f4ff6df14e0d22d2
2016-10-26 17:14:12 -07:00
Sunny Goyal 35fe7be54e Removing some deprecated code around page layers
1) setChildrenDrawnWithCacheEnabled: deprecated
2) Removing custom logic based on isHardwareAccelerated. This check was not being
used consistantly everywhere

Bug: 29761236
Change-Id: Ic4a9c764f154497e376e37de2351fe04d1b48500
2016-10-26 13:14:03 -07:00
Tony Wickham 4feb27e6b1 Restore mDragInfo when deferring onDropComplete() for uninstall.
We moved mDragInfo = null to onDragEnd() since onDropComplete()
isn't called for pre-drags, but this led to NPE when returning
from unistall or app info since onDropComplete() is called after
onDragEnd() in this case. So now we restore a copy of mDragInfo.

Bug: 32415014
Change-Id: I7ef4fb7145c3c78039af1131e77538969db58141
2016-10-26 12:51:14 -07:00
Tony Wickham d1f034708b Don't move to adjacent page if it is full when dropping on it.
Bug: 32003721
Change-Id: Ia81b75a73f510ad2a58764dec9eb7e57b9bf2dcd
2016-10-24 10:27:56 -07:00
Tony Wickham 5fd72d865e Merge "Don't allow multiple shortcuts to be dragged simultaneously." into ub-launcher3-master 2016-10-21 18:51:50 +00:00
Tony Wickham c92fe89327 Don't allow multiple shortcuts to be dragged simultaneously.
When starting a drag when another is already in progress, the
original drag view is left dangling until launcher is killed.

Bug: 32231238
Change-Id: I5ff94b82971c539231f8f588059dc84845cc88f0
2016-10-21 11:37:25 -07:00
Sunny Goyal 44ac576545 Updating the search illustrations to have transparent background
Bug: 32234314
Change-Id: If279e97acce6b7522ec587014afab8d48a2296dd
2016-10-20 11:45:59 +01:00
Sunny Goyal fcb0928256 Fixing text search where a word starting with lower case was not being matched
am: 28a64381b6

Change-Id: Ib5158d42219478c97d6bec5049e3354ee1087094
2016-10-20 09:29:57 +00:00
Tony Wickham 1da143940c Merge "Mark cells as unoccupied in onDragStart instead of startDrag." into ub-launcher3-master 2016-10-19 16:48:43 +00:00
Sunny Goyal 28a64381b6 Fixing text search where a word starting with lower case was
not being matched

Bug: 32249413
Change-Id: I0f5e24052759a734fe0df3bd3d0bf2e7ef7f2713
2016-10-19 07:54:22 +01:00
Sunny Goyal d164b7f4ab Fixing static instance of Indexer being created in the model
Indexer depends on the locale and should be created when ever the config
changes. Moving the widget indexing to the adapter (similar to allApps)
which gets created whenever the activity is recreated.
This fixes the bug where widgets indexing breaks if locale changes while launcher
process is alive
Also fixing the bug in widget model cloning where the HashMap was not cloning
the underlying ArrayList

Change-Id: I7dbe6290e73299c4c07aa7fa564077a2649e1a4c
2016-10-19 07:42:34 +01:00
Jonathan Miranda 67115b1a84 Merge "Show error toast messages when there is no room for the item when icon is not to be added to folder." into ub-launcher3-master 2016-10-18 21:49:09 +00:00
Jon Miranda 9485e5f293 Show error toast messages when there is no room for the item when icon is not to be added to folder.
* when user tries to add item to full hot seat from workspace.
* when user tries to add item to full home screen from workspace.
* refactored so that Workspace handles displaying error messages.

Bug: 15574422
Change-Id: Ibc98c7f45bc0c646dc4636660fba62be9db22ac0
2016-10-18 14:47:31 -07:00
Tony Wickham 4e47b5b0d6 Mark cells as unoccupied in onDragStart instead of startDrag.
Also move cleanup (resetting variables to null) to onDragEnd
instead of onDropCompleted. These changes are necessary because
pre-drags (for apps with shortcuts) don't call onDragStart
or onDropCompleted.

Bug: 32246571
Change-Id: Ib18fac64555e9158b776f9c12afc2cb807b3c355
2016-10-18 14:46:02 -07:00
Sunny Goyal 645760793d Merge "Alienating QSB" into ub-launcher3-master 2016-10-18 20:57:46 +00:00
Sunny Goyal d25e2f5e42 Merge "Removing unused background padding from base recycler view" into ub-launcher3-master 2016-10-18 20:44:54 +00:00
Sunny Goyal 00e106880d Removing unused background padding from base recycler view
Change-Id: I36f68a143df8f3668074b3539aa9af170a91e511
2016-10-18 21:36:29 +01:00
Sunny Goyal ed5d960ec1 Removing some bitmap drawables.
Loading the edge drawables only when legacy DND is enabled

Change-Id: I1c66d03146fb7fa7d61a4abf8c2e5a4289a117b9
2016-10-18 15:55:55 +01:00
Sunny Goyal 2e013ea7f6 Alienating QSB
> Moving all QSB widget handling code in a separate package
> QSB is handled on a separate host, independent of the main
host. This allows us to safely reset either of the two hosts
> Also removing the logic around closeSystemDialog:
   Launcher does not use any panels which need closing
   System sends an onActivityResult(RESULT_CANCELLED), we do
   not need special handling for waitingForResult
> Fixing bug when auto-generated qsb widget id was not being saved

Change-Id: I2d889b7b1c80b14785d14f35624142a4b78452de
2016-10-18 11:44:21 +01:00
Sunny Goyal d2959b9ee7 Missing call in write to parcel
am: a833b6d720

Change-Id: Ifc9dc38a0ddc6787f78fddadd2c2307d2e413c4f
2016-10-18 08:27:00 +00:00
Sunny Goyal a833b6d720 Missing call in write to parcel
Bug: 17924700
Change-Id: Ie48757fc53674979b8e92f96b5281f965e2ef3b4
2016-10-18 08:51:22 +01:00
Sunny Goyal b0bb486769 Removing the logic around closeSystemDialog on ACTION_CLOSE_SYSTEM_DIALOGS Launcher does not use any panels which need closing & system sends an onActivityResult(RESULT_CANCELLED), we do not need special handling for waitingForResult
am: f4b457709f

Change-Id: I2880167fbf37ff62ec4af88e233ab0b555453dae
2016-10-17 23:42:28 +00:00
Sunny Goyal f4b457709f Removing the logic around closeSystemDialog on ACTION_CLOSE_SYSTEM_DIALOGS
Launcher does not use any panels which need closing & system sends an
onActivityResult(RESULT_CANCELLED), we do  not need special handling for
waitingForResult

Bug: 32127718
Change-Id: Iff5161444bc909442f6acbe52cb3fb5a2d9ae4da
2016-10-18 00:17:54 +01:00
Bill Yi d51ffaec80 Import translations. DO NOT MERGE
am: 3cca5a0cae  -s ours

Change-Id: Iafd1f484aa07db9cdde2e934a8bfb3dc24e61725
2016-10-14 09:22:54 +00:00
Bill Yi 02662a1209 Import translations. DO NOT MERGE
Change-Id: I086069707cac0763e3d3704db8ba414c514b83d3
Auto-generated-cl: translation import
2016-10-13 16:57:53 -07:00
Bill Yi 3cca5a0cae Import translations. DO NOT MERGE
Change-Id: I93bb668512491ac8c026e8a75b8a50b0252965d4
Auto-generated-cl: translation import
2016-10-13 16:56:31 -07:00
Sunny Goyal b57ff9bd2f Merge "Fixing crash in folder" into ub-launcher3-master 2016-10-13 19:32:19 +00:00
Sunny Goyal f9136dac42 Fixing crash in folder
Getting the parent, before the folder is removed from DragLayer

Bug: 32141195
Change-Id: I0bd3163a1425c994280cd61197845afab3c2c185
2016-10-13 09:49:52 -07:00
Sunny Goyal 2a65020da1 Removing the section break UI support
This was an exploration for an alternative UI in all apps, where we
show section headers before every section. This was never released.

Change-Id: I2d36f1d078cc9a6f3ba6f0ec9655412182c9b016
2016-10-13 09:39:36 -07:00
Tony Wickham 7630369904 Merge "Add feature flag to disable light status bar" into ub-launcher3-calgary-polish
am: 1d29c6f7d2

Change-Id: Ic526e6ed254d7af5832afa4ce3dc47747031fec3
2016-10-13 00:53:15 +00:00
Tony Wickham 7061c9788f Add feature flag to disable light status bar
am: 0fed55bf03

Change-Id: Ia42af86a0e052bb05f0ed2ce6e8372b4408fed13
2016-10-13 00:53:13 +00:00
Tony Wickham 1d29c6f7d2 Merge "Add feature flag to disable light status bar" into ub-launcher3-calgary-polish 2016-10-13 00:41:57 +00:00
Tony Wickham 0fed55bf03 Add feature flag to disable light status bar
Bug: 32085545
Change-Id: I4860145b00893c20f7e37817e9659ccd90409966
2016-10-12 16:14:36 -07:00
Tony Wickham 33f0a768ef Merge "Use Launcher.getLauncher(Context) instead of type-casting." into ub-launcher3-calgary-polish
am: cf6195268d

Change-Id: I6b2d73ab0f3053d088f7d579330592dae637db9d
2016-10-12 21:48:32 +00:00
Tony Wickham 6982de2485 resolve merge conflicts of 2fd0208 to ub-launcher3-master
Change-Id: I20ad6eaace81786be080e28d6eb551908add6d90
2016-10-12 14:38:43 -07:00
Tony Wickham cf6195268d Merge "Use Launcher.getLauncher(Context) instead of type-casting." into ub-launcher3-calgary-polish 2016-10-12 21:22:05 +00:00
Sunny Goyal 3f0a53fa44 Making the width of the fast scroller popup as wrap_content
Adding minWidth and width=wrap_content, so that the popup can
grow for wider characters.

Change-Id: I6e0c4087df51e37f696c47f20f146f32d41e8bc8
2016-10-11 15:51:29 -07:00
Sunny Goyal f8fa9e4124 Merge "Simplifying fast scroller logic" into ub-launcher3-master 2016-10-11 22:09:48 +00:00
Sunny Goyal 9c76a9cece Announcing the final action when the drag-drop completes
am: 3f8864069b

Change-Id: Iba49c7ba1d1c2d1f4c279970bbcc3ff96af5ccc0
2016-10-11 20:12:59 +00:00
Sunny Goyal 3f8864069b Announcing the final action when the drag-drop completes
Bug:31926812
Change-Id: Id0566cc7dc15732981320807a02fb9cae8a885e6
2016-10-11 10:55:14 -07:00
TreeHugger Robot fd8eaee27f Merge "Import translations. DO NOT MERGE" into ub-launcher3-master 2016-10-11 07:22:03 +00:00