Commit Graph

78451 Commits

Author SHA1 Message Date
Android Build Coastguard Worker d75dbbcba7 Snap for 12502765 from 8915d3c3b8 to 25Q1-release
Change-Id: I4e714821abb3e9fd570e0e9d6d1fe7376d52f91b
2024-10-15 23:23:09 +00:00
Treehugger Robot 8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
Treehugger Robot 242d5b9e26 Merge "Revert "Add screenrecord for testWorkspaceSwitchToAllApps"" into main 2024-10-15 17:58:28 +00:00
Tracy Zhou ada58203ad Merge "Disallow 2-finger swipe from the corners to trigger assistant from trackpad" into main 2024-10-15 17:30:53 +00:00
Brian Isganitis dc4f56040a Merge "Migrate to FakeLauncherPrefs for Taskbar unit tests." into main 2024-10-15 17:08:35 +00:00
Jordan Silva d2867286ff Merge "Update OverviewCommandHelper to use Executors.MAIN to reduce the percentage of missed frames" into main 2024-10-15 16:52:05 +00:00
Graciela Putri 19c00bb849 Merge "Add task menu item to move task to external display" into main 2024-10-15 16:51:20 +00:00
Federico Baron 44854ed9d5 Revert "Add screenrecord for testWorkspaceSwitchToAllApps"
This reverts commit 1d12cbcd23.

Reason for revert: bug resolved

Change-Id: Ie5a15594cb3b168c5368f6bd54aab2c6a9d718ae
2024-10-15 16:11:10 +00:00
Liran Binyamin cfd3326efd Merge "Update taskbar window size for flyout" into main 2024-10-15 13:26:11 +00:00
Treehugger Robot 28dbcc7260 Merge "Optimize updating hotseat items in overflown taskbar" into main 2024-10-15 07:28:45 +00:00
Sunny Goyal 2ee9a604b6 Merge "Fixing leak in LauncherAppWidgetProviderInfo" into main 2024-10-15 02:03:27 +00:00
Sukesh Ram bd923a2b98 Merge "Fix Taskbar Y-Translation with Visible Bottom Sheet" into main 2024-10-15 01:34:41 +00:00
Andy Wickham 9605643883 Merge "Migrate Contextual Search code to AOSP" into main 2024-10-15 00:47:02 +00:00
Liran Binyamin c33fe5bd56 Update taskbar window size for flyout
This change updates the taskbar window size after the flyout view
has measured itself. This ensure that the taskbar window is tall
enough to display the entire flyout.

When the flyout is removed we reset the taskbar window size.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully and tested manually -- code is not wired up
Change-Id: I5e8618e57443212e1c4f19ab20d1542ae2d1b865
2024-10-14 19:59:59 -04:00
Sukesh Ram d82503fc42 Fix Taskbar Y-Translation with Visible Bottom Sheet
When bottom sheet is visible, such as in SUW or when app launcher pauses, the taskbar three buttons are translated upwards clashing with SUW UI.

Flag: EXEMPT bugfix
Bug: 358532768
Test: Manual
Change-Id: I0d18bda5cb7aeae894f5058df89cc413e34c00fc
2024-10-14 23:41:38 +00:00
Android Build Coastguard Worker fde2ed2777 Snap for 12496712 from 3a0583272b to 25Q1-release
Change-Id: I846e964587e0245b2f0bd570501e5deeb67007e0
2024-10-14 23:23:02 +00:00
Sunny Goyal e4ce5ebc5e Fixing leak in LauncherAppWidgetProviderInfo
Bug: 372998377
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Ibf7c66f2aba510f86d23825816639bc3197884aa
2024-10-14 16:22:52 -07:00
Sihua Ma 58fc65dedf [Dagger] Make CustomWidgetManager provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE Dagger change
Change-Id: I9c2a9cc12aa2a409e8f9053a059426843f72deed
2024-10-14 22:35:59 +00:00
Brian Isganitis a3ec98e06d Migrate to FakeLauncherPrefs for Taskbar unit tests.
Deprecates the preference rules.

Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
Change-Id: Ic3a9e589b556232d196942d687e2e2bddc000877
2024-10-14 18:13:23 -04:00
Treehugger Robot 3a0583272b Merge "Add screenrecord for testWorkspaceSwitchToAllApps" into main 2024-10-14 19:44:47 +00:00
Brian Isganitis db0da19752 Merge "Fix package name for TaskbarEduTooltipControllerTest" into main 2024-10-14 18:32:42 +00:00
Jordan Silva 7eae20bcb1 Update OverviewCommandHelper to use Executors.MAIN to reduce the percentage of missed frames
This change will reduce the increase in the amount of missed frames measured by crystalball. I believe coroutines launch is competing with Executors.MAIN for scheduling and running tasks in the main thread, thus the increase in missing frames.

Fix: 366077002
Flag: com.android.launcher3.enable_overview_command_helper_timeout
Test: OverviewCommandHelperTest
Test: android.platform.test.scenario.launcher.CloseApp3ButtonModeMicrobenchmark#testOpenLauncher
Test: atp:v2/android-crystalball-eng/health/microbench/launcher/main/launcher-action-suite
Change-Id: I4477879d4f065ec3883f2c3cb3ef044e973ce0cb
2024-10-14 17:46:14 +00:00
Sunny Goyal 0bf39fdf26 Merge "Removing unnecessary SafeClosable requirement from DaggerSingletonObject" into main 2024-10-14 17:06:13 +00:00
Sam Cackett 4676744257 Merge "Fix jank resulting from TaskView resizing" into main 2024-10-14 16:45:51 +00:00
fbaron 1d12cbcd23 Add screenrecord for testWorkspaceSwitchToAllApps
Flag: EXEMPT TEST_ONLY
Test: TaplTestsQuickstep#testWorkspaceSwitchToAllApps
Bug: 371615571
Change-Id: Ib2ce1d1b56b1710e65bad8eaa5de89949ec22c7e
2024-10-14 09:42:20 -07:00
Brian Isganitis 805cadc1e7 Fix package name for TaskbarEduTooltipControllerTest
Change-Id: I12795bb8506f44f7bb6af6176f2a647b5f099e50
Flag: TEST_ONLY
Bug: No
Test: go/testedequals
2024-10-14 16:27:19 +00:00
Graciela Wissen Putri 2f4ccc63b6 Add task menu item to move task to external display
Call SystemUiProxy.moveToExternalDisplay to move existing Overview task to desktop in external display

Bug: 372872848
Test: atest
NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest
Flag: com.android.window.flags.move_to_external_display_shortcut
Change-Id: I096a9839956ab5cab86bd0aaabc625a8587ca42a
2024-10-14 15:14:01 +00:00
samcackett 5a01f588be Fix jank resulting from TaskView resizing
Don't include taskbar height when calculating TaskView size, otherwise
this results in an unnecessary jump when the taskbar changes, either
when navigating from DesktopWindowing to Overview or pinning the
Taskbar in Overview

Bug: 343882478
Fix: 373319262
Test: unbundled/launcher/nexus_image_test_platform OverviewImageNoTransientTaskbarTest
Flag: NONE Bugfix
Change-Id: I09de0e8b4386dd9b8ccbe5330ff0c6075ef773f2
2024-10-14 11:08:02 +00:00
Tracy Zhou dbd3c09623 Disallow 2-finger swipe from the corners to trigger assistant from trackpad
Bug: 358337581
Test: manual
Flag: EXEMPT bugfix
Change-Id: I62994afe0e3edaaa990f58b44b87efa16f0580ec
2024-10-13 15:53:41 -07:00
Android Build Coastguard Worker dad3b1a4fb Snap for 12492721 from 9777937d41 to 25Q1-release
Change-Id: I5edc1338c763722dd86a4b7909b95d997cecc91c
2024-10-13 21:22:12 +00:00
Treehugger Robot 9777937d41 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-12 22:24:21 +00:00
Android Build Coastguard Worker 7d9fab6931 Snap for 12491918 from 093cf62e69 to 25Q1-release
Change-Id: I8fa332987c045621bfef604063662eaf91f361b6
2024-10-12 21:22:12 +00:00
Sunny Goyal bf9d047b53 Removing unnecessary SafeClosable requirement from DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger
Change-Id: I453159be83e92eee92f5a18cfe0d3ea9a3123f47
2024-10-12 01:26:50 -07:00
Brandon Dayauon 093cf62e69 Merge "Force config update when twoline is toggled." into main 2024-10-12 05:33:47 +00:00
Android Build Coastguard Worker dd45923b37 Snap for 12488717 from bb9300c7d5 to 25Q1-release
Change-Id: I9a22dd64ab6937f5b0da0c017a6bafa3a1fdca57
2024-10-12 01:22:56 +00:00
Treehugger Robot 1758aa68cf Merge "Simplifying some LauncherModel logic" into main 2024-10-12 01:06:27 +00:00
Toni Barzic 518ca4609c Optimize updating hotseat items in overflown taskbar
The logic for updating hotseat items in taskbar involved adding all
available recent items to the view, and then removing ones that
overflow. It also preemptively added overflow icon, and then removed it
when no overflow was detected.

This cl updates logic to stop adding recent items before they cause
overflow, and add overflow icon only when needed.

Bug: 368119679
Test: Keep opening apps until taskbar enters overflow, and verify that
expected number of app icons is displayed, and overflow icon is shown in
the correct place.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: Icaad4386b54bbfccba8ace5876d7fe5c90cb7798
2024-10-11 23:15:45 +00:00
Treehugger Robot 99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Brandon Dayauon 05105162d7 Force config update when twoline is toggled.
Based on the bug, it seems that onHandleConfigChange was not called via the perfetto trace. Here is the call order:
1) Loader Task is created
2) Loader task runs
3) Preinflation happens from setApps() in bindAllApplications() via ModelCallbacks.kt
4) When show long app names toggle happens: it eventually triggers an onHandleConfigurationChanged() which is traceable in perfetto.
5) After configChange, preinflation happens again.

In step 4) there is an early return that happens and makes it so it doesn't call the reinflation of views that happens in the mModel.rebindCallbacks().
When the force configUpdate happens upon toggle, reset the variable after it is done.

bug: 370121944
Test: presubmit/manually/perfetto in bug
Flag: NONE trying to fix edge case
Change-Id: Id0ba591bfe583b300cc241fcfc37db6dd5a85363
2024-10-11 15:43:02 -07:00
Brandon Dayauon 7e1ca3965b Merge changes from topic "fastScrollerPrivateSpaceDrawableToLetters" into main
* changes:
  Add spannedDrawable for the divider in the letter fastScroller.
  Only have private space drawable section for beginning of private space section and keep letters for everything else.
2024-10-11 22:33:53 +00:00
Treehugger Robot 73093d7218 Merge "Improve max taskbar icon count calculation" into main 2024-10-11 21:40:36 +00:00
Brian Isganitis bdc5dd5c86 Merge "Run Taskbar controller tests on VirtualDisplay." into main 2024-10-11 21:03:12 +00:00
Vinit Nayak 8071a64923 Merge "Remove unused API removeFromSideStage" into main 2024-10-11 20:53:25 +00:00
Toni Barzic 1295ffec85 Improve max taskbar icon count calculation
Updates calculation for max number of icons that can be shown in the
taskbar before hitting overflow to:
*   account for size of the three button nav, if shown
*   size of margins between icons
*   difference in all apps button and divider icon sizes (compared
    to baseline icon size)

Bug: 368119679
Test: Keep adding app icons to taskbar in desktop session until it hits
overflow with three button nav enabled, both in landscape and portrait
orientation - verify the taskbar enters overflow before icons start to
overlap with nav buttons.
With button navigation disabled, taskbar enters overflow as it starts
nearing screen edge. Transition between transient and persistent taskbar
keep consistent number of icons shown.

Flag: com.android.launcher3.taskbar_overflow
Change-Id: I66a12b390295dd50937e66a5bdf0e3e616b4a850
2024-10-11 19:50:25 +00:00
Sunny Goyal c363295cf1 Simplifying some LauncherModel logic
> Converting various if-else-if blocks to when
> Moving SessionMailureTask to its own class
> Moving install session callbacks to ModelCallbacks

Bug: 372553045
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I027b35f271b84f079fa3135b56dc15bb7375b2e0
2024-10-11 11:43:47 -07:00
Sunny Goyal 43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Randy Pfohl bb9300c7d5 Merge "Small refactor to remove unecessary inheritance" into main 2024-10-11 16:30:44 +00:00
Vinit Nayak de7cf6330d Remove unused API removeFromSideStage
Bug: 349828130
Test: Compiles
Flag: EXEMPT refactor
Change-Id: I14e18cf75a445d7ec89f6627d85ef7832ee59dae
2024-10-10 18:28:15 -07:00
Treehugger Robot 247bc0461a Merge "Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"" into main 2024-10-10 23:35:41 +00:00
Brandon Dayauon c9ac51c521 Add spannedDrawable for the divider in the letter fastScroller.
Divider exported from: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2751-194737&node-type=frame&m=dev

bug:358673724
Test photo: https://drive.google.com/file/d/1I_Mu7mjxboP3puAJuiA9X9V3ogFR0oin/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ica5f05befbd63dc93b9c50bbbd6821cd931d148b
2024-10-10 16:31:41 -07:00