Commit Graph

73483 Commits

Author SHA1 Message Date
Jeremy Sim d36d4f3f94 Fix bug where app pair icons were appearing empty
Using similar logic as other BubbleTextViews, checks for PlaceholderIconDrawables and redraws the icons if needed.

Fixes: 316041983
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I017f1d5597fd28d37ca9a8a5758f33468e46f384
2024-01-03 15:13:48 +00:00
Vinit Nayak a85fa48883 Merge "Improve null safety for app pairs" into main 2024-01-03 15:11:27 +00:00
Riddle Hsu 78611ea4ca Merge "Reduce redundant IPC when switching app by navigation bar" into main 2024-01-03 06:30:44 +00:00
Vinit Nayak d6493f4558 Improve null safety for app pairs
- Improves crash safety in AppPairIcon.java. An app pair should never have more or fewer than 2 app members, but if it happens somehow and there is an app pair on the home screen, the device will enter a crash loop that is hard to recover from. Added some safety checks so that it doesn't happen.

Fixes: 317283244
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I2cbd90f028f7c31af6e832b5515502ba992f0b54
2024-01-02 22:22:02 -08:00
Andy Wickham 6ab98924f3 Merge "Update Launcher3 TAPL "find app icon" logic to allow whitespace." into main 2024-01-03 06:05:50 +00:00
Fengjiang Li 772675ed11 Merge "Revert "Fix small gap between widget resize frame and widget background."" into main 2024-01-03 00:51:44 +00:00
Tracy Zhou 9742e603b5 Merge "Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification" into main 2024-01-03 00:12:56 +00:00
Charlie Anderson 81b6b21faf Merge "Adding extensions for backup restore test" into main 2024-01-02 23:30:55 +00:00
Fengjiang Li e81f4b8dc5 Revert "Fix small gap between widget resize frame and widget background."
This reverts commit 1e6bbf368b.

Reason for revert: b/317375712 TAPL is failing

Change-Id: Ib6b200f99c9feb7986ffca50015c02f3e558fc84
2024-01-02 23:00:03 +00:00
Tracy Zhou 5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Vadim Tryshev 756da982fc Merge "Always waiting for launcher stop from launchIntoSplitScreen()" into main 2024-01-02 21:49:09 +00:00
Charlie Anderson d6fc23f230 Adding extensions for backup restore test
Bug: 294386159
Test: presubmit
Flag: N/A
Change-Id: I4acc48c0bdd967d3c5463c85acd275a57d4a28ba
2024-01-02 16:19:32 -05:00
Fengjiang Li afbf61a150 Merge "Add assertion error message so test failure is more descriptive" into main 2024-01-02 21:18:40 +00:00
Jagrut Desai 2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Vadim Tryshev b36f70a8e3 Always waiting for launcher stop from launchIntoSplitScreen()
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I7f3c818355d43def7a29fbc1f087f2bdd150da0d
2024-01-02 12:40:04 -08:00
Vadim Tryshev fdf79d917d Merge "Waiting for NORMAL state after removing work profile" into main 2024-01-02 20:33:32 +00:00
Fengjiang Li abd3d6ddcc Merge "Revert " ALLAPPS PREINFLATION to TEAMFOOD"" into main 2024-01-02 20:00:35 +00:00
Hyunyoung Song 0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00
Fengjiang Li 937f163a4e Add assertion error message so test failure is more descriptive
Flag: NONE
Bug: 316588649
Test: unit test
Change-Id: I8be89ac00da0ffff367aad15177d50d254645195
2024-01-02 09:52:34 -08:00
Vadim Tryshev 9838b73ced Waiting for NORMAL state after removing work profile
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Iddeb41dcf702855790e847417566636613f327b4
2023-12-29 19:08:56 -08:00
Vadim Tryshev ff03dd19c7 Merge "Waiting for Launcher activity to stop when starting a Launchable into split screen" into main 2023-12-28 19:26:43 +00:00
Yunfan Chen 2c385bec7b Merge "Do not recreate taskbar due to unestimated bounds" into main 2023-12-28 11:09:16 +00:00
Bill Yi 767da4889e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 663c446926 -s ours am: 41f4b05347 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25755413

Change-Id: I1bfb0a4c8551adec19976288e44e1fa4706b61aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-27 23:43:24 +00:00
Bill Yi 41f4b05347 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 663c446926 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25755413

Change-Id: I70e667d459dc457b8009027c8a98d6ce18b3451d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-27 23:02:06 +00:00
Bill Yi f68aedbd86 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-27 22:16:51 +00:00
Saumya Prakash 664375d43a Merge "Ensure the back gesture tutorial icon renders correctly for RTL" into main 2023-12-27 21:35:13 +00:00
Bill Yi 663c446926 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I500c8f6d2dd74ab7ba3c3fde85d59eb54c75bc79
2023-12-26 17:27:58 -08:00
Bill Yi 78941bd1a9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iee5a6456177dc64115c3de5d651b7a9aca0ff36d
2023-12-26 17:27:33 -08:00
Brandon Dayauon f4d2c13752 Merge "Change all apps handle color to outLineVariant." into main 2023-12-27 01:03:56 +00:00
Uwais Ashraf 8a037e3b2e Merge "Create Launcher3RoboTests and enable Robolectric on small set of tests" into main 2023-12-22 17:27:58 +00:00
Riddle Hsu 894c17c87b Reduce redundant IPC when switching app by navigation bar
In SplitScreenController#onStartingSplitLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;

This avoids a latency from the 2-way IPC in
RecentsAnimationListener#onTasksAppeared.

Bug: 275508603
Test: Capture trace when switching app by quickstep.

Change-Id: Ia11cbca0d38cdc2bfd676dfa3d59a5c8931a2d6e
2023-12-22 20:14:31 +08:00
Tony Wickham 2ad9d442a4 Merge "Update live tile during dismiss anim even if disabled at start" into main 2023-12-21 22:58:02 +00:00
Brandon Dayauon 46884202f5 Merge "Fix padding between text and (x) icon in work profile card." into main 2023-12-21 22:25:41 +00:00
Saumya Prakash 4f0c2ec9b7 Ensure the back gesture tutorial icon renders correctly for RTL
This change adds RTL support for the back gesture icon on the main menu
of the gesture tutorial menu. In RTL mode, it was previously rendering
in the middle of the screen.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 309564541
Test: ran the tutorial in RTL mode in different form factors.
Change-Id: I24def01ed205355ced23060068ddd74af61134ab
2023-12-21 21:33:53 +00:00
Treehugger Robot 5221d39bda [automerger skipped] Merge "List baseline_filename on modules that are implititly using it" into main am: aa5a060093 am: da91e1d940 am: cd6c9acae5 -s ours
am skip reason: Merged-In Idcd6b8c8868b05a34fe621c5c05aa21cc1f149ea with SHA-1 bad33e6f85 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2886506

Change-Id: I0bb19a6380bcac466fe17c82cbdd997915bf9261
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 20:10:15 +00:00
Treehugger Robot cd6c9acae5 Merge "List baseline_filename on modules that are implititly using it" into main am: aa5a060093 am: da91e1d940
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2886506

Change-Id: I62d3de11b1003068b123a776abc5b5701fb45087
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 19:37:47 +00:00
Brandon Dayauon c800c97697 Change all apps handle color to outLineVariant.
Before the change the color was colorSurfaceVariant but should be updated to outlineVariant.

bug:275087095
Test: Manual -
Before darkTheme:https://screenshot.googleplex.com/94KykP7mjhBsKUc
After darkTheme:https://screenshot.googleplex.com/3N5XaSRonQkFuis
Before lightTheme:https://screenshot.googleplex.com/BNigdK4GWgSe2fm
After lightTheme: https://screenshot.googleplex.com/3Li5DUCDxXeACac
Flag: None

Change-Id: Ie7b077e05108d53dab869fcc1225ddae993207f2
2023-12-21 18:52:29 +00:00
Treehugger Robot da91e1d940 Merge "List baseline_filename on modules that are implititly using it" into main am: aa5a060093
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2886506

Change-Id: Ib6973650c99c5d92a3548864e56fb3a977766249
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-21 18:52:09 +00:00
Treehugger Robot aa5a060093 Merge "List baseline_filename on modules that are implititly using it" into main 2023-12-21 18:06:12 +00:00
Cole Faust 5573de9064 List baseline_filename on modules that are implititly using it
lintable modules currently pick up files named "lint-baseline.xml" to use as the
lint baseline implicitly. This is confusing because you could end up using the
baseline files in more modules than intended. Lint also has a feature where it
requests you remove unnecessary findings from the baseline file, so something
could be necessary for one module, but unnecessary for another that accidentally
picked up the baseline.

We're removing the implicit detection of the baseline file, which requires
all modules using it to list the baseline file explicitly.

Bug: 272769514
Test: Presubmits
Change-Id: Idcd6b8c8868b05a34fe621c5c05aa21cc1f149ea
Merged-In: Idcd6b8c8868b05a34fe621c5c05aa21cc1f149ea
2023-12-21 17:36:34 +00:00
Cole Faust 794e329796 Merge "List baseline_filename on modules that are implititly using it" into main 2023-12-21 17:27:11 +00:00
Liran Binyamin 0d09a45e40 Merge "Handle recreate_taskbar in QuickstepTestInformationHandler" into main 2023-12-21 15:40:03 +00:00
Uwais Ashraf 861f2fdc81 Create Launcher3RoboTests and enable Robolectric on small set of tests
Test: atest Launcher3RoboTests
Bug: 316551909
Flag: NA
Change-Id: Ib1bbaf49e3e608f8c67005c129e090711df1e99c
2023-12-21 15:06:12 +00:00
Johannes Gallmann 5714801784 Merge "Fix statusbar appearance during predictive back to home by fling" into main 2023-12-21 08:05:21 +00:00
Johannes Gallmann ccff1b84ea Merge "Fix NullPointerException in LauncherBackAnimationController" into main 2023-12-21 08:04:42 +00:00
Jeremy Sim 227d3b79f3 Merge "Ignore taskbar launch request if app(s) are already running" into main 2023-12-21 07:00:27 +00:00
Yunfan Chen f00adbeb68 Do not recreate taskbar due to unestimated bounds
The change around configuration and display cutout to support flexible
display setup is making the received display info is not calculated as
the hard-coded way in taskbar. It will cause the taskbar recreated when
the device reaches a given rotation for the first time.

The recreation is not necessary as it is only a hint of taskbar's
estimation doesn't match the result. Block the recreation in that case
to avoid user visible animation issue.

Bug: 302387383
Test: Rotate a device with movable cutout and no recreation happens
Flag: ACONFIG com.android.window.flags.allows_screen_size_decoupled_from_status_bar_and_cutout TRUNKFOOD
Flag: ACONFIG com.android.window.flags.movable_cutout_configuration DEVELOPMENT
Change-Id: I1aa6add57ec49a49cc7473bfaada6d9212c1fc4b
2023-12-21 14:35:20 +09:00
Andy Wickham 373de559c2 Update Launcher3 TAPL "find app icon" logic to allow whitespace.
Previously this used the content description which was generally the
same as the displayed text with whitespace adjustments + additional
text (e.g. "Play Store has 7 notifications").

That worked fine, but I thought it would be a bit more robust to work
with the text directly. Specifically, we consider it a match if all
of the non-whitespace characters are there, along with optional added
whitespace between characters. See TaplUtilityTests for examples.

More importantly for the other change in this topic, this Pattern is
also used for search result icons, to allow those tests to pass with
multiline labels enabled.

Bug: 315053839
Flag: LEGACY ENABLE_TWOLINE_DEVICESEARCH ENABLED
Test: Manual and TaplTestsTaskbarSearch + other unit tests

Change-Id: I4ad52840d743f06576d415f4e5ea6d8870e5dd2c
2023-12-20 19:57:11 -06:00
Fengjiang Li f63532e610 Merge "Fix small gap between widget resize frame and widget background." into main 2023-12-21 01:34:16 +00:00
Jeremy Sim 9a7b6f972b Ignore taskbar launch request if app(s) are already running
This CL fixes several issues:
- When launching an app pair on top of the exact same app pair, Overview no longer enters a broken state
- When launching another app quickly after launching an app pair, splitscreen no longer breaks

Fixes: 315190686
Test: Launch app pair and then launch same app pair again from Taskbar -- Overview does not break
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I0d474dd89359e1a10a881c5cf8deee64754219c3
2023-12-21 10:13:20 +09:00