Commit Graph

22991 Commits

Author SHA1 Message Date
Tony Wickham d2fffa6ea5 Inline TaskView#resetVisualProperties() into RecentsView
- This was only used in RecentsView#resetTaskVisuals() anyway
- Previously resetVisualProperties() just called resetViewTransforms()
  plus setFullscreenProgress(0) and setModalness(0)
- The latter 2, specificially setFullscreenProgress(0) led to problems
  such as the bug below. Instead, we should reset to the current
  mFullscreenProgress and mTaskModalness.

Bug: task view sometimes shifted up during quick switch
Steps:
- Do the quick switch gesture very quickly
- At the start of the gesture, we call getTasks(), which calls
  applyLoadPlan() asynchronously
- applyLoadPlan() calls resetTaskVisuals(), so if this happened
  after the gesture ended, we would setFullscreenProgress(0) on all
  the task views, hence the upwards shift (if the gesture was still in
  progress, it would reapply the real fullscreen progress)

Fixes: 157105795
Change-Id: Idb9d91ff89701d726838b47f955d4300f5ef13bd
2020-06-18 20:25:34 -05:00
TreeHugger Robot 946696124a Merge "Don't set mLikelyToStartNewTask=true before slop for first gesture" into ub-launcher3-rvc-dev 2020-06-15 20:24:51 +00:00
Tony Wickham f3cd3762c9 Don't set mLikelyToStartNewTask=true before slop for first gesture
We should only set it to true before the slop when continuing the
gesture, otherwise gestures to home could attach the adjacent
task view before the transition even starts.

Bug: 158855957
Change-Id: I86eba9bad9c85e05d5274d7396160762a28e5cf1
2020-06-15 14:09:14 -05:00
TreeHugger Robot 832aa03a4b Merge "[race condition] Improve hotseat availability when launcher is recreated" into ub-launcher3-rvc-dev 2020-06-15 18:16:59 +00:00
TreeHugger Robot 8555146d9a Merge "Gates blur code behind BlurUtils#supportsBlursOnWindows." into ub-launcher3-rvc-dev 2020-06-15 18:14:01 +00:00
TreeHugger Robot 72cf3d31a5 Merge "Remove a comment that a line of code is a workaround" into ub-launcher3-rvc-dev 2020-06-15 18:06:20 +00:00
vadimt f6a179d3ae Remove a comment that a line of code is a workaround
Bug: 157099707
Change-Id: I417df10735438caf6fd7fd5833817b5c43a1e856
2020-06-15 10:19:15 -07:00
Samuel Fufa 8e90ee0362 [race condition] Improve hotseat availability when launcher is recreated
In cases where onCreate does not get called before bindPredictedItems, mHotseatPredictionController will be null. This results in the hotseat remaining empty until AiAi sends predictions.

Bug: 158867468
Test: Manual
Change-Id: I4f3c3fc41f489e96a9f91dc9505202ae9ce9cce1
2020-06-14 18:30:50 -07:00
thiruram 8da127f175 Updates StatsLogManager to log LauncherAtom.ItemInfo directly.
This method is requied for logging tap on QSB with just container info.

Bug: 154717227

Change-Id: I0c61c86724b4faafe4073a578b92a654ca23727a
2020-06-14 02:02:08 +00:00
Vadim Tryshev aeacb7c850 Merge "Enable FallbackRecentsTest" into ub-launcher3-rvc-dev 2020-06-13 00:55:06 +00:00
TreeHugger Robot 48f600c51d Merge "[Overview Actions] onBackPressed for the modal state will go to overview." into ub-launcher3-rvc-dev 2020-06-13 00:52:48 +00:00
Becky Qiu e1fdf3e059 [Overview Actions] Add a decelerateInterpolator for motion of select mode.
Test: local
Bug: 157777836

Change-Id: I8cbc14c41e9046aa5993fe4add010acdd612539a
2020-06-12 17:07:42 -07:00
Becky Qiu fb40075752 [Overview Actions] onBackPressed for the modal state will go to overview.
Test: local
Bug: 157778187
Change-Id: Ie5252d39e54ca11de389dd698bfb7751fdf8f60e
2020-06-12 17:04:18 -07:00
TreeHugger Robot 690b8fb3f2 Merge "Fixing recents animation not getting completed sometimes when using 3P launcher" into ub-launcher3-rvc-dev 2020-06-12 22:35:40 +00:00
vadimt 01bb8125b0 Enable FallbackRecentsTest
With some temporary workarounds.

Bug: 143488140

Change-Id: Id1ed2d06fd3265a6aa7f98d2900733f580359944
2020-06-12 15:12:37 -07:00
Sunny Goyal 05179b6650 Fixing recents animation not getting completed sometimes when using 3P launcher
Bug: 158855992
Change-Id: I2c0cb74edfea5406e79aa99d6604183e63c1f0f1
2020-06-12 22:07:41 +00:00
TreeHugger Robot 161ed5ad9b Merge "Announce folder content size with folder title" into ub-launcher3-rvc-dev 2020-06-12 21:55:33 +00:00
Tony Wickham d2d9837b3e Merge "Skip fling anim if it is a no-op, to save a frame of aniamtion" into ub-launcher3-rvc-dev 2020-06-12 21:10:29 +00:00
Tony Wickham 5112cdd30b Skip fling anim if it is a no-op, to save a frame of aniamtion
Bug: 158701272
Change-Id: Id2bc502d1caaeefeca339d5e5ad355ad8ba6d7ec
2020-06-12 14:23:46 -05:00
TreeHugger Robot a41762f846 Merge "Adding a new attribute to speficy folder label directly in layout" into ub-launcher3-rvc-dev 2020-06-12 18:48:51 +00:00
TreeHugger Robot e3a51fec39 Merge "Fixing sysui visibility changing multiple times on startup" into ub-launcher3-rvc-dev 2020-06-12 18:45:41 +00:00
TreeHugger Robot 1eb6b2acf6 Merge "Creating correct device profile when appContext and launcher context do not match" into ub-launcher3-rvc-dev 2020-06-12 18:37:30 +00:00
Samuel Fufa 1150ab3825 Announce folder content size with folder title
Bug: 144094885
Test: Manual
Change-Id: I340f9292b62163e1d72778024f1765c7618084c2
2020-06-12 11:25:32 -07:00
Jon Miranda 7c57559930 Gates blur code behind BlurUtils#supportsBlursOnWindows.
This "fixes" the bug where wallpaper zoom does not reset to 0 when
screen turns off since we no longer require a valid surface to set the depth
when blur is disabled.

Note that the bug still exists when blur is enabled, which will need to be
fixed in a follow up CL.

Bug: 157946272
Change-Id: I43179435885c95eb2ecf406fa5c291badf5a1ed3
2020-06-12 11:03:10 -07:00
Hyunyoung Song 13c2bc7303 LAUNCHER_APP_LAUNCH_TAP should log correctly for icons inside folder
Bug: 137777105

Change-Id: I5c1552481fc1b788ba41c57bfe97f126f55e5b16
2020-06-11 23:51:17 -07:00
TreeHugger Robot 662796d18b Merge "Fix quick switching to any task that already appeared" into ub-launcher3-rvc-dev 2020-06-12 05:22:44 +00:00
TreeHugger Robot 368621a4bb Merge "ADD NPE check before shortcut key creation." into ub-launcher3-rvc-dev 2020-06-11 23:00:05 +00:00
TreeHugger Robot 4aef742314 Merge "Reduce launcher logs in bugreports" into ub-launcher3-rvc-dev 2020-06-11 22:41:39 +00:00
Samuel Fufa adbe9b6075 ADD NPE check before shortcut key creation.
Bug: 156871815
Change-Id: I88132a51f80062eaa76da5838d20c5fe93224635
2020-06-11 15:15:02 -07:00
Samuel Fufa 852145c9b5 Reduce launcher logs in bugreports
Bug: 158216867
Test: Manual
Change-Id: I068550f2c0b233d5c7a6c4685efb36b62ced5dde
2020-06-11 15:02:58 -07:00
TreeHugger Robot 8449aeaf6e Merge "Adding tooltip for Select button." into ub-launcher3-rvc-dev 2020-06-11 21:07:39 +00:00
Sreyas da727bbb98 Adding tooltip for Select button.
Change-Id: I3a09d20b6dd26e81b8a010e2d2da52c52408e845
2020-06-11 13:29:37 -07:00
Samuel Fufa 6fd62fde91 Migrate Hotseat logging to WW
Bug: 158218197
Change-Id: I77743b78593f169ffc30f91ab9963052417dac23
2020-06-11 09:27:36 -07:00
Tracy Zhou 3b18d41e2c Merge "Consider folder diff differently" into ub-launcher3-rvc-dev 2020-06-11 05:21:18 +00:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Sunny Goyal de52876a2b Fixing sysui visibility changing multiple times on startup
> During startup shelftop is updated after all-apps, causing all-apps to
set the sysuiVisibility according to it's own UI

Bug: 156422012
Change-Id: Idee06249ad45946ed0a9dc84702510ad90a305f4
2020-06-10 19:13:36 -07:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
TreeHugger Robot ca5e9cb7ef Merge "Notify SysUi on device rotation for back gesture" into ub-launcher3-rvc-dev 2020-06-10 23:14:06 +00:00
TreeHugger Robot 97c399aa9f Merge "[Overview Actions] Add actions to the task menu for in-place landscape." into ub-launcher3-rvc-dev 2020-06-10 23:08:36 +00:00
Sreyas Rangaraju 9a391afbf1 Merge "Fix Task Icon menu behavior." into ub-launcher3-rvc-dev 2020-06-10 22:47:28 +00:00
Samuel Fufa 5b2da14e72 Show discovery tip for hybrid hotseat
Doc: go/hybrid-hotseat-tips

Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.

Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
2020-06-10 15:12:55 -07:00
Becky Qiu 849622f6cb [Overview Actions] Add actions to the task menu for in-place landscape.
Test: local
Bug: 153736749
Change-Id: I9ba5a089e434e75de7d9cc29ebd303f7a1388324
2020-06-10 15:04:56 -07:00
thiruram ba0a6b61a3 Log folder open event into WW.
Bug: 158597506

Sample Log: https://paste.googleplex.com/5351626992779264

Change-Id: Ifb2f061924035abc84472a9a03d1b4212588428b
2020-06-10 15:00:19 -07:00
TreeHugger Robot c936fe1146 Merge "Add null check before updating animation progress" into ub-launcher3-rvc-dev 2020-06-10 21:51:45 +00:00
TreeHugger Robot 16823c2c03 Merge "Set qsb fade interpolator same as workspace for home <-> overview" into ub-launcher3-rvc-dev 2020-06-10 21:45:41 +00:00
TreeHugger Robot 479ff47a72 Merge "Allows Accessibility to focus on specified view in AbstractFloatingView." into ub-launcher3-rvc-dev 2020-06-10 20:58:06 +00:00
Tony Wickham 779955390c Add null check before updating animation progress
Haven't been able to reproduce it locally, but seems theoretically
possible if we get an onDrag() event right after something else
cancels the animation (which clears the animation controller).

Bug: 157900227
Change-Id: Ia134aa948e62d39f71e41dd4e6b98f3227ae0522
2020-06-10 15:36:52 -05:00
Andy Wickham bc83edbf4d Allows Accessibility to focus on specified view in AbstractFloatingView.
Here, the first item in an ArrowPopup or Folder are focused on.

Note: There's another pre-existing bug where it announces
"Home screen x of y" when the floating view appears; this
change doesn't address that.

Fixes: 147470419
Change-Id: I1dc70edc21ea7c19a5742208512738d6c4a94067
2020-06-10 12:03:43 -07:00
thiruram 18c2495b8f Adds PredictedHotseatContainer to launcher_atom.proto
Used for differentiating logs from normal hotseat and predicted hotseat.

Bug: 158218197
Change-Id: I011ff724ea0916b32f680dc24e8d6090d3df766d
2020-06-10 10:44:58 -07:00