Commit Graph

22541 Commits

Author SHA1 Message Date
Vinit Nayak d00d5e182a Merge "Use DeviceProfile to check multiWindowMode" into ub-launcher3-rvc-dev am: 482435c01b
Change-Id: I877e06a3c2a22741ff1892bb5ed347c266de15c2
2020-04-25 02:23:42 +00:00
Vinit Nayak 482435c01b Merge "Use DeviceProfile to check multiWindowMode" into ub-launcher3-rvc-dev 2020-04-25 02:11:50 +00:00
TreeHugger Robot 6da915902c Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev am: ea0c4f57be
Change-Id: Ia6a4f5b007700d3e87487dffb4b8decda3480319
2020-04-25 01:32:01 +00:00
TreeHugger Robot ea0c4f57be Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev 2020-04-25 01:14:10 +00:00
Vinit Nayak 11c6671d27 Use DeviceProfile to check multiWindowMode
Prevent extra IPC calls when checking for
multiWindowMode by using existing DeviceProfile.
This might be made irrelevant by b/142282126

Fixes: 149571513
Change-Id: Ia41cbfd56c67dd78f4d9c10bf1469d0d2a9e581d
2020-04-24 17:22:30 -07:00
TreeHugger Robot fd9155eb42 Merge "Creating default implementation for state lisnter method" into ub-launcher3-rvc-dev am: c6800e40e2
Change-Id: I1343f1730188e38fa39bb925080a045ee365f24f
2020-04-24 23:49:57 +00:00
TreeHugger Robot c6800e40e2 Merge "Creating default implementation for state lisnter method" into ub-launcher3-rvc-dev 2020-04-24 23:49:33 +00:00
TreeHugger Robot aa607f8414 Merge "Clear swipe region cache on nav mode switch" into ub-launcher3-rvc-dev am: 2450f524c6
Change-Id: Ifd365e63136d23552c069441719362603f7a7f7d
2020-04-24 23:48:44 +00:00
Vinit Nayak 9b5795a579 Hide shelf in 2-Button Landscape
Disable overview rotation in 2-Button
until we can figure out the correct
transition/animation.
TODO: b/154665738

Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.

Change-Id: Ib67906b11e24def870a39f57b5156e29db258fd7
2020-04-24 16:43:37 -07:00
TreeHugger Robot 2450f524c6 Merge "Clear swipe region cache on nav mode switch" into ub-launcher3-rvc-dev 2020-04-24 23:31:04 +00:00
Sunny Goyal aeec80ddbb Creating default implementation for state lisnter method
> The transition start is used rarely

Change-Id: I0d33f0f6372eb4ef89bfbb66968612693b7c6033
2020-04-24 15:41:29 -07:00
Vinit Nayak dcec265f0d Clear swipe region cache on nav mode switch
Fixes: 154955192, 150958400
Test: Switched from gesture nav to 3 button,
was no longer able to swipe up

Change-Id: Icc7b27eb7bd1eb5ddf25d7e7c3464a77a3a88f24
2020-04-24 15:05:17 -07:00
TreeHugger Robot 3176077614 Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev am: a29a69943a
Change-Id: I324727deb4c83401e9c1ed13d2c8b0add146ac7e
2020-04-24 20:15:50 +00:00
TreeHugger Robot a29a69943a Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev
* changes:
  Adds ripple effect for successful Back gestures in tutorial.
  Adds feedback to Home and Back tutorials.
2020-04-24 19:58:48 +00:00
Tracy Zhou 8908dc2c63 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev am: 879d3ade68
Change-Id: I0a8688f66bbe3312b22305639b62ac0c5e7e1b0c
2020-04-24 19:40:14 +00:00
Tracy Zhou 879d3ade68 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev
* changes:
  fix GridBackupTableTest in comply with grid size migration
  Turn on V2 migration algorithm feature flag
2020-04-24 19:26:44 +00:00
TreeHugger Robot b1b9f73f49 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev am: acafb3a287
Change-Id: Ifa261e649504c28b8b206b5b2cf7ab7b446bdb95
2020-04-24 19:11:18 +00:00
TreeHugger Robot acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham e992fab187 Adds ripple effect for successful Back gestures in tutorial.
Emanates from where the gesture was started.

Demo: https://drive.google.com/open?id=1oaXOSUiZP6Hi7J6W4H2NIFVVu0tQfKWm
Bug: 148542211
Change-Id: I38874b8b731864cbfdf963a5e44a59c8c3d30c51
2020-04-24 18:16:43 +00:00
Andy Wickham 64a91132c5 Adds feedback to Home and Back tutorials.
Back feedback:
 - Too far from edge of screen
 - Cancelled (reversed gesture, swiped upwards, etc.)
 - Inside nav bar region
 - Demo: https://drive.google.com/open?id=1pc_hr7i-iZmgF37CN8oijPjhOvvsJoEG

Home feedback:
 - Too far from edge of screen
 - Paused too long (Overview detected)
 - Swiped sideways instead of up
 - Demo: https://drive.google.com/open?id=1NGYAlqV2wJtM2DOJ1pZM-r8N1SYVtMos

Bug: 148542211
Test: Manual
Change-Id: I627ed7c6e9b005d35794e4ae568529b5613cbf70
2020-04-24 18:15:23 +00:00
Andy Wickham 6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Vinit Nayak 00e9da0a48 Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev am: 49d3fe598c
Change-Id: I9ead961382546616e3d1907ce587022884447c35
2020-04-24 17:58:27 +00:00
Vinit Nayak 49d3fe598c Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev 2020-04-24 17:48:01 +00:00
TreeHugger Robot 8f70fd555a Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev am: 7e0a1ac606
Change-Id: I54c35b48f16ab77ddb39f33bf74d335e007f16c4
2020-04-24 15:23:06 +00:00
TreeHugger Robot 7e0a1ac606 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev 2020-04-24 15:06:28 +00:00
Adam Cohen 683714434b Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev am: 59d305fefe
Change-Id: I4739ae2a8bbd72ff1afd7be0ffc25056a89189d3
2020-04-24 03:03:25 +00:00
Adam Cohen 59d305fefe Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev 2020-04-24 02:50:23 +00:00
Ming-Shin Lu 4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
Adam Cohen 1d13c0bf13 Cleanup reorder animations to not require layout on every frame
=> Extending on previous CL to separate multiple translation properties
   and avoiding expensive layout pass

Test: manual

Change-Id: I058da7367fb320b9f432bef9482be2966d3a7d42
2020-04-24 01:28:39 +00:00
Tracy Zhou 27b7bfa44e Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev am: f4e5a1a119
Change-Id: Idddef9cab7fe08066b670ac2edda2fa4b4c04169
2020-04-23 18:10:36 +00:00
Tracy Zhou f4e5a1a119 Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev 2020-04-23 17:47:29 +00:00
vadimt 1c2005151e Checking that there are no more than 2 live activities at any moment am: 0703464556
Change-Id: Ia2d09a1359a5af2b9688c130ffc1874f807d0bc9
2020-04-23 17:35:42 +00:00
vadimt 0703464556 Checking that there are no more than 2 live activities at any moment
This is tightening the makeshift strictmode criteria.

Starting with this moment, we will know that there is
no memory growth during tests execution, which is a big deal.

Big: 139137636

Change-Id: I5edc84524463bd1736d727496ad0fc031bb9624c
2020-04-23 16:35:09 +00:00
Pinyao Ting 26c4e23e9a fix GridBackupTableTest in comply with grid size migration
Bug: 154166808
Test: GridBackupTableTest
Change-Id: I7af35ceed7edb77ac0d9c443d7eccbcef19ae476
2020-04-23 09:18:46 -07:00
Tracy Zhou 219426f870 Turn on V2 migration algorithm feature flag
This flag is behind grid options master flag, so it won't go to all dogfood users yet.
I will turn on grid options flag after enough bug bash, hopefully at the end of this week.

Bug: 154154093
Test: N/A
Change-Id: I608af1cd3c5613f7cc33a940a145309ac90a6c00
2020-04-23 09:18:46 -07:00
TreeHugger Robot 413e570969 Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev am: d73d39b45a
Change-Id: I4d12fe2a1af697ba44e0b3c5b8516e2a11d16911
2020-04-23 03:37:22 +00:00
TreeHugger Robot d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
TreeHugger Robot 7065c49cfe Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev am: 8d5a000071
Change-Id: Ie0dd431ea42c4dc1134d11dd12de624224884e10
2020-04-23 01:41:38 +00:00
TreeHugger Robot 8d5a000071 Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev 2020-04-23 01:25:06 +00:00
Tracy Zhou ed5f3082b0 Special handling when a db for one grid option is not setup yet
- Init KEY_MIGRATION_SRC_WORKSPACE_SIZE and KEY_MIGRATION_SRC_HOTSEAT_COUNT
- Load default workspace only when default db is created, not when peeking into dbs of other grid options during grid preview / migration

Fixes: 154184711
Test: run grid preview and migration right after a cleared cache Pixel Launcher
Change-Id: I86c7072b8c4a9da76e289c55ab440071f192fc38
2020-04-22 18:13:42 -07:00
TreeHugger Robot 345dd7a13c Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev am: 1bb37acb5d
Change-Id: I64d45689b9b7be921d07ef9cfef5363610bfb5af
2020-04-23 00:22:18 +00:00
TreeHugger Robot 1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
TreeHugger Robot 183f6b2956 Merge "Stop computing scroll if handler is invalidated" into ub-launcher3-rvc-dev am: cea3ed48e5
Change-Id: I90c97b7f14cdf8f41520a7fa1154284c01598194
2020-04-22 23:50:22 +00:00
TreeHugger Robot a9eb592600 Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev am: 2309597c9a
Change-Id: If0632eefa72d771728a790df47e1ec24a4fe6c50
2020-04-22 23:50:15 +00:00
Tony Wickham 6a6301c569 Always return RecentsView to translation 0 on drag end
After reaching overview, we let the user translate RecentsView
if they continue dragging around. But when they let go, we need
to return RecentsView to translation 0 since that's no longer
part of the state machine.

Change-Id: I30b51485339a3b6c3dd52bda113b1a05b6e885fa
2020-04-22 18:42:40 -05:00
TreeHugger Robot cea3ed48e5 Merge "Stop computing scroll if handler is invalidated" into ub-launcher3-rvc-dev 2020-04-22 23:39:11 +00:00
TreeHugger Robot 2309597c9a Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev 2020-04-22 23:34:00 +00:00
Tony Wickham 22757e840c Don't allow swiping from overview to all apps in 3 button mode
Bug: 154761926
Change-Id: I155faec27f3b96e2f11aaec318d6846a893885e6
2020-04-22 23:13:48 +00:00
TreeHugger Robot 23a5c8009b Merge "Fixing recentsView getting translated in NavBarToHomeTouchController" into ub-launcher3-rvc-dev am: 3e60577fa1
Change-Id: Ib0b9ae6621726361d6143b07b9be1c895bf3eec8
2020-04-22 23:00:13 +00:00