Commit Graph

21178 Commits

Author SHA1 Message Date
Treehugger Robot 75ebd70172 Merge "Don't populate accessibility menu when split selection is active" into main 2025-01-09 12:10:28 -08:00
Ats Jenk eb15dbbe70 Merge "Use down and up event diff for bubble bar click" into main 2025-01-09 10:58:20 -08:00
Ats Jenk 65e60920b8 Use down and up event diff for bubble bar click
When determining if a touch event on bubble bar area is a click,
check the time diff between receiving ACTION_DOWN and ACTION_UP
motion events.
This matches with how the click handling is implemented in
View.java.

Bug: 385928447
Test: tap on bubble bar to expand it, long-press on bubble bar to move
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.ShowMultipleBubblesAndSwitchTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I5a4a6605adf08f21b28b017cb6edfcb7b898a762
2025-01-09 08:58:54 -08:00
Ats Jenk 0570605e10 Merge "Use bubble count for checking if bubble bar has bubbles" into main 2025-01-09 08:48:14 -08:00
samcackett 7e2b19508c Don't populate accessibility menu when split selection is active
User should only be able to select the second app to split with, not
dismiss or take any other action.

Fix: 320221290
Test: Enable Switch Access. Open some apps.
Go to Overview and select "Split".
Select the second app. Accessibility menu should not be shown.
Flag: EXEMPT bugfix

Change-Id: I9075e018261949366dec21f64249308601690dbe
2025-01-09 14:34:51 +00:00
Treehugger Robot 753229687e Merge "Don't use announceForAccessibility in RecentsView" into main 2025-01-09 05:31:57 -08:00
Gustav Sennton c06d6845e4 Merge "Override desktop tasks corner radius during recents transition" into main 2025-01-09 03:33:29 -08:00
Alex Chau cb50273ad0 Merge changes Ic571a506,I0877cff7 into main
* changes:
  Reland "Introduce `mTaskViewCount` inside the RecentsView"
  Run the given callback only inside `runOnPageScrollsInitialized`
2025-01-09 02:49:23 -08:00
Alex Chau b4183ee9ce Merge "Add test to open Desktop with fullsreen live tile" into main 2025-01-09 02:47:56 -08:00
samcackett 318e9184c8 Don't use announceForAccessibility in RecentsView
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.

Fix: 386001961
Test: Enable Talkback.
  Open some apps.
  Go to Overview and dismiss an app.
  Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix

Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
2025-01-09 01:09:51 -08:00
Treehugger Robot 61b805709c Merge "Ensure split screen cancel label doesn't wrap" into main 2025-01-08 23:31:53 -08:00
Treehugger Robot c0db036ea8 Merge "Use system configured font weight" into main 2025-01-08 20:41:18 -08:00
Ats Jenk f67cfbe6ac Use bubble count for checking if bubble bar has bubbles
hasBubbles() was checking if there is a selected bubble. If there was one, it returned true.
Update it to return true when bubble bar has bubble views.
This aligns it with the name of the method and the javadoc.

Bug: 385928447
Change-Id: If3dafb7608f71b8600dbac064b08a7f7114a361f
Test: check that bubble bar is tappable
Test: check that bubble bar is shown next to QSB on foldable
Test: check bubble bar position with 3 button nav
Flag: com.android.wm.shell.enable_bubble_bar
2025-01-08 14:27:27 -08:00
minch ef86780cda Reland "Introduce mTaskViewCount inside the RecentsView"
Manually reland ag/30692743 without the part of change inside
PagedView. The related crash has been handled by ag/31218694.

Flag: EXEMPT as relanding
Bug: 385612978
Test: Manual
Change-Id: Ic571a506bea025ff7d1f2e964300c27a935302a3
2025-01-08 18:59:05 +00:00
Alex Chau a2857a9940 Add test to open Desktop with fullsreen live tile
Fix: 388266322
Test: TaplTestsOverviewDesktop#enterDesktopViaOverviewMenu
Flag: EXEMPT test only
Change-Id: I6d581671a81289abe362c42c8d4e826da59b7c70
2025-01-08 18:09:42 +00:00
Treehugger Robot 569e032b24 Merge "Add debug logs to SpringAnimationRunner.onUpdate" into main 2025-01-08 09:40:13 -08:00
Treehugger Robot 6c45afc3d8 Merge "Migrate TopTaskTracker instance to DaggerSingletonObject" into main 2025-01-08 09:10:02 -08:00
Schneider Victor-tulias e6079bfa01 Merge "Fix test Dagger initialization deadlock in RecentsDisplayModel" into main 2025-01-08 07:16:41 -08:00
samcackett 288bdd9d56 Use system configured font weight
Fix: 379643698
Test: Enable Bold text (Settings > Accessibility > Display size and
text) and check the emoty recents view text is bold
Flag: EXEMPT bugfix

Change-Id: I8f4d2f61247b168c777b751a3b3dd12299e7011f
2025-01-08 15:05:06 +00:00
Will Osborn 68ef02ca44 Merge "Move recents dependency destruction to onDestroy from onDetachedWindow" into main 2025-01-08 06:57:23 -08:00
Alex Chau 679d6a5240 Merge "Revert "Introduce mTaskViewCount inside the RecentsView"" into main 2025-01-08 02:28:37 -08:00
samcackett bc3e644652 Migrate TopTaskTracker instance to DaggerSingletonObject
Fix: 371377451
Test: Manual
Flag: EXEMPT Dagger integration
Change-Id: I0b51fb7973a89e9d6f59d4c2c8544fdd0ccbf74e
2025-01-08 08:15:13 +00:00
Treehugger Robot 6184be660e Merge "Correctly use areDesktopTasksVisibleAndNotInOverview() in DesktopVisibilityController" into main 2025-01-07 15:08:25 -08:00
minch 59440da093 Revert "Introduce mTaskViewCount inside the RecentsView"
Manually revert ag/30692743 because of a performance
regression tracking at b/385612978 .

Flag: EXEMPT as reverting
Bug: 385612978
Test: Manual
Change-Id: Iadcdc07588755ee47b6d6d37db08291aa707ecfe
2025-01-07 22:12:01 +00:00
Sunny Goyal 56297bcd4a Merge "Removing RotationTouchHelper state management from RecentsAnimationDeviceState" into main 2025-01-07 12:47:56 -08:00
Schneider Victor-Tulias ef3e18715b Fix test Dagger initialization deadlock in RecentsDisplayModel
- Fixes a deadlock created when initializing RecentsDisplayModel
- Also fixes an IllegalStateException when initializing RecentsDisplayModel before the default display has initialized

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I5d3e000d722c311e0d5431034b68635c402c8109
2025-01-07 12:19:50 -08:00
Treehugger Robot 8173c2b5a8 Merge "Revert "Dismiss recents when device goes to sleep"" into main 2025-01-07 10:54:56 -08:00
Treehugger Robot 5b52f8ea8e Merge "Refactor getHighestVisibleTaskIndex to return TaksView and remove requiredTaskViewAt" into main 2025-01-07 10:20:51 -08:00
Will Osborn 7fecb97dfb Move recents dependency destruction to onDestroy from onDetachedWindow
With Overview running in a window, this clearing up needs to move later in the  lifecycle.

Bug: 388232647
Test: ran locally on device
Flag: EXEMPT bugfix
Change-Id: Id35c7fce390c2874b453c8b14c4eb0e7220ccd94
2025-01-07 17:51:30 +00:00
Alex Chau 0a7fc448e6 Correctly use areDesktopTasksVisibleAndNotInOverview() in DesktopVisibilityController
- The refactoring ag/30993068 mis-use areDesktopTasksVisible() instead of areDesktopTasksVisibleAndNotInOverview()
- This causes Taskbar mode to change at wrong timing

Bug: 388266322
Test: Swipe up from fullscreen app, launch desktop task
Flag: EXEMPT bugfix
Change-Id: I75a4c7497fe7e4d03a4029d678086f859c8c55b8
2025-01-07 17:45:37 +00:00
samcackett 9e1b1cd5fa Ensure split screen cancel label doesn't wrap
Fix: 379811238
Bug: 328577545
Bug: 345128488
Test: Visual inspection of instructions view in different languages/form
factors and display densities
Flag: EXEMPT bugfix

Change-Id: Iabdb76b7a02957e1918475b8a00f395f64e96301
2025-01-07 17:27:40 +00:00
Ats Jenk c2012f23d3 Merge "Add debug logging to root cause tap issues" into main 2025-01-07 09:09:48 -08:00
Schneider Victor-Tulias 7fe128f148 Add debug logs to SpringAnimationRunner.onUpdate
Flag: com.android.launcher3.enable_additional_home_animations
Bug: 387942297
Test: checked logs
Change-Id: I3627269a7132623fd315226813fbefc856a541d6
2025-01-07 11:36:07 -05:00
Alex Chau 3aca1797ee Refactor getHighestVisibleTaskIndex to return TaksView and remove requiredTaskViewAt
- Removed last usage of requiredTaskViewAt, which is a dangerous method assuming there must be a TaskView at certain index

Bug: 379942019
Test: manually on Task rebalancing after dismiss
Flag: EXEMPT refactor
Change-Id: Ib53e0f47435d6fb9f8fd42f89b045160e75b5e54
2025-01-07 16:09:11 +00:00
Schneider Victor-tulias a4c8c7fafb Merge changes Iceb7c9cf,I1e802e67 into main
* changes:
  Fix NPE in LauncherSwipeHandlerV2Test.setup
  Update recents states sent to tests by RecentsWindowManager
2025-01-07 07:46:03 -08:00
Schneider Victor-Tulias 4cf5febd2d Fix NPE in LauncherSwipeHandlerV2Test.setup
RecentsDisplayModel doesn't need to be a mock. If it is mocked, then RecentsDisplayModel.getFallbackWindowInterface also needs to be mocked.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: Iceb7c9cf6e9c3b0f3d08f85097ee3fde7e71f157
2025-01-07 10:41:25 -05:00
Schneider Victor-Tulias 878b2af8ea Update recents states sent to tests by RecentsWindowManager
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 382527932
Test: Tapl tests
Change-Id: I1e802e6787570e781d59e61cf03ce62c8a1edb47
2025-01-07 10:41:17 -05:00
Treehugger Robot 1165fb5a71 Merge "Adding ThemeManager as a centralized place for controlling icon theming" into main 2025-01-07 07:02:43 -08:00
Gustav Sennton 3bec45cdee Override desktop tasks corner radius during recents transition
Set the corner radius of desktop task surfaces to 0 during recents
transitions so that corner radius doesn't interfere with the surface
bounds and corner radius applied to the RemoteAnimationTarget leashes.

Bug: 378657004
Test: manual
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix

Change-Id: Ia653ace883cabfcd573ac138cb22affd96f7f229
2025-01-07 14:36:15 +00:00
Jordan Silva 612b124b75 Revert "Dismiss recents when device goes to sleep"
This reverts commit aed3b14abc.

Reason for revert: This fix introduced other issues, see b/386304079, b/384731940

Bug: 319365581
Bug: 386304079
Bug: 384731940
Change-Id: Ib49975208888fe54dd8bfb8dc3815f8825c8b5e8
2025-01-07 05:00:56 -08:00
Wei Sheng Shih a6ee3810c8 Merge "Reduce extra binder call for take task snapshot.(2/2)" into main 2025-01-07 03:04:35 -08:00
Vinay Joglekar 09be152da2 Merge "Add instrumentation for adding overview task to desktop window using overivew task's menu." into main 2025-01-07 00:08:15 -08:00
Sunny Goyal c369d1e4af Adding ThemeManager as a centralized place for controlling icon theming
Bug: 381897614
Flag: EXEMPT refactor
Test: atest ThemeManagerTest

Change-Id: Ib1dafdcc303f05f78cf586741c3d35243ab06e69
2025-01-06 21:53:22 -08:00
Sunny Goyal 0e3948a5fd Removing RotationTouchHelper state management from RecentsAnimationDeviceState
RotationTouchHelper is a singleton and can manage its lifecycle statically

Bug: 386288280
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I3e3105ac982ec716d5e2ee10f459d3e1cf55cd0d
2025-01-06 16:33:35 -08:00
Ats Jenk 81c278f526 Add debug logging to root cause tap issues
Adding logs to the bubble bar tap handling.

Bug: 385928447
Test: n/a, adding logs
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I192d9b348c3d705197faae654df71133b6f10ec2
2025-01-06 16:12:58 -08:00
Treehugger Robot eb453571d9 Merge "Converting DesktopVisibilityController to a singleton" into main 2025-01-06 12:05:48 -08:00
vinayjoglekar 9d31790a7b Add instrumentation for adding overview task to desktop window using overivew task's menu.
Test needed to be updated since there is null check for the view and the context here.

https://source.corp.google.com/h/googleplex-android/platform/superproject/main-al-dev/+/main-al-dev:frameworks/base/core/java/com/android/internal/jank/InteractionJankMonitor.java;l=846

Bug: 339585622
Test: DesktopSystemShortcutTest
Flag: NONE new perfetto instrumentation
Change-Id: I33b7e83f548e8364ac09ffa7ba2cac7a52bbbf77
2025-01-06 11:20:24 -08:00
Treehugger Robot 9594716850 Merge "Use Dispatchers.Main.immediate to run code quickly that runs on main." into main 2025-01-06 09:57:58 -08:00
Hyunyoung Song d783b429c0 Merge "Prevent CtS invocation in fake landscape mode" into main 2025-01-06 09:33:58 -08:00
Uwais Ashraf b1f28aa75e Use Dispatchers.Main.immediate to run code quickly that runs on main.
immediate dispatcher schedules code on main (post{...}) if the current coroutine context is not main. However, if the coroutine context is main it will run synchronously without scheduling the work.

This removes all the continuations that come from initialisation of flow collectors.

Bug: 387511656
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Checking perfetto traces shows that this reduces the number of continuations on main by ~120 for 30 apps
Change-Id: I6c5ffba893e470c25d81f044f83cf43cb80588b8
2025-01-06 16:06:26 +00:00