Commit Graph

79821 Commits

Author SHA1 Message Date
Treehugger Robot ce9ea2caef Merge "Simplifying IconShape" into main 2025-01-09 18:14:30 -08:00
Sebastián Franco a237a71a1c Merge "Making sure we don't use Launcher when null" into main 2025-01-09 15:35:02 -08:00
Sunny Goyal 1138f5fe59 Simplifying IconShape
Removing various custom shapes and replacing it with a generic shape implementation. This works with any valid svg path.

Bug: 366237794
Flag: EXEMPT refactor
Test: atest IconShapeTest
Change-Id: I4665bc657b8bffc4d4efa30cebe00341b3140c55
2025-01-09 15:04:46 -08:00
Riddle Hsu 6eda95c70c Merge "Wait for launcher state before proceeding next test step" into main 2025-01-09 13:54:54 -08:00
Treehugger Robot 49337285b7 Merge "Attempt to fix TaplUninstallRemoveTest.testUninstallFromAllApps" into main 2025-01-09 13:27:59 -08:00
Sebastian Franco cc5911a57b Making sure we don't use Launcher when null
Fix: 386230683
Test: all test that use @PortraitLandscape
Flag: TEST_ONLY
Change-Id: I40dfd0e8f42a68649e1cbb2f8e69ce617a415f68
2025-01-09 13:04:37 -08:00
Treehugger Robot 75ebd70172 Merge "Don't populate accessibility menu when split selection is active" into main 2025-01-09 12:10:28 -08:00
Ats Jenk eb15dbbe70 Merge "Use down and up event diff for bubble bar click" into main 2025-01-09 10:58:20 -08:00
Stefan Andonian 56f17cfddf Attempt to fix TaplUninstallRemoveTest.testUninstallFromAllApps
Based on the video, it seems that existing app icons cause the long press menu
to be opened when the test bot is trying to scroll to open the AllApps page.
The fix is to clear the data so there are no icons that will interrupt said scrolling.

There might be 2 issues that are affecting this test based on my research. So if it still fails, that doesn't mean this change wasn't necessary. I think there might also be an issue with the test infrastructure.

Bug: 386231522
Test: Ran a go/abdt run to verify test isn't flaky. This does have 100% reproduction though.
Flag: EXEMPT test fix
Change-Id: Id2b1cf89eda39d1d921af0da544f92604c3f8591
2025-01-09 10:30:22 -08:00
Sihua Ma e9f1c33f04 Merge "Add debug logs to folder open anim" into main 2025-01-09 09:27:08 -08:00
Ats Jenk 65e60920b8 Use down and up event diff for bubble bar click
When determining if a touch event on bubble bar area is a click,
check the time diff between receiving ACTION_DOWN and ACTION_UP
motion events.
This matches with how the click handling is implemented in
View.java.

Bug: 385928447
Test: tap on bubble bar to expand it, long-press on bubble bar to move
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.ShowMultipleBubblesAndSwitchTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I5a4a6605adf08f21b28b017cb6edfcb7b898a762
2025-01-09 08:58:54 -08:00
Ats Jenk 0570605e10 Merge "Use bubble count for checking if bubble bar has bubbles" into main 2025-01-09 08:48:14 -08:00
samcackett 7e2b19508c Don't populate accessibility menu when split selection is active
User should only be able to select the second app to split with, not
dismiss or take any other action.

Fix: 320221290
Test: Enable Switch Access. Open some apps.
Go to Overview and select "Split".
Select the second app. Accessibility menu should not be shown.
Flag: EXEMPT bugfix

Change-Id: I9075e018261949366dec21f64249308601690dbe
2025-01-09 14:34:51 +00:00
Treehugger Robot 753229687e Merge "Don't use announceForAccessibility in RecentsView" into main 2025-01-09 05:31:57 -08:00
Gustav Sennton c06d6845e4 Merge "Override desktop tasks corner radius during recents transition" into main 2025-01-09 03:33:29 -08:00
Alex Chau cb50273ad0 Merge changes Ic571a506,I0877cff7 into main
* changes:
  Reland "Introduce `mTaskViewCount` inside the RecentsView"
  Run the given callback only inside `runOnPageScrollsInitialized`
2025-01-09 02:49:23 -08:00
Alex Chau b4183ee9ce Merge "Add test to open Desktop with fullsreen live tile" into main 2025-01-09 02:47:56 -08:00
samcackett 318e9184c8 Don't use announceForAccessibility in RecentsView
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.

Fix: 386001961
Test: Enable Talkback.
  Open some apps.
  Go to Overview and dismiss an app.
  Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix

Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
2025-01-09 01:09:51 -08:00
Treehugger Robot 61b805709c Merge "Ensure split screen cancel label doesn't wrap" into main 2025-01-08 23:31:53 -08:00
Riddle Hsu a584c24493 Wait for launcher state before proceeding next test step
Otherwise if scrollToAppIcon is called immediately, it could
interrupt the state that causes the test to be unable to drag
the icon into workspace.

Fix: 388510107
Flag: TEST_ONLY
Test: atest Launcher3Tests:ThemeIconsTest#testIconWithoutTheme
Change-Id: Ied77b3f8d2f19de18d054a80643f3d13c5641ac4
2025-01-09 12:58:39 +08:00
Treehugger Robot c0db036ea8 Merge "Use system configured font weight" into main 2025-01-08 20:41:18 -08:00
Sebastián Franco 4d0f53b478 Merge "Promote ReorderAlgorithmUnitTest since it's not failing anymore" into main 2025-01-08 19:35:42 -08:00
Treehugger Robot dbbedf9e62 Merge "Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder" into main 2025-01-08 18:54:12 -08:00
Treehugger Robot b49023dc3b Merge "Move all db calls for grid migration inside a SQLiteTransaction" into main 2025-01-08 16:56:24 -08:00
Sihua Ma a5d096b922 Add debug logs to folder open anim
Bug: 383526431
Flag: EXEMPT logs only
Test: None
Change-Id: Ib18d63e7f8ab194f8fda74aa99d99c9aa27f5f19
2025-01-08 22:53:53 +00:00
Stefan Andonian 4a89d0ff9e Merge "Add ScreenRecord annotation to flaky test RequestPinItem" into main 2025-01-08 14:49:03 -08:00
Ats Jenk f67cfbe6ac Use bubble count for checking if bubble bar has bubbles
hasBubbles() was checking if there is a selected bubble. If there was one, it returned true.
Update it to return true when bubble bar has bubble views.
This aligns it with the name of the method and the javadoc.

Bug: 385928447
Change-Id: If3dafb7608f71b8600dbac064b08a7f7114a361f
Test: check that bubble bar is tappable
Test: check that bubble bar is shown next to QSB on foldable
Test: check bubble bar position with 3 button nav
Flag: com.android.wm.shell.enable_bubble_bar
2025-01-08 14:27:27 -08:00
Stefan Andonian 2c2e24f38d Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder
Bug: 383917141
Test: Passes Presubmit
Flag: EXEMPT flaky test investigation
Change-Id: Icf045821c42fdf9f8e60ae45d0d98ff2bc25e927
2025-01-08 14:17:02 -08:00
fbaron a94ecdfac0 Move all db calls for grid migration inside a SQLiteTransaction
Bug: 388564911
Flag: com.android.launcher3.one_grid_specs
Test: GridSizeMigrationTest
Change-Id: I22a373ea5b71a0713eeba37e8d09e09130eae525
2025-01-08 13:44:34 -08:00
Stefan Andonian 8295c92e8e Add ScreenRecord annotation to flaky test RequestPinItem
Bug: 386243192
Test: Test runs fine with annotation.
Flag: EXEMPT unit test bug investigation
Change-Id: I27f8dc0fb55521ed37b743a0149dbe2ac60ad7ff
2025-01-08 12:53:08 -08:00
Treehugger Robot 13cb405ff0 Merge "Remove no longer meaningful upstream: true flag." into main 2025-01-08 12:29:51 -08:00
Sebastian Franco a8e1984852 Promote ReorderAlgorithmUnitTest since it's not failing anymore
Fix: 332527963
Flag: TEST_ONLY
Test: ReorderAlgorithmUnitTest
Change-Id: I69257ff8a267f6f2e94f8d0c3c5e0c662ec5efb9
2025-01-08 12:20:13 -08:00
minch ef86780cda Reland "Introduce mTaskViewCount inside the RecentsView"
Manually reland ag/30692743 without the part of change inside
PagedView. The related crash has been handled by ag/31218694.

Flag: EXEMPT as relanding
Bug: 385612978
Test: Manual
Change-Id: Ic571a506bea025ff7d1f2e964300c27a935302a3
2025-01-08 18:59:05 +00:00
Treehugger Robot b3a6b8c33d Merge "Fixing local atest runs of Launcher tests" into main 2025-01-08 10:44:53 -08:00
minch a69673de08 Run the given callback only inside runOnPageScrollsInitialized
Let `PagedView.runOnPageScrollsInitialized` run the given callback only
instead of running all the current existing callbacks inside
`mOnPageScrollsInitializedCallbacks` once `mPageScrolls` has been
initialized.
All the existing callbacks will be run by
`PagedView.onPageScrollsInitialized` instead.
By doing this, we can avoid some unexpected crash while running
the pending callbacks in some scenarios. E.g., removeAllViews.

Flag: EXEMPT fix a regression
Bug: 385612978
Test: Manual
Change-Id: I0877cff752aabd1569dd54a9d04001687f90a5f6
2025-01-08 18:44:40 +00:00
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
Rex Hoffman 2c1c08a1ac Remove no longer meaningful upstream: true flag.
This used to direct robolectric tests to /external/robolectric rather than the older/unmaintained /external/robolectric-shadows, that has since been deleted.

Change-Id: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
Flag: TEST_ONLY
Test: CI
Bug: 386652866
2025-01-08 10:13:04 -08:00
Alex Chau a2857a9940 Add test to open Desktop with fullsreen live tile
Fix: 388266322
Test: TaplTestsOverviewDesktop#enterDesktopViaOverviewMenu
Flag: EXEMPT test only
Change-Id: I6d581671a81289abe362c42c8d4e826da59b7c70
2025-01-08 18:09:42 +00:00
Treehugger Robot 569e032b24 Merge "Add debug logs to SpringAnimationRunner.onUpdate" into main 2025-01-08 09:40:13 -08:00
George Lin a1037f63a7 Merge "Return list of one default option when shape not enabled (1/2)" into main 2025-01-08 09:13:47 -08:00
Treehugger Robot 6c45afc3d8 Merge "Migrate TopTaskTracker instance to DaggerSingletonObject" into main 2025-01-08 09:10:02 -08:00
Schneider Victor-tulias e6079bfa01 Merge "Fix test Dagger initialization deadlock in RecentsDisplayModel" into main 2025-01-08 07:16:41 -08:00
samcackett 288bdd9d56 Use system configured font weight
Fix: 379643698
Test: Enable Bold text (Settings > Accessibility > Display size and
text) and check the emoty recents view text is bold
Flag: EXEMPT bugfix

Change-Id: I8f4d2f61247b168c777b751a3b3dd12299e7011f
2025-01-08 15:05:06 +00:00
Will Osborn 68ef02ca44 Merge "Move recents dependency destruction to onDestroy from onDetachedWindow" into main 2025-01-08 06:57:23 -08:00
Alex Chau 679d6a5240 Merge "Revert "Introduce mTaskViewCount inside the RecentsView"" into main 2025-01-08 02:28:37 -08:00
samcackett bc3e644652 Migrate TopTaskTracker instance to DaggerSingletonObject
Fix: 371377451
Test: Manual
Flag: EXEMPT Dagger integration
Change-Id: I0b51fb7973a89e9d6f59d4c2c8544fdd0ccbf74e
2025-01-08 08:15:13 +00:00
Vadim Tryshev ef95aa29fa Fixing local atest runs of Launcher tests
When running tests locally on CF, installing test apk either fails or returns INSTALL_FAILED_VERIFICATION_FAILURE.

Somehow this doesn’t happen when running on ATP.

For local runs, fixing by disabling verification.

Bug: 378782502
Test: local atest; presubmit
Flag: NONE Test change
Change-Id: I31b6d14587dbfed129ae3ddeef5e86f3c60432e9
2025-01-07 19:07:01 -08:00
Treehugger Robot 2dbb255975 Merge "Maintain Talkback / Voice Access / etc. focus after moving item in Workspace." into main 2025-01-07 17:32:54 -08:00
Stefan Andonian 8a0f9b7f15 Merge "Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere." into main 2025-01-07 16:22:10 -08:00
Treehugger Robot 6184be660e Merge "Correctly use areDesktopTasksVisibleAndNotInOverview() in DesktopVisibilityController" into main 2025-01-07 15:08:25 -08:00