Note that this does not convert any widgets what were bound when
a different global search app was installed. Thus Froyo -> Froyo
upgrades without userdata wipe will see "Problem loading widget".
Workaround: Remove the search widget and add a new one.
Change-Id: I2bcd211c10bbaba66f5f3f82b6785396d957aa25
It looks like the evil hack in 14f122bf84 to make the workspace
not animate didn't completely work. The key to reproducing this bug is to make sure the
activity is destroyed and to have last gone to an app from a screen other than the center
screen, because that causes it to get reloaded from the icicle, which makes the timing
more amenable to missing the animation, because the view isn't attached yet.
Before, Launcher2 sent an intent to
com.android.settings/com.android.settings.LauncherAppWidgetBinder
to bind any converted appwidgets. That doesn't seem to work anymore,
and is not how non-converted widgets are bound. Changing to
binding the widgets directly fixes a problem where the search
widget was not bound after an upgrade from Eclair to Master.
The search widget conversion problem was introduced in
Change I85d64defe155c0cad97fafef6a3db62c6cab504a
where I got rid of the built-in search widget.
This patch may break conversion of legacy built-in
clock and photo widgets, but I believe that was already broken
because of the non-functional widget binding mechanism.
Bug: http://b/2322160
Merge commit 'bdc5a45de6708c241a414805bdec65428c9ddd88' into eclair-mr2-plus-aosp
* commit 'bdc5a45de6708c241a414805bdec65428c9ddd88':
Still trying to fix 2320348 - Launcher2 crashed: AIOOBE at com.android.launcher2.AllAppsView$RolloRS.removeApp
Merge commit '3ecbd81f99d2005172f431d2bf207b698154fe29' into eclair-mr2
* commit '3ecbd81f99d2005172f431d2bf207b698154fe29':
Still trying to fix 2320348 - Launcher2 crashed: AIOOBE at com.android.launcher2.AllAppsView$RolloRS.removeApp
Merge commit '6801766784c752609fc4a63db9038e5f64db6453'
* commit '6801766784c752609fc4a63db9038e5f64db6453':
Launcher2 - This might fix the missing app problem and the crash in removeApp.
Merge commit '15237db04c12c3bf193211a878aa69ea91e2052a' into eclair-mr2-plus-aosp
* commit '15237db04c12c3bf193211a878aa69ea91e2052a':
Launcher2 - This might fix the missing app problem and the crash in removeApp.
Merge commit '8cf34293dc2f078bf023ac77d007f5182f9b9357' into eclair-mr2
* commit '8cf34293dc2f078bf023ac77d007f5182f9b9357':
Launcher2 - This might fix the missing app problem and the crash in removeApp.
This marks the apps list as dirty by default. Usually, because of how long
it takes the loader thread to run, the apps list comes in after the surface
has been initialized. However, if the surface isn't around yet when setApps
is called, then setApps won't set mRollo.mAppsDirty because mRollo is null.
The extra null check is necessary for the normal case when mAllAppsList isn't
ready yet when the surface comes in.
Merge commit 'fd379524674a3af9d00b7df13bb2f3ed44fd4f90'
* commit 'fd379524674a3af9d00b7df13bb2f3ed44fd4f90':
fix 2315821 and 2315729 - problems caused because the apps list could become
Merge commit '41ed4478ad9782a1d68de733e4cef8fec0647ef9' into eclair-mr2-plus-aosp
* commit '41ed4478ad9782a1d68de733e4cef8fec0647ef9':
Import revised translations. DO NOT MERGE
Merge commit '616e3a0892511e14b812228e6e8d879c44082cb4' into eclair-mr2-plus-aosp
* commit '616e3a0892511e14b812228e6e8d879c44082cb4':
fix 2315821 and 2315729 - problems caused because the apps list could become
Merge commit '6799f0f9ced102e84475b5af3dbca16c0e6f2280' into eclair-mr2
* commit '6799f0f9ced102e84475b5af3dbca16c0e6f2280':
Import revised translations. DO NOT MERGE
Merge commit '8eea3914a012eec703b5c7829361bbc6e356dc66' into eclair-mr2
* commit '8eea3914a012eec703b5c7829361bbc6e356dc66':
fix 2315821 and 2315729 - problems caused because the apps list could become
Merge commit 'ca1ae49cebd6b0cc56be4e83a69d279c141533a6'
* commit 'ca1ae49cebd6b0cc56be4e83a69d279c141533a6':
Get rid of the built-in search widget in Launcher2
Merge commit '31f8c994a34dbff4573d32dcc49eec75e7bb546d'
* commit '31f8c994a34dbff4573d32dcc49eec75e7bb546d':
Fix 2305903 Scrolling trackball upwards at the top of the app menu selects app at the bottom left
Merge commit '761d6da8f68d619c7e6cb079504903904da54433'
* commit '761d6da8f68d619c7e6cb079504903904da54433':
Let the user click the dots during a scroll on Home.
Merge commit '7984c9496bcaeca23ee7fdecc4d4f1bb2467e0f2' into eclair-mr2-plus-aosp
* commit '7984c9496bcaeca23ee7fdecc4d4f1bb2467e0f2':
Get rid of the built-in search widget in Launcher2
Merge commit '5a7970b536bfee8cb486f42c0ab70f1d6ea80fe9' into eclair-mr2-plus-aosp
* commit '5a7970b536bfee8cb486f42c0ab70f1d6ea80fe9':
Fix 2305903 Scrolling trackball upwards at the top of the app menu selects app at the bottom left
Merge commit '546917a5ad2ed8fb2013982156044faa29d11fc9' into eclair-mr2-plus-aosp
* commit '546917a5ad2ed8fb2013982156044faa29d11fc9':
Fix 2306862 - Launcher2 crashed: in libs/rs. Uploading texture without a context.
Merge commit 'f8e6a80acd4e5558fdf7e0559f1043a2b183a8fa' into eclair-mr2-plus-aosp
* commit 'f8e6a80acd4e5558fdf7e0559f1043a2b183a8fa':
Let the user click the dots during a scroll on Home.
Bjorn Bringert
Romain Guy
Joe Onorato
Eric Fischer
Jason Sams
Jean-Baptiste Queru
Tom Taylor
Android (Google) Code Review