Commit Graph

21844 Commits

Author SHA1 Message Date
Matthew Ng cd5ed8b28f Merging ub-launcher3-qt-dev, build 5508646
Test: Manual

Bug:112934365 [STOP SHIP BUG] Sysui Navigation Bar Prototype Tracking Bug:114136250 Have a more spartan RecentsActivity on android go Bug:118758133 Add logging to track undo box usage Bug:119992316 Widget screen won't close when tapping back or home button Bug:128857973 With dark display and black accent device theme, App list header not visible on all apps screen. Bug:129279637 [Logging] Long press|tap on app icon from Task should be logged Bug:129497226 Remove setInteractionState from the contract Bug:129723135 Broken tests: swipe from killed launcher doesn't open overview Bug:129806241 [a11y][Qt] Remove an app icon in Home screen, the popup "Item removed" with UNDO doesn't follow the settings of Time to take action. Bug:129985827 [Fully Gestural Navigation] Delay Recents animation when swiping up Bug:130851537 Recents and notification shelf both became nonresponsive after I "palmed" the screen while it was on. Bug:131095241 Recents Go should support landscape app => landscape thumbnail transition Bug:131303610 Backedup shortcut icons are not badged Bug:131339235 Don't layout empty task views if we have the real content Bug:131364673 [Failing test] FallbackRecentsTest
Change-Id: I04018e14bd6d9ba77005e72fe20f4a3ede886abf
2019-04-26 11:59:39 -07:00
Matthew Ng 06e0d80d15 Added back code removed earlier from OverviewInterationState
Change: ag/7199900

Test: manual
Fixes: 129497226
Change-Id: Ibf0b1d4ade8ef5a2f0ceb545df505e9de419ec50
(cherry picked from commit cad531248e)
2019-04-26 18:00:12 +00:00
Hyunyoung Song a0d542b046 Merge "Night accent color Bug: 128857973" into ub-launcher3-qt-dev 2019-04-26 17:32:20 +00:00
Hyunyoung Song 572c746f74 Night accent color
Bug: 128857973

Change-Id: If81e9684143967480259a01e59694676875b0df1
2019-04-26 10:13:08 -07:00
Vadim Tryshev 8bb8e56580 Merge "Set portrait orientation for FallbackRecentsTest" into ub-launcher3-qt-dev 2019-04-26 01:11:43 +00:00
TreeHugger Robot f5ef0be08d Merge "Rotate thumbnail view based off device orientation" into ub-launcher3-qt-dev 2019-04-26 00:57:58 +00:00
vadimt dd4d390f38 Set portrait orientation for FallbackRecentsTest
Bug: 131364673
Change-Id: I77f3058e09eadc5bcbfe48c768f78883082a526d
2019-04-25 17:53:26 -07:00
TreeHugger Robot b6b7952d12 Merge "Round thumbnail corners" into ub-launcher3-qt-dev 2019-04-26 00:47:38 +00:00
Vadim Tryshev f099fb45b8 Merge "Annotating DigitalWellBeingToastTest so that it actually runs in lab :)" into ub-launcher3-qt-dev 2019-04-26 00:44:04 +00:00
Kevin a4949471be Rotate thumbnail view based off device orientation
In landscape mode, recents thumbnails should be shown horizontally, so
this CL modifies the custom view so that it resizes to display a
horizontal snapshot.

Bug: 114136250
Bug: 131095241
Test: Rotate recents, see view width change appropriately
Change-Id: Ic3d8d039535c673567d19c372da211d177691a81
2019-04-25 17:43:48 -07:00
vadimt 55fa21eb95 Annotating DigitalWellBeingToastTest so that it actually runs in lab :)
And starting a test app :)))))

Change-Id: I3b326a40651b0e4293dee26e4ef5f991cd7b7d0d
2019-04-25 17:34:23 -07:00
Kevin 90bddf0cf8 Round thumbnail corners
Round the task thumbnail corners as per the mocks by setting the bitmap
as a shader.

Bug: 114136250
Test: See rounded thumbnails on recents Go
Change-Id: I2bf8ebce34deb0d1cb6199cf8f6d5fa6ac746bb8
2019-04-25 17:27:01 -07:00
Tony Wickham 0cc53e7f6a Merge "Decouple recents view from window while swiping up" into ub-launcher3-qt-dev 2019-04-26 00:10:34 +00:00
TreeHugger Robot 529bff9a66 Merge "Remove interaction flag code replaced by QuickStepContract (1/2)" into ub-launcher3-qt-dev 2019-04-25 23:36:23 +00:00
TreeHugger Robot 3c007368a7 Merge "Cleanup unnecessary override dump method" into ub-launcher3-qt-dev 2019-04-25 23:22:04 +00:00
Hyunyoung Song 9e7d2acc22 Cleanup unnecessary override dump method
Change-Id: Ic2909a4d382362ddec9bcc2c738d13120e792fd8
2019-04-25 16:08:52 -07:00
Matthew Ng b60dce7268 Remove interaction flag code replaced by QuickStepContract (1/2)
Test: manual
Bug: 112934365
Fixes: 129497226
Change-Id: Id128eee4eaa620f0b9c461ef5adf0a16e9ea9a2c
2019-04-25 23:01:12 +00:00
Hyunyoung Song efe8475093 Merge "Add important dump logging Bug: 130851537 Bug: 119992316" into ub-launcher3-qt-dev 2019-04-25 22:33:31 +00:00
Hyunyoung Song a310a80c7b Add important dump logging
Bug: 130851537
Bug: 119992316

Change-Id: I3de7c1d910d1aecd80b47a85284565c79fe0e2cc
2019-04-25 15:14:44 -07:00
Tony Wickham 03f27013bf Log undo button click
Also fix a bug where we logged workspace swipe upon clicking undo, since
rebinding the pages causes us to reset mCurrentPage = 0 followed by
setCurrentPage(pageBoundFirst). Since the page isn't actually visibly
changing, we shouldn't log in that case.

Bug: 118758133
Change-Id: Ie87164a8c7c278680f67dee75657210bd33408a4
2019-04-25 14:22:54 -07:00
Hyunyoung Song 1e4a43ac67 Merge "Add logging for Task Icon interaction" into ub-launcher3-qt-dev 2019-04-25 20:30:43 +00:00
TreeHugger Robot db4e713c18 Merge "Don't layout empty tasks in layout anim if we have the actual content." into ub-launcher3-qt-dev 2019-04-25 20:22:08 +00:00
Kevin 1335c36c15 Don't layout empty tasks in layout anim if we have the actual content.
When we load the task content (icons, snapshots, etc), oftentimes, we
are still in the middle of the layout animation where items are fading
in from bottom to top. At this point, we start a second content-fill
animation from bottom to top that fades from empty => filled after the
first animation.  However, we can improve this so that empty views
aren't shown for a split second for some of the later laid out views.

If the first animation has not finished and we would animate a content
change from empty => filled but the view is currently still not visible,
we should just complete the content transition on the spot so that the
layout animation lays out the filled version instead.

Bug: 131339235
Test: Go to recents, observe lay out animation does not continue to lay
out the empty view first

Change-Id: I936a81e6cf8b3552cdee90c183fc841f50ec9ea8
2019-04-25 12:53:20 -07:00
Vadim Tryshev a5ed906db8 Merge "Enable testStressSwipeToOverview()" into ub-launcher3-qt-dev 2019-04-25 19:11:26 +00:00
TreeHugger Robot 4fd2dff408 Merge "Use AccessibilityManager#getRecommendedTimeoutMillis for Snackbar" into ub-launcher3-qt-dev 2019-04-25 18:58:39 +00:00
vadimt ab03a7eb19 Enable testStressSwipeToOverview()
Underlying issue has been fixed.

Bug: 129723135
Change-Id: I336de8bb38360ee83023caa17bc90a601db3b9e2
2019-04-25 11:57:41 -07:00
Hyunyoung Song fd94cd5498 Add logging for Task Icon interaction
Bug: 129279637
Change-Id: I135bad16015129b3b60bb13e86783d623e504b1b
2019-04-25 11:56:04 -07:00
Tony Wickham 5519a0f6a8 Use AccessibilityManager#getRecommendedTimeoutMillis for Snackbar
Bug: 129806241
Change-Id: I4aabc3ee33560960f3117d82f9873fce60f1278a
2019-04-25 11:47:22 -07:00
Tony Wickham 2a3c936440 Merge "Call initTransitionEndpoints in constructor" into ub-launcher3-qt-dev 2019-04-25 18:46:45 +00:00
Sunny Goyal 587421adbf Merge "Filling in content values on the worker thread" into ub-launcher3-qt-dev 2019-04-25 17:38:13 +00:00
Winson Chung d4e8bdbc62 Merging ub-launcher3-qt-dev, build 5505393
Test: Manual
Bug:111411630 Dark theme popup blends in with the normal background
Bug:113952590 [STOP SHIP BUG] WM Experiment: Slim the navigation bar
Bug:114136250 Have a more spartan RecentsActivity on android go
Bug:117106893 Enable all @Ignore-d Launcher tests
Bug:118678948 A11Y: TalkBack: After adding shortcut app icon on the homescreen, sometimes shortcuts app icons are not accessible with TalkBack.
Bug:122700646 Launcher crashed after uninstalling app
Bug:123985787 Respect dialogCornerRadius for all apps / widgets / settings / shortcut menu / dwb / task / overview (everything)
Bug:126229665 Launcher home screen should properly use Headline/ body font
Bug:126450861 Tab structure update and tips for Theme Picker
Bug:126587956 Create an app to use with Launcher testing
Bug:126596502 [touchflow] Use platform long press in launcher
Bug:126738409 Icon packs for launcher
Bug:126822309 Launcher > Overview > "No recent item" is not using theme font
Bug:127689526 [icons] hourglass_bottom and hourglass_top
Bug:127840207 [logging] quickswitch usage
Bug:128531133 Make TAPL diagnostics clearer
Bug:128649657 Define overlayable.xml for icon packs
Bug:128808922 [QT-QP1A] Click to change orientation in GCA secure mode will lead to unlock screen.
Bug:128857973 With dark display and black accent device theme, App list header not visible on all apps screen.
Bug:129145824 When predictions are disabled, the hotseat does not appear in quickstep
Bug:129146717 Do not allow overlays to change attribute format
Bug:129297464 [Gesture Nav] Exclude edges from most Launcher / Overview states.
Bug:129328259 [Regression] Suspended app icons turn full colour during open animation
Bug:129421279 FloatingIconView should be removed when user interacts with launcher
Bug:129434166 Lab-only flake: drag to workspace doesn't happen
Bug:129785904 [Gesture Nav] Verify that gestures are disabled appropriately in transient states
Bug:129955150 Launcher settings' icon is not using consistent grey
Bug:129985827 [Fully Gestural Navigation] Delay Recents animation when swiping up
Bug:130053407 [Tests broken] testLearn: settings is not present in the prediction row
Bug:130160876 Full gesture navigation with fast switcher shows part of "clear all" message
Bug:130415177 Launcher displays app as suspended when it is not if setPackagesSuspended is called multiple times
Bug:130440957 Recents Go view visibility not updating while loading UI is up
Bug:130442915 Jank observed while navigating from long press app shortcut.
Bug:130562632 DefaultLayoutProviderTest.testCustomProfileLoaded_with_folder is flaking
Bug:130580680 Recents Go does not load views right after boot
Bug:130635650 Recents Go thumbnails not updating on app => recents transition
Bug:130735711 Should fix overview shortcut in Recents Go landscape mode
Bug:130739123 Tests failure: Attempt to invoke virtual method 'int com.android.launcher3.views.BaseDragLayer.getChildCount()' on a null object reference
Bug:130740246 Recents Go crashes from ViewTreeObserver being dead
Bug:130746661 Fix NPE for getting task from loading task UI in Recents Go
Bug:130820737 Recents Go remove animation doesn't always work
Bug:130914022 Add a test for DWB toast
Bug:130917995 onConfigChanged when apps are auto installed
Bug:131095241 Recents Go should support landscape app => landscape thumbnail transition
Bug:131102753 crosshatch_svelte doesn't boot on ToT master on 4/22 because of FATAL exception in launcher3
Bug:131170582 [Flaky test] TaplTestsLauncher3.testDragShortcut
Bug:131250710 ControlType.CLEAL_ALL_BUTTON logging is gone
Bug:78240090 (Quickstep) Swiping down on the shelf while scrolling carousel
Change-Id: I4ef9beb24fab6be4fcff44b330e30d486fc01f03
2019-04-25 10:02:23 -07:00
Sunny Goyal 2e4477accb Filling in content values on the worker thread
Writing to disk hapens on the worker thread, so if we create content values on
UI thread, some values can change before it is written to disk.
This happens in case of shortcuts, where the badge is applied after the icon is queued,
but before it is written

Bug: 131303610
Change-Id: Ic35b17071d4ed3e5c5fee9f003a225e4ffdc74f3
2019-04-25 07:08:15 -07:00
TreeHugger Robot 1c9d3974b5 Merge "Re-adding clear-all button logging" into ub-launcher3-qt-dev 2019-04-25 01:50:42 +00:00
Tony Wickham 56511361ba Merge "Pass correct value to updatePaused() in setDisallowPause()" into ub-launcher3-qt-dev 2019-04-25 01:34:22 +00:00
Tony Wickham 4f24370f72 Pass correct value to updatePaused() in setDisallowPause()
Change-Id: Iabc3a3aac85bcf426ab18437e006cc95fa89fbc0
2019-04-24 18:20:23 -07:00
TreeHugger Robot c2b14d9fc8 Merge "Fix overview cmd launching wrong task in landscape" into ub-launcher3-qt-dev 2019-04-25 01:17:06 +00:00
Kevin 71d3e30fd1 Fix overview cmd launching wrong task in landscape
Previously we used the bottom most view in recents list to launch the
recent task when the user pressed the overview button. However, if
the user is in landscape and scrolls up so the bottom view is not
attached, pressing overview command will launch whatever the bottom task
is visually which is incorrect. Instead, we get the actual task from the
model to launch and only use the "view => app" animation if the view for
that task is attached. If it isn't, we use the basic animation.

Bug: 130735711
Test: Go to landscape, scroll up, hit command, launches correct task
Change-Id: Idff88054443259e917bbec1b47d78efbb1544283
2019-04-24 18:01:08 -07:00
vadimt 325a48b01a Re-adding clear-all button logging
Bug: 131250710
Change-Id: If31a84bf6db37b295fc0e2c4d8db8ed4b7baa037
2019-04-24 17:50:29 -07:00
Tony 5c13972e11 Decouple recents view from window while swiping up
Add setRecentsAttachedToWindow(boolean attached, boolean animate) with
the following conditions:

Conditions for attached
- Motion is paused and shelf is peeking
- xDisplacement > yDisplacement (to ensure seamless quick switch)
- We are continuing the previous quick switch gesture
- Gesture has ended and endTarget is RECENTS or NEW_TASK

Conditions for animate
- Recents is visible. Since the running task is invisible, this is
  true if either an adjacent TaskView is visible, or if we’re
  continuing the previous gesture

Currently the attach/detatch animation is just fading recents in/out.

Test:
- Swipe up to go home does not show the recents list at all. Instead,
  all the visuals/motion focus on the app window animating into the
  home screen.
- Recents appears when swiping and holding, to indicate that letting
  go will land in recents. The shelf also appears with haptic feedback
  in this case to reinforce this.
- The next task is immediately visible when quick switching (swiping
  left to right on the nav bar).

Bug: 129985827
Change-Id: Ib0c16f583bfd5b02d2f9f68c9688edc980a39d75
2019-04-24 17:36:42 -07:00
Tony Wickham d0d39f1769 Merge "Move logic that overrides MotionPauseDetector to callers" into ub-launcher3-qt-dev 2019-04-25 00:34:47 +00:00
TreeHugger Robot 23060080fe Merge "Hide Clear all button during quick switch" into ub-launcher3-qt-dev 2019-04-25 00:19:34 +00:00
Tony Wickham 5e58b447b0 Call initTransitionEndpoints in constructor
Before, the soonest we initTransitionEndpoints() is in
onRecentsAnimationStart(), which might be too late if launcher was
killed. (In that case, the gesture might end before we ever get
onRecentsAnimationStart(), and thus will never consider the distance
traveled great enough to trigger recents since we don't have endpoints.)

Bug: 129723135
Change-Id: I349f62244aaba8369926b14f90acd994fd40a93a
2019-04-24 17:19:07 -07:00
Tony Wickham 66d1c2fada Hide Clear all button during quick switch
- Add support for mMinScrollX to PagedView
- Add RECENTS_CLEAR_ALL_BUTTON as a state-specified visible element
- In BackgroundAppState, set Clear all invisible and bound RecentsView
  scroll to the last task

Test:
- Open an app, quick switch until reaching the end, ensure Clear all
  does not show up and an overscroll effect is performed
- Enter overview, scroll to the end and ensure Clear all shows up
- Same tests in RTL and 3rd party launcher

Bug: 130160876
Change-Id: I5fb958744d0055b83ced1f8b0d7face0e06a0cc5
2019-04-24 17:09:34 -07:00
Hyunyoung Song a6f1969981 Merge "Fix NPE / add downX,Y location for all swipes/ add extra debugging info Bug: 122700646 Bug: 127840207" into ub-launcher3-qt-dev 2019-04-24 23:34:12 +00:00
Hyunyoung Song bf44bc342f Fix NPE / add downX,Y location for all swipes/ add extra debugging info
Bug: 122700646
Bug: 127840207

Change-Id: I5862c8950565df172a933114e1fb2f9c4575593e
2019-04-24 16:16:51 -07:00
Tony bbea105be0 Move logic that overrides MotionPauseDetector to callers
There are 2 conditions that we force the MotionPauseDetector to treat
the motion as not paused:
1. If we haven't passed a small displacement (48dp before, 36dp now)
2. If we have moved mostly orthogonally

These existed soley for the OtherActivityInputConsumer case, because
1. We only need the displacement requirement to make room for the
   peeking shelf, which doesn't exist in other cases (it's already there on
   home for example)
2. We can only move orthogonally for quick switch, which again doesn't
   exist for other users of MotionPauseDetector.

So now instead of checking min displacement and orthogonal distance
inside MotionPauseDetector, we let callers setDisallowPause()
before adding positions to their MotionPauseDetector.

The only user visible change is that you no longer have to swipe up 48dp
before we allow pause to overview from home. This also paves the way to
using the same logic that determines to disallowPause to also detach
recents from the window while swiping up from an app.

Bug: 129985827
Change-Id: Ie690aa314da3260aff2209341a29638604f9501c
2019-04-24 16:10:40 -07:00
Matthew Ng 6b435c2a6a Removing left over experimental overlays and frame width (2/2)
Frame width is not used because navigation bar is always on the bottom.

Test: manual
Bug: 113952590
Change-Id: I48c29ffa4ca982a7aa20e2cced019e50580fe302
(cherry picked from commit 69a329e79e)
2019-04-24 22:32:38 +00:00
TreeHugger Robot b0c81fc031 Merge "Play haptic on Assistant gesture invoked" into ub-launcher3-qt-dev 2019-04-24 21:33:28 +00:00
Adam Cohen ad2b0a7261 Play haptic on Assistant gesture invoked
Change-Id: I32c5d406999b6086a928b0a232c955a52fe23019
2019-04-24 17:16:15 -04:00
TreeHugger Robot ab184166aa Merge "Additional Assistant gesture tuning" into ub-launcher3-qt-dev 2019-04-24 20:57:21 +00:00