Commit Graph

49925 Commits

Author SHA1 Message Date
Alex Chau bcf2060c5d Handle split select rotation am: 86ef5e924a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405843

Change-Id: Ife26f26f92bd2f0a238ea19c9e9958d655e96083
2021-12-08 11:55:07 +00:00
Alex Chau 86ef5e924a Handle split select rotation
- Update floatingTaskView, apply splitsSelectTranslation and splitPrimaryScorllOffest when rotating while in split select
- Moved getSplitSelectTranslation to RecentsView
- When in portrait, treat STAGE_POSITION_BOTTOM_OR_RIGHT as STAGE_POSITION_TOP_OR_LEFT in split translation calculation
- Apply splitsSelectTranslation for portrait grid too

Fix: 201721153
Test: manual
Change-Id: I768a3b15de4d434674058b274c368798f5852917
2021-12-08 11:35:02 +00:00
Alex Chau 9fa58b2fee Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 0bd0733ef4.

Reason for revert: b/209025715
Bug: 189807374

Change-Id: I477bacc318e84c16f124cf776ddd8446959755aa
2021-12-08 11:17:14 +00:00
Tracy Zhou 74fd7af92d Add content descriptions to task bar nav buttons
Fixes: 209608812
Test: manual
Change-Id: Iba50abfb2a3d33104b6d88574df0bc7b5daf1d3a
2021-12-08 10:44:31 +00:00
TreeHugger Robot 935501e377 [automerger skipped] Merge "[DO NOT MERGE] Remove one search flag and code from sc-v2." into sc-v2-dev am: 57b9c472dc am: 8531ede97e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407148

Change-Id: I1305cb7562d3a821674d1327454755391cc49b6b
2021-12-08 07:40:43 +00:00
Becky Qiu 872fcc197b [automerger skipped] [DO NOT MERGE] Remove one search flag and code from sc-v2. am: d0a9f1502b am: 9b2673cda4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407148

Change-Id: Idc06b29a16910ee5ee695ecbc61af60f3f6f4a5d
2021-12-08 07:40:41 +00:00
TreeHugger Robot 8531ede97e Merge "[DO NOT MERGE] Remove one search flag and code from sc-v2." into sc-v2-dev am: 57b9c472dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407148

Change-Id: I37287669f8d8b5756fcd9f240cd60a1cbef8c1db
2021-12-08 07:25:59 +00:00
Becky Qiu 9b2673cda4 [DO NOT MERGE] Remove one search flag and code from sc-v2. am: d0a9f1502b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407148

Change-Id: I20a1bfac918e53367ab1af1203e0a94de02b1893
2021-12-08 07:25:57 +00:00
TreeHugger Robot 57b9c472dc Merge "[DO NOT MERGE] Remove one search flag and code from sc-v2." into sc-v2-dev 2021-12-08 06:57:28 +00:00
Brian Isganitis 5cbe2e0dc6 [automerger skipped] Merge "Adding support for logging wallpaper container info." into sc-v2-dev am: d3ebc4c692 am: 1b5dd42e61 -s ours
am skip reason: Merged-In I6dd7ac20af7afd675d8a886d5b838263680f773e with SHA-1 111a5c5df5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16335450

Change-Id: Id52f91b0e34b22842c7cb21cd60afc510f24b51c
2021-12-08 06:30:56 +00:00
Brian Isganitis 1b5dd42e61 Merge "Adding support for logging wallpaper container info." into sc-v2-dev am: d3ebc4c692
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16335450

Change-Id: Ic26d48fe0190f8362acbd76170b649f5686a46e9
2021-12-08 06:14:10 +00:00
Vinit Nayak 0f12803061 Fix split animation for grid RTL
Fixes: 202156862
Test: Tested grid + non grid,
RTL + LTR

Change-Id: I303f60efdd9f2f2ea412e31e574d9a3b50fecf30
2021-12-07 22:13:06 -08:00
Brian Isganitis d3ebc4c692 Merge "Adding support for logging wallpaper container info." into sc-v2-dev 2021-12-08 05:48:30 +00:00
Vinit Nayak 534a53c022 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev am: 4e0d4239e4 am: 4cc39a0d4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16415376

Change-Id: I42f653fb05d46d6f23828808b4341befbee14be3
2021-12-08 04:31:31 +00:00
Vinit Nayak 4cc39a0d4c Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev am: 4e0d4239e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16415376

Change-Id: Ic42943df8cdb92f2b6b5582c908d7edef437d303
2021-12-08 04:15:36 +00:00
Vinit Nayak 4e0d4239e4 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-12-08 04:02:31 +00:00
Brian Isganitis 79efba935f Adding support for logging wallpaper container info.
Test: https://paste.googleplex.com/5350571797118976 shows logging carousel size and index of wallpaper tapped. If the wallpaper is a live wallpaper, we also log its application info.
Bug: 188222480
Change-Id: I6dd7ac20af7afd675d8a886d5b838263680f773e
Merged-In: I6dd7ac20af7afd675d8a886d5b838263680f773e
2021-12-08 00:22:59 +00:00
Brian Isganitis cb1ef031de Merge "Adding support for logging wallpaper container info." 2021-12-08 00:22:04 +00:00
Android Build Coastguard Worker 30de09f0c1 Snap for 7977275 from 992db75dae to sc-v2-release
Change-Id: I6f7b3a2eecad0b626024b1dd08ef7cd1c26d7668
2021-12-08 00:08:27 +00:00
Tony Wickham b58230d15b Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev am: 779879ce3d am: 562ca940e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405551

Change-Id: Ic703ea1b35ff2e0b8b5e1ea1a316251184fbec42
2021-12-07 21:15:32 +00:00
Tony Wickham 24675d36b7 Improve quick switch from home to taskbar
- Add LauncherState#isTaskbarAlignedWithHotseat() which defaults to !isTaskbarStashed(), but is always false for quick switch from home
- Replaced FLAG_TRANSITION_STATE_START_STASHED and FLAG_TRANSITION_STATE_COMMITTED_STASHED with FLAG_STATE_TRANSITION_RUNNING and a reference to mLauncherState. STATE_START is equivalent to TRANSITION_RUNNING changing to true, and STATE_COMMITTED is equivalent to TRANSITION_RUNNING changing to false. Then can get details from the state such as whether taskbar is stashed and icon alignment from mLauncherState

Test: quick switch from home, both with taskbar stashed in apps and not
Fixes: 194728611
Bug: 204657916
Change-Id: I6cf84ec73a4036e14cc7268667c6f62100884c27
2021-12-07 13:13:48 -08:00
Vinit Nayak 0bd0733ef4 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I529dba5d4df3d0c3366c111e70991a36bec4bfc3
2021-12-07 13:07:32 -08:00
Tony Wickham 562ca940e2 Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev am: 779879ce3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405551

Change-Id: I876064e6ca079acf04ffdf17ee38060e270852a7
2021-12-07 20:56:27 +00:00
Tony Wickham 779879ce3d Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev 2021-12-07 20:42:55 +00:00
Vinit Nayak 0d40e19c4a Animate split divider
* TODO currently it doesn't animate when
dragging a split task back down because we need
to sync that with the other task scaling
animation playback controllers.
* It also doesn't animate in when opening a
split pair from overview because I think shell
is setting it to be visible before the divider
leash even makes it to launcher

Bug: 202914644

Change-Id: I6c60cffdb63aa262d0b547f85acc604c0c8a3637
2021-12-07 11:20:30 -08:00
Alex Chau bb9681902e [automerger skipped] Use percentage scaling for overview thumbnail size am: 992db75dae -s ours am: a51230f68b -s ours
am skip reason: Merged-In Id04871464bdb3ef2d6b046977b0ffd9bd51bc230 with SHA-1 4f7952ead4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16389090

Change-Id: I02a49d8c0e10d201ad43f3641f956a1c14a73c0a
2021-12-07 16:29:46 +00:00
Alex Chau a51230f68b [automerger skipped] Use percentage scaling for overview thumbnail size am: 992db75dae -s ours
am skip reason: Merged-In Id04871464bdb3ef2d6b046977b0ffd9bd51bc230 with SHA-1 4f7952ead4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16389090

Change-Id: If737116ecabc2cfd992391846b572d8e73c3993e
2021-12-07 16:06:44 +00:00
Alex Chau 992db75dae Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
Merged-In: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 14:50:40 +00:00
Alex Chau a5470710a3 Use percentage scaling for overview thumbnail size am: 4f7952ead4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16389092

Change-Id: I18751b12e2c7fa2b376545a95426594cbadffd07
2021-12-07 14:50:04 +00:00
Alex Chau 4f7952ead4 Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 11:00:48 +00:00
Tony Wickham 9566290e13 Cleanup some taskbar/hotseat handoff issues
- Clearly distinguish Home <-> App icon alignment (ForResumedState and ForGestureState) from Home <-> Home states (ForLauncherState) by renaming onIconAlignmentRatioChanged() to onIconAlignmentRatioChangedForAppAndHomeTransition (for the former)
- Make sure initial state is properly applied by treating all flags as changed
- onIconAlignmentRatioChangedForStateTransition only runs when launcher is resumed (fixes 208648294)
- Animate taskbar background alpha when going between home and app, separate from icon alignment (bug: 204657916)
- Only copy hotseat's alpha to taskbar when hotseat is originally visible (also bug: 204657916)

Test: Open an app on small screen, open large screen and ensure taskbar stays at the bottom instead of aligning with non-present hotseat (bug: 208648294)
Test: Swipe up and down on home scren, ensure taskbar background never appears and there's no jump between taskbar and hotseat
Change-Id: Iea59965118f2bdbd8ce49279f76fb01fbd61f60b
2021-12-06 17:16:19 -08:00
Android Build Coastguard Worker 6b31c3287a Snap for 7973711 from 3d206ca917 to sc-v2-release
Change-Id: I0604767c3698a518f9e2351b5437de61929a831d
2021-12-07 00:08:53 +00:00
Tony Wickham 7af54403a3 Remove LauncherState.TASKBAR visible element
It's no longer used, so removing to cleanup code and reduce confusion

Test: no functional change
Fixes: 209512651
Change-Id: Ibd671bde7190df976b5365331731a55a9abdbb35
2021-12-06 15:59:39 -08:00
Becky Qiu d0a9f1502b [DO NOT MERGE] Remove one search flag and code from sc-v2.
Bug: 209501163
Test: manual
Change-Id: Iee1c8276a1f81aa0f54e8a342cfdd3f01d7ab1b7
2021-12-06 15:22:04 -08:00
Tony Wickham f1951ce1f7 Fix taskbar stash misalignment when going from app to overview
Keep taskbar unaligned with hotseat if we're stashing anyway

Test: Swipe up from app with taskbar present to overview, check frame by frame to ensure icons morph directly into the handle instead of above it
Fixes: 208697792
Change-Id: If3238286b3383e75eb71fbd3b97d34bb3b44340b
2021-12-06 15:15:34 -08:00
Tony Wickham 94c97fbe59 Merge "Fix taskbar jumping when going home" into sc-v2-dev am: 3d206ca917 am: a19a64e97f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374170

Change-Id: I8c7ee58d94bd0608aec7ddbff5e864782aedf4cc
2021-12-06 20:51:24 +00:00
Tony Wickham a19a64e97f Merge "Fix taskbar jumping when going home" into sc-v2-dev am: 3d206ca917
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374170

Change-Id: I8ad15ee9afd48aeb05ae1e4e89503d0e683ca5a6
2021-12-06 20:36:58 +00:00
Tony Wickham 3d206ca917 Merge "Fix taskbar jumping when going home" into sc-v2-dev 2021-12-06 20:15:20 +00:00
Jon Miranda 986a447ee2 Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev am: 52ee4ec4aa am: faedc9004c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194658

Change-Id: If3e72442f3cd3b976d688ffef366a188683247fe
2021-12-06 19:03:41 +00:00
Jon Miranda faedc9004c Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev am: 52ee4ec4aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194658

Change-Id: If13ed6d01cd440182338c18f8317f691b9d7d33e
2021-12-06 18:38:32 +00:00
Brian Isganitis 111a5c5df5 Adding support for logging wallpaper container info.
Test: https://paste.googleplex.com/5350571797118976 shows logging carousel size and index of wallpaper tapped. If the wallpaper is a live wallpaper, we also log its application info.
Bug: 188222480
Change-Id: I6dd7ac20af7afd675d8a886d5b838263680f773e
2021-12-06 18:37:07 +00:00
Jon Miranda 52ee4ec4aa Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev 2021-12-06 18:17:52 +00:00
Alex Chau 5ec74a16f0 Merge "Add back screenshot button to Launcher3" into sc-v2-dev am: 5656154f1a am: abda7bc69c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365185

Change-Id: I61b276bc55eb8486828e5ee9c19251065564d56e
2021-12-06 18:06:27 +00:00
Alex Chau abda7bc69c Merge "Add back screenshot button to Launcher3" into sc-v2-dev am: 5656154f1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365185

Change-Id: If09fd87ad2c2c1d6ca473c9260fbb91ea3f822c3
2021-12-06 17:51:21 +00:00
Alex Chau 5656154f1a Merge "Add back screenshot button to Launcher3" into sc-v2-dev 2021-12-06 17:37:42 +00:00
Schneider Victor-tulias e9bd547a54 Merge "Update taskbar edu strings for i10n." into sc-v2-dev am: 6c9dbb8db6 am: ad5f39c990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374605

Change-Id: I5a88a4c01933f42f86a656b59d8737509120ac36
2021-12-06 16:03:01 +00:00
Schneider Victor-tulias ad5f39c990 Merge "Update taskbar edu strings for i10n." into sc-v2-dev am: 6c9dbb8db6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374605

Change-Id: I1f8861ac7a692e8336ab05952b938fc00ebafc32
2021-12-06 15:47:56 +00:00
Schneider Victor-tulias 6c9dbb8db6 Merge "Update taskbar edu strings for i10n." into sc-v2-dev 2021-12-06 15:30:11 +00:00
András Klöczl 0722fb1b2a Merge "Add TAPL tests for two panel workspace" into sc-v2-dev am: f4a161eef3 am: f5ee9c87b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16357467

Change-Id: I5e29e4e23a1a49e2c6ba9322a700d675040e5ca6
2021-12-06 14:46:54 +00:00
András Klöczl f5ee9c87b8 Merge "Add TAPL tests for two panel workspace" into sc-v2-dev am: f4a161eef3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16357467

Change-Id: Icc7a700ad85315c95a3ff542d63a2c7ba888bf96
2021-12-06 14:29:15 +00:00