Commit Graph

49925 Commits

Author SHA1 Message Date
Tony Wickham 36e5f812d5 Merge "Don't clobber in progress page transition in applyLoadPlan()" into sc-v2-dev 2021-12-14 16:18:39 +00:00
Ling Wo 06119c9c6a Merge "delete appIcon from workspace via TAPL" into sc-v2-dev am: 361d8286cc am: 7f389d6317
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16189765

Change-Id: I4d2d76c92933e45dab99566e460c4f59804f59e7
2021-12-14 02:55:17 +00:00
Ling Wo 7f389d6317 Merge "delete appIcon from workspace via TAPL" into sc-v2-dev am: 361d8286cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16189765

Change-Id: Ia004c65470959ef3e7dcc3799bcda9de6b15725e
2021-12-14 02:34:50 +00:00
Ling Wo 361d8286cc Merge "delete appIcon from workspace via TAPL" into sc-v2-dev 2021-12-14 02:10:59 +00:00
Tony Wickham db34fba43f Don't clobber in progress page transition in applyLoadPlan()
Also only reloadIfNeeded() instead of always reloading in showCurrentTask(), which is called twice as the gesture starts and could contribute to jank.

Test: quickly quick switch from app A to B, ensure no jumpcut back to A
Bug: 205499708
Change-Id: I516020551d3f76eb4025df848bf4c88adf5499b7
2021-12-14 00:25:08 +00:00
Sebastian Franco 3a50ab4af1 Adding ripple effect to the "All Apps tab" buttons.
Test: Manually tested
Fix: 192252147
Change-Id: I38d37b581b998dc05f087533cff3968ebe0cb00d
2021-12-13 14:18:32 -06:00
TreeHugger Robot 61da68ed8c Merge "Set default value for rank field in launcher logs to ItemInfo.rank." into sc-v2-dev am: ed6cbbc9a6 am: 67daf300e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16360368

Change-Id: I9deab9ebbb33ac8ed8f6708120416679cb0f2647
2021-12-13 19:39:44 +00:00
TreeHugger Robot 67daf300e2 Merge "Set default value for rank field in launcher logs to ItemInfo.rank." into sc-v2-dev am: ed6cbbc9a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16360368

Change-Id: Ic15c841f299bd8d14d3c7c4352ad9d76fdecaa04
2021-12-13 19:07:36 +00:00
TreeHugger Robot ed6cbbc9a6 Merge "Set default value for rank field in launcher logs to ItemInfo.rank." into sc-v2-dev 2021-12-13 18:48:09 +00:00
Sunny Goyal 761327b103 Fixing drawable cloning does not preserve badge
Bug: 209503720
Test: Manual
Change-Id: I77606c7067cad6d1faea3c57affd6dde317d06ac
2021-12-13 20:03:39 +05:30
TreeHugger Robot 46643ab66d Merge "Add cheap aidl tracing suitable for always-on-tracing (3/3)" 2021-12-13 13:55:32 +00:00
TreeHugger Robot 1e9e5f64fc Merge "Add setSuggestOnChrome method to OneSearch interface" 2021-12-13 10:02:45 +00:00
Shawn Lin 39ada8ad58 Merge "Notify system to report the rounded corners that task bar draws" 2021-12-13 08:26:01 +00:00
shawnlin beae64cd95 Notify system to report the rounded corners that task bar draws
Task bar draws fake rouned corner above itself and it should notify
system to report that fake ones to apps.

Bug: 196387239
Test: make

Change-Id: I1d9732de71fbe653ed56e468e211b1bfb4dd2b37
2021-12-13 13:33:59 +08:00
Winson Chung 1d85bd4130 Merge "Account for early display rotation for gestures with shell transitions" 2021-12-13 05:29:09 +00:00
TreeHugger Robot 9f8f98dae2 Merge "Tune taskbar handle height" 2021-12-12 12:37:50 +00:00
Siarhei Vishniakou 81ff81227e Add ALLOW_SLIPPERY_TOUCHES to make StatusBarTouchController slippery
LauncherActivity uses FLAG_SLIPPERY for certain interactions. For
example, when home screen is shown, and the user pulls down from not the
top of the screen, and notification shade is getting displayed, then the
touch should be getting transferred to the NotificationShade using
FLAG_SLIPPERY.

The newly introduced permission is added to launcher in order for this
flag to be applied to the window.

Bug: 206188649
Bug: 157929241
Test: reviewed logs, ensure that NexusLauncherActivity has FLAG_SLIPPERY
Test: re-ran the performance regression test
Change-Id: I8d05fa3663687b5382a59b0d47cdac404844c3b7
2021-12-12 06:22:08 +00:00
Android Build Coastguard Worker bfc565b923 Snap for 7992035 from be0360c6d8 to sc-v2-release
Change-Id: Ifaf25cf921b3cc752130f0a12e7558651bf6092f
2021-12-11 22:08:00 +00:00
Ling WO 85336c23fb delete appIcon from workspace via TAPL
1. Create a new class for DropBar icon.
2. Implement function to delete appIcon from workspace.
3. Add testDeleteFromWorkspace to TaplTestsLauncher3.

Bug: 205593009
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDeleteFromWorkspace

Change-Id: I259b909aebcdcc1c73af63a9970db43dab3e86eb
2021-12-10 18:14:41 -08:00
TreeHugger Robot 434d537725 Merge "Report contentInsets only based on what they will be inside apps" into sc-v2-dev am: be0360c6d8 am: 86be069897
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16442237

Change-Id: I848ee10d672d713b326fafbe2fdf789ababe1dd2
2021-12-11 02:09:07 +00:00
TreeHugger Robot 5c7a0ae1c9 Merge "DeviceProfile.overviewRowSpacing should exclude extra top margin on grid tasks" into sc-v2-dev am: 953873dd18 am: a370c8880f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440097

Change-Id: I5ce9a676cd30790b89a5a63ffbbc390c602f7f7e
2021-12-11 02:08:36 +00:00
Android Build Coastguard Worker 4010693afb Snap for 7989966 from 7ac2a71b94 to sc-v2-release
Change-Id: I80a39d1cc91bb982faa6e46063dcca57108ada2d
2021-12-11 02:07:38 +00:00
TreeHugger Robot 86be069897 Merge "Report contentInsets only based on what they will be inside apps" into sc-v2-dev am: be0360c6d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16442237

Change-Id: I3f2382b320e7e13673e9a156e0250133e15d2d7d
2021-12-11 01:51:46 +00:00
TreeHugger Robot a370c8880f Merge "DeviceProfile.overviewRowSpacing should exclude extra top margin on grid tasks" into sc-v2-dev am: 953873dd18
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440097

Change-Id: Ifa60729ab1b7cf9031dc03698684879a202ff1f4
2021-12-11 01:51:08 +00:00
TreeHugger Robot be0360c6d8 Merge "Report contentInsets only based on what they will be inside apps" into sc-v2-dev 2021-12-11 01:30:26 +00:00
TreeHugger Robot 953873dd18 Merge "DeviceProfile.overviewRowSpacing should exclude extra top margin on grid tasks" into sc-v2-dev 2021-12-11 01:12:57 +00:00
Shuming Hao 22fbc854ea Toggle notification panel when new buttons are clicked in taskbar
This CL adds toggle notification panel function for new buttons in Kingyo taskbar.

Bug: 199333223
Test: m, verify that clicking the new buttons will expand/collapse quick settings and notification panel

Recall: http://recall/clips/993bc14b-98a7-4d7d-98c4-17ba271d4da9
Change-Id: I8c7383d2efa6f15de10a50173cfff86ab20ebb4c
2021-12-10 16:52:47 -08:00
TreeHugger Robot 890bfc8914 Merge "Allow restore across form factors" into sc-v2-dev am: 5599b02141 am: 7f4adf679e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440220

Change-Id: Ic4b2b4cb76e646ed750b5a9bccbf14b07310f59a
2021-12-11 00:50:38 +00:00
TreeHugger Robot 7f4adf679e Merge "Allow restore across form factors" into sc-v2-dev am: 5599b02141
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440220

Change-Id: I46024c6edf3539fa495ed491c679d1cdce8b5dd0
2021-12-11 00:36:04 +00:00
Daichi Hirono db5960de5e Add new buttons to taskbar
Cherry picked from commit 53db50dd0b2bd6ed1842b25396c9c52b7abe1157
after resolving conflicts

The CL adds two new buttons for desktop usage.
No listeners are registered yet.

Recall: http://recall/clips/f52b70ed-c437-4374-a492-e4b7c802520a

Bug: 198355239
Test: m, verify that new buttons are added

Change-Id: I1d4a12da3041e113a978c37c9e36ec085d15e8b3
2021-12-10 16:24:24 -08:00
TreeHugger Robot 5599b02141 Merge "Allow restore across form factors" into sc-v2-dev 2021-12-11 00:11:56 +00:00
Jon Miranda f9d4932707 Merge "Display in-memory icon for app close while AdaptiveIcon loads." into sc-v2-dev am: b788f9f7f7 am: 2539cd207e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16441110

Change-Id: I759f7a0194d730af565dd140d057dff618701630
2021-12-10 23:55:41 +00:00
Tony Wickham c7b8957bbb Report contentInsets only based on what they will be inside apps
This avoids changing them when going from an app to launcher (most obvious when going to overview).

This also allows us to not change insets on apps when opening/closing IME, which reduces potential jumpiness.

Finally, also use this logic for 3P launchers by calling directly from TaskbarDragLayerController instead of TaskbarUIController (which was only overridden by LauncherTaskbarUIController). This fixes some bad issues like sending fullscreen insets when opening a folder from taskbar.

Test: Open Calculator, unstash taskbar, go to overview and ensure no jump as taskbar stashes.
Fixes: 200805319
Change-Id: I4f1cc187398d0051863ff44ea90b7ab9c6aaa8f9
2021-12-10 23:47:18 +00:00
Jon Miranda 2539cd207e Merge "Display in-memory icon for app close while AdaptiveIcon loads." into sc-v2-dev am: b788f9f7f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16441110

Change-Id: I21e8ad9e5df8dacba63601911f08782d8c935b0d
2021-12-10 23:38:56 +00:00
Alex Chau 4c98374d99 DeviceProfile.overviewRowSpacing should exclude extra top margin on grid tasks
Bug: 207350366
Bug: 210158657
Test: manual
Change-Id: I28116407c4267259a75fd39637104cea9db73fe3
2021-12-10 23:29:08 +00:00
Jon Miranda b788f9f7f7 Merge "Display in-memory icon for app close while AdaptiveIcon loads." into sc-v2-dev 2021-12-10 23:20:42 +00:00
Tony Wickham a38bcacf05 Merge "Fix taskbar being empty" into sc-v2-dev am: 0e0e1cef09 am: 8dedf2f6bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16439570

Change-Id: I103a05b42d340653aec6d1328402037fcf7db783
2021-12-10 22:44:40 +00:00
Tony Wickham 8dedf2f6bc Merge "Fix taskbar being empty" into sc-v2-dev am: 0e0e1cef09
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16439570

Change-Id: I35766ede95fe4e73c883f7a187a23ba109ccb811
2021-12-10 22:30:02 +00:00
Tony Wickham 0e0e1cef09 Merge "Fix taskbar being empty" into sc-v2-dev 2021-12-10 22:11:17 +00:00
Alex Chau ab26c62c4a Allow restore across form factors
- Removed deviceTypeCompatible check and allow restore across for mfactors
- In AOSP default device_profile, mark 3x3, 4x4, and 5x5 as phone only. On tablets they'll reflow to 6x5.

Bug: 198575341
Bug: 210129187
Test: Only 3x3, 4x4 and 5x5 are enabled on phone
Test: Only 6x5 is enabled on tablet
Test: Phone backup of 4x4 get restored and reflow to 6x5 on tablet
Change-Id: I36a641d47fcee86ace0fea3d9194d61d12517f13
2021-12-10 22:00:49 +00:00
Jon Miranda 0c2f0faef1 Display in-memory icon for app close while AdaptiveIcon loads.
- We already display the BubbleTextView icon during app close
  since we need the shadows to ensure a clean handoff.
- Previously, we waited until the icon and the AdaptiveIcon were
  both loaded to show the FloatingIconView.
- This change immediately shows the BubbleTextView icon so that
  we can have something displayed in the cases where AdaptiveIcon
  is slow to load (ie. immediately after killing/restarting launcher).

Currently there are cases where we defer some BubbleTextView drawing to
ClipIconView. We can refactor in master so that ClipIconView is only used
when drawable is an AdaptiveIcon.

Bug: 207389002
Test: manual
Change-Id: Ie54642fef4258862a155ab0aba6e49cea9c9ead0
2021-12-10 13:25:39 -08:00
Jon Miranda 5902269fed Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev am: 7ac2a71b94 am: 48d82e2c19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16425110

Change-Id: I8e7d3a99a70a50352ed51674a7aa9e0c4f970cea
2021-12-10 19:11:28 +00:00
Jon Miranda 48d82e2c19 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev am: 7ac2a71b94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16425110

Change-Id: I60f6a9e8ae87bb011f9e7f4a7b11748415f044c1
2021-12-10 18:48:18 +00:00
Jon Miranda 7ac2a71b94 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev 2021-12-10 18:36:15 +00:00
Alex Chau 58f1b7f77e Don't snap to focused task in split select am: 9ef8e2dcee am: abc325df91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440098

Change-Id: I6ddd47521b21868e7c70d724aedcb42f791d9b32
2021-12-10 18:24:47 +00:00
Tony Wickham 0606773905 Fix taskbar being empty
We set mIconAlignmentForResumedState in endGestureStateOverride(), but then we call applyState() which might aniamte mIAFRS to a different value. To avoid this, set it after applyState() instead.

Specific repro:
1. Open Calculator
2. Go to Overview
3. Dismiss Calculator
  3a. This calls endGestureStateOverride() because the running tile ends
  3b. Previously, we called mIAFRS.updateValue(1) but then applyState() animated it to 0 because we're still in Overview which is an unstashed state. Now the animation to 0 is before setting explicitly to 1.
4. Go home (this sets mIconAlignmentForLauncherState = 1)
5. Open Calculator again. Previously, mIAFRS was already 0 so animating to 0 was ignored. Now, mIAFRS starts at 1 (which is right since launcher is resumed).

Test: see above
Fixes: 210109500
Change-Id: I13f40908f8636291d63ef4b885ac9d08bbf4d393
2021-12-10 18:20:13 +00:00
Alex Chau abc325df91 Don't snap to focused task in split select am: 9ef8e2dcee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440098

Change-Id: I7b4df5edd72b9f351629ba216cdf506ea8c8f8f9
2021-12-10 18:07:47 +00:00
Alex Chau 9fee3fd379 Allow column size of search container to be configured
- Added numSearchContainerColumns in grid-option to control search container's width, defaults to numColumns if not specified

Bug: 210127246
Test: manual
Change-Id: I0c2594f0eeab8844dcff9468e603282a09fae0bd
2021-12-10 17:55:51 +00:00
Alex Chau 1ced59acb4 Allow snapping to focused task in overview grid am: b6ad9dfaf5 am: 17a0eec015
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16378986

Change-Id: Id925b44f6a324e821150efe1b3e1cc001497c69e
2021-12-10 15:28:44 +00:00
Alex Chau 9ef8e2dcee Don't snap to focused task in split select
- In split select there is no overview actions, and focused task's snappign position is not centered, it's weird to snap so avoid it
- Follow-up of ag/16378986

Bug: 208644826
Test: manual
Change-Id: I260b5c6164db562717346396b1830af02d408944
2021-12-10 15:27:17 +00:00