Commit Graph

38594 Commits

Author SHA1 Message Date
Tony Wickham cc6b8488bf Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev am: b4aefc1277
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16325264

Change-Id: Ic361bc9236c9df493cc56d7a69a5e9a629b6f05c
2021-11-24 18:17:40 +00:00
Tony Wickham b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Alex Chau c28e01c0a6 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev am: 226bd5b973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330423

Change-Id: I4a768643dcb6f024058c8ff501aa771cad3a80e9
2021-11-24 10:37:34 +00:00
András Klöczl 2d1cfb899b Merge "Migrate workspace item adding tests to kotlin" into sc-v2-dev am: 283798dbd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16321893

Change-Id: I1fd1ed39633fdc4c48a8d4a6c0b568faa8a39e09
2021-11-24 10:37:26 +00:00
Alex Chau 226bd5b973 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev 2021-11-24 10:32:46 +00:00
András Klöczl 283798dbd5 Merge "Migrate workspace item adding tests to kotlin" into sc-v2-dev 2021-11-24 10:21:39 +00:00
Tony Wickham 821e37b447 Stash taskbar when IME is present, including during gestures
- SysUI removes SYSUI_STATE_IME_SHOWING when starting a gesture from an app, but because unstashing has implications on the gesture transition (e.g. clips the bottom of the app), we defer handling the ime hiding until the gesture settles. Repurposed the flow that swaps the taskbar background during the gesture to support this case as well.
- Delay the unstash when IME is closing, to align with the end of the IME exit transition
- Remove TaskbarViewController.ALPHA_INDEX_IME now that we stash when IME is opening, since stashing already hides the taskbar icons
- Also support passing a starting progress to the stashed handle reveal animation, to allow it to be reversed when cancelled. For example, when returning to an app that has IME showing, we first start unstashing because we're in an app, but then we get the signal that IME is attached so we stash again almost immediately (within a frame or two).

Test: In both 3 button and fully gestural, open a keyboard in an app, ensure taskbar gets out of the way and then reappears at the end when the keyboard is dismissed
Bug: 202511986
Change-Id: I93c298a98ba369ea6310466ff3f802231c582687
2021-11-23 16:37:06 -08:00
Winson Chung ee70dafcf0 Merge "Prevent setting launcher layer has opaque when there is content behind" into sc-v2-dev am: 2919653136
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16326556

Change-Id: Iba972f344019fab23e4ebe7b6f4a67593e780aff
2021-11-23 23:19:30 +00:00
Winson Chung 2919653136 Merge "Prevent setting launcher layer has opaque when there is content behind" into sc-v2-dev 2021-11-23 23:04:01 +00:00
Winson Chung c0098a8628 Merge "Removing logs" into sc-v2-dev am: c1afaa4042
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16248600

Change-Id: Ie38f32ba284d072a11d94ec314a1d50f9beacf26
2021-11-23 22:07:54 +00:00
Winson Chung c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak f36ba262a8 Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev am: 458832c09e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16301835

Change-Id: I8ea18722f8dae8dffe62b09f1d4ef4eae3e45b94
2021-11-23 20:22:11 +00:00
Vinit Nayak 458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
TreeHugger Robot 65715599ec Merge "Add scrim below TaskMenu" into sc-v2-dev am: db5f5f05e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16321951

Change-Id: I1b16592d9b69364288dddd045e70bd712dfe97a4
2021-11-23 19:33:35 +00:00
Winson Chung c9a2a042e1 Fix issue with Shell listeners being unbound if SysUI is restarted am: 34e384d2e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16326990

Change-Id: Ie6a6def0e2ada6949da568cfa2e54757455c5458
2021-11-23 19:33:28 +00:00
TreeHugger Robot db5f5f05e7 Merge "Add scrim below TaskMenu" into sc-v2-dev 2021-11-23 19:29:00 +00:00
Andras Kloczl e77eafc263 Migrate workspace item adding tests to kotlin
In a former CL (http://ag/16064580) I've tried to
do the same but presubmit was constantly failing,
probably because the test is in kotlin.

Test: AddWorkspaceItemsTaskTest.kt
Bug: 199160559
Change-Id: Ie1bc4fcd4f94cd7cb0601c21bbdf273452b9dd1f
2021-11-23 18:32:12 +00:00
Alex Chau 460638e5ef Fix grid layout problem after going back from split select
- Don't reset mFocusedTaskViewId when focused task become split, so it's reset properly when it's added back to RecentsView
- Moved applySplitScrollOffset to RecentsViewStateController to be called after mSplitHiddenTaskView is added back to RecentsView
- Update scroll after going back from split
- Don't reset mSplitHiddenTaskView's translation as it'll clear the grid translations

Test: manual
Bug: 181707736
Change-Id: I4bd204fc537ee520216f875b3eddf4dc94f7bfd8
2021-11-23 16:07:25 +00:00
Thales Lima f316a267d8 Add scrim below TaskMenu
When opening a menu, a scrim with 80% alpha should be shown on top of
Recents view.

Align task menu second row with icon: when the menu shows up in the
bottom row in landscape, the menu should be aligned on the second row.

TODO: there is a RTL bug that I'm waiting because it also affects other
parts, not only this menu.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: I6846ee937cb5e739e8be64d17045bc3b32e28e46
2021-11-23 09:13:25 -03:00
Winson Chung 34e384d2e1 Fix issue with Shell listeners being unbound if SysUI is restarted
- If SysUI is restarted (ie. during dev or a crash), the components
  registering the shell listeners may not be aware of this, and
  listener callbacks will not be re-registered.  Currently all the
  listeners are managed correctly (bound & later unbound) so we can
  just keep the active listener references to re-register if this
  happens.

Bug: 207142749
Test: Kill SysUI, start some apps and ensure Launcher still shows them
      in recents
Change-Id: Iba3b11ee972caf8f0b482942d38c3a7359211180
2021-11-23 08:04:14 +00:00
Winson Chung 6526973952 Prevent setting launcher layer has opaque when there is content behind
- This can prevent the layered content behind to not be visible (and
  since launcher draws a cutout and the wallpaper isn't shown, may
  result in a black rect.  We only specialize for this case while
  Launcher is in Overview.
- Also don't need to defer updating drawsBelowRecents, this can result
  in the state not being reflected since it runs after the last update
  of the transform params

Bug: 205789573
Test: Swipe up from app and ensure behind layers are visible (also
      ensure this doesn't affect blur during the swipe or optimizations
      after you leave overview)
Change-Id: I07689b3d9b65708797576e5fbefe12fb1f544119
2021-11-23 05:21:31 +00:00
TreeHugger Robot 4b3006da4c Merge "Invoke Assistant on 3 button long click on Taskbar" into sc-v2-dev am: 0b7ed895e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308573

Change-Id: Ibabaf721c1322a6db907e665e97ee9e676b2630c
2021-11-23 03:50:11 +00:00
TreeHugger Robot 0b7ed895e7 Merge "Invoke Assistant on 3 button long click on Taskbar" into sc-v2-dev 2021-11-23 03:34:04 +00:00
Vinit Nayak bca13abc82 Invoke Assistant on 3 button long click on Taskbar
Bug: 204273914
Change-Id: I757fa40ad9ac0ace44b57c7dd08ec30b4c0ae6d0
2021-11-22 17:32:16 -08:00
Winson Chung 52d5ec0143 Merge "Skip scheduling frame callback if view root is already detached" into sc-v2-dev am: a5642379d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308550

Change-Id: Ic05deba16fd01fc2bda81b91a1273ba798b7c92a
2021-11-23 00:54:53 +00:00
Winson Chung a5642379d9 Merge "Skip scheduling frame callback if view root is already detached" into sc-v2-dev 2021-11-23 00:41:30 +00:00
Tony Wickham 7a957e914e Merge "Add support for dark tint on taskbar nav buttons" into sc-v2-dev am: 426b021e22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16250063

Change-Id: If91a62cc9d5e41666bd7617ca8909cc2ede333ba
2021-11-22 22:24:28 +00:00
Tony Wickham 426b021e22 Merge "Add support for dark tint on taskbar nav buttons" into sc-v2-dev 2021-11-22 22:05:35 +00:00
Alex Chau 97c12c8b72 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev am: 48644c75b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306378

Change-Id: Idf836f0f62791930900a8fab0cceff9731ecd8dd
2021-11-22 21:13:21 +00:00
TreeHugger Robot 1bad3382fc Merge "Add timeout to AbstractLauncherUiTest.getOnUiThread" into sc-v2-dev am: 953641e28d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16321879

Change-Id: I763c42250a2793647122c3c12423457bc2a140c5
2021-11-22 21:13:14 +00:00
Alex Chau 48644c75b3 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev 2021-11-22 21:07:41 +00:00
TreeHugger Robot 953641e28d Merge "Add timeout to AbstractLauncherUiTest.getOnUiThread" into sc-v2-dev 2021-11-22 20:59:16 +00:00
vadimt edb0527dbd Logging the stack trace for system anomaly messages am: 499e2055a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16322469

Change-Id: I86b2c6379ce08d42fe727a6c63679136ffe428de
2021-11-22 20:37:38 +00:00
Alex Chau 31b46953cb Add timeout to AbstractLauncherUiTest.getOnUiThread
- Send signal 6 to Launcher process when this happens to get a thread dump

Bug: 203416429
Test: labtest
Change-Id: If22b58418be33131e7f585e718a2197cda2e7365
2021-11-22 18:36:11 +00:00
vadimt 499e2055a6 Logging the stack trace for system anomaly messages
With these system anomalies, you are never sure that the system/tests will be able to normally bubble up the error.

Bug: 203416429
Test: presubmit

Change-Id: Ie1d3d183cf6e56778d5c052ef7b8e0541bbc6255
(cherry picked from commit 37542c8c0e)
2021-11-22 18:08:00 +00:00
Winson Chung 1c0bced602 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev am: 550dc8dc69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308385

Change-Id: Iebab222d49fec6fc8d427890b247692921ae54b4
2021-11-22 17:27:41 +00:00
Alex Chau 04068586d4 Log the display state when number of screen bounds is inconsistent am: 4f49c9ce62
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16230738

Change-Id: I9acc687a7bf5944b3c87ed48feb8b3c01e4d27ec
2021-11-22 17:27:35 +00:00
Winson Chung 550dc8dc69 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev 2021-11-22 17:22:16 +00:00
Alex Chau 4f49c9ce62 Log the display state when number of screen bounds is inconsistent
- If the number of screen bounds a.k.a. number of displays has changed, it should be a bug from system and add a log for that

Bug: 198965093
Test: manual
Change-Id: I74612e6c0d2f3cfd52b509e43ea16adf0eec76de
2021-11-22 15:16:17 +00:00
Alex Chau 0c59f1ac7b Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev am: 3c2298668a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307753

Change-Id: I9cf958a545f24c5ce609dac73166dbaf830a413c
2021-11-22 11:23:22 +00:00
Alex Chau 3c2298668a Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev 2021-11-22 11:12:23 +00:00
Winson Chung e2074f01c0 Skip scheduling frame callback if view root is already detached
- Also remove references to deprecrated compat class

Bug: 206932656
Test: Presubmit
Change-Id: I1add65b0fe03dedea872d162e51095bf9c648acf
2021-11-20 00:58:43 +00:00
Winson Chung c2a84d887f Clear ref after animation if visual stashing not supported
Bug: 206814323
Test: Presubmit
Change-Id: Ia38bd2707edbddf1b1f2ad98b3cdac4c8c62a6d3
2021-11-19 23:52:18 +00:00
Winson Chung 616f181857 Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev am: 5e49df2bbe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307006

Change-Id: Iec12b5058211a8fd49badcfc85fd656a03e2a00f
2021-11-19 22:40:54 +00:00
Winson Chung 5e49df2bbe Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev 2021-11-19 22:24:13 +00:00
Jonathan Miranda 1b7ffc9b2b Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev am: 2d9ac4e67f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307200

Change-Id: I58ee7c72effc3445abc104e2d863df0235516cf9
2021-11-19 22:10:38 +00:00
Jonathan Miranda 2d9ac4e67f Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev 2021-11-19 22:05:07 +00:00
Vinit Nayak 01eab872ad Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev am: 54baaae0ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307108

Change-Id: I3ee7c10880f722243485d5082c4c25ba3b013f94
2021-11-19 22:04:35 +00:00
Vinit Nayak 54baaae0ab Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 21:51:03 +00:00
Zak Cohen d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00