Commit Graph

53916 Commits

Author SHA1 Message Date
Sebastián Franco 5e8c248e1f Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev am: 73b8ee9390
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20122918

Change-Id: Id29fb15737ee63e64c3c3e484872c688cbb2f097
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 21:15:45 +00:00
Sebastián Franco 73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
TreeHugger Robot 22b6d5112b Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: 6ccf536f94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20164543

Change-Id: Iaec5bbd931e45ed5ae478ef8f5e91841e0b9c093
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 19:17:36 +00:00
TreeHugger Robot 6ccf536f94 Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-14 18:42:05 +00:00
Zim 83776629df Disable Launcher AIDL_TAG tracing special case
Since we enable generate_traces by default for the system and
signature apps, we can remove this special case

Test: Manual
Bug: 161393989
Change-Id: Iff92c0a729a9b9b038fb6310c7509925c59547b6
Merged-In: Iff92c0a729a9b9b038fb6310c7509925c59547b6
2022-10-14 19:28:50 +01:00
Alex Chau 47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
Pat Manning 31cf44c48c Add launcher metrics for tracking kids nav mode change events.
Bug: 241762670
Test: wwdebug && wwlogcat
Change-Id: I5bf05ce1660078951896e0e331bbe74f8f2ebc5f
2022-10-14 16:24:32 +00:00
Pat Manning 423ad32120 Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev am: 956631ec3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852201

Change-Id: I3cf341312b71312fdea021ca34ea9b186e1b0d93
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 13:37:42 +00:00
Pat Manning 956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
TreeHugger Robot 8d7387042f Merge "Update taskbar state when launcher pauses" into tm-qpr-dev am: a1734ad12e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20192617

Change-Id: I290ffa98e5c6c6458983413430bf236c16abf3a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 03:55:26 +00:00
TreeHugger Robot a1734ad12e Merge "Update taskbar state when launcher pauses" into tm-qpr-dev 2022-10-14 03:23:40 +00:00
Alex Chau d8465a72cd Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev am: 41ab3f3e14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20139153

Change-Id: I8f5163a7cf28f9a49b3d4e1dbd3e0777a96448d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 01:07:56 +00:00
Alex Chau 41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Evan Rosky 14145d131a Update taskbar state when launcher pauses
With shell-transit, we need to defer updating state when resumed
(until we commit a transient launch state); however, for pause
this isn't necessary. In fact, now that taskbar exists in overview,
we must update state on-pause since the taskbar is no-longer
already-closed.

Bug: 253473765
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep#testOverview
Change-Id: I347da03a211f5b2685f7b18666b2ebb93a1731ef
2022-10-14 00:11:25 +00:00
Nicolò Mazzucato c757108519 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev am: 4afab0b210
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175247

Change-Id: I21e4f205591cc030fb92f06ff2faa101de97391b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 23:27:26 +00:00
Nicolò Mazzucato 4afab0b210 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev 2022-10-13 23:06:50 +00:00
Vinit Nayak 0f6526e0c4 Improve TaskMenuView layouts for split pairs
* Instead of basing calculations on the TaskView view,
use the TaskThumbnailView as the anchor.
This helps us prevent having to re-calculate positions
that were already done to layout the thumbnails
* TODO: Gracefully handle re-positioning task menu view
on rotation

Bug: 249693334
Test: Manual, opening task menu view in
land/seascape in portrait, w/ and w/o home rotation

Change-Id: I02da96d2735657d5340e23056de69392ff8452c4
2022-10-13 14:15:14 -07:00
Vinit Nayak d955e318c3 Merge "Fix casts to Math.round() in real landscape" into tm-qpr-dev am: 0bc70442d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20179629

Change-Id: Iad37a502a5e1b14109b0bbb742a30a5323237eeb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 20:31:39 +00:00
Vinit Nayak 0bc70442d6 Merge "Fix casts to Math.round() in real landscape" into tm-qpr-dev 2022-10-13 20:02:05 +00:00
Vinit Nayak b26664800e Fix casts to Math.round() in real landscape
Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation in real landscape.

Change-Id: Ia59efda737de94a4b64f9d0a1f84cd116539107b
2022-10-13 13:01:39 -07:00
Federico Baron b9afac3a26 Merge "Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)" into tm-qpr-dev am: 922bde1df3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20177132

Change-Id: I808056e8bdd8c6a620454ec8269290765b8aee2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 18:17:24 +00:00
Federico Baron 922bde1df3 Merge "Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)" into tm-qpr-dev 2022-10-13 17:48:40 +00:00
Alex Chau 2104aac3bb Merge "Only support manual stashing while in app" into tm-qpr-dev am: e966537123
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20178104

Change-Id: I786bdf2d70a89368ce790c4bcefd62f8ac261496
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 14:19:12 +00:00
Alex Chau e966537123 Merge "Only support manual stashing while in app" into tm-qpr-dev 2022-10-13 13:48:46 +00:00
Nicolo' Mazzucato 74c3a0024b Cancel unfold animation when rotation changes
In DeviceFoldStateProvider.kt, FOLD_UPDATE_FINISH_HALF_OPEN is emitted if the rotation changes while the animation is in progress.

 This targets the case when the device goes to tabletop mode during the transition.

+ Using RotationChangeProvider to fix problems when the new orientation change was received in a background thread unexpectedly. This fixes: (1) wrong launcher icons movement after the rotation, and (2) wrong dark overlay scrim after rotation.

+ Minor formattig fixes by ktfmt

Bug: 241743859
Test: DeviceFoldStateProviderTest && NaturalRotationUnfoldProgressProviderTest && manual stress testing
Change-Id: Iee234e4b832cad8298b69356fce7c14d75e89ccc
2022-10-13 09:16:44 +00:00
Ling Wo 5c239ba4f7 Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion
Bug: 242246407
Test: atest
Change-Id: Icde0185c82b1d34570d83bd8b9750acb57a8e39c
2022-10-13 01:46:45 +00:00
Federico Baron c722e7d814 Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)
Fix: 249814494
Test: Manual
Change-Id: I03008dd24ddb9a0ba4c5a44878cbdf04c65de435
2022-10-12 15:42:34 -07:00
TreeHugger Robot 97c4e6d04d Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev am: 24dd3f57b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20027847

Change-Id: I85c9d13c4a1bf329ae68aaf3984aa40859ac89f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 21:30:10 +00:00
TreeHugger Robot 24dd3f57b2 Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev 2022-10-12 21:10:16 +00:00
Alex Chau 38dae63910 Only support manual stashing while in app
- For taskbar in overview, don't allow stashing

Fix: 253042515
Test: With taskbar in overview, long press do nothing. Taskbar is still stashable in app
Test: Without taskbar in overview, taskbar still transform to nav handle in overview
Change-Id: I8f353a473a8570df72acda2338c4b984a69dc5c0
2022-10-12 18:16:50 +01:00
Sebastian Franco d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
TreeHugger Robot afda58246e Merge "Enable taskbar in overview by default" into tm-qpr-dev am: 2613431914
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20111701

Change-Id: I510f11b58b6d950c649af9fd77137ffabe734411
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 12:50:29 +00:00
TreeHugger Robot 2613431914 Merge "Enable taskbar in overview by default" into tm-qpr-dev 2022-10-12 12:21:14 +00:00
Pat Manning e793bac632 Merge "Use wm shell splash screen animation to reveal app after tasks have appeared." into tm-qpr-dev am: a283b551d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886384

Change-Id: Ia8968e6ec48f3e877ba020d0498afa0520248324
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 11:53:12 +00:00
Pat Manning a283b551d2 Merge "Use wm shell splash screen animation to reveal app after tasks have appeared." into tm-qpr-dev 2022-10-12 11:34:41 +00:00
Jeremy Sim 0ac4708396 Prevent doubling up on split placeholder insets
This patch makes it so that the split placeholder uses only one inset for buffering the top of the icon: either the default split placeholder inset, or the device's built-in screen inset.

Currently, when we determine the size of the split placeholder, we add the placeholder's default inset to the device's built-in screen inset (camera cutouts, etc.). On some devices, this causes a very large combined inset, and it doesn't leave enough room for all the other UI elements, especially when 3-button mode is active. This patch cuts out one of the insets by selecting only one of the insets to respect (the larger one).

Fixes: 241164191
Test: Manual, checked all emulated inset types on a variety of screen sizes
Change-Id: Ica0e791bf4b8b757ad3fb87ab1cf3105b97a61dc
2022-10-11 21:26:43 -07:00
TreeHugger Robot dd1a143a29 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev am: 5c4b6b50d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20086056

Change-Id: I785f86e0daa82618a03c1633ea0efc710e482139
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 03:04:33 +00:00
TreeHugger Robot 5c4b6b50d7 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev 2022-10-12 02:27:37 +00:00
TreeHugger Robot 997edd2dad Merge "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly." into tm-qpr-dev am: 1337b31b3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20076231

Change-Id: I47588e0653e55228b0ba42b288ae437b29e38e9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 00:51:03 +00:00
TreeHugger Robot 1337b31b3f Merge "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly." into tm-qpr-dev 2022-10-12 00:17:33 +00:00
Vinit Nayak 2081742cb7 First pass at Taskbar layout UI polish for SUW
Bug: 231906478
Change-Id: I5d55d1e33f928d4b8034c356565a0f9d8bc5c3fb
2022-10-12 00:04:27 +00:00
Brandon Dayauon 215ddb9b92 Merge "Scale icons from search to make app icons big like AA -> workspace" into tm-qpr-dev am: 956851e7ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19774829

Change-Id: Ic092c9a5cc32f42eaf7f9a8e0dc34ddd16aae310
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 23:06:52 +00:00
Brandon Dayauon 956851e7ca Merge "Scale icons from search to make app icons big like AA -> workspace" into tm-qpr-dev 2022-10-11 22:40:13 +00:00
Schneider Victor-tulias a0be92c830 Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly.
Bug: 244593270
Test: Manually checked logs
Change-Id: Ie6d0395a45a025d1562a722154d3dd3b42618ccc
2022-10-11 15:12:13 -07:00
Sebastián Franco bd484f174a Merge "Prevent double touch inputs in the BaseDragLayer" into tm-qpr-dev am: 73049b14b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040579

Change-Id: Id45956331342c37e1d5f81d355c07c82837fc9d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 20:57:03 +00:00
Brandon Dayauon d3755f46cc Scale icons from search to make app icons big like AA -> workspace
when dragging from search.

To scale the icon during dragging (instead of long press) I created a scale variable within DragOptions
so that right before dragStart gets called in DragController.java (in callOnDragStart())
the dragview scales before dragging..
 * note: the scale from search is 1.687 and the scale from allApps is 1.107
- included searchResult and smallSearchResult
- Added animation for scaling icon (used Interpolators.EMPHASIZED 500ms as suggested by motion designer)
- Cancel animation when drag finishes

bug: 222666176
test: Manual - after: https://drive.google.com/file/d/1ZZHnXlzdTxlM-RUIdJ6EOYkPPg6tCUxC/view?usp=sharing
before: https://drive.google.com/file/d/1NpBz3kT_slHXtpXObr_G8K6SZYG9_bLX/view?usp=sharing

Change-Id: I01309a3be928987ba00422ad947b80a3df865973
2022-10-11 13:29:35 -07:00
Sebastián Franco 73049b14b9 Merge "Prevent double touch inputs in the BaseDragLayer" into tm-qpr-dev 2022-10-11 20:22:45 +00:00
Xin Li cded8966ef [automerger skipped] Merge tm-qpr-dev-plus-aosp-without-vendor@9129937 am: 6c5e11c3d5 -s ours
am skip reason: Merged-In Ie774ec691c1005f3eb37600db6b25da57b9a88ea with SHA-1 601cf30cf6 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20135590

Change-Id: I646fb17cac60ac6d4316e4f4bc4b03e87e93ba79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 17:55:35 +00:00
Alex Chau 517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Sebastian Franco 68fc44ffad Prevent double touch inputs in the BaseDragLayer
If you hold a long press and while pressing you start another
long press again with another finger, then a new onLongPress event
will trigger and in some cases we are not processing that case.

By ignoring the evetns with the flag ACTION_OUTSIDE we can prevent
such cases.

Fix: 247477725
Test: ReorderWidgets
Change-Id: I31833bc54db2771809562bd1f92c8523eb2f05ab
2022-10-11 09:54:46 -05:00