Commit Graph

53916 Commits

Author SHA1 Message Date
Vinit Nayak 05e238ff32 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I2d4308adb3a6396732b663a2f05e9af115318261
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 00:43:22 +00:00
Vinit Nayak b9b7c38d55 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev 2022-10-21 00:07:53 +00:00
Ats Jenk b5b3b054d1 Clicking on desktop tile brings apps to front
Override launchTasks() method from TaskView to ensure we always call
into WMShell to bring desktop apps to front. And don't run single task
animation logic.

Bug: 254738174
Test: manual, enable shell transitions, click on desktop tile in recents
Change-Id: Ibe85cbe14d3378a89ba7bfd5f394f0c3e44f304d
2022-10-20 17:06:47 -07:00
Brian Isganitis 7ed3c82636 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev am: 2bcc3f8599
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19930974

Change-Id: Id1010f7f19454d51b19a11b1d5ed72fe39632332
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:31:44 +00:00
Treehugger Robot 14946c1fa3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I748f2372116aa8bba282a0f1925e3968a9fed0ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:16:08 +00:00
Vinit Nayak c136a1f837 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev am: e690ef7f80
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20232996

Change-Id: Ife8a1a5869452cc869a58b6bac126f74a2afab81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:01:33 +00:00
Sukesh Ram c6d4df87f0 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-10-20 22:58:46 +00:00
Brian Isganitis 2bcc3f8599 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev 2022-10-20 22:54:06 +00:00
Vinit Nayak e690ef7f80 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:57 +00:00
Treehugger Robot 533b937fd3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I6b47e8706afe05f5fdac403e79c87a533fbcc2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 22:45:27 +00:00
Treehugger Robot 35157974d4 Merge "Fix errorprone warnings that should be errors" 2022-10-20 21:45:41 +00:00
Jeremy Sim 0c1d05a636 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev am: 8edca84cd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20155090

Change-Id: Ic5165669dd22c312bf2b73382134c607f48f199f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 21:31:27 +00:00
Jeremy Sim 8edca84cd5 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev 2022-10-20 20:59:49 +00:00
Brian Isganitis 043e982d00 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev am: ddbe35cc87
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915466

Change-Id: Ifa46e8a0331d53ae35cc3d4f3cfbaf0e1b39a574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 18:36:51 +00:00
Sukesh Ram aee55077cc Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-10-20 18:11:15 +00:00
Brian Isganitis ddbe35cc87 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev 2022-10-20 18:08:07 +00:00
Sunny Goyal fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
TreeHugger Robot dc24cc87fc Merge "Removing the dependency on LooperExecutor in ViewCapture" into tm-qpr-dev am: 4206239318
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20237551

Change-Id: I8130c06a6008981980ba4a7bfe4da8b5f348cbde
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 17:05:14 +00:00
TreeHugger Robot 4206239318 Merge "Removing the dependency on LooperExecutor in ViewCapture" into tm-qpr-dev 2022-10-20 16:41:46 +00:00
TreeHugger Robot 3b908345d3 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev am: 26e7dc1789
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20224650

Change-Id: Ife5fb1ef7445177398bc3daf2e7a6f68897fb1a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 16:38:27 +00:00
TreeHugger Robot 26e7dc1789 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev 2022-10-20 16:35:52 +00:00
Thales Lima ed8c69baca Make all handheld grids scalable
Also increase the icon size in the XML until the icon is sized correctly.

Fix: 239419094
Bug: 235886078
Test: manual
Change-Id: I0c7d75181a61177cc5993ba7002c3ccc8fd60fbf
2022-10-20 11:51:59 +01:00
Thales Lima a64a914ddf Calculate taskbar content size for edu
Using the value calculated in layout was not working because TaskbarView onLayout() was being called after TaskbarEduView onMeasure(). Now uses the same value on all orientations based on taskbar icon size.

Fixes: 252945031
Test: manual
Change-Id: Ib6914901638c82f3b3ec4c9b86f6c20e84d34d0f
2022-10-20 11:48:06 +01:00
Tony Huang 0fb921ef36 Snapshot 2 tasks when swipe up split case
Swipe up snapshot only capture the top one task, but for split
screen case it should capture two tasks otherwise the snapshot
in overview would be empty in some cases.

Fix: 247420799
Test: manual
Test: pass existing tests
Change-Id: I3acd477eaca3cb98d86e2446dbb2dbd6295c687d
2022-10-20 14:10:06 +08:00
TreeHugger Robot 9ae49dcbca Merge "Remove redundant createAdapter override." into tm-qpr-dev am: 8a40f0557b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240748

Change-Id: I181c471339e2bf293ec19cb5c2ce25cc59b1e4fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 05:26:36 +00:00
TreeHugger Robot 8a40f0557b Merge "Remove redundant createAdapter override." into tm-qpr-dev 2022-10-20 04:57:15 +00:00
Vinit Nayak 981034687a Scale screenWidth for split proportionally for thumbnail matrix
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
2022-10-19 21:39:50 -07:00
Sunny Goyal cc6290d81f Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Ic6c00cea6febb0e36e147a4811e73f89fbfd4a78
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 01:00:10 +00:00
Brian Isganitis 9ca7744877 Remove redundant createAdapter override.
It is the same as ActivityAllAppsContainerView#createAdapter, so it can
be cleaned up.

Test: Manual
Fix: 254545341
Change-Id: Ib23369a53c8c0a1f8f05b671526eb82a07b6f0e3
2022-10-20 00:41:59 +00:00
Sunny Goyal d79f84fffe Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev 2022-10-20 00:26:13 +00:00
TreeHugger Robot 0967d53cf5 Merge "Add scroll up and scroll down logging." into tm-qpr-dev am: 821ef94974
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20181861

Change-Id: Ib706da61a874cfaaad7bc74f1568e110842cbfe9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 21:15:26 +00:00
TreeHugger Robot 821ef94974 Merge "Add scroll up and scroll down logging." into tm-qpr-dev 2022-10-19 20:31:54 +00:00
Federico Baron 5ff03db6a6 Merge changes I03636e28,I6cf6d52e into tm-qpr-dev am: 41235d529b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20095896

Change-Id: Ifbb8ec9b6115e0e3298406c8986e0a495af6d732
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 20:02:02 +00:00
Federico Baron 41235d529b Merge changes I03636e28,I6cf6d52e into tm-qpr-dev
* changes:
  Fix page indicator dots height in workspace
  Change delightful pagination flag and use it for workspace
2022-10-19 19:33:18 +00:00
Sukesh Ram b066f41fa3 Drag from appDrawer & pin onto secondary display homescreen
Bug: 239246505
Test: Manual
Change-Id: I817d8ef700f2d7caec6fa63123935502f17f2d2f
Merged-In: I817d8ef700f2d7caec6fa63123935502f17f2d2f
2022-10-19 18:22:01 +00:00
Zimuzo Ezeozue c6117e0d60 Merge "Disable Launcher AIDL_TAG tracing special case" am: cf36563f87 am: 6b07d27bbf
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2253778

Change-Id: I70a65c7e3608e27c38323ff06bb316728a9b2b62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 18:12:35 +00:00
Anushree Ganjam 0de35265c1 Add scroll up and scroll down logging.
Bug: 247601175
Test: Manual. https://paste.googleplex.com/5757099224072192

Change-Id: Iec1697e1580c75572c9e77ec349942301ee87694
2022-10-19 18:00:45 +00:00
Andy Wickham f4abbadb21 Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev am: a57bff8473
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20105877

Change-Id: I552f8d30d4a65e5a61a536ac47d21849fb53f1be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 17:55:20 +00:00
TreeHugger Robot e260265fe2 Merge "Decouple taskbar background from overveiw scrim if taskbar is in overview" into tm-qpr-dev am: 913b5afb43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20189272

Change-Id: I92eefce9361a89a99b9778384d2b749ba6dfc2ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 17:54:31 +00:00
Zimuzo Ezeozue 6b07d27bbf Merge "Disable Launcher AIDL_TAG tracing special case" am: cf36563f87
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2253778

Change-Id: I644c8c0431a1f5a71cc54ecf543bbfbeee824c6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 17:44:56 +00:00
Andy Wickham a57bff8473 Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev 2022-10-19 17:40:52 +00:00
Sunny Goyal 5fd67c75fa Removing the dependency on LooperExecutor in ViewCapture
Bug: 254487496
Test: Verified that the frame time stays the same
Change-Id: Ib6ffc209e6df5b1293245971cc12d085549bcd1d
2022-10-19 10:27:53 -07:00
TreeHugger Robot 913b5afb43 Merge "Decouple taskbar background from overveiw scrim if taskbar is in overview" into tm-qpr-dev 2022-10-19 17:18:25 +00:00
Zimuzo Ezeozue cf36563f87 Merge "Disable Launcher AIDL_TAG tracing special case" 2022-10-19 17:08:05 +00:00
Thales Lima 0503584f8a Merge "Remove KtR workaround" into tm-qpr-dev am: 994b181676
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20221668

Change-Id: I8a35758f0ee59abbb0e9fc055852a0f6a90362c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 14:32:28 +00:00
TreeHugger Robot 08092b2cfb Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev am: c9928a1ddf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20154536

Change-Id: I1fe0c0d4410b83c657047b59fc6988ede9b3b880
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 14:31:57 +00:00
Pat Manning 986e5dde13 Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: ded9a7485e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697622

Change-Id: I6a7660b64929d4467bc4aa79e6bcc003ec73f336
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 14:30:58 +00:00
Thales Lima 72539ecb16 Merge "Convert make to bp" into tm-qpr-dev am: c863b90571
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19258809

Change-Id: Ibc6d33eb3056db39b5f9922ca44f2fbfca96fc04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 14:28:58 +00:00
Nicolo' Mazzucato 9d4b775b1d Add CUJ_RECENTS_SCROLLING
This adds Jank instrumentation every time recent tasks are scrolled.

Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while scrolling
Change-Id: I3904257ef60a4e09c91a0d5297beadad0bce8785
2022-10-19 14:25:10 +00:00
Thales Lima 994b181676 Merge "Remove KtR workaround" into tm-qpr-dev 2022-10-19 14:04:48 +00:00