PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
53,916 Commits 1 Branch 0 Tags
c57c76281618a7f94de3145567efb81bb376f14e
Commit Graph

53916 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Luca Zuccarini 56ccb4eda5 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev 2022-11-15 10:54:03 +00:00
TreeHugger Robot 1660639dc0 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: Ib60f471012fb310366f82e55653cdc65c2e7dd5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 10:15:55 +00:00
TreeHugger Robot e2334d76fe Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev 2022-11-15 09:53:02 +00:00
Saumya Prakash b67ffcb04b Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Iaad0a7624aa157f982c8156c993d5b98faac8c4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 03:06:02 +00:00
Saumya Prakash 59a3c51a43 Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev 2022-11-15 02:45:29 +00:00
TreeHugger Robot c9452b5f70 Merge "Make settings button touch target size larger" into tm-qpr-dev am: f7d000a6c7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468591

Change-Id: Ia112118efc7f4925a92ffc28c9cf3d5da7d70cdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-15 02:35:41 +00:00
TreeHugger Robot f7d000a6c7 Merge "Make settings button touch target size larger" into tm-qpr-dev 2022-11-15 01:44:11 +00:00
Vinit Nayak b2711a81e6 Update unsupported split app error text 
Bug: 258822425
Change-Id: I8ac24d094d14a5f65a1d83303a9fd087c76bf066
 2022-11-14 15:20:25 -08:00
Saumya Prakash 7eac37254b Add a flag for the redesigned Gesture Nav Tutorial 
We plan to improve the gesture navigation education tutorial as
discussed and shown in go/gesture-nav-education.

Test: N/A
Bug: 241813570
Change-Id: I2ad8d12cf14c1b3f0eec3208ad12a24ac54b9dbc
 2022-11-14 22:38:21 +00:00
Alex Chau 2426514bf6 Put IDP.getDeviceProfile logging behind a feature flag 
- To avoid memory regression in performance testse

Fix: 257359801
Test: manual
Change-Id: I5ed768d90dba149eeb8f7be7d1d229b0b599a485
 2022-11-14 21:19:44 +00:00
Sihua Ma 7a382f139d Making talkback focus on the widget after the resize 
Fix: 216386890
Test: Manual
Change-Id: I79b0280c0f24a81be44e1578755ed90cf3343f88
 2022-11-14 13:12:44 -08:00
Schneider Victor-tulias 7d9e1d6fb9 Merge "Return to home when overview command fails." into tm-qpr-dev am: 62b9f80d1e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442700

Change-Id: I0a5517e8d26e276e021f49dd39deacffaec79b5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-14 21:08:08 +00:00
Schneider Victor-tulias 62b9f80d1e Merge "Return to home when overview command fails." into tm-qpr-dev 2022-11-14 20:44:52 +00:00
Jon Miranda 5eba9000df Update transient taskbar transition duration to match spec (417ms). 
Bug: 246632728
Bug: 246641848
Test: manual
Change-Id: If3f73774444c6074a81101d91d291ef33edcaf9c
 2022-11-14 12:28:20 -08:00
Jon Miranda 9787ae6ad9 Allow transient taskbar to unstash over soft ime 
Bug: 255818649
Test: pull up ime, swipe to reveal taskbar
Change-Id: Ibae77c8a29d06093823f2421fbf851979f9babed
 2022-11-14 11:30:55 -08:00
Vinit Nayak f47e27ee4f Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev am: 50306445a1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20324839

Change-Id: Ie80c46c5c86fde41f259ff2e07ca4213b45a673d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-14 19:21:19 +00:00
Vinit Nayak 50306445a1 Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev 2022-11-14 19:07:59 +00:00
Federico Baron 9b30b84879 Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I63d9f134fe7c428d1dfe1dc02dcd6e418f6b98f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-14 19:06:46 +00:00
Federico Baron e779a8c783 Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev 2022-11-14 18:39:38 +00:00
Federico Baron 2a8ed8a3e8 Make settings button touch target size larger 
The touch target of this item was 32dp, now we change it to 48dp to make it easier to interact with the button

Fix: 179116216
Test: enable talkback, then go to home settings -> suggestions -> suggestions on home screen. Turn on suggestions on home screen. Notice touch target size is small in settings button of toast.
Change-Id: I5b8b2ac99f3843cf6fe838cf572565a334e23b2a
 2022-11-14 10:13:28 -08:00
Jerry Chang b4f100354e Merge "Make multi-instances split opt-in based" into tm-qpr-dev am: 168c204f49 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20306070

Change-Id: Icec4268adf433679226a7cb26dbdfd0327e899a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-14 13:51:16 +00:00
Jerry Chang 168c204f49 Merge "Make multi-instances split opt-in based" into tm-qpr-dev 2022-11-14 13:29:46 +00:00
Vinit Nayak b8ef284a6c Only show split button for single fullscreen task if taskbar is present in Overview am: 584332202c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442504

Change-Id: Ifde61fadc084a707e60a0d66db2f4fd06b7ef669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-12 03:11:16 +00:00
Colin Cross d930011746 Add a lint baseline for Launcher3 
The lint version in tm-qpr-dev incorrectly flags BaseActivity.java.
Add an entry to lint-baseline.xml file to silence the incorrect
error.  The newer version of lint in master doesn't have the false
positive.

Bug: 258754271
Bug: 256019562
Test: m RUN_ERROR_PRONE=true javac-check lint-check
Change-Id: I2fd22e96c8e89b7dc25132089e36d599e012e747
Merged-In: If02f87ef74c73321afa3427d845ad80539292b30
 2022-11-11 23:27:20 +00:00
Federico Baron c0dc93d384 Add flag for 'Improve widget picker UX on large display form factor' 
here's how we plan on improving widget picker under this flag: https://docs.google.com/presentation/d/1mcdjJWutr-ZGbPOndhe1D8YCdCh6EbO8eNyK3YMMVEY/edit#slide=id.g1571d496dda_0_145
Test: N/A
Bug: 256684299

Change-Id: I365516b43e70a37c7b93e089b6822c58a0f81540
 2022-11-11 22:24:18 +00:00
Anushree Ganjam c36593139c Introduce imeHeight in KeyboardStateManager. 
Bug: 204781396
Test: Manual
Change-Id: If9dc9427a73ab22d6418edb9c954e79fd0958395
 2022-11-11 19:20:16 +00:00
Anushree Ganjam 6024013953 Add SearchResultCode to onSearchResult() 
Bug: 204781396
Test: Manual
Change-Id: Ia776be0fdd42e1d5fa405911e28d9b0a12c1fdde
 2022-11-11 18:26:58 +00:00
Anushree Ganjam 96c72745ae Add ImpressionLogger to StatsLogManager 
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
 2022-11-11 18:23:25 +00:00
Vinit Nayak eae4c99434 Prevent dropping a drag from TaskbarAllApps in Overview 
* Don't close TaskbarAllApps once drag starts
(see comment in code regarding needing multiple shared drag
layers)
* Hide app menu split options for taskbar in overview
* One TODO is that the animation needs to be tweaked
because the scale of the icon when it's returned is too large.
* I think maybe we have to change the
TaskbarDragController#mDragIconSize since that gets directly
set from a resource. Unclear.

Test: Dragged in TaskbarAllApps in overivew and in split
select, app returned to original position and not taskbar
Bug: 251747761

Change-Id: I785f34b0bdb0b0abfc440450494074f8dfe7c31a
 2022-11-10 16:17:26 -08:00
Vinit Nayak 584332202c Only show split button for single fullscreen task if taskbar is present in Overview 
* Taskbar in overview allows second app to be
selected so user wouldn't be stuck in split
select state

Fixes: 258543259
Test: Tested w/ flag on and off
w/ one and multiple flags
w/ fullscreen and split single focused task

Change-Id: Ie588ad66fde4e012e08d8f5abbe1eef5a1a5db6b
 2022-11-10 14:20:03 -08:00
Sebastian Franco 592e2691f6 Fix the wiggle reorder aniamtion stopping if dragging 
We were using the minimum span to calculate the cell position
of the widget and if you move slightly because the minimum is usually smaller than the current size it would calculate wrong cell positions
that are change more frequently because it's smaller.

Also, I went back and moved
performReorder(... CellLayout.MODE_SHOW_REORDER_HINT) with the
alarm if block as it was before one of my refactors, it still works
if they are separate but is harder to think about the logic if they
are divided so it's better to all be in one block.

Fix: 255421416
Test: manual testing, reordering and making sure the animation is playing well.
Test: atest ReorderWidgets (to make sure the reorder is not broken)
Change-Id: I3eff5bc9f21fda8f2f8908380397d8639ac15ff9
 2022-11-10 21:53:33 +00:00
Anushree Ganjam 9d77abc3f4 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: If02f87ef74c73321afa3427d845ad80539292b30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:43:32 +00:00
Anushree Ganjam 04c268daef Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: I21481a4769668479d161f5557caddaa8b7b85edf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:43:22 +00:00
Anushree Ganjam b63cc3f113 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev 2022-11-10 20:31:01 +00:00
Anushree Ganjam fd7afb707a Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev 2022-11-10 20:19:42 +00:00
Pat Manning e6d4939db8 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev am: 3c7a7a92b3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411892

Change-Id: Ib44b14ba9fb1781efc443d6d10668aac4fdabeae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:11:14 +00:00
TreeHugger Robot ed50adb7b4 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I6cb50a223aa63323812133b50499fb84b6c19698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 20:09:29 +00:00
Pat Manning 3c7a7a92b3 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev 2022-11-10 19:58:48 +00:00
Schneider Victor-tulias 0844f2e8ef Return to home when overview command fails. 
Returning a runnable list that doesn't get run later causes the overview command to be added to the pending command queue, but never gets removed. This causes following overview (and home on tablets) commands not to respond.

Test: forcefully caused the error condition programmatically; checked the queue is cleared and the user is sent home.
Fixes: 255851262
Change-Id: I9d2f54960c54963b1e7480a597d05911201c152b
 2022-11-10 11:56:09 -08:00
TreeHugger Robot 267d7179cd Merge "Create test for default grid" into tm-qpr-dev 2022-11-10 19:37:11 +00:00
Saumya Prakash 8d2f42ddd2 Merge "Add padding around clear all button in overview." into tm-qpr-dev am: 6db7d31ced 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413157

Change-Id: I0f9883e153ddb2ab09f17ac3ed453f73ad626496
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 19:29:43 +00:00
Vinit Nayak 4b6c05c2ef Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: I6cd4962097e2c72762cf28f8c4feb01efa66f22b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 19:28:59 +00:00
Saumya Prakash 6db7d31ced Merge "Add padding around clear all button in overview." into tm-qpr-dev 2022-11-10 19:27:53 +00:00
Jeremy Sim 3d0b47a5ea Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev am: d5525c3bda 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20365694

Change-Id: I8d1e153a3d9f2b04293a41a0e008cc348fe028d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-10 19:25:02 +00:00
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" 
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
 2022-11-10 11:11:14 -08:00
Jeremy Sim d5525c3bda Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev 2022-11-10 18:56:22 +00:00
Anushree Ganjam 29eb74f9bd Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags. 
Bug: 204781396
Test: Manual
Change-Id: Icd1170d8fc349ca3a50836ef0d1d0c9a0c793002
 2022-11-10 17:41:20 +00:00
Anushree Ganjam f213afc0a7 Add OnLayoutCompleted() Listener. 
OnLayoutCompleted() Listener for RecyclerView.LayoutManager#onLayoutCompleted(RecyclerView.State) so we can do impression logging when RecyclerView has finished laying out the items.

Bug: 204781396
Test: Manual
Change-Id: I59b81e98415b2b0c6f3b26d2c41d348242342048
 2022-11-10 17:38:59 +00:00
Luca Zuccarini 431f05b3a0 [Toast] Update A-Z <-> Toast transition for drawable backgrounds. 
This and the other change in the topic are protected by a new feature
flag (included here).

Bug: 229297414
Bug: 248006105
Test: manual (see screenshots and recordings in the second bug)
Change-Id: I3478d7e194ee5d3bc4f8affdadbec969c033d084
 2022-11-10 14:43:20 +00:00