When "Don't keep activities" is enabled in developer settings, the RecentsView gets re-initialized every home gesture. The home animation can often finish before the load plan ever gets applied, so the page scrolls can be used before the RecentsView has had a chance to add all its TaskViews and recalculate its page scroll.
Fixes: 249020573
Test: launched an app and went home
Change-Id: I83ca9de60b50693f7a22b08534ec36973cd6a0fc
- ITYPE_BOTTOM_MANDATORY_GESTURES should always be > 0 in gesture
navigation mode, but before we were setting it equal to tappableHeight
which is 0 if the taskbar is stashed. Fixed it to be contentHeight
instead.
- Updated VIS insets to only override them to be 0 for tappableElement,
not for others like navigationBars. We still only override this for
gesture navigation; 3 button mode will continue reporting the same as
we report to the underlying apps.
Test: manually with 3 button mode, gesture nav mode with taskbar
stashed/unstashed; checked that TaskbarInsetsController dump looks as
expected, and that behaviors like Assistant and IME look correct
Flag: none
Fixes: 262516176
Change-Id: I5a1cdf5a9956777d3189ef6042493e2f5aa9b162
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize
Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.
Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.
Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.
Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher
Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
EDU will now end up hiding due to
TaskbarLauncherStateController#onStateChangeApplied closing all AFVs if
we are going to home or overview.
This is a quickfix to make it harder to accidentally close the EDU when
testing out the transient taskbar. We will eventually be moving to a
lighter EDU UI where having gestures occuring behind it will be less
awkward.
Test: Manual
Bug: 260769010
Change-Id: I477abe9339ed10cb3aed8d1a0fbe0e22ac14c7ab
- Moved to new position
- Using 3x3 icon
- New Colors
Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.
Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models
Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
This polishes closing both at the same time when they are on top of each
other.
Test: Manual
Bug: 217261955
Change-Id: Iecb8658b98debb0225d3b59da99ecb34d008971a
- During gestures from taskbar all apps, unstash immediately in
transient.
- Overlay closes sooner if all apps is open (still done later for EDU).
- Taskbar stashes in overview when All Apps is opened.
- Transient app-window threshold is ignored if All Apps is opened.
Test: Manual
Fix: 262076812
Change-Id: I46b2dcdc75ee0cc15c1b47da2139ff8c20cf618a
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space
Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
- Transient taskbar nav threshold now works in overlays.
- Delay closing overlay to transient app-window threshold if necessary.
- Persistent taskbar no longer stashes for EDU overlay.
- EDU overlay provides enough bottom padding for transient and
persistent taskbar.
Test: Manual
Bug: 217261955
Change-Id: I2ae5612ef70a6d09e22f83f8117cdbf2a0a053b8
Fix: 260769010
Schneider Victor-tulias
Tony Wickham
Alex Chau
Sunny Goyal
Bill Yi
Jeremy Sim
Brian Isganitis
Jon Miranda
TreeHugger Robot
Pat Manning
Andy Wickham
Federico Baron
Ats Jenk