7a19cccafe
Override displacement for transient taskbar instead of mCurrentShift
...
mCurrentShift is based on displacement, but is used and set in different
places. To keep consistency throughout, we should override the
displacement at the source instead.
Test: manually swiped up between home/overview threshold and catch up
threshold; let go to go to overview and ensure no jump occurs.
Flag: teamfood (ENABLE_TRANSIENT_TASKBAR)
Fixes: 259981285
Change-Id: Id9f5b2bcdc2e56e15ddb6d93c4ee5d5ececc094d
2022-11-21 20:14:56 +00:00
5dd9cffa5d
Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev am: 1a8b95a9d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20483285
Change-Id: I02c2f8c040064ec5c0f304fc86d76199f799abe1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:21:15 +00:00
5ff72eaa46
Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev am: 0ccbd7334c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20522179
Change-Id: I19f12060d771c4121642a5dbaf8ccdd291795a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:20:02 +00:00
183f07e0da
Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev am: 455eca41be
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20514045
Change-Id: Iada41f7e36da2570cf285c6291de801a7f15597f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:19:09 +00:00
8b9090cc35
Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev am: b9e03da563
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20521649
Change-Id: Iaff26841709cacabfd6254e1e05c8a328eb36da9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:16:40 +00:00
1a8b95a9d4
Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev
2022-11-21 19:04:15 +00:00
0ccbd7334c
Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev
2022-11-21 19:04:04 +00:00
455eca41be
Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev
2022-11-21 19:02:44 +00:00
b9e03da563
Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev
2022-11-21 19:01:04 +00:00
3ea711d992
Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev am: 104517cefb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411886
Change-Id: I0a4f2a8755c49d230417c9b71afaa9ccd6ff410d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 18:49:35 +00:00
d46450dd1f
Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev am: 8700307b23
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20501358
Change-Id: Ie3cf43c96594bb0201678e189fd874a74535f4b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 18:49:07 +00:00
104517cefb
Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev
2022-11-21 18:30:19 +00:00
8700307b23
Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev
2022-11-21 18:18:49 +00:00
9cddf4133b
Cleanup overview threshold which was only needed for 2-button mode
...
- Removed hasReachedOverviewThreshold() and mPassedOverviewThreshold
- Changed calculateEndTargetForNonFling() to check velocity.y to
determine whether to go HOME or LAST_TASK when no other conditions are
met (e.g. mIsMotionPaused still goes to RECENTS). To allow transient
taskbar to override this so that user stays in LAST_TASK when invoking
the taskbar, kept setHasReachedHomeOverviewThreshold() but renamed it
to setCanSlowSwipeGoHome(),
Test: TaplTestsQuickstep, manually tested on tablet and phone to ensure
the correct end target was chosen when hitting this code path in
calculateEndTargetForNonFling
Flag: teamfood (ENABLE_TRANSIENT_TASKBAR)
Fixes: 259715295
Change-Id: I925be3433d7d2792cdc2a75a18dc575019f2cc95
2022-11-21 17:57:20 +00:00
1ba39205bc
Fix NPE from using DeviceLockedInputConsumer after the surface has been released
...
Fixes: 243154747
Test: swipe up from camera app while device is locked
Change-Id: Ia92e3e3cccb37e0d14592b0f3094f5aba1073300
2022-11-19 12:26:34 -08:00
4ff301eb9d
Do not start drag from pre-drag if cancelled during animation.
...
This change affects the preDragCondition for icons that do not have a
popup menu. The condition assumes we are still in pre-drag after
DragView is finished animating, but the user can cancel the drag in this
time (e.g. by releasing their finger early).
Test: Manual. Holding and releasing on suspended icon does not crash,
while holding and dragging still works as expected.
Fix: 258233476
Change-Id: Ic76f785cffcbfe0fe51eb1473022f2dc34563070
2022-11-19 02:32:08 +00:00
244d48097f
Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev am: 793c37153a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20490352
Change-Id: I26e1675d9832f5c80c430450698a908e93951e1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 02:27:13 +00:00
0964f40f1f
Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev am: e912742234
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470530
Change-Id: Ieb4dd888a30103985cc4a4aa10ce24824d8a41e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 02:27:02 +00:00
793c37153a
Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev
2022-11-19 02:19:25 +00:00
e912742234
Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev
2022-11-19 01:58:37 +00:00
9af9ebcd2f
Merge "Clear drag views during swipe up animation progress" into tm-qpr-dev am: 7b516983bc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446856
Change-Id: Ib41e1a777127f4562d3f5c7dd4242f5d84fb62b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 23:41:19 +00:00
7b516983bc
Merge "Clear drag views during swipe up animation progress" into tm-qpr-dev
2022-11-18 22:59:10 +00:00
c970bd5b61
Merge "Only allow one TaskbarRecentsAnimationsListener at a time." into tm-qpr-dev am: 543528594a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20067011
Change-Id: Id526d0dae17759e6268b9621d53b6b810dddbd13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 21:53:42 +00:00
543528594a
Merge "Only allow one TaskbarRecentsAnimationsListener at a time." into tm-qpr-dev
2022-11-18 21:38:58 +00:00
3a93f9f5d4
Merge "Update PluginManager Import" into tm-qpr-dev am: d5ab17164d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20455291
Change-Id: Ia7c4699c1b2248582bc30afb930559e8bd3cb457
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 21:26:36 +00:00
7ae410b011
Merge "Fix home/overview threshold." into tm-qpr-dev am: e3bcc7bf40
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20511766
Change-Id: Ibbf9b180a26715787f9b3d1decb25fc7e8b96e35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 21:26:11 +00:00
d5ab17164d
Merge "Update PluginManager Import" into tm-qpr-dev
2022-11-18 21:17:18 +00:00
08be3775f6
Prevent x-axis window movement during the initial swipe up to show transient taskbar
...
- If gesture starts and isLikelyToStartANewTask=true, we do not clamp
- If gesture starts and isLikelyToStartANewTask=false AND transient taskbar is not
already showing, we clamp the scrolling
Bug: 258851206
Test: swipe up to show taskbar, no x-axis movement
swipe left/right still works as expected
Change-Id: Iac194df63e03b4a28b49008983c88c165847aa31
2022-11-18 13:10:34 -08:00
e3bcc7bf40
Merge "Fix home/overview threshold." into tm-qpr-dev
2022-11-18 21:02:01 +00:00
e04a878709
Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."
...
This reverts commit a0be92c830
2022-11-18 11:00:33 -08:00
53c66c4afe
Merge "Update test for vertical split" into tm-qpr-dev am: 9de3256583
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20455918
Change-Id: I22f047cef11967f9b32354246f66d9ce82d548ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 18:43:06 +00:00
9de3256583
Merge "Update test for vertical split" into tm-qpr-dev
2022-11-18 18:21:10 +00:00
1c3916daeb
Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev am: 9b3aaf2b7d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508312
Change-Id: Ief0f13b064472a37924ce7fe5c05adf8f35c23a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 17:21:57 +00:00
9b3aaf2b7d
Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev
2022-11-18 16:45:30 +00:00
81e33a07d3
Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev am: 4b26e8f081
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20511769
Change-Id: If783c22198f860dee1e184040f3aa64dea9805e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 03:41:01 +00:00
4b26e8f081
Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev
2022-11-18 03:12:00 +00:00
21d4253c01
Fix home/overview threshold.
...
Fixes: 258836670
Test: Enable I06e16d78c179b7c3281f423ed8c7dd6cfc42229a to visually show
thresholds on screen
Swipe up to overview where taskbar not showing
and also with taskbar already showing
Change-Id: Ie7487a5f869c0718d9ee08209dee8331a01d5989
2022-11-17 18:09:31 -08:00
57a3312468
Merge "Add a11y titles for taskbar windows." into tm-qpr-dev am: 50b3b62eba
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20239440
Change-Id: If23159090c979589410bd41a1c82ceb28e70582f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 02:00:04 +00:00
ed37fabc9c
Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156
Change-Id: I2a176b09a92ce02acd2a406f6647701098164328
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 01:57:55 +00:00
50b3b62eba
Merge "Add a11y titles for taskbar windows." into tm-qpr-dev
2022-11-18 01:56:22 +00:00
3a801de233
Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev
2022-11-18 01:44:01 +00:00
424c7f4393
Still launch disabled item if we can't handle its click.
...
See where ItemClickHandler#handleDisabledItemClick returns false for
context. If we do not honor this return value, the framework will not
show a dialog in response to attempting launch the item.
Fix: 258232619
Test: Manual
Change-Id: Ie3b112eea17caf0a84defb331133bda9f3add5b6
2022-11-18 01:09:18 +00:00
825ede3e92
Update test for vertical split
...
* Takes into account taskbar insets, not sure what
expected val should be so copied the same logic from code
Bug: 219411750
Test: Ran test, passes
Change-Id: I6230a3d043e41446c35c9b393abf4a2e0ea891af
2022-11-17 16:39:27 -08:00
b626411c99
Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860
Change-Id: I397957b5d9584aebf4182930763a2c5ab6401073
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 00:17:45 +00:00
9390b500a9
Only allow one TaskbarRecentsAnimationsListener at a time.
...
If another animation is created while one is occurring, we should clean
up the previous one.
Test: Manual
Fix: 233868461
Change-Id: Idf0e33ae95cbf19741ee943e450d478b1e18716b
2022-11-18 00:02:53 +00:00
3233010c5a
Merge "Move SharedPreferences code to its own class." into tm-qpr-dev
2022-11-17 23:46:26 +00:00
92924fca3e
Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev am: 4059ff0a0c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469952
Change-Id: Id803a2004f4574287a2d225ed67f30949e6731da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 23:27:22 +00:00
4059ff0a0c
Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev
2022-11-17 23:03:31 +00:00
2049f3990a
Use mContext instead of TaskbarActivityContex to enable transient taskbar.
...
Bug: 259586791
Bug: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ibb0a8e8539946f3a496318a6a9cf4b553693d790
2022-11-17 14:20:33 -08:00
383c950918
Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev am: 193f8992f1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20486066
Change-Id: I6200232bd2f266a365e8559ca060f0594052d797
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 22:11:05 +00:00
Tony Wickham
Ats Jenk
Brian Isganitis
Schneider Victor-tulias
TreeHugger Robot
Ikram Gabiyev
Jon Miranda
Sihua Ma
Hawkwood Glazier
Vinit Nayak
Stefan Andonian