Commit Graph

11086 Commits

Author SHA1 Message Date
Jon Miranda 5441cce805 Ensures that we end back to home animation on the last animation frame.
This fixes the bug where user performs double swipe back to home and we
have a floating window on the screen.

Fixes: 277515917
Test: From an app, back swipe to home, and then immediately back swipe
      to home again
Flag: NONE
Change-Id: If312ee55efeaadde896511c6d449826368b15a84
2024-02-09 00:43:31 +00:00
Mady Mellor 31f53abe45 Follow changes for MagneticTarget.Listener to pass the dragged object
Flag: None; bug fix
Test: atest MagnetizedObjectTest MenuViewLayerTest DragToInteractAnimationControllerTest
Test: manual - drag and dismiss bubbles while stack is expanded
                 - drag and dismiss the stack
Bug: 315127709

Change-Id: I74d6711d822ea8873f468b1a4745d45937b81ef9
2024-02-08 15:44:06 -08:00
Winson Chung 7a9923c2c7 Merge "Fix issue with wrong token used for input consumer unregistration" into main 2024-02-08 19:05:44 +00:00
Winson Chung b917c9ef52 Fix issue with wrong token used for input consumer unregistration
- Calling TIS.onUserUnlocked() will create a new InputConsumerController
  and also call register() on that consumer, which will under the hood
  destroy and create the consumer with WM.  However, if onUserUnlocked()
  is called multiple times (generally not the case), the second call
  will trigger the creation of a new InputConsumerController and try
  to call destroy with the new consumer's token instead of the old
  one, and when it creates a new consumer WM will throw an exception
  complaining that there is already a consumer.

  We should instead use the same input consumer controller instance
  for each registration so that we can destroy with the same token that
  was previously used to create the consumer

Fixes: 313284686
Test: Force trigger onUserUnlocked() multiple times and ensure no crash
Change-Id: I67da9a1ca82568770d470fd94f17378fd50c02f4
2024-02-08 19:05:30 +00:00
Luca Zuccarini 9fd2b31005 Merge "Rename a few more animations classes to cover transitions in general." into main 2024-02-08 16:34:22 +00:00
Luca Zuccarini 9ac91ffa63 Merge "Rename ActivityLaunchAnimator to cover transitions in general." into main 2024-02-08 10:15:43 +00:00
bvineeth b6b3ea976f Add HOME_TO_APP tag to CUJ_TASKBAR_EXPAND/COLLAPSE
Test: checked traces
Bug: 263362887
Flag: NA
Change-Id: If85e05544b5595c6b27b1af885882415751779d5
2024-02-08 09:24:09 +00:00
Jon @ f670b96e31 Merge "Update state for when task launched in live tile mode gets cancelled." into main 2024-02-08 00:00:21 +00:00
Tracy Zhou e14948d0f6 Merge "Show hotseat instead of stashed taskbar handle after entering stage split from fullscreen app via keyboard shortcut" into main 2024-02-07 22:04:20 +00:00
Jon Miranda 4af3e80cae Update state for when task launched in live tile mode gets cancelled.
This fixes the bug where taskbar shows up on home screen.

Fixes: 314790864
Flag: N/A
Test: From overview, tap on app, then immediately swipe to go home

Change-Id: I3aaa8cbe67edefc43ccd6db90ee7647152a862fc
2024-02-07 11:29:07 -08:00
Vadim Tryshev 6a0c468563 Merge "Revert "Add unit test for StatusBarTouchController.java"" into main 2024-02-07 18:54:43 +00:00
Helen Cheuk eece9356e2 Merge "Show taskbar when external keyboard is attached, in 3 button nav mode and desktop windowing mode" into main 2024-02-07 14:30:12 +00:00
Jagrut Desai 8f4e0d0c83 Merge "Fixing NPE android.platform.test.scenario.launcher.overview testcases" into main 2024-02-06 22:57:09 +00:00
Fengjiang Li 7f827e1527 Merge "[Predictive Back] Replace legacy flag with aconfig flag in launcher" into main 2024-02-06 21:57:34 +00:00
Shamali Patwa efebbb21fe Merge "Update prediction task to provide categorized suggestions." into main 2024-02-06 21:36:14 +00:00
Tracy Zhou b7efb5cb49 Merge "Only hide back button in SUW when ime is rendering it" into main 2024-02-06 20:24:29 +00:00
Sunny Goyal d1176bccf9 Merge "Using system API for rotating DisplayCutout instead of rotating it ourselves" into main 2024-02-06 20:20:47 +00:00
Jagrut Desai 77d2e7860a Fixing NPE android.platform.test.scenario.launcher.overview testcases
Test: Presubmit, run staging platinum test on this change
Bug: 303256981
Flag: NONE
Change-Id: I9f807b008bb08909b4a08e750b4357b7d23eba39
2024-02-06 11:41:44 -08:00
Sunny Goyal a90500d233 Using system API for rotating DisplayCutout instead of rotating it ourselves
Bug: 321913010
Flag: NONE
Test: Manual
Change-Id: Iebbc8c17dc3b92a73866b7e22dfbde18eb3a52ff
2024-02-06 10:26:18 -08:00
Shamali P 57c1eedbc6 Update prediction task to provide categorized suggestions.
Also adds a helper in popup data provider to provide categorized
suggestions. Used in follow up CL to update the UI.

Bug: 318410881
Test: WidgetsPredictionUpdateTaskTest and manual with follow up changes
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ie80e8ba7bbe874f7c4b0e579446edf571036555e
2024-02-06 18:14:49 +00:00
Luca Zuccarini a2dd8a2629 Rename a few more animations classes to cover transitions in general.
Soon they will be used for both launches and returns, so these names
are more accurate.

Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: I618780f0416a466a6672a2e694cb3e3ffd3f1396
2024-02-06 17:06:26 +00:00
Alex Chau 1380459097 Merge "Fix Select mode problem with animation off" into main 2024-02-06 16:55:56 +00:00
Ram Muthiah 87b5785548 Revert "Add unit test for StatusBarTouchController.java"
This reverts commit 1f0465e9f2.

Reason for revert: Droidmonitor investigation of test suite failure

Bug: 323976612
Change-Id: I07895d5c10984def103c240664755b96b79f1fb5
2024-02-06 16:50:10 +00:00
Johannes Gallmann 2441874a75 Merge "Fix crash for predictive back to home fallback animation" into main 2024-02-06 16:13:30 +00:00
Alex Chau 55b8b43fef Fix Select mode problem with animation off
- Avoid calling resetTaskVisuals when entering Modal state with animation off, it should only be called when leaving Overview, to be consistent with animation on case
- Use a separate property to control alpha for modalness, to avoid being overridden by other transition

Fix: 320314839
Test: presubmit
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I12a35682e25c3a70bc263afdc90a7895d6c56f11
2024-02-06 14:16:43 +00:00
Luca Zuccarini 1fcfe364ba Rename ActivityLaunchAnimator to cover transitions in general.
Soon it will be used for both launches and returns, so this name is
more accurate.

Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: Iaff2589401af24c6e9f604b3d7fa11e819fc941a
2024-02-06 14:07:44 +00:00
Vinit Nayak bc663baab0 Merge "Fix bug with portrait-fold devices animating app pairs launch wrongly" into main 2024-02-06 13:15:33 +00:00
Jeremy Sim 2d0fd0780a Fix bug with portrait-fold devices animating app pairs launch wrongly
This CL makes it so that isLeftRightSplit is correctly called instead of isLandscape when animating an app pair launch.

Fixes: 318756992
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: Id766a3f9bd315abc277e36a118fd233156cf3898
2024-02-06 18:40:03 +08:00
Vinit Nayak d471844135 Merge "Revert^2 "Prevent taskbar animation for contextual split from home"" into main 2024-02-06 03:53:38 +00:00
Fengjiang Li cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Vinit Nayak 5f2b7242f3 Revert^2 "Prevent taskbar animation for contextual split from home"
This reverts commit 8b78849c44.

Reason for revert: Did not fix failing test b/323418145

Change-Id: Ic0897dda930a76aa27fba6e9de925b653d63a7f4
2024-02-06 00:00:35 +00:00
Fengjiang Li 3088ae55d1 Merge "Add unit test for StatusBarTouchController.java" into main 2024-02-05 22:29:35 +00:00
Vinit Nayak 562fe01e5e Merge "Update fail fast check logic" into main 2024-02-05 20:00:08 +00:00
Fengjiang Li 1f0465e9f2 Add unit test for StatusBarTouchController.java
Test: this one
Flag: NONE
Bug: 282945183
Change-Id: I76eb4389d71d7a03e038ed6b01b6f5b7923fd11a
2024-02-05 11:51:01 -08:00
Vinit Nayak ccab39e714 Merge "Revert "Prevent taskbar animation for contextual split from home"" into main 2024-02-05 19:39:00 +00:00
Vadim Tryshev 3517550379 Merge "Starting measuring displacement from the edge of the slop zone" into main 2024-02-05 18:22:12 +00:00
Vinit Nayak 628a039721 Update fail fast check logic
* Incorrectly wasn't erroring out when flag was not enabled

Bug: 295467097
Change-Id: I5716309f832d1170ea92ad357897299c0438d2d0
2024-02-05 10:21:26 -08:00
Uwais Ashraf 810a82f13e Merge "Extract GroupedTaskView size calcs to a method to prevent measure calls" into main 2024-02-05 11:35:11 +00:00
Uwais Ashraf 0d355abe38 Extract GroupedTaskView size calcs to a method to prevent measure calls
Bug: 313644427
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I494f09455104372209b9087d13a704a4fe52bb62
2024-02-05 10:27:12 +00:00
Tracy Zhou e9f4635426 Show hotseat instead of stashed taskbar handle after entering stage split from fullscreen app via keyboard shortcut
Besides finishing the recents animation from fullscreen app, we also need to update the taskbar state

Fixes: 323561157
Test: Go to a fullscreen app, trigger the split shortcut, make sure the hotseat icons are visible on the home screen
Change-Id: I36f47846ed0bc7f7036ae22452a28efc9cb09bc7
2024-02-03 06:04:00 +00:00
Tracy Zhou 6474a3b455 Merge "Add split instructions to stage split from keyboard shortcut" into main 2024-02-03 06:02:48 +00:00
Tony Wickham cac7c6f682 Merge "Send finish callback even if there is no icon to animate to" into main 2024-02-02 22:37:44 +00:00
Vinit Nayak 92dd621d8e Merge "Intercept clicks for non-supported split targets on workspace" into main 2024-02-02 22:07:53 +00:00
Mady Mellor 5912d0f6d9 Merge "Launcher: use aconfig flag for bubble bar" into main 2024-02-02 21:04:32 +00:00
Vadim Tryshev 94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Tracy Zhou d0b9aae52c Add split instructions to stage split from keyboard shortcut
Fixes: 319098298
Test: When launching split from fullscreen app via keyboard shortcut, the split instruction shows
Change-Id: Ie64e5e65384a24825edc7ae6c8dea3203e2bd916
2024-02-02 11:29:10 -08:00
helencheuk 04cd8f2852 Show taskbar when external keyboard is attached, in 3 button nav mode and desktop windowing mode
Bug: 280497051
Test: Manual, turn on desktop windowing mode. Enter input mode in an app, drag it from the top to be  window mode. Verify if taskbar is present
Flag: N/A
Change-Id: I31dc922c480cd0b39a64763155777b906e3bd14a
2024-02-02 17:31:13 +00:00
Vinit Nayak ec52ed9f99 Intercept clicks for non-supported split targets on workspace
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets

Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual

Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
2024-02-02 08:17:13 -08:00
Sam Cackett 8b997289f0 Merge "Fix issue with IconAppChipView animated states" into main 2024-02-02 12:27:45 +00:00
samcackett fee52acb29 Fix issue with IconAppChipView animated states
Cancel in progress animations and resume from previous position.
Display TaskMenuView once.

Fixes: 322813710
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I73410d6116876ca83f3b16311d2e9eb372308295
2024-02-02 11:08:47 +00:00