Commit Graph

11086 Commits

Author SHA1 Message Date
Johannes Gallmann f3fe3b47a4 Merge "Fix flickers when invoking overview transition during predictive back-to-home" into main 2024-02-23 17:15:46 +00:00
Pat Manning 5aa23d41dd Focus a task by default when using keyboard to go to overview.
Fix: 322898816
Test: TaplTestsQuickstep.java
Flag: None.
Change-Id: I6d4b0ca6593ed2ac7c7d8793954c36e55b5978de
2024-02-23 12:22:06 +00:00
Alex Chau 58bd15c6ab Fix setContentAlpha skipping all TaskViews when runningTaskId is -1
- Currently when runningTaskId is -1, it can skips setting contentAlpha for all TaskViews if they haven't been loaded, this cause RecentsView to become empty in the bug
- Can be reproduced with excludeFromRecents=true apps

Bug: 324495241
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure RecentsView is visible after gesture settles
Flag: None

Change-Id: I9f1b4ffed6d09805c83c6e2241903c73d4ead9ad
2024-02-23 11:59:48 +00:00
Johannes Gallmann c71b48c658 Transfer coordinate into new Rect instead of in-place
Other parts of the animation rely on currentRectF to remain stable, therefore we shouldn't modify the RectF object in place.

Bug: 323628523
Flag: NONE
Test: Manual, i.e. verifying that widget close (and app close) animation animates correctly regardless of device orientation
Change-Id: I48e9ed047b956db654192eef39e5d94fbac53553
2024-02-23 12:30:46 +01:00
Johannes Gallmann 0ccdb91990 Fix flickers when invoking overview transition during predictive back-to-home
Bug: 321923510
Bug: 321968468
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying that recents transition is not invokable during the predictive back to home animations and instead the flickerless overview transition is is invoked (same as for regular back-to-home)
Change-Id: I90029de8d0c98853d38ed8984cbe7cda3b566b5a
2024-02-23 10:29:26 +01:00
bvineeth fdf6df3226 Add tags for CUJ_TASKBAR_EXPAND/COLLAPSE
Test: Checked traces
Flag: None
Bug: b/263362887
Change-Id: I28652b0629b8033fe931809bacceeede3c36ea93
2024-02-23 03:27:54 +00:00
Vineeth Bhende 510886fc14 Merge "Fix taskbar_expand/collapse jank monitor" into main 2024-02-23 03:01:58 +00:00
Treehugger Robot b6cbb2a419 Merge "Make getTaskSize actaully a getter that does not modify member variables" into main 2024-02-22 23:03:03 +00:00
Jeremy Sim 1a98a9d874 Fix app pair launches with certain apps
This CL changes the way app pairs are saved. Previously, we saved the app pair using WorkspaceItemInfos directly from Recents, which caused certain apps to fail on launch because they weren't being launched with the correct Intent.

Now, we look up a proper launchable WorkspaceItemInfo from the AllAppsStore and save that to the app pair, which should fix the launch issues.

Bug: 323112914
Bug: 323110399
Test: Can launch Slides, Play Store, and Calendar when part of an app pair.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I475afa1a237c50ffb0ffaf85af43912a803b8011
2024-02-22 22:58:44 +00:00
Sunny Goyal 1d6f76f811 Merge "Adding support for async view inflation" into main 2024-02-22 22:38:41 +00:00
Anushree Ganjam cc971f67f5 Merge "Remove Unused parts of LauncherPrefs causing cyclical dependency." into main 2024-02-22 21:53:21 +00:00
Will Leshner 0467404c25 Tweak WidgetPickerActivity size filtering.
Better conform to documentation about how to use widget sizes when
filtering for sizes in WidgetPickerActivity.

Bug: 322191186
Test: atest Launcher3Tests
Flag: NA
Change-Id: I4239e64dd620e00a3c55046bfb66fe3099336aac
2024-02-22 12:50:50 -08:00
Sunny Goyal 72a74669e7 Adding support for async view inflation
Bug: 318539160
Test: atest AsyncBindingTest; atest ItemInflaterTest
Flag: aconfig enable_workspace_inflation DEVELOPMENT
Change-Id: I77a373db7a5805f68f4b8cbfa9b586b5674252de
2024-02-22 10:58:48 -08:00
Jagrut Desai 08a4e68bae Merge "Handle SystemGestureRegion in TaskbarDragLayer" into main 2024-02-22 17:55:28 +00:00
Orhan Uysal 6d73b0a201 Make taskbar visibilty change only in desktop.
Make the DesktopVisibilityController not change the taskbar visibility
when there are no freeform tasks visible.

Test: Go from freeform to fullscreen, observe taskbar doesn't pop up
Bug: 323129412
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing DEVELOPMENT
Change-Id: I67f246cfc2ddc198326c093fd0af83886de8b0a9
2024-02-22 17:13:42 +00:00
Eghosa Ewansiha-Vlachavas 80232ea229 [2/n] Replace read-only desktop windowing flag with runtime flag
Replace use of `enable_desktop_windowing` flag with
`enable_desktop_windowing_mode` flag

Flag: NONE
Bug: 304778354
Fixes: 326060018
Test: build & `adb shell device_config put lse_desktop_experience
com.android.window.flags.enable_desktop_windowing_mode true && adb
reboot` desktop windowing mode should be enabled.

Change-Id: Idc44e2b7a8b738f15f8d3812a0c4fc1a4b4861c1
2024-02-22 17:02:45 +00:00
Sam Cackett becd601c68 Merge "Translate IconMenu to top / left of thumbnail view" into main 2024-02-22 08:59:42 +00:00
Stefan Andonian 21ab3b979b Remove Unused parts of LauncherPrefs causing cyclical dependency.
This "migration" feature was planned as an effort to reduce latency upon
startup. That being said, now that there is a loading screen being added
to pixel startup time, it doesn't make sense to perform a risky data
migration just to save a 100ms or so of startup time. Therefore, I am
removing this code as a clean up effort to make LauncherPrefs simpler.
Also, there was a cyclical dependency introduced in b/324670265 that
makes this cleanup effort especially worthwhile, as it resolves a bug
for other developers.

Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I81df710057d80fbd071bc26a53cb191d453e7dee
2024-02-22 05:50:15 +00:00
bvineeth 4d38783106 Fix taskbar_expand/collapse jank monitor
Issue : Currently opposite jank is being reported taskbar expand and taskbar collapse


Test: Checked the trace
Fixes: b/326333977
Flag: None
Change-Id: Ib5adeb33506717ee28d669c5d46557087ebf7e60
2024-02-22 04:12:45 +00:00
Treehugger Robot a5e8751f0d Merge "Merging multiple implementations of CancellableTask" into main 2024-02-22 02:54:30 +00:00
helencheuk 00ddb5e3a9 Stash taskbar when software keyboard is docked
Stash taskbar when
1) Software keybaord is docked
2) Input toolbar is placed at the taskbar area (stash so toolbar and taskbar would not overlap)

Testing result:
https://drive.google.com/file/d/1NMDexHl0FgyHFaOUh_GSEEUU2k08STJH/view?usp=sharing

Bug: 317251202
Test: TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Flag: N/A

Change-Id: I90662bc6e68f644e919f5c702059476b02519ed6
2024-02-21 23:03:03 +00:00
Jagrut Desai c8a5176bfc Handle SystemGestureRegion in TaskbarDragLayer
- Currently user can tap on taskbar icons when in persitent mode when a popup is visible on screen.
we are making it so that touch event is not performed at view level and get dismissed before at drag layer.

Test: Presubmit, Manual
Bug: 320229858
Flag: NONE
Change-Id: I9a76faa0e282317d808ba0f55b49741dc7b750a3
2024-02-21 11:35:29 -08:00
Brandon Dayauon 0fa9113028 Merge "Add home settings toggle featureflag for enablingTwoLineText" into main 2024-02-21 18:14:21 +00:00
Luca Zuccarini df33f361b0 Move remote animation utils to the Animation lib.
This is so that they can be used within the Animation lib itself, while
remaining available to all current users, since the SysUI shared lib
also depends on Animation lib.

Bug: 323863002
Flag: NA
Test: still builds, tests still pass, manually tested areas that depend
on these utils.

Change-Id: I10de17b51c05054efe957ed1073a1cbe6baf05c5
2024-02-21 15:03:51 +00:00
Vineeth Bhende 18f3f63a2c Merge "Add tag for cuj OPEN_ALL_APPS when swiping to open all apps" into main 2024-02-21 02:25:19 +00:00
Vinit Nayak 2b031727f0 Merge "Log split metrics through individual sessions" into main 2024-02-21 00:20:44 +00:00
samcackett 6eaa509481 Translate IconMenu to top / left of thumbnail view
When splitting a task that is already part of a split app pair from the
 TaskBar, with the enableOverviewIconMenu feature enabled, position the
 IconMenu to the left of a leftRightSplitApp pair, or the top of a
 topBottomSplitApp pair

Fixes: 317001670
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I4740d7c96635ee9542f7061938baf6fbf2ca01d4
2024-02-20 16:05:10 +00:00
Schneider Victor-tulias 56aa9ed61b Update KQS launch task callbacks
Updated KQS to allow launching tasks through OverviewCommandHelper to allow launching the overview task without it having focus.

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324888738
Fixes: 324904244
Test: used enter and tap to launch tasks in KQS
Change-Id: I6de38ceea22c362a52a420c8ba0165ba23e5c862
2024-02-20 14:54:08 +00:00
Alex Chau 5e8811e126 Make getTaskSize actaully a getter that does not modify member variables
- This is a follow-up of ag/26255150 to clean-up usage of getTaskSize
- Removed getTasksize and updatePivots in onLayout, as updateSizeAndPaddings has covered all scenarios
- mLastComputedTaskSize will only be updated from updateSizeAndPaddings, with minor refactoring on how mTaskWidh/mTaskHeight/padding are calculated

Bug: 325314248
Test: Manual on home/app->overview, rotations, fold/unfold etc.
Flag: None
Change-Id: I031a36e5e065a28070fb3f7f146978279f7d8886
2024-02-20 13:30:48 +00:00
Johannes Gallmann db22e3008e Use STANDARD_DECELERATE interpolator for predictive back to home
Bug: 325647546
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying increased responsiveness during first phase of back gesture
Change-Id: Ie31d7fba7ca307c96830e0656887cda89d9bbb1a
2024-02-20 14:23:26 +01:00
Alex Chau d564a9d26c Merge "Update pivots after taskSize is updated" into main 2024-02-20 11:57:49 +00:00
Alex Chau a6def81654 Merge "Don't run parallax animation for grid overview" into main 2024-02-20 11:35:36 +00:00
Alex Chau ec6f0bad38 Don't run parallax animation for grid overview
Bug: 286821534
Test: manual
Flag: None
Change-Id: I08c77ce5d538ee07374e9f88fc4d00cc8165f28b
2024-02-20 11:34:58 +00:00
Treehugger Robot 89170d6fab Merge "Update color of Overview ShareTarget scrim" into main 2024-02-19 14:17:47 +00:00
Alex Chau 51c09ed13e Merge "Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership" into main 2024-02-19 12:00:56 +00:00
Alex Chau 6ff4c1f5a4 Merge "Always run animateClose when closing TaskMenuView" into main 2024-02-19 10:27:32 +00:00
Anushree Ganjam 9ea1724245 Merge "Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK." into main 2024-02-17 00:23:11 +00:00
Anushree Ganjam 06c98fd685 Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK.
Jank CUJ's cannot be added in LauncherState since it's aosp code.
Introduced `onBackPressComplete` method so the LauncherState subclasses can override this method to get back press complete call after back press animation is successful. Here we can add necessary jank CUJ's.

Perfetto trace : https://ui.perfetto.dev/#!/?s=3fc6eed848bdd692949ddb3afbdcdf04a7ef0d99cb9a83804ce9e1840492ed66

Test: Perfetto trace. https://screenshot.googleplex.com/5yviY5LxKusnKvF.png
Bug: 319132905
Flag: NA. Adding jank CUJ.

Change-Id: Ia418f06cb76fe4e14c2032c62c2250e9143442f2
2024-02-16 14:35:20 -08:00
Jon @ d3693424f5 Merge "Notify home is visible when launching a translucent app." into main 2024-02-16 21:43:28 +00:00
Treehugger Robot 821715127d Merge "Prevent taskbar reset animation from playing when gesture is in progress." into main 2024-02-16 21:36:59 +00:00
Ats Jenk ca99653959 Merge "Create bubbles input consumer before nav bar long press" into main 2024-02-16 19:52:08 +00:00
Alex Chau c302daec2f Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership
- RecentsView only see itself owning RecentsAnimationController and RemoteTargetHandle after live tile is enabled via onGestureAnimationEnd to RECENTS
- RecentsView will finish recents animation if it owns RecentsAnimationController and is leaving RecentsView
- Otherwise, reset() would not reset RecentsAnimationController or RemoteTargetHandle
- Added logging for interaction between gesture and RecentsView to aid future debugging

Bug: 288557298
Test: manual
Flag: None
Change-Id: Icdcb91b98b2bb5d6d3bc30070f533ea79915bc09
2024-02-16 19:23:08 +00:00
Alex Chau 1ae5e169b0 Update pivots after taskSize is updated
- For case that there are no TaskViews, onLayout is not called, so updatePivots isn't called when folding

Fix: 325314248
Test: Manual
Flag: None
Change-Id: If7377f2e4fcbe4a874f823bb99b0b197cd5f7b87
2024-02-16 15:23:35 +00:00
Alex Chau 60ad90e519 Always run animateClose when closing TaskMenuView
- This avoid diverging code path when animation is off
- Also made sure menuTranslationX and Y always reset when not needed
- Also remove AnimatedVectorDrawable in favour of scale animation in code, as AnimatedVectorDrawable doesn't work well when animation is off

Bug: 319086207
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I4a18cf4aac3237031095c2600c777b6c4c3e518f
2024-02-16 14:58:14 +00:00
bvineeth e8bdf16b65 Add tag for cuj OPEN_ALL_APPS when swiping to open all apps
Test: Checked trace
Bug: b/270128536
Flag: None
Change-Id: I0d5f562fc156423af2b5ce7e54e1bff54a522aa6
2024-02-16 10:41:15 +00:00
Vineeth Bhende e2a76cee2b Merge "Add CUJ-LAUNCHER_OPEN_ALL_APPS instrumentation from taskbar" into main 2024-02-16 04:02:24 +00:00
Ikram Gabiyev 1979abe353 Merge "Move IPip and IPipAnimationListener to common" into main 2024-02-15 23:42:51 +00:00
Jon Miranda 26447ddc98 Notify home is visible when launching a translucent app.
To fix the taskbar stash delay when launching an app, ag/18875100
sets the state so that the taskbar stashes immediately after
app is launched.

Since we cannot know if the app is translucent at that point,
we have to check after the animation is started so we can update the
launcher visibility state.

Bug: 314792981
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TRUNKFOOD
Test: HomeObserverTest
Change-Id: Ifc3a6559d7a8c6fda4c08a0fc2d6791da46b38d6
2024-02-15 13:55:42 -08:00
Schneider Victor-tulias 00a484bf03 Merge "Fix alt-tab initial focus in overview on phones" into main 2024-02-15 21:06:08 +00:00
Sunny Goyal cc1dad0cae Merging multiple implementations of CancellableTask
Bug: 318539160
Flag: None
Test: Manual
Change-Id: Ie855427c2676e0ce76655e4dd67472c0b5e435d8
2024-02-15 13:01:10 -08:00