Commit Graph

11086 Commits

Author SHA1 Message Date
Jeremy Sim f9551e4cc1 Merge "Fix bug with Taskbar launches in Overview" into tm-qpr-dev am: bc1fa1e6a4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890017

Change-Id: I53382fd8559820495872b76c34218f3cb071b0be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-19 02:31:09 +00:00
Jeremy Sim bc1fa1e6a4 Merge "Fix bug with Taskbar launches in Overview" into tm-qpr-dev 2023-01-19 02:23:32 +00:00
TreeHugger Robot 8c3d0fb5df Merge "Close Taskbar AllApps when going from overview to home" into tm-qpr-dev am: 7c323889aa am: 3cb0796d36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20980934

Change-Id: Ie896ab713b9100da43f495536cf6f86ae5613849
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 22:06:43 +00:00
TreeHugger Robot 3cb0796d36 Merge "Close Taskbar AllApps when going from overview to home" into tm-qpr-dev am: 7c323889aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20980934

Change-Id: I1ff479f7475d613ee36aa94ecca42620b47465aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 21:31:35 +00:00
Miranda Kephart 00ae9eb815 Merge "Update ImageActionUtils to construct a ScreenshotRequest" 2023-01-18 21:10:39 +00:00
TreeHugger Robot 7c323889aa Merge "Close Taskbar AllApps when going from overview to home" into tm-qpr-dev 2023-01-18 20:54:43 +00:00
TreeHugger Robot 05de99177f Merge "Using AnimatedFloat for maintaing TaskbarInAppDisplayProgress instead of a float array" into tm-qpr-dev am: 3080803691 am: eace1bc8e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968627

Change-Id: Ic1d9557c96d37a3d9d5c94ca732a5c40f2ef1e71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 19:11:54 +00:00
Vinit Nayak b1c47227b1 Add unit tests for TaskbarKeyguardController
* Remove setting back button tint for SUW as that
is now done in ag/20953768

Bug: 230027385
Change-Id: I2c157ed67487cab9ba721fa659973351780509bb
2023-01-18 10:42:45 -08:00
TreeHugger Robot eace1bc8e3 Merge "Using AnimatedFloat for maintaing TaskbarInAppDisplayProgress instead of a float array" into tm-qpr-dev am: 3080803691
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968627

Change-Id: I9491981efa3ead36d8d16480a599dd773e17deb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 18:34:44 +00:00
Sunny Goyal a0ddda45ad Merge "Updating TaskbarStashController API" into tm-qpr-dev am: ff5697302b am: 24ef99966f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968628

Change-Id: I46bd67154ae5085e4538170ee5262b3cc533581e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 18:00:26 +00:00
Miranda Kephart 6e6f555182 Update ImageActionUtils to construct a ScreenshotRequest
Bug: 264457397
Test: atest
Change-Id: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
2023-01-18 17:45:14 +00:00
TreeHugger Robot 3080803691 Merge "Using AnimatedFloat for maintaing TaskbarInAppDisplayProgress instead of a float array" into tm-qpr-dev 2023-01-18 17:35:24 +00:00
Sunny Goyal 24ef99966f Merge "Updating TaskbarStashController API" into tm-qpr-dev am: ff5697302b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968628

Change-Id: I5df111238f109d4ea3b50354adccab780e30b216
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 17:22:02 +00:00
Sunny Goyal ff5697302b Merge "Updating TaskbarStashController API" into tm-qpr-dev 2023-01-18 16:53:55 +00:00
Nick Chameyev a8037620bd Calculate StatusBar height locally in Launcher
When reading the status bar inset on devices with
multiple displays after switching the displays
the inset is not updated immediately (SystemUI
should update the height of the window first by
reacting to the display switch in it's own process).

Due to this race condition Launcher is very likely
to calculate DeviceProfile with incorrect inset
of the previous display first and update it to
the correct one only after SystemUI finished the
window update.

To avoid this adding calculation of the StatusBar
height to Launcher locally using the same utility
method that is used by SystemUI.

Bug: 264656380
Test: manual test that the statusbar height is calculated
 correctly in Launcher on a device with two displays, both on
 the inner and outer display and different rotations
Change-Id: Ia16ecadd8fcac29082d27ca693ab7740ce6161c4
2023-01-18 16:04:41 +00:00
Pat Manning effe64381b Reset splash icon when task icon is null to avoid caching incorrect drawable.
Fix: 263365662
Test: manual
Change-Id: I79390381f4cab79b9729bd819630eeb9c8b47d1d
2023-01-18 13:20:54 +00:00
Tony Wickham ccd389dbdf Merge "Fix launcher crash by set divider hidden" into tm-qpr-dev am: f8176700d3 am: 763a9f2059
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20955885

Change-Id: I919e1cb8cb739cab0d0ce79a8c5a434683f7ca53
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 23:04:16 +00:00
Tony Wickham 763a9f2059 Merge "Fix launcher crash by set divider hidden" into tm-qpr-dev am: f8176700d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20955885

Change-Id: I7bdc51009808c5ad209367be19d8fe3e96f74985
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 22:32:40 +00:00
Tony Wickham f8176700d3 Merge "Fix launcher crash by set divider hidden" into tm-qpr-dev 2023-01-17 21:31:36 +00:00
Stefan Andonian 6a651e63c9 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a am: 60e3b74522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I7a69b534e3df890034eb897e8d61517e75828702
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 19:29:02 +00:00
Stefan Andonian 60e3b74522 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I291aeed8952555e9dd35b4dfe2e1c73db889351a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 18:52:00 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Nicolo' Mazzucato cb7bd50247 Log device profile changes in perfetto traces
This is needed to easily spot unwanted DeviceProfile changes in perfetto traces, as each one causes many new inflation and slows down the ui thread considerably.

Test: recorded trace with this log
Bug: 258214245
Change-Id: I805d56d4dfe1c08d7f28215c0462d01fcaece84e
2023-01-17 14:54:11 +00:00
Jeremy Sim 2842bc72fd Fix bug with Taskbar launches in Overview
This patch fixes a bug where Taskbar launches (tapping an icon on the Taskbar) were not executing correctly in Overview.

Now that Taskbar is always present in Overview, we need to handle cases where the user taps to launch an app, but the app is already visible to the user in Overview. This was breaking in a noticeable way with split apps, where the Taskbar simply wouldn't respond when the tapped app was already visible as a live tile.

Fixed by polling RecentsModel for already-running tasks, checking to see if the associated TaskView is visible to the user or not, and calling launchTasks() on the TaskView if so. If the tile is not visible to the user, the app will launch normally.

Fixes: 261952204
Test: Work in progress
Change-Id: If761546913bde7451a22456a272ba6c31942c5f8
2023-01-17 13:54:47 +08:00
Alex Chau 835ccc58e0 Close Taskbar AllApps when going from overview to home
- Also trigger closeAllOpenViews when changing state to NORMAL

Fix: 265689318
Test: manual
Change-Id: I109c0f3a3c741844c8747bd76a6c38bf301ec737
2023-01-16 18:20:27 +00:00
Tony Huang 3f5d510b38 Fix launcher crash by set divider hidden
We will hide divider when isLikelyToStartNewTask become true, but
this call sometime earlier than onRecentsAnimationStart then cause
crash because mRecentsAnimationTargets is still null.

Fix this by checking mRecentsAnimationTargets before set divider
visibility. And also add new condition to hide divider to ensure
it hidden if such case happened.

Fix: 265238266
Test: manaul
Test: pass existing tests
Change-Id: I80b1294e69a52e7ac5255cd8e55e7c5e6a3dcbcb
2023-01-16 14:29:19 +08:00
Sunny Goyal a34521e434 Updating TaskbarStashController API
> Making the state animator nonNull to avoid null checks at caller
> Updating the methods names to explicitely indication animation
  being started or not

Bug: 265352919
Test: Verified on device
Change-Id: I1f5b47921f831ed0b202aced10825c8e1d39a4dc
2023-01-14 08:07:44 -08:00
Tony Wickham 7d41212d42 Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev am: a329718dcf am: 4f90d44377
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20886425

Change-Id: I046559dca1c9e2866005de73663ca9e5d32940b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 03:18:59 +00:00
Tony Wickham 4f90d44377 Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev am: a329718dcf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20886425

Change-Id: I61fe680a135268379e741a171ed2d29febbeca99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:15:34 +00:00
Sebastián Franco 075bd276ca Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev am: 519714449f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838734

Change-Id: Id6707d575fecfeae28b704fd8701c82f4288a9f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:14:48 +00:00
Tony Wickham a329718dcf Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev 2023-01-14 01:09:52 +00:00
Sebastián Franco 519714449f Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev 2023-01-14 00:59:47 +00:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Randy Pfohl def579a82f Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd am: f763efa527
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: Ib63c994382afea82b05815a210079a2c924fafaa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 00:08:06 +00:00
Randy Pfohl f763efa527 Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: I7a302c76532621837b54fbf38dd153fb15f975b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 23:28:30 +00:00
Randy Pfohl dcd79bd6cd Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev 2023-01-13 23:02:41 +00:00
Johannes Gallmann c047a8885c Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7 am: f2709309bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: I13c25d2e87498a6a28dd018dacf6451cbaabb092
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:49:01 +00:00
TreeHugger Robot ec59c7b9c5 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29 am: 2618fcf11c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ic56fd8e629f376893eb10fd21d39384cb3299d0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:48:52 +00:00
TreeHugger Robot 021877cbb4 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147 am: dda983334f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I55e5316bdfc7a004f31b44a0fadc54d97695ea2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:48:32 +00:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Johannes Gallmann f2709309bb Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: Ia1e8d8830a99268870f4c9f3cf59ca5d32a731b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 17:55:35 +00:00
Johannes Gallmann 4aa135f3c7 Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev 2023-01-13 17:28:42 +00:00
TreeHugger Robot 2618fcf11c Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ica6895eddd30abb925ce9b87322711213ae14f68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 16:01:52 +00:00
TreeHugger Robot 60c7dfec29 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev 2023-01-13 15:49:07 +00:00
TreeHugger Robot dda983334f Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I4a77261e41700023d6f3c8856db040b9369a013f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 13:46:23 +00:00
TreeHugger Robot 5f3784d147 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev 2023-01-13 13:01:03 +00:00
Vinit Nayak 07cccd161f Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8 am: f47ba402c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5ea97c57ae8e590da7c963c52ec3307b536f410b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:18:32 +00:00
Vinit Nayak f47ba402c8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5798568fcfc64ef8d7ce3a5175e45f249c53e08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:14:59 +00:00
Vinit Nayak f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Jeremy Sim 6872bc1236 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71 am: 2bc8635b0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ida4e65f9c12d412ba176dc950219b4c19697877d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 00:27:28 +00:00