Commit Graph

11086 Commits

Author SHA1 Message Date
Chavi Weingarten 0aa21b3918 Merge "Updated SurfaceSyncGroup API definition." 2023-01-30 16:35:54 +00:00
Luca Zuccarini 8e1818e789 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev am: f70e2f0a95 am: 20650ab555
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836638

Change-Id: I73f3653bd7777df7d5454add3ebc5c7b5663d088
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-30 15:38:17 +00:00
Luca Zuccarini 20650ab555 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev am: f70e2f0a95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836638

Change-Id: Ic4f5610fe4c04a5b876356d9912bf8f9eabc35b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-30 14:51:12 +00:00
Luca Zuccarini f70e2f0a95 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev 2023-01-30 14:25:48 +00:00
Tracy Zhou 6692653328 Disable quickswitch for trackpad gestures
Bug: 261815244
Test: make sure (1) if user starts by swiping up, disable quickswitch (they will land either in overview, home, or the current app) (2) if user starts by quick switching, cancel the gesture

Change-Id: I6b59cec0089d5e6f22eee3241c6336345dd15dce
2023-01-29 23:56:00 -08:00
Winson Chung 4bfef12fdd Merge "Include SysUI state in stashing check" into tm-qpr-dev am: 0a381d4115 am: 3b67bcd0f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120299

Change-Id: I89158bb65c5db395dac6b9e9bde58e65b9f547c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-29 07:07:30 +00:00
Winson Chung 3b67bcd0f9 Merge "Include SysUI state in stashing check" into tm-qpr-dev am: 0a381d4115
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120299

Change-Id: Ie35303e08e9658497be60b193fd405ddcea89c63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-29 06:24:23 +00:00
Winson Chung 0a381d4115 Merge "Include SysUI state in stashing check" into tm-qpr-dev 2023-01-29 05:57:50 +00:00
Winson Chung 62c74f9633 Include SysUI state in stashing check
Fixes: 266890635
Test: Open home controls over lockscreen, go back
Change-Id: Ic486ccdc4698f53507bc56875ccebef06826a6a4
2023-01-29 05:57:39 +00:00
Vinit Nayak 7ffc338a42 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev am: d710773889 am: fd185e6402
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20956773

Change-Id: I78f6b8fee567230a59d533ca17bebc3c578e9040
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-28 07:08:17 +00:00
Vinit Nayak fd185e6402 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev am: d710773889
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20956773

Change-Id: I65ec9dbc148013ed6143f868398078e4f32bf4a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-28 06:26:13 +00:00
Vinit Nayak d710773889 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev 2023-01-28 05:25:12 +00:00
Jagrut Desai e42feb4db5 Merge "Add divider line into taskbar." into tm-qpr-dev am: 307b6e2475 am: 617cb7c4e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968623

Change-Id: I0e60024a0c3ef3df5d5eb3994cf705a3b8d4ca4f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-28 02:21:47 +00:00
Jagrut Desai 617cb7c4e1 Merge "Add divider line into taskbar." into tm-qpr-dev am: 307b6e2475
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968623

Change-Id: Iebee8c1a98ff8f5ee1bc60cd72921fe417878dd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-28 01:54:25 +00:00
Jagrut Desai 307b6e2475 Merge "Add divider line into taskbar." into tm-qpr-dev 2023-01-28 01:22:03 +00:00
Vinit Nayak 49dc6d2712 Launch initial split from taskbar in overview app menu
* Consolidated init calls in SplitSelectStateController
* Also add support to launch from taskbar all apps
* Add logic in SplitSelectStateController to know whether
or not we need to dismiss existing TaskView vs relying
on mSplitHiddenTaskView null check
* Default click handling for SplitShortcut is to start
split selection mode

Bug: 251747761
Test: Initiated split from smart actions, thumbnail app
icon, home, taskbar in overview, all apps. Saw it choose
the latest thumbnail

Change-Id: Ib4f64e619c97615af458a19a9c0efd86c92979d9
2023-01-27 16:46:14 -08:00
Schneider Victor-tulias ece659d11a Revert "Revert^2 "Cancel gestures on launcher destroy""
This reverts commit 377eb40985.

Reason for revert: failing tests
Fixes: 266606727
Fixes: 266621449

Change-Id: I61094be02fb73c5ad65ee65be5ed93a3364f37ef
2023-01-27 14:38:19 -08:00
Stefan Andonian 59d78bea68 Merge "Load home properly even if AllSetActivity fails Go To Home Swipe." into tm-qpr-dev am: d01497d714 am: 8e97128a7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21048063

Change-Id: I172bb350e7ccb70ae60f17f4b579a8b0eb49a0ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-27 20:14:43 +00:00
Stefan Andonian 8e97128a7e Merge "Load home properly even if AllSetActivity fails Go To Home Swipe." into tm-qpr-dev am: d01497d714
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21048063

Change-Id: Ia04f38a55b7ac76f895719878ea5cafc7e22e1a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-27 19:25:27 +00:00
Tony Wickham 602f3074f9 Remove ALPHA_INDEX_IME_BUTTON_NAV
Taskbar already stashes when IME is showing, which hides the taskbar
icons in 3 button mode. Hence this extra flag seems redundant and breaks
Transient Taskbar, which allows unstashing taskbar over IME

Test: Install 3P keyboard, swiping taskbar up over IME still shows icons
Test: Connect physical keyboard, icons still hide in 3 button nav when
the IME switcher is showing
Fixes: 264723145

Change-Id: Iafb89e765668d70a1bfad2e136957a2ef8924514
2023-01-27 17:24:46 +00:00
Luca Zuccarini 2098381808 [Toast] Introduce SysUI's animation library to the transition manager.
Bug: 250588519
Test: manual, see videos in bug
Change-Id: Iccc440c95ecc14d39e35d911798e239b698b950a
2023-01-27 13:49:40 +00:00
Stefan Andonian 713517ee65 Load home properly even if AllSetActivity fails Go To Home Swipe.
If the user swipes to go home before the Launcher can startup properly,
the user will be stuck on a black screen after swiping up to go home
after reaching the AllSet page after completing the setup wizard. This
change forces the device to go home if the go to home swipe is going to
fail (aka if the Launcher hasn't finished initializing).

Bug: 261901912
Test: Manually verified the device doesn't get stuck like before. UX is
not perfect since the Launcher still needs to load for a few hundred
milliseconds, but the user doesn't get stuck on a black screen.

Change-Id: I8590e7ec1e341ba17db853900de7186284b07e93
2023-01-26 22:03:15 +00:00
Hongwei Wang 3f3ae45154 Refactor to use the PipContentOverlay
Use the same PipContentOverlay in Launcher as in WMShell, this should
further make it easier to experiment the app icon overlay (solid
background with app icon as an overlay).

Bug: 265998256
Test: Enter PiP from Google Maps, ensure the content overlay works
Change-Id: I1ce008700da44bdc28b9515e03aeb3c9c9633f59
2023-01-26 13:33:09 -08:00
Bryce Lee 29953016ac Merge "Do not allow system gestures when dreaming." into tm-qpr-dev am: 3a0e420e6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968629

Change-Id: I1b74df97bd786656d308519248ba416c542ed88f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-26 21:27:02 +00:00
Bryce Lee 3a0e420e6f Merge "Do not allow system gestures when dreaming." into tm-qpr-dev 2023-01-26 21:08:59 +00:00
Winson Chung 39def7300e Fix issue with floating rotation button being in the wrong corner (launcher)
- Add option for the rotation button to be positioned to the right
  when in ROTATION_0

Bug: 265197526
Test: atest FloatingRotationButtonPositionCalculatorTest
Test: foldable-folded (floating rot button in sysui, natural rot=rot_0)
      foldable-unfolded (floating rot button in launcher, natural rot=rot_0)
      tablet (floating rot in launcher, natural rot=rot_270)
Change-Id: I856a0be2e10fceb34254cd58ceb58dfa8a1819bd
2023-01-26 20:41:54 +00:00
Tony Wickham b9ecff07e4 Fix TaskbarBackgroundRenderer not being applied correctly in 2 cases
- Rename isInAppAndNotStashed to areTaskbarIconsVisibleAndNotStashing,
  and check taskbarViewController.areIconsVisible() accordingly. This
  effectively handles the same as before, but also handles Overview,
  which is not inApp but does have areIconsVisible()
  - This fixes bubble scrim over overview taskbar, as well as showing
    taskbar background behind assistant in 3 button mode.
- Also fix nav bar button dark density changing when applying the
  separate background for assistant

Test: Open bubble and invoke assistant in overview, over IME, inside
an app, over home
Fixes: 266715337

Change-Id: Ie655de7abd1634e2165543d57664d7c7e054a986
2023-01-26 00:53:01 +00:00
Schneider Victor-tulias 48f3ee9e06 Update the gesture nav tutorial to use a mock transient taskbar
These are temporary UI updates until the redesigned gesture nav tutorial is ready.

Fixes: 265857697
Test: ran tutorial on large screen device
Change-Id: I3e50de1b0f5cd9e84dccea17c7ac07d3668e1168
2023-01-25 11:12:04 -08:00
Jagrut Desai 98cea8165d Add divider line into taskbar.
Test: Visual(Pics in buganizer)
Bug: 265347148
Change-Id: Ia2fbd5f0938b7eed520652573f4aca5346685429
2023-01-25 10:09:26 -08:00
Bryce Lee 05c9d551d8 Do not allow system gestures when dreaming.
Currently, TaskBar expansion is allowed when an activity context is
available. Since Dreams are implemented as an activity, this leads
to being able to expand the TaskBar over a dream. This changelist
updates the logic to not allow system gestures when dreaming.

Test: manual
Bug: 265755700
Change-Id: If58608c1e491da7906a2615681da0514fa49cfc8
Merged-In: If58608c1e491da7906a2615681da0514fa49cfc8
2023-01-25 17:15:18 +00:00
Azhara Assanova bf0e65a6e9 Add a no-op flag to mutable implicit PendingIntents
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the intents passed into
getPendingIntent() can be both explicit and implicit, so we added
a no-op FLAG_ALLOW_UNSAFE_IMPLICIT_INTENT to bypass the above block of
mutable implicit PendingIntents.

The flag is introduced in ag/21018466.

Bug: 236704164
Bug: 229362273
Test: TH passes
Change-Id: Ia26c8f92d1b4b50e04bc6b487619f54efc7d5a1d
2023-01-25 15:39:35 +00:00
Tracy Zhou fc47142fbe Merge "Revert "Swipe-up from the bar area on the home screen should pull up overview"" 2023-01-25 07:59:10 +00:00
Tracy Zhou 16938d35a9 Revert "Swipe-up from the bar area on the home screen should pull up overview"
This reverts commit c5985751c4.

Reason for revert: Confirmed with Manasi that we don't want to have a different behavior for the trackpad gesture even if it starts from the task bar area. It should be treated the same.

Change-Id: I5817c477968545e452d7600d43825209e2c75c37
2023-01-25 07:58:45 +00:00
Fengjiang Li 41d2aa4db3 Merge "Predictive back: widget to all apps" into tm-qpr-dev am: e73db2a011 am: c5a715f531
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968630

Change-Id: I06791cb598cb1be27a285ae98812650fe3ceffec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 06:46:16 +00:00
Fengjiang Li c5a715f531 Merge "Predictive back: widget to all apps" into tm-qpr-dev am: e73db2a011
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968630

Change-Id: I8b4fb27d441dc449873bfe95ef40a047805bf3d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 05:59:56 +00:00
Bryce Lee fdd410dec7 Merge "Do not allow system gestures when dreaming." 2023-01-25 00:19:16 +00:00
Evan Rosky 1d2abb366d Merge "Revert^8 "Enable Shell Transitions"" 2023-01-25 00:08:16 +00:00
Fengjiang Li 6bb8d79549 Predictive back: widget to all apps
This CL adds a layer of OnBackPressedHanlderRouter to Launcher:
1. 4 OnBackPressedHandler(s) are added in such order: auto cancel action mode handler, drag handler, view handler and state handler
2. first handler who can handle back will handle the entire back gesture
3. Let WidgetsFullSheet to handle widget to all apps transition

Bug: b/260956481
Test: manual
Change-Id: Idbce3dcec746226dd68aaabaddc8fe01334e9673
2023-01-24 15:51:46 -08:00
Schneider Victor-tulias cd09b276c5 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev am: 74484f4a99 am: 86fbe3c7ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680308

Change-Id: I8c6e5b7431631ce5577dc6ba8435d607fc3bc883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 19:32:52 +00:00
Schneider Victor-tulias 86fbe3c7ea Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev am: 74484f4a99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680308

Change-Id: I53c04f6c97087528d18af02e7f8f3842851f9dc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:24:01 +00:00
Alex Chau a4dbf074f5 Merge "Destroy taskbar if it's not present in DeviceProfile" into tm-qpr-dev am: 1103195e42 am: a06576bc36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060664

Change-Id: Ic7baad6b4dea7d231ba7635ffebdfd3815526a84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:06:22 +00:00
Ats Jenk 0cba2dc700 Merge "Fix flicker when opening transient taskbar" into tm-qpr-dev am: 5858226f02 am: 0800534b21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21077864

Change-Id: I9b2a1a299e58cdef39229e4eeb872d04c1db253b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:04:01 +00:00
Schneider Victor-tulias 74484f4a99 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev 2023-01-24 17:55:54 +00:00
Alex Chau a06576bc36 Merge "Destroy taskbar if it's not present in DeviceProfile" into tm-qpr-dev am: 1103195e42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060664

Change-Id: I35f6f8a8773a60e358bf68bbcb7b93d7467d03c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 17:38:51 +00:00
Ats Jenk 0800534b21 Merge "Fix flicker when opening transient taskbar" into tm-qpr-dev am: 5858226f02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21077864

Change-Id: I3a8676ce00fce6e1859600045aeec447f6a7a55e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 17:38:10 +00:00
Alex Chau 1103195e42 Merge "Destroy taskbar if it's not present in DeviceProfile" into tm-qpr-dev 2023-01-24 17:35:37 +00:00
Ats Jenk 5858226f02 Merge "Fix flicker when opening transient taskbar" into tm-qpr-dev 2023-01-24 16:59:00 +00:00
Bryce Lee 31e90481d1 Do not allow system gestures when dreaming.
Currently, TaskBar expansion is allowed when an activity context is
available. Since Dreams are implemented as an activity, this leads
to being able to expand the TaskBar over a dream. This changelist
updates the logic to not allow system gestures when dreaming.

Test: manual
Bug: 265755700
Change-Id: If58608c1e491da7906a2615681da0514fa49cfc8
2023-01-24 03:59:38 +00:00
Ats Jenk 1668aeca49 Fix flicker when opening transient taskbar
When transient taskbar is opened, launcher state updates to background
and then quickswitch. Quickswitch launches the last task which is the
DesktopTaskView when desktop tasks are visible.
DesktopTaskView launchTasks is called which ensures that desktop tasks
are visible on top again and launcher state updates to normal.
If launcher state moves to normal with animation, the task views for any
visible desktop task flicker on screen. To remove this flicker, stop
animating state transitions when moving from DesktopTaskView back to
home screen.
This can be readdressed when implement a proper recents animation.

Bug: 263264985
Test: enable transient taskbar, put some tasks on desktop,
  swipe up to show transient taskbar, observe no flicker
Test: have some tasks on desktop, swipe up to overview, click on desktop
  tile, observe they are brought to front
Change-Id: I6ee5c55d9b805d6ef6d58ea137e697ccd40cda29
2023-01-23 16:59:54 -08:00
Sunny Goyal d77858ecd9 Merge "Moving all intent receiver register calls to a single place" into tm-qpr-dev am: e1daf91dfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20933568

Change-Id: Iaf7284b1aa81da22d223ee0af4cdc8ec1cf45656
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 00:58:02 +00:00