Commit Graph

11086 Commits

Author SHA1 Message Date
Luca Zuccarini 07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Winson Chung 98fbe25da9 Try to handle side-task launches even if not fully transitioned to overview
- The launcher state does not transition from Background -> Overview
  until the overview animation finishes, and if a side task is launched
  before that happens, then we receive onTaskAppeared() but
  isInLiveTileMode() is false, which results in a state where no
  animation of the side task surface is run, and the recents animation
  is not finished.  In these cases, if we've already calculated the
  end target is RECENTS, then we can still animate the side task
- Adding some more gesture logs to indicate side task launched (or didn't)

Bug: 279114961
Test: Go to overview and launch next task

Change-Id: I23eac8721da801f14cc95fc6781a0ef9f0355cc0
2023-05-25 06:14:53 +00:00
Jordan Silva 135adf3d90 Merge "Fix TaskView bind and orientation state called multiple times" into udc-qpr-dev 2023-05-24 23:28:39 +00:00
Vinit Nayak 57de6565a0 Resize mRemoteTargetHandles when RecentsAnimationStarts
* TopTaskTracker gets updated too late after we've exited
split screen so we can't use that to determine how many
RemoteTargetHandles to use
* We default to 2, and then scale it down to 1. Because we
modify the array holding the handles directly, it should
also get updated in AbsSwipeUpHandler
* Temporary solution to stop setting up RecentsView if we detect that
TopTaskTracker has incorrect data and re-setup when we get
onRecentsAnimationStart()

Test: Tested quickswitch in gestural and recents button
double tap in button nav.
Bug: 236226779
Flag: none

Change-Id: I1bae7aed1f8712ddd1bf496acfcb851c0e32a115
2023-05-24 16:26:33 -07:00
Tracy Zhou 24bbc6a577 Merge "Animate expansion of notification panel before ACTION_UP" into udc-qpr-dev 2023-05-24 20:29:18 +00:00
Jagrut Desai ab7ea8a07a Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev am: 990aef6c00 am: 97ec1855a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23220591

Change-Id: I410846f848704b706afb6af4d1b5718cbf0062f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-24 19:05:03 +00:00
Schneider Victor-tulias 9a7de100f4 Update gesture nav edu motion and colors
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
2023-05-24 18:36:39 +00:00
Jagrut Desai 990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Schneider Victor-tulias 8f26e47736 Fix keyboard quick switch d-pad left/right traversal direction
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 284156698
Test: tried keyboard quick switching with d-pad left/right in rtl/ltr
Change-Id: Idb7466b316cb7cbd9f592c5949d2c95c3278d85f
2023-05-24 10:04:05 -07:00
Jordan Silva 8554f90ea6 Fix TaskView bind and orientation state called multiple times
DWB toast initialization is being called 3 times for every TaskView. Twice during the TaskView bind (setOrientationState and bind), and for every TaskView loaded in applyLoadPlan the bind and the setOrientationState are invoked. This CL removes the excessive calls in the TaskView bind and applyLoadPlan.
The DWB for the focused task view is still being called twice due to orientation update for the focused task.

Bug: 281980412
Flag: N/A
Test: atest DigitalWellBeingToastTest
Change-Id: Id301b53b9cb0dfc23a81debec67a6de9a35485b9
2023-05-24 16:29:54 +00:00
Andreas Agvard eea784aea8 Adds an flag guarded extension point for long press nav handle behavior
Bug: 282993230
Flag: ENABLE_LONG_PRESS_NAV_HANDLE disabled
Test: Manual

Change-Id: I541886cc13af1db46bc38d4e18556be99bef7713
2023-05-24 16:24:42 +02:00
Luca Zuccarini 5a5b110030 Merge "Remove redundant instances of depth controller." into udc-dev am: f898ee474c am: 100ea1d75a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23390637

Change-Id: I8633d53d08a053bf552b307ad546efc9a999a28e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-24 13:02:12 +00:00
Luca Zuccarini f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Tracy Zhou 942a8b996f Animate expansion of notification panel before ACTION_UP
Fixes: 280335619
Test: Make sure that the notificaton shade can be pulled down before ACTION_UP
Change-Id: Ib29b17e4d8e42391e5ec46f230226debe0cc1186
2023-05-23 22:58:45 -07:00
Mady Mellor 6dea6d1624 Modify Taskbar code to accommodate bubble bar gesture to stash/unstash
* Bubble bar typically follows the behavior of taskbar - if taskbar
  is shown, the bubble bar is shown, if taskbar hides, bubble bar
  hides.
* The bubble bar has 3 states: stashed, collapsed (unstashed but
  the bubbles are not expanded), and expanded. When bubbles are
  expanded, this means WMShell is rendering the bubble
  expanded view. In this situation taskbar becomes collapsed.

Bug: 253318833
Test: manual - flag turned on - see go/bubble-bar-tests
Test: manual - flag turned off:
             - launch an app, ensure taskbar is stashed
             - unstash taskbar, drag down on taskbar, ensure it
               becomes stashed
             - be in an app, unstash taskbar, interact with the app,
               ensure taskbar is stashed
             - be in an app, unstash taskbar, select an app from it,
               ensure taskbar is stashed & app is opened
Flag: WM_BUBBLE_BAR
Change-Id: I7b481d768182c8429160ab4a9b213b885a7d78bc
2023-05-23 14:02:50 -07:00
Jagrut Desai 5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Luca Zuccarini a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Tony Huang 7bae2b82ef Merge "Hide divider immediately if going to launcher" into udc-dev am: 2d586455dc am: 645158f067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23368297

Change-Id: I89962cb8501423c7d365e9d145ed97c8ad003ae3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 04:15:09 +00:00
Yunfan Chen 0135f1748b Merge "Migrate the insetsRoundedCornerFrame to InsetsFrameProvider" into udc-qpr-dev 2023-05-23 04:01:39 +00:00
Tony Huang 2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Treehugger Robot 3550f03c8d Merge "Adding debug tracing for b/262282528" into udc-dev am: 25e94ccb1b am: 8f9cc84297
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23359117

Change-Id: I187c7b00e47d3a67f748e2d9c250e6ee77d44e53
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 00:17:29 +00:00
Vinit Nayak 69ee1b9caf Handle fullscreen app launchs in split init flow for SplitSelectDataHolder
* SystemUi split APIs are overloaded to launch fullscreen tasks
as well, break that out into a separate method for clarity
* Have SplitSelectDataHolder also special case fullscreen launches

Bug: 283045822
Test: Launched various combinations of split tasks,
also tapped on initial view to see fullscreen launch with tasks
and intents
Flag: none

Change-Id: If3de9784b72e0f5f27f1b6d97cbf835b8f5391de
2023-05-22 16:30:04 -07:00
Treehugger Robot 25e94ccb1b Merge "Adding debug tracing for b/262282528" into udc-dev 2023-05-22 22:48:47 +00:00
Schneider Victor-tulias 1ba474a657 Merge "Update BorderAnimator to work with layout updates" into udc-dev am: b323851e01 am: 56ae9055d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23320817

Change-Id: I6fd06cab51198d0ba440eea5cb235ecebb6ee1b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 21:52:13 +00:00
Liran Binyamin 5cc006da6a Don't create the bubble bar controllers if the bubble bar view does not exist. This fixes a crash that happens when changing navigation modes.
Bug: 269670598
Test: Tested manually on a physical device
Change-Id: Ifd75418eb969b5d1de8625c0b9ff8884f8005ec5
2023-05-22 17:28:39 -04:00
Schneider Victor-tulias 28821554ac Merge "Fix redesigned gesture nav jank" into udc-dev am: bd0188abd1 am: 3a32a4d20b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267694

Change-Id: I19b409a952d0e88f19846ed87951921fa50c117a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:23:56 +00:00
Schneider Victor-tulias b323851e01 Merge "Update BorderAnimator to work with layout updates" into udc-dev 2023-05-22 20:17:35 +00:00
Schneider Victor-tulias bd0188abd1 Merge "Fix redesigned gesture nav jank" into udc-dev 2023-05-22 19:01:35 +00:00
Jagrut Desai dbd4079ec1 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev am: 6acf350107 am: a6b655ade5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23269396

Change-Id: I5d38212bba1fe03243364f3e14490344553c68e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 18:38:46 +00:00
Schneider Victor-tulias 7dee27f470 Update BorderAnimator to work with layout updates
1. if a 'ViewScaleTargetProvider' is being used, this can cause a crash
2. otherwise, the old border bounds are reapplied, which is likely no longer correct

Updated BorderAnimator to use 'BorderAnimationParams' rather than 'ViewScaleTargetProvider'. This removes some unnecessary null checks while making the util class simpler to use. It also allows us to listen for specific view events for the border animation.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 283272516
Test: opened the keyboard quick switch view and highlighted a view in recents view, then rotated the screen several times
Change-Id: I7959d6cd892ebcdd2c68163dd56c358815494af6
2023-05-22 11:33:57 -07:00
Tracy Zhou faa2fa0285 Merge "[Trackpad] Gesture navigation in 3-button mode" into udc-qpr-dev 2023-05-22 17:52:04 +00:00
Jagrut Desai 6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Treehugger Robot 7eeaae488e Merge "Add developer option to tweak All Apps from Overview threshold." into udc-qpr-dev 2023-05-22 16:06:42 +00:00
Tony Huang 2083c5450d Hide divider immediately if going to launcher
Divider should hide immediately when going to launcher, this fix
the divider hidden delay in 3-btn-nav mode.

Fix: 283058496
Test: manual
Test: pass existing tests
Change-Id: Ia4eaba8020c564cc95b8652fe0f7066b653b9df4
2023-05-22 16:38:14 +08:00
Tracy Zhou 6a71c2a6f5 [Trackpad] Gesture navigation in 3-button mode
Back gesture will be in a separate change

Bug: 279948218
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/0b8e838a-89b0-4451-ad44-df2916db877d
Change-Id: I1f14ca873efa33684e36ac1f0f72d766815752ae
2023-05-21 22:45:37 -07:00
Jon Miranda d88ce20005 Merge "Fix SUW unstash animation." into udc-dev am: 9e0eee3729 am: bdb4531729
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23352149

Change-Id: I38e1d23e36c9e67d5bdd3cd273b6e6573d145945
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 21:00:10 +00:00
Jon Miranda 9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda 0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
vadimt 144a9508be Adding debug tracing for b/262282528
We see two long-clicks on the taskbar instead of expected one.

Bug: 262282528
Test: presubmit
Change-Id: I231d54ac08cf53ac7b0b6177da6b671314998021
2023-05-19 17:04:04 -07:00
Jagrut Desai 709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Andy Wickham af5bb30141 Add developer option to tweak All Apps from Overview threshold.
Ability to move threshold from shift 1.05 to 5.0. Saved as an int
from 105 to 500. Shift 1.0 is where Overview rests; using this
value exactly causes a slight glitch while settling.

Demo (slightly outdated min value and flavor text):
https://drive.google.com/file/d/1PaS4MjFM1P9ZHQ-400tXUbDz_-z8qYtC/view?usp=drive_link&resourcekey=0-ZX-ofW4AzN0-Qjqo4OmU-g

Bug: 281717218
Test: Manual
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: I5acfb46f9df16e9d3091a7822c449301bc6067f9
2023-05-19 21:26:35 +00:00
Achim Thesmann ab66d1461d Allow BAL in Launcher
Widgets like Google News were blocked when they tried to start
background activities on non-Pixel devices that use Launcher3.

Bug: 281617254
Test: manual test
Change-Id: I2b68aeafd0d1dce7b37428dcada58d2648e57681
2023-05-19 21:05:56 +00:00
Vinit Nayak c83f94cde3 Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev am: 258019fe8e am: 1f27273c06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23320818

Change-Id: I11104b119109468f3b0984fb670b6196c418b97d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 18:43:42 +00:00
Vinit Nayak 258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Luca Zuccarini 2449a01b22 Add a view type check to ensure the right animation is used.
Bug: 265134143
Test: recorded perfetto trace, see bug
Change-Id: If6abc36f0f43c6bb632fc824c19717c1231b32dc
2023-05-19 09:51:15 +00:00
Hongwei Wang ba46fe8f94 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev am: 0c66b151e3 am: 2ef78aa7d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23321279

Change-Id: I65f500cbd7280ec09b7feeef096c74b7372c7454
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 01:03:33 +00:00
Saumya Prakash ae2aab9217 Merge changes If2c82082,I03532b80 into udc-dev am: 66e7ec721b am: 1b12262d07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23159151

Change-Id: I31b599f7b1e3cd4a3ed6dc659ba9b3f5b258334b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 23:13:58 +00:00
Hongwei Wang 0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Ats Jenk 7377639653 Merge "Show a persistent toast when selecting desktop apps on home screen" into udc-qpr-dev 2023-05-18 22:24:26 +00:00
Saumya Prakash 66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00