Commit Graph

11086 Commits

Author SHA1 Message Date
Sunny Goyal ee9740462e Simplifying some test utility methods
Bug: 283821111
Test: Presubmit
Flag: N/A
Change-Id: I7b9690bc0cc53d097d26cd4f0ab2dd36ba88e1cb
2023-06-02 13:30:55 +00:00
Santiago Aboy Solanes 0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Treehugger Robot 329f11180d Merge "Create separate fullscreen launch type for shortcuts" into udc-dev am: 55f38fb397 am: 0189f4454a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23480181

Change-Id: I79987e6f9f237cbaf2f2a4317e93506fe216b7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 06:37:06 +00:00
Treehugger Robot 55f38fb397 Merge "Create separate fullscreen launch type for shortcuts" into udc-dev 2023-06-02 05:22:23 +00:00
Anushree Ganjam 87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00
Anushree Ganjam 9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Vinit Nayak 748bbe46a5 Merge "Skip drawing taskbar background in setup" into udc-dev am: e65bf2a620 am: c037eb916c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23481079

Change-Id: I4d9793f98148910b0f2414c292f5c6be7cabf5aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:36:41 +00:00
Vinit Nayak e65bf2a620 Merge "Skip drawing taskbar background in setup" into udc-dev 2023-06-01 23:13:19 +00:00
Anushree Ganjam 97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Sunny Goyal cbb13841f5 Merge "Revert "Add hover state border line to overview task item by usi..."" into udc-qpr-dev 2023-06-01 21:39:15 +00:00
Sunny Goyal 8dbdd3d702 Revert "Add hover state border line to overview task item by usi..."
Revert submission 23378417-cherrypick-overview-border-249859410-786docmioso

Reason for revert: flaky implementation

Reverted changes: /q/submissionid:23378417-cherrypick-overview-border-249859410-786docmioso

Change-Id: I6792fc25dbbd80db24df93ebd7a974b0dc0ba5d5
2023-06-01 21:29:13 +00:00
Sunny Goyal 3e596d3aa4 Updating the top scrim to also use dynamicaly generated bitmap
Bug: 237818532
Test: Verified on device
Flag: N/A
Change-Id: I22ceb470677ab9df53e40fb78f0292b7fd5e2241
2023-06-01 19:20:04 +00:00
Vinit Nayak 5364b0dac9 Skip drawing taskbar background in setup
Test: Manually went into SUW and observed
Fixes: 272674390
Change-Id: I102d1433692793f51d930e710d68134d4536c397
2023-06-01 10:52:39 -07:00
Sunny Goyal 50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Helen Cheuk ed4c2acf58 Merge "Add hover state border line to overview task item by using the same approach used by keyboard focus state" into udc-qpr-dev 2023-06-01 15:45:01 +00:00
Nick Chameyev c1eafd92ab Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-qpr-dev 2023-06-01 12:55:27 +00:00
Jagrut Desai 9edf316ca3 Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev am: e208e02aba am: 3d630fdddb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455641

Change-Id: I4b47b8d6304830311eef6545ee08bfee51554269
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 21:26:47 +00:00
Jagrut Desai e208e02aba Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev 2023-05-31 20:45:37 +00:00
Schneider Victor-tulias fc32303ebf Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev am: 8f95307087 am: 9dd8eacd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23375885

Change-Id: I7b6cfeb031aefc61441a030aac15d2674ef83b1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 19:20:54 +00:00
Schneider Victor-tulias 8f95307087 Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev 2023-05-31 17:49:35 +00:00
Jagrut Desai 84e959a72a Fixing Toast Hiding behind Taskbar - Part 2
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
Nick Chameyev 6d756970e7 [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-05-31 17:12:08 +00:00
Kateryna Ivanova 72fbdc7976 Merge "Migrate Interpolators from Launcher3 to the public animation library" into udc-qpr-dev 2023-05-31 15:25:40 +00:00
Vinit Nayak 9cea469bc9 Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev am: 52ac882e9b am: 7916ab1e26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267214

Change-Id: Ib0895dfd51575b5e43cb60c73c28a5c047eb9c51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 23:39:52 +00:00
Vinit Nayak 52ac882e9b Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev 2023-05-30 22:10:28 +00:00
Vinit Nayak 8852010eb8 Create separate fullscreen launch type for shortcuts
Bug: 283045822
Test: Verified via debugger the right API is called,
still have issues on split side
Flag: none

Change-Id: Ic2fcbf4ffe05503b0c2e1fade3e3e990498cf6cf
2023-05-30 13:43:24 -07:00
helencheuk 64975ae992 Add hover state border line to overview task item by using the same approach used by keyboard focus state
Reviewed TAPL DD: https://docs.google.com/document/d/1OmCLgTDw3gFOMXjEvH0W1XoAe0n2J5pPdyMcAHtflMA/edit?resourcekey=0-bXle-rOnQqOR_RJBffRybQ
Fix: 249859410
Test: OverviewTaskImageTest

Change-Id: Ic9ce4e9fe90f38a4bf4be6c7deed302a12a3192a
2023-05-30 21:30:14 +01:00
Brian Isganitis 1f2919d634 Merge "Fix how task stack listener closes overlays on task changes." into udc-qpr-dev 2023-05-30 19:21:15 +00:00
Stefan Andonian 4439bec7aa Merge "Use LockedUserState in TouchInteractionService." into udc-qpr-dev 2023-05-30 18:55:02 +00:00
Tracy Zhou 073a04f639 Merge "Simplify trackpad multi-finger gesture recognition logic for gesture nav" into udc-qpr-dev 2023-05-30 16:38:16 +00:00
Kateryna Ivanova 7120373bbc Migrate Interpolators from Launcher3 to the public animation library
Test: atest
Bug: 271850966
Change-Id: Iba999f2e753764a37d35e508e707df02388432e9
2023-05-30 07:20:38 +00:00
Tracy Zhou 48ac5a0f74 Simplify trackpad multi-finger gesture recognition logic for gesture nav
Now we can use AXIS_GESTURE_SWIPE_FINGER_COUNT per ag/23288416

Test: swipe up to overview / home; workspace scroll 2-finger only / quick switch/ pull down notifications works
Bug: 284463803
Change-Id: Ie1c7d13f4683d3b9c8de6e5ea2821df73b97ca29
2023-05-27 21:16:25 -07:00
Achim Thesmann 5644e3f1fd Merge "Allow BAL in Launcher" into udc-dev am: 2bcfbd3739 am: fc6ffba0bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23342819

Change-Id: I0773e3c7123af7066eec8e29c5bc9c8fc40c4c59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-27 19:18:44 +00:00
Achim Thesmann 2bcfbd3739 Merge "Allow BAL in Launcher" into udc-dev 2023-05-27 17:48:16 +00:00
Ats Jenk 40f9151ff0 Merge "Support alt+tab for desktop tasks" into udc-qpr-dev 2023-05-27 05:52:46 +00:00
Vinit Nayak 23bded7f62 Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev am: ed7b50efee am: 6641699a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23379363

Change-Id: I3bc803af7929974bef8bba5c22831f8020adb173
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 23:47:06 +00:00
Ats Jenk 3067874559 Support alt+tab for desktop tasks
Updates keyboard quickswitch logic handle quickswitching while on
desktop. When on desktop, alt+tab moves only between desktop tasks.
Fullscreen tasks are shown in the overflow tile and can be accessed by
going to overview.

TODO:
- when not in desktop and using quickswitch, show the desktop tile as a
  combined tile in the row, similar to what is shown in overview

Flag: persist.wm.debug.desktop_mode_2
Bug: 280468885
Test: open some apps on desktop and have some fullscreen apps opened in
  the background, when on desktop, observe that alt+tab only switches
  between desktop tasks
Test: same setup, but switch to a fullscreen app, observe that alt+tab
  only switches between fullscreen tasks and desktop is accessible from
  overview

Change-Id: Ib19f2eaa24363bbd0669c8c8c3d99ed9d9118a17
2023-05-26 15:38:58 -07:00
Schneider Victor-tulias f304ab8e2b Fix launcher activity leak in TouchInteractionService
TouchInteractionService cannot be garbage collected until it has been cleared from the sysui process. Switching to use a WeakReference to help with garbage collection.

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
Change-Id: I37aa5f858f2ae0ac78b46478ab4c5f24770bd64f
2023-05-26 14:39:14 -07:00
Brian Isganitis 34c6b871af Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
2023-05-26 21:04:19 +00:00
Vinit Nayak ed7b50efee Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev 2023-05-26 20:19:19 +00:00
Schneider Victor-tulias 2f3ad0bc36 Merge "Update gesture nav edu motion and colors" into udc-dev am: b4e91b14bd am: 2256dfcec1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23389667

Change-Id: Ibd7edffcc8e3492497ca06008f4ce5e8bc94c183
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 19:57:55 +00:00
Schneider Victor-tulias 1a72f089f8 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev am: 010a55d377 am: 2359172135
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23413644

Change-Id: I348efad29014e088e351368d7fb23934f70edbeb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 19:57:43 +00:00
Stefan Andonian cf36a3f3a8 Use LockedUserState in TouchInteractionService.
This change was previously attempted, but failed because of a tricky issue where the LockedUserState singleton object was getting permanently set to a mock context in LockedUserStateTest, and then was failing TaplTests because isUserUnlocked was always false.

This fixes that by avoiding using the singleton LockedUserState instance in the unit tests.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly. Post-submit was tested and this CL passed all previously
failing tests: https://android-build.googleplex.com/builds/abtd/run/L12900000960898179

Change-Id: I045c9f2558a6bdacb4bfa029fbf6a07c3c190fe7
2023-05-26 17:06:09 +00:00
Schneider Victor-tulias b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Schneider Victor-tulias 010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00
Winson Chung f1815885a4 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev am: a5fb95df57 am: 61a6937e5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23425161

Change-Id: I5c3cc7570cf7d1a7e043f8473361c93d44f183d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 06:04:30 +00:00
Winson Chung a5fb95df57 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev 2023-05-26 04:25:21 +00:00
Luca Zuccarini 5a5560e3d1 Merge "Add a view type check to ensure the right animation is used." into udc-dev am: 07c3491ec2 am: 1de059dbeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22433062

Change-Id: I7cca0f7a47cd265137f0006b76fee37eedac861a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:48:28 +00:00