* Previously we defaulted to 2 handles, but we didn't take into
account the posibility of having assistant showing a translucent
task on top of 2 apps. Or other tasks such as Home controls.
* We can scale down the number of handles we have from
initialization (as done in assignTargetsForSplitscreen), but it's
a bit harder to scale up. This is a separate, larger problem in
that the handles are created and needed before onAnimationStart(),
so Launcher doesn't know exactly how many handles are needed to be
created for the recents animation, that's determined by the actual
onAnimationStart() call itself.
* There's a small known bug only in the split case where one of
the tasks shows up over the assistant task, but can live with that
to minimize changes. (peanutbutter@ to clarify?)
Demo: https://drive.google.com/file/d/1hqipfdym_rRXFsAW932es7UdxTx66Zu4/view?usp=drive_link&resourcekey=0-Ri_Kl0xCNN3E81StTh4vxw
As you can see, Assistant translucent overlay seems to work well,
but there are still some glitches with Home controls. Specifically,
there is a flicker, sometimes followed by a black screen, when
returning to the split tasks with Home controls open on top. The
flicker also happens with Assistant, but I haven't seen the black
screen for that case yet. In any case, the crash is avoided, so...
progress? (Also these flickers/black screen happen for Home controls
even without splitscreen).
Original change by peanutbutter@: ag/24830632
Test: Tested assistant result tasks with fullscreen and splitscreen,
and by itself. Seems to animate fine. Also tested with Home controls,
which animates fine and avoids the crash, but still has some issues
when re-opening the tasks as described above.
Flag: NA
Bug: 321328009
Change-Id: I0aa04a6a14cf723b34431855483662039c96e553
Bug: 230395757
Test: Factory reset in unfolded. Check bar sampling. Fold and swipe up from an app different from system color to overview. Observe the bar color change.
Change-Id: I7d94a3a8f17a40fbabd4d65629846eb12bdbd3d6
* If we start split from allApps or workspace and then go into
workspace, clear all button was previously showing since it's
only hidding via state manager transitions
* Modify the normal Overview LauncherState to provide a split
translation when we are in contextual and have already selected
the first app in split
Fixes: 296006310
Test: Manually started from overview and workspace,
grid tiles look correct, no clear all button
Flags: aconfig com.android.wm.shell.enable_split_contextual
Change-Id: I8630ce7297119392bb0abb07cdb39592eabf129a
Instead of dealing with changing dark theme which can lead to races
with stale Taskbar icons, instead just go home and launch the IME
activity. This is sufficient because the taskbar height changes
when going between home and an app, and the IME will stash the
Taskbar during this transition.
Fixes: 320490387
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Flag: None
Change-Id: Ib5b1481751af0bf1fccda085c78174f6612441b9
* Currently unarchival tests only pass for Launcher3. We extend the broadcast receiver to AndroidManifest-common to also support NexusLauncher tests.
Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I9be459a2a0648063d62538eed20c0a6e7644ad44
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.
Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
* Ideal animation TODO, this is to help
unblock for now.
Flag: Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Test: With flag on and off, from home, overview, all apps
Bug: 296351434
Change-Id: Ida743a881519796ed8ce3e5966aa708c84521c51
These modules fail to compile when use_resource_processor is enabled
by default, disable them explicitly for now.
Bug: 319712088
Test: m javac-check
Flag: NA
Change-Id: I0f7ee108aab802ee1882f8017ea4b47346e38683
Devices with a square aspect ratio were previously seeing a prompt to rotate the screen for the gesture navigation tutorial. This change enables the tutorial for such devices but will still show the prompt to rotate the device if the aspect ratio would make the tutorial animations look wrong.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fix: 321650001
Test: Tried gesture tutorial on various devices of different aspect
ratios and ensured that the prompt to rotate the device only shows up on
devices that do not have a square aspect ratio.
Change-Id: I7a6ca40e09a8202a9b54d898e0c68cc142694342
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.
Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
Test: Presubmits passing, checked cases manually. No automated checking
because it is an animation bug.
Fix: 316992943
Flag: NA
Change-Id: Ieb19571d081ba894842322ba77e76c31db57b98e
When system language is set to an RTL language, we move the bubble bar
to the left.
Move the stashed bubble bar handle to the left in this case.
Tweak the bubble bar expand animation so that the bubbles expand from
the left edge.
Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: repeat following steps with LTR and RTL system languages
- add couple of bubbles to bubble bar, open an app, observe stashed
handle on the left
- swipe up from system navbar to show taskbar and bubble bar
- swipe up from bubble bar handle to show bubble bar and expand it
- drag bubble bar to dismiss target and back out and release
Change-Id: Ia3b7892bba732a5278168d63db0594087f55fad4
Shamali P
Himanshu Gupta
Tracy Zhou
Andy Wickham
Vinit Nayak
Sunny Goyal
Jakob Schneider
Johannes Gallmann
Tony Wickham
Colin Cross
Rohit Goyal
Brandon Dayauon
Sebastián Franco
Uwais Ashraf
Saumya Prakash
Ats Jenk
Holly Jiuyu Sun