Commit Graph

23099 Commits

Author SHA1 Message Date
android-build-team Robot c2f9eee121 Snap for 5876498 from a7a1b57bc8 to qt-qpr1-release
Change-Id: I866d5ec8927a6212cd51532492d91c88d6822cc8
2019-09-14 23:17:16 +00:00
Hyunyoung Song a7a1b57bc8 Merging ub-launcher3-qt-qpr1-dev, build 5872416
Test: Manual

Bug:121280703 P2 Finish implementation of PortraitLandscape annotation for tests
Bug:135633159 P3 [QPR] Promise icons on home screen
Bug:135638690 P1 [QPR] On-device app search
Bug:137106918 P2 UX: Accidental NGA triggering when hitting Undo actions in apps
Bug:137200188 P3 Home screen app title disappears during animation
Bug:138195597 P2 Wrong icon animated on return to home screen
Bug:138396187 P1 Swipe and hold from an app no longer uses spring to animate adjacent task
Bug:138729157 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : want to fling backwards in widgets, flung back, but the current state is not WIDGETS; Unexpected launcher object visible: workspace
Bug:138729456 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug:138964490 P1 Support DeviceConfig to drive ToggleableFlags
Bug:139021165 P2 [TEST TRACKER] [QPR] Promise icons on home screen
Bug:139137636 P2 Create memory tests for Launcher
Bug:139551306 P4 [Polish] Reduce shelf paddings in Overview
Bug:139885365 P3 App open animation different between launcher suggested apps and launcher home screen/drawer
Bug:139918680 P2 [a11y] Talkback shouldn't keep focusing on the background item and speak the description of the background item again after entering Widget list.
Bug:140076379 P1 Launcher ub-launcher3-qt-qpr1-dev Branch Build Keeps Crashing due to Exception
Bug:140252951 P2 Add widget launch test.
Bug:140308849 P2 Jank during swipe up to home, especially noticeable after pausing first
Bug:140311911 P2 Flake in Launcher tests: java.lang.AssertionError: Stable state != state: OverviewState, LauncherState
Bug:140405990 P2 [a11y] Unable to add shortcut to Home screen by Voice access or Switch access.
Bug:140819614 P1 If an install session is abandoned for an already installed app, the corresponding icon is removed
Bug:140823188 P1 AppPredictionsUITests failing
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Change-Id: I1efae6216c53b1fee3e105c9356ed43c4bf46c6e
2019-09-12 15:22:35 -07:00
Pinyao Ting 39216c1533 Fix the issue deep shortcuts cannot be added to workspace via
voice/switch access

Bug: 140405990
Change-Id: Ie54d9c738fc51445f3aa49458ff4fc1dd6e4fc67
Merged-In: Ie54d9c738fc51445f3aa49458ff4fc1dd6e4fc67
(cherry picked from commit 8a739f9511)
2019-09-12 20:33:03 +00:00
Vadim Tryshev de5e5afae5 Merge "Fixing widget tests" into ub-launcher3-qt-qpr1-dev 2019-09-12 20:32:00 +00:00
vadimt 6b3cbf116d Fixing widget tests
Bug: 140837771
Change-Id: If5dcf455b1a87b06c883dd1f0d46c6748e6d1a94
2019-09-12 12:49:59 -07:00
Jon Miranda d6ae55d968 Fix failing test testPromiseIcon_addedFromEligibleSession.
Test: Ran tests on device
Bug: 140819614
Change-Id: I8ee6836d3a06f315518aa4829c8e2ddf8cf5f74d
2019-09-12 16:58:51 +00:00
android-build-team Robot db8d3902b2 Snap for 5869577 from 241cd90203 to qt-qpr1-release
Change-Id: I9013ccb5f59180cad0c9ee3ecdeb97ea82e3375f
2019-09-12 03:22:47 +00:00
Tony Wickham fc520edbc6 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev 2019-09-11 23:42:23 +00:00
Tony Wickham 51f2919815 Replace OnGlobalLayoutListener with StateListener to update predictions
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.

Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
2019-09-11 14:41:52 -07:00
TreeHugger Robot cfdeb06205 Merge "Fix bug where existing icon is removed when install session is abandonded." into ub-launcher3-qt-qpr1-dev 2019-09-11 20:43:36 +00:00
TreeHugger Robot 791dd73217 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev 2019-09-11 20:16:19 +00:00
android-build-team Robot 49e516b148 Merge cherrypicks of [9372739] into qt-qpr1-release
Change-Id: Ib0a6069fd9daa1ad9137d5c80d052ea05250015b
2019-09-11 19:54:56 +00:00
Jon Miranda 9b82a41411 [DO NOT MERGE] Fix NumberFormatException for launcher.
Fix is already in ub-launcher3-master: I5094b22ddc77c45590cea1a5f5dead0dc7580abf

Bug: 140076379
Change-Id: I01948cf71ef2e058dc1ef8c506f174856ee09e0d
(cherry picked from commit d49fe3130e)
(cherry picked from commit 241cd90203)
2019-09-11 19:54:51 +00:00
Jon Miranda 1c247cf451 Fix bug where existing icon is removed when install session is abandonded.
- Ensure we only add promise icons for apps that aren't already installed to
  our internal list of session ids.
- Ensure we only remove promise icons created from the install session when
  that session is abandonded.

Bug: 140819614
Change-Id: I3c93865b5e96a9c7a160154b45a38eb90ac9d183
2019-09-11 12:37:14 -07:00
vadimt 5e742772d0 Adding testing for opening a widget
Bug: 140252951
Change-Id: Ic1c867db602f1890b74e7b539b44b2a440267384
2019-09-11 12:36:46 -07:00
Hyunyoung Song e17a699618 When DeviceConfig/FeatureFlag value is different than the previous
value, refresh icon cache

Bug: 135638690
Bug: 138964490

Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background

Afterwards, saw if "bank" would show BofA app or not

Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
2019-09-11 10:38:14 -07:00
Jon Miranda 241cd90203 [DO NOT MERGE] Fix NumberFormatException for launcher.
Fix is already in ub-launcher3-master: I5094b22ddc77c45590cea1a5f5dead0dc7580abf

Bug: 140076379
Change-Id: I01948cf71ef2e058dc1ef8c506f174856ee09e0d
(cherry picked from commit d49fe3130e)
2019-09-11 16:56:53 +00:00
android-build-team Robot fc89fc0b16 Snap for 5867030 from 151970d535 to qt-qpr1-release
Change-Id: I6599936575b56b690dd1f23adc38c3f92deb2feb
2019-09-11 03:12:28 +00:00
vadimt 599b1fc4d3 Reenabling some widget tests
Bug: 140837771
Change-Id: I437f39b4a7f4b518551a157858c9b1a4812ee65d
2019-09-10 18:37:28 -07:00
vadimt d81f60f324 Disable currently failing widget tests
Change-Id: I2009b9c6f11a698bcf12a0b5ba97f98262fcee54
2019-09-10 13:58:22 -07:00
TreeHugger Robot 8aee0b2cb5 Merge "Ensure the icon load request matches the ItemInfo for the floating view." into ub-launcher3-qt-qpr1-dev 2019-09-10 16:49:24 +00:00
Jon Miranda bdda7251df Ensure the icon load request matches the ItemInfo for the floating view.
This fixes the bug where the wrong icon is present during the app close
animation.

Bug: 138195597
Change-Id: Ife2c6ad135dde54583f6f2bb2caf3b1e9325e064
Merged-In: Ib3767ec5c2b4eb22b35e5148879e11d2c1b28e3c
2019-09-10 15:51:25 +00:00
Sunny Goyal 3600fb7777 Adding support for building a "spring like animation" with precomputed values
Bug: 138396187
Change-Id: Idba323090ecd9aca43c01414a32ab3b2e292e73e
2019-09-09 17:21:53 -07:00
Jonathan Miranda 735d1fe124 Merge "Add tests for play promise icons." into ub-launcher3-qt-qpr1-dev 2019-09-09 21:44:15 +00:00
Miranda Kephart 329cc8c53f Merge "Add distance threshold for assistant gesture fling" into ub-launcher3-qt-qpr1-dev 2019-09-09 21:02:43 +00:00
TreeHugger Robot 01f8fb9132 Merge "Support for getting Launcher Pss by tests" into ub-launcher3-qt-qpr1-dev 2019-09-09 17:02:15 +00:00
vadimt f083b7741a Add one null check to tests
Change-Id: Ib4b50ac06d44b1811e0388bc373fe420fa5570fd
2019-09-06 18:08:22 -07:00
vadimt 2bad570b40 Support for getting Launcher Pss by tests
Bug: 139137636
Change-Id: I8cad7dec07ce400cf927e3fc2ba9904fef942d9a
2019-09-06 16:50:51 -07:00
Jon Miranda 4b9edfbbe5 Add tests for play promise icons.
Bug: 139021165
Change-Id: Ie1a049b283b70f6bd22b43c09aef263282cb0f56
Merged-In: I45469b7523d8aea12c34d460c7b69c571a415675
2019-09-06 21:57:04 +00:00
TreeHugger Robot 243dd30da3 Merge "Add tracing for non-dragging icon" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:57:01 +00:00
Tony Wickham d785fc289c Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:27:41 +00:00
vadimt 30618db33f Add tracing for non-dragging icon
Bug: 138729456
Change-Id: Ib18f1544f2520509bd982f032bf3ed0c72ca9529
2019-09-05 14:08:39 -07:00
Vadim Tryshev b34f951e7e Merge "Adding a test method to get a Launcher object when it becomes non-null" into ub-launcher3-qt-qpr1-dev 2019-09-05 18:49:10 +00:00
vadimt cf61e16a2c Adding a test method to get a Launcher object when it becomes non-null
Change-Id: I1c56777c87827b5edf1c7f55ad9639321e598311
2019-09-04 19:02:54 -07:00
vadimt 8c2efd0de0 Enabling some tests in landscape mode
Bug: 121280703
Change-Id: I285638d832594d5fed26ee812737a4356b110899
2019-09-04 17:33:52 -07:00
TreeHugger Robot e1335c2359 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev 2019-09-05 00:13:30 +00:00
vadimt 758a1d983d Removing flinging via UI Automator
UI Automator loses events. Switching to the homemade scrolling.

Bug: 138729157
Change-Id: Ib09bd5714e83eadfc65b54202867bf375e6b47c5
2019-09-04 16:35:19 -07:00
TreeHugger Robot 1bd96b1e96 Merge "Update app open/close animations." into ub-launcher3-qt-qpr1-dev 2019-09-04 22:33:33 +00:00
Jon Miranda 9b78e190fa Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 21:45:05 +00:00
Vadim Tryshev 846656f138 Merge "Enabling debug tracing for all UI tests" into ub-launcher3-qt-qpr1-dev 2019-09-04 17:52:11 +00:00
Vadim Tryshev 5e893727f8 Merge "Removing numbers from error message" into ub-launcher3-qt-qpr1-dev 2019-09-04 00:54:21 +00:00
vadimt 0ce38af957 Enabling debug tracing for all UI tests
Change-Id: I434ee378baf35de955c8a589b8380e1751e4107a
2019-09-03 17:16:34 -07:00
vadimt 849cdc803d Removing numbers from error message
They interfere with flake clustering

Change-Id: I845b6e080824e00b9442070d53a0a3b448670d67
2019-09-03 17:01:27 -07:00
Tony Wickham bfdeda96e6 Properly prevent All Apps relayouts by avoiding scrollToPosition
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.

This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.

Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout().  If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.

Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
2019-09-03 16:16:54 -07:00
Andy Wickham 90c16ace8a Reduces padding of the Overview shelf in no button mode.
Before: https://screenshot.googleplex.com/iw6baTCfoy2.png
After: https://screenshot.googleplex.com/8CcsQvLhYDo.png
Desired: https://b.corp.google.com/action/issues/139551306/attachments/26925873?download=false

Test: Examined before and after padding and verified 3-button is unaffected.
Fixes: 139551306

Change-Id: Ia416399cf25e7c6c2fb8aa84ad20e7ad74dcd31b
(cherry picked from commit ddc9622e92)
2019-09-03 22:05:20 +00:00
Andy Wickham c40872b913 Marks ScrimView unimportant for accessibility when Widgets screen is opened.
This prevents it from holding focus while the Widgets screen is visible
(after using Widgets action from the All Apps caret thingy).

Test: Manually followed steps provided in bug, and issue not seen after this change.
Fixes: 139918680
Change-Id: I280ac97fb7ff9fa67f1c6a1ce9cdfa9e451231eb
2019-09-03 21:20:22 +00:00
TreeHugger Robot 505a88140e Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:27:11 +00:00
Sunny Goyal a42681f6d2 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:23:18 +00:00
Jon Miranda a8c7c0b713 Only add promise icon if icon is provided in the SessionInfo.
- In some cases, SessionInfo is created without an icon until later on
  in the install process. This prevents promise icons with default Android
  logo from appearing.
- This will also prevent apps without a launching activity from appearing
  as a promise icon and then disappearing when the app is installed.

Bug: 135633159
Change-Id: I30adde8bf2cf583bffca8ed878f9cc20d6d41a13
2019-09-03 08:13:09 -07:00
TreeHugger Robot 78ebf57e9f Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev 2019-08-31 00:55:55 +00:00