Commit Graph

20549 Commits

Author SHA1 Message Date
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Treehugger Robot 4674c3bb2b Merge "Fix NPE in QuickstepTestInformationHandler#getWindowInsets" into main 2024-10-29 20:34:54 +00:00
Treehugger Robot 7112a56ede Merge "Tapping overflow button toggles KQS" into main 2024-10-29 19:56:33 +00:00
Schneider Victor-Tulias 3736f44f8e Fix NPE in QuickstepTestInformationHandler#getWindowInsets
Flag: EXEMPT fixing NPE
Fixes: 28555142
Test: TAPL tests
Change-Id: I722dfe196b93861723ef3de9961f0a30b9056583
2024-10-29 14:27:25 -04:00
Treehugger Robot 62962e65cf Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-29 18:17:34 +00:00
Vinay Joglekar 9859982e0a Merge "Fix icon during split task which is inside DW from taskbar." into main 2024-10-29 14:29:50 +00:00
vinayjoglekar f6a773a476 Fix icon during split task which is inside DW from taskbar.
We don't animate DesktopTaskView into split placeholder to avoid having desktop icon as the split placeholder, which isn't accurate as we're only splitting with a single task rather than the whole desktop.

Test: Manual, split app from taskbar which is in desktop window
Fix: 376002803
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ib62d831b1f0c0ca5ee8f355a15f14baff8ec67ee
2024-10-29 14:29:15 +00:00
Treehugger Robot 9c062e472d Merge "Add a feature flag to toggle DW carousel detach" into main 2024-10-29 14:21:13 +00:00
Bill Yi 11d7806cdd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic07e472cbad23a039bb8a9d8a3db2fd22e08d6b4
2024-10-28 22:56:31 -07:00
Treehugger Robot 5e77702197 Merge "Prevent tap in swipe up zone from closing KQS" into main 2024-10-29 01:57:55 +00:00
Treehugger Robot e6b473a284 Merge "Delete Unused Flag related to Altering how the workspace is loaded." into main 2024-10-28 21:42:56 +00:00
Sukesh Ram 4781b26bf4 Merge "Revert "Fix Taskbar Y-Translation with Visible Bottom Sheet"" into main 2024-10-28 21:42:54 +00:00
Liran Binyamin 6fc00481ab Merge "Allow updating the flyout message" into main 2024-10-28 20:48:45 +00:00
Jagrut Desai d7cb00cfb2 Merge "Fix Taskbar Touchable Region when overview is in split select mode" into main 2024-10-28 17:33:36 +00:00
Randy Pfohl 6dab7bac46 Merge "Enabling Fallback launcher cases" into main 2024-10-28 17:28:58 +00:00
randypfohl 9d7141d1fe Enabling Fallback launcher cases
Test: Locally tested and verified flow for fallback.

Flag:  com.android.launcher3.enable_launcher_overview_in_window

Bug: 365777265

Change-Id: I991a82152b47f2cfb7c1335c699e297b8f53bcf3
2024-10-28 17:28:27 +00:00
Sukesh Ram 99c442b015 Revert "Fix Taskbar Y-Translation with Visible Bottom Sheet"
This reverts commit d82503fc42.

Reason for revert: Introduced crashes

Change-Id: I0956f746e25ccfe655169580fd802d33f99c0652
2024-10-28 17:26:47 +00:00
Treehugger Robot 4a3c23a902 Merge changes I83746510,Ie2aa28cd into main
* changes:
  Fix TAPL OverviewTask to use correct resource to measure height
  Add TAPL test for dismiss DesktopTaskView
2024-10-28 17:18:36 +00:00
Alex Chau edd7ff2fa1 Add a feature flag to toggle DW carousel detach
Fix: 376015547
Flag: com.android.launcher3.enable_desktop_windowing_carousel_detach
Test: manual
Change-Id: I98d4fbb17e8e432c94842c38d83735533d5ea197
2024-10-28 14:29:31 +00:00
Liran Binyamin 35e6157303 Allow updating the flyout message
Add functions to allow updating the contents of the flyout while it
is either expanding or fully expanded.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Iea3fc7df792e02605df6b44c1da39e267f6d9d43
2024-10-28 09:58:37 -04:00
Jordan Silva a244c0b70e Fix TAPL OverviewTask to use correct resource to measure height
The background in DesktopTaskView wasn't added for accessibility, so it couldn't be retrieved from the view hierarchy during e2e tests. This view is necessary to calculate the correct size of the DesktopTaskView.

The changes in this cl:
- Add backgroundView to DesktopTaskView's children for accessibility
- Use the correct snapshot resource for desktop mode in OverviewTask

Bug: 353948500
Change-Id: I83746510849e4013d623d49cbaccebd81daba96d
Flag: EXEMPT bugfix
Test: TaplTestsOverviewDesktop
2024-10-28 12:25:25 +00:00
Jordan Silva 7054095b16 Add TAPL test for dismiss DesktopTaskView
This CL adds 2 new E2E Tapl tests for checking dismiss DesktopTaskView.
- dismissFocusedTask_thenDesktopIsCentered validates the following scenarios:
  - Scenario: When Focused Task is in the center of the screen, with 1 other task in the grid and 1 desktop task.
  - When focused task is dismissed, the next task in the grid takes its place to be the next focused task at the center of the screen.
  - When the last focused task is dismissed, the desktop task takes its place at the center of the screen.

- dismissDesktopTask_thenFocusedTaskIsCentred validates the following scenarios:
  - Scenario: When Desktop Task is in the center of the screen, with 1 focused task and 1 task in the grid.
  - When focused task is dismissed, the next task in the grid takes its place, adjacent to desktop task.
  - When desktop task is dismissed, the focused task takes its place at the center of the screen.

Fix: 353948500
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Ie2aa28cd2b30a2bf10e877721416399bcf47acf6
2024-10-28 12:25:25 +00:00
Vinay Joglekar 972531f529 Merge "Fix flickering of tasks in desktop window when opened as static tile." into main 2024-10-26 12:18:13 +00:00
Treehugger Robot 423178c71e Merge "Match taskbar edge padding to nav button end insets" into main 2024-10-26 03:19:14 +00:00
Stefan Andonian bb85110a0d Delete Unused Flag related to Altering how the workspace is loaded.
This flagged feature was never released, and instead was thought to be too
complicated compared to the benefits in decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: I672708e26cb37d1e2b22c4510f9c3500edd4f959
2024-10-25 22:28:55 +00:00
Toni Barzic befd6bb1ea Prevent tap in swipe up zone from closing KQS
Tap down action in swipe up start zone may or may not be start of a
navigation gesture - for example, it may be start of a tab on an icon in
the task bar. If the user taps on the taskbar overflow button, closing
the KQS on tap down produces unintended behavior (KQS is closed on tap
down, and reopened on tap up). Additionally, this produces inconsistent
behavior in response to app icon taps depending on whether gesture
navigation is enabled or not.
Instead, close KQS as part of `hideOverlayWindow()`, which gets called
when a swipe gesture actually starts (note that KQS is added to the
overlay's drag layer).
Additionally, make sure that KeyboardQuickSwitchController state is
reset if KeyboardQuickSwitchView gets detached from UI due to the
taskbar overlay getting hidden (e.g. in response to home button).
Without this, in certain situations, KQS may get hidden with the
controller thinking the UI is still shown - in case the user releases
the Alt + Tab key combination in this state, the shortcut would end up
getting handled, and switch to the next task.

Bug: 368119679

Test: Press and hold Alt+Tab (while an app is open). After KQS is open,
Swipe up to transition to overflow, or home screen - KQS gets hidden.
Releasing Alt+Tab is no-op.
Test: Press and hold Alt+Tab (while an app is open) with three button
navigation enabled. Press home button. KQS gets hidden. Releasting
Alt+Tab is no-op.
Test: Press and hold Alt+Tab. After KQS is open, open an app from task
bar (either transient or persistent), or all apps list. KQS gets closed,
Releasing Alt+Tab is no-op.

Flag: EXEMPT bugfix

Change-Id: I8b561db3c6ec8a9c7de93e330faf8e3e4d3c8f4e
2024-10-25 21:43:56 +00:00
Toni Barzic 20e420ca40 Match taskbar edge padding to nav button end insets
When calculating max number of items to show in a taskbar with overflow,
reserve space for taskbar end/start margins that matches inline nav
buttons end spacing.

Bug: 368119679
Test: None
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I1205663ed4455ae1e7807f8d4edf5aaf2beba7d4
2024-10-25 20:49:04 +00:00
Mykola Podolian ddf212523f Merge changes Ibdecabd1,If330dc9e into main
* changes:
  Added scale animation for taskbar pinning transition.
  Animate the bubble bar Y for task bar pinned/unpinned switches.
2024-10-25 19:48:55 +00:00
Mykola Podolian f871e64f3c Merge "Set proper interpolators and durations for the bubble bar animations" into main 2024-10-25 19:48:08 +00:00
Anushree Ganjam ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Uwais Ashraf 821bcaade5 Merge changes I65e6ad57,I0335e4d0 into main
* changes:
  Remove listener in destroy() that caused a memory leak.
  Reuse TTV, recreating deps to get faster load times, lower mem usage
2024-10-25 17:11:37 +00:00
Uwais Ashraf b80f90bc0d Remove listener in destroy() that caused a memory leak.
Fix: 370916189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manually looking at heap dumps. Verify leaked obj no longer there
Change-Id: I65e6ad57d1ac6873946d836d8221b67deef548b1
2024-10-25 15:18:23 +00:00
Uwais Ashraf 6f61228a6b Reuse TTV, recreating deps to get faster load times, lower mem usage
Use a ViewPool for DesktopTaskView for same reason.

Fix: 369590189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manually looking at slow-mo videos of home to overview
Change-Id: I0335e4d0eea4841145815244bbbec19541f31c73
2024-10-25 15:18:08 +00:00
vinayjoglekar d5d51e51d7 Fix flickering of tasks in desktop window when opened as static tile.
This for loop was added to fix animation glitch if there is scenario of showing splash screen(on config change). Live tiles don't have this issue because we don't create RemoteTargetHandles.

Fix is to set Z-Index as per correct order since current value is same for all tasks.

Test: Manual, Add multiple apps to desktop task, Make it static tile and launch.
Fix: 370731110
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I9e3f1fd1333b6113423f51309917317febc1805b
2024-10-25 10:30:38 +01:00
Toni Barzic 143edac127 Tapping overflow button toggles KQS
Updates the taskbar overflow button handler to toggle the KQS instead of
merely showing it. The toggle action will open KQS view if it's not
visible, or close it if it's visible and has been shown from the
taskbar. If the view is shown, but in response to Alt+Tab, the view will
be closed, and reshown above the task bar.

Requires CL:30016166 for tapping to work as expected, and CL:30074037
for tapping overflow button reopen KQS over shelf if KQS is already
active for Alt+Tab

Bug: 368119679
Test: Enter task bar overflow. Tap overflow button to show KQS, tap
overlow button to hide KQS. Press Alt+Tab, tap overflow button to
reshow KQS over taskbar, and with filtered set of tasks.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: Id598f9cad649aa174aaf1c5802bf6b6837413d1e
2024-10-25 03:28:17 +00:00
Treehugger Robot 38c94afefc Merge "Actually merge the colors for recent indicators." into main 2024-10-24 23:26:18 +00:00
Jagrut Desai 9aa005b657 Fix Taskbar Touchable Region when overview is in split select mode
The problem: when Overview is in split slect mode second split app pick from taskbar take you back home. Why, because upon touch the taskbar touch region get
 set to empty and then we later don't meet any conditions to set default touch region to something.

The solution: change the condition of checking overview in onTaskbarOrBubblebarWindowHeightOrInsetsChanged so that we check that taskbar is in any overview s
tate and we don't rely on the stash controller flag alone. we follow similar logic in updateInsetsTouchability, but we gate that only behind transient taskba
r hence this was not an issue for transient taskbar.

Test: Manual
Bug: 373559050
Flag: EXEMPT bugfix
Change-Id: Ia507354f42959ce9d320114a313bfc533186b524
2024-10-24 15:31:02 -07:00
mpodolian 92d25cd21d Added scale animation for taskbar pinning transition.
Animate the bubble bar icons size and padding for taskbar change mode
animation.

Bug: 345698412
Test: TaskbarPinningControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ibdecabd1310203dc956f69673dc446a0e7e556a6
2024-10-24 13:45:11 -07:00
Mykola Podolian f85a484a9d Merge "Removed stashing hotseat calls." into main 2024-10-24 20:36:06 +00:00
mpodolian ed7ef84782 Set proper interpolators and durations for the bubble bar animations
Set proper interpolator and duration for bubble bar expansion and
collapsing animation. Also set animation properties for the taskbar
fade in and out animations.

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Expand / collapse bubble bar when taskbar is pinned and
expanded bubble bar would intersect the task bar.
Fixes: 360821863

Change-Id: Ia83d6aecdae921721a31b45f22400f878040f3d6
2024-10-24 13:14:54 -07:00
Brandon Dayauon 838a5e9d23 Merge "Add trace logs in Launcher for perfetto to investigate two line issue" into main 2024-10-24 19:35:15 +00:00
Anushree Ganjam ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
Saumya Prakash 747c6b4427 Merge "Prevent Search taskbar edu from showing on home screen." into main 2024-10-24 18:00:24 +00:00
Wen-chien Wang 94fb42cef9 Merge "Add margins to KQS view that is triggered from taskbar" into main 2024-10-24 17:47:37 +00:00
Liran Binyamin abc4b6a137 Merge "Handle taps on bubble bar flyout" into main 2024-10-24 13:26:50 +00:00
Brandon Dayauon 51db65ee49 Add trace logs in Launcher for perfetto to investigate two line issue
bug:375267130
Test manually screenshot:
onIdpChange: https://screenshot.googleplex.com/ASbyGFoAhTXgnWK
statefulActivityOnConfigChange: https://screenshot.googleplex.com/gLqxeJN7TzUURCy
Flag: NONE adding traces to perfetto

Change-Id: Ib2ac49fb8668fdfc91c8e38b91a4afd10127a4c5
2024-10-23 22:59:58 -07:00
Treehugger Robot 388701a031 Merge "Add debugging logs to transition animation" into main 2024-10-24 05:51:18 +00:00
Mykola Podolian 4dc6617988 Merge "Updated bubble bar position to be center aligned with the hotseat" into main 2024-10-24 02:10:43 +00:00
Sihua Ma aa921fa3eb Add debugging logs to transition animation
Test: N/A
Bug: 364465567
Flag: EXEMPT logs only
Change-Id: I8275c43ac44cd4b027fa8ad3d94fe0e84063b8d1
2024-10-24 00:58:58 +00:00
Treehugger Robot 1e4f42ff7f Merge "Account for all apps offset during taskbar layout" into main 2024-10-24 00:10:08 +00:00