Commit Graph

78628 Commits

Author SHA1 Message Date
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Treehugger Robot 4674c3bb2b Merge "Fix NPE in QuickstepTestInformationHandler#getWindowInsets" into main 2024-10-29 20:34:54 +00:00
Brandon Dayauon 0b2acd6516 Merge changes from topic "AddWorkSchedulerInWorkProfileFlag" into main
* changes:
  Add work_scheduler_in_work_profile flag.
  Remove layoutTransitions for current FAB and use custom animation.
2024-10-29 20:17:02 +00:00
Treehugger Robot 7112a56ede Merge "Tapping overflow button toggles KQS" into main 2024-10-29 19:56:33 +00:00
Schneider Victor-Tulias 3736f44f8e Fix NPE in QuickstepTestInformationHandler#getWindowInsets
Flag: EXEMPT fixing NPE
Fixes: 28555142
Test: TAPL tests
Change-Id: I722dfe196b93861723ef3de9961f0a30b9056583
2024-10-29 14:27:25 -04:00
Treehugger Robot 4f5a78a9bf Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-29 18:17:34 +00:00
Treehugger Robot 62962e65cf Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-29 18:17:34 +00:00
Brandon Dayauon 586df9898a Add work_scheduler_in_work_profile flag.
bug: 361589193
Test: NONE, presubmit
Flag: NONE flag not submitted yet
Change-Id: Iedc9513110f1a2ec4efaf5454987ff86051cda90
2024-10-29 09:50:16 -07:00
Brandon Dayauon a7123472ce Remove layoutTransitions for current FAB and use custom animation.
Have background contain left and right padding of 16dp.
That way upon collapse, its easier to animate so that every other view's space but the icon is removed.
Spec when expanded/collapsed: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2839-365095&node-type=text&m=dev

bug: 361589193
Test: manually - video:https://drive.google.com/file/d/1K7HCpayZBa_oo9p3XV10QQX4miTy_d3q/view?usp=sharing
withRTL: https://drive.google.com/file/d/1NfUEyEvzjfQamujv4EqLNBqB47mPNG1Y/view?usp=sharing
Flag: NONE just changing expandedFAB to use custom animations from layoutTransition

Change-Id: I7948633850a1010175eb4f0248daff22cf2f2c87
2024-10-29 09:50:13 -07:00
Vinay Joglekar 9859982e0a Merge "Fix icon during split task which is inside DW from taskbar." into main 2024-10-29 14:29:50 +00:00
vinayjoglekar f6a773a476 Fix icon during split task which is inside DW from taskbar.
We don't animate DesktopTaskView into split placeholder to avoid having desktop icon as the split placeholder, which isn't accurate as we're only splitting with a single task rather than the whole desktop.

Test: Manual, split app from taskbar which is in desktop window
Fix: 376002803
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ib62d831b1f0c0ca5ee8f355a15f14baff8ec67ee
2024-10-29 14:29:15 +00:00
Treehugger Robot 9c062e472d Merge "Add a feature flag to toggle DW carousel detach" into main 2024-10-29 14:21:13 +00:00
Shamali Patwa a01ae91369 Merge changes from topic "sheader-a11y" into main
* changes:
  Fix issue that expanding only search result led to weird scroll
  Fix issue that items were invisible in 2-pane picker with talkback.
2024-10-29 12:45:38 +00:00
Federico Baron 43cc25b64b Merge "Fix grid migration tests with grid migration refactor flag on" into main 2024-10-29 07:01:16 +00:00
Bill Yi 69a8022769 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0d4b964477ba5067abc1c27d9560110595b8e192
2024-10-28 22:57:24 -07:00
Bill Yi 11d7806cdd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic07e472cbad23a039bb8a9d8a3db2fd22e08d6b4
2024-10-28 22:56:31 -07:00
Sebastián Franco 8b871a329a Merge "Migrating LauncherDbUtils to kotlin" into main 2024-10-29 02:53:20 +00:00
Treehugger Robot 5e77702197 Merge "Prevent tap in swipe up zone from closing KQS" into main 2024-10-29 01:57:55 +00:00
Sebastian Franco b402c0f081 Migrating LauncherDbUtils to kotlin
Bug: 364711814
Flag: EXEMPT refactor
Test: DatabaseHelperTest
Change-Id: I140689fd16d3dbb373fd267448dce3fd4094e0ec
2024-10-28 16:25:30 -07:00
Treehugger Robot e6b473a284 Merge "Delete Unused Flag related to Altering how the workspace is loaded." into main 2024-10-28 21:42:56 +00:00
Sukesh Ram 4781b26bf4 Merge "Revert "Fix Taskbar Y-Translation with Visible Bottom Sheet"" into main 2024-10-28 21:42:54 +00:00
Liran Binyamin 6fc00481ab Merge "Allow updating the flyout message" into main 2024-10-28 20:48:45 +00:00
Treehugger Robot 3ea2e2f887 Merge "Remove dependencies on the 1-variant fallback" into main 2024-10-28 20:46:33 +00:00
Treehugger Robot 84b2583695 Merge "Cleaning up unused flag." into main 2024-10-28 20:18:56 +00:00
George Lin 54c3ab841a Merge "Shape screen communication with the Launcher's app (2/2)" into main 2024-10-28 20:15:40 +00:00
Cole Faust cfa4fe7e2b Remove dependencies on the 1-variant fallback
When adding a dependencies, if the variants don't match, but the
dependency only has 1 variant anyways, soong will always use that
variant. This makes it hard to add new variants to soong, because the
1-variant fallback stops being used and you start getting missing
variant errors. Make changes to bp files such that all dependencies
correctly specify the variant to use.

Bug: 372091092
Flag: EXEMPT refactor
Test: m nothing
Change-Id: Ifa43c0488e4cd40d6195fe2af3de5faa4f5996ea
2024-10-28 12:20:53 -07:00
Charlie Anderson b021c32c89 Merge "Fix flagging for LoaderTask broadcast tests and add more coverage" into main 2024-10-28 18:55:43 +00:00
Treehugger Robot 5e4d5704de Merge "Focus search container by default" into main 2024-10-28 17:55:59 +00:00
fbaron 22029f6517 Fix grid migration tests with grid migration refactor flag on
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2dceb5f9756da7ee7e7ef2d5ec29b3550a51e965
2024-10-28 10:46:17 -07:00
Jagrut Desai d7cb00cfb2 Merge "Fix Taskbar Touchable Region when overview is in split select mode" into main 2024-10-28 17:33:36 +00:00
Randy Pfohl 6dab7bac46 Merge "Enabling Fallback launcher cases" into main 2024-10-28 17:28:58 +00:00
randypfohl 9d7141d1fe Enabling Fallback launcher cases
Test: Locally tested and verified flow for fallback.

Flag:  com.android.launcher3.enable_launcher_overview_in_window

Bug: 365777265

Change-Id: I991a82152b47f2cfb7c1335c699e297b8f53bcf3
2024-10-28 17:28:27 +00:00
Sukesh Ram 99c442b015 Revert "Fix Taskbar Y-Translation with Visible Bottom Sheet"
This reverts commit d82503fc42.

Reason for revert: Introduced crashes

Change-Id: I0956f746e25ccfe655169580fd802d33f99c0652
2024-10-28 17:26:47 +00:00
Treehugger Robot 4a3c23a902 Merge changes I83746510,Ie2aa28cd into main
* changes:
  Fix TAPL OverviewTask to use correct resource to measure height
  Add TAPL test for dismiss DesktopTaskView
2024-10-28 17:18:36 +00:00
Charlie Anderson 7df6af5831 Fix flagging for LoaderTask broadcast tests and add more coverage
Flag: EXEMPT just tests
Bug: 375674876
Bug: 375704692
Test: LoaderTaskTest and presubmit
Change-Id: Ied00f9282f48ee88949697e5d684c489013e8aeb
2024-10-28 13:15:27 -04:00
George Lin f052a2ccf7 Shape screen communication with the Launcher's app (2/2)
Support querying / preview / apply for the shapes from the Launcher's
app.

Test: Manually tested that it works
Bug: 348664593
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I2b2fa570eb71c8975354f154640cc4891f16116b
2024-10-28 15:36:57 +00:00
Alex Chau edd7ff2fa1 Add a feature flag to toggle DW carousel detach
Fix: 376015547
Flag: com.android.launcher3.enable_desktop_windowing_carousel_detach
Test: manual
Change-Id: I98d4fbb17e8e432c94842c38d83735533d5ea197
2024-10-28 14:29:31 +00:00
Liran Binyamin 35e6157303 Allow updating the flyout message
Add functions to allow updating the contents of the flyout while it
is either expanding or fully expanded.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Iea3fc7df792e02605df6b44c1da39e267f6d9d43
2024-10-28 09:58:37 -04:00
Jordan Silva a244c0b70e Fix TAPL OverviewTask to use correct resource to measure height
The background in DesktopTaskView wasn't added for accessibility, so it couldn't be retrieved from the view hierarchy during e2e tests. This view is necessary to calculate the correct size of the DesktopTaskView.

The changes in this cl:
- Add backgroundView to DesktopTaskView's children for accessibility
- Use the correct snapshot resource for desktop mode in OverviewTask

Bug: 353948500
Change-Id: I83746510849e4013d623d49cbaccebd81daba96d
Flag: EXEMPT bugfix
Test: TaplTestsOverviewDesktop
2024-10-28 12:25:25 +00:00
Jordan Silva 7054095b16 Add TAPL test for dismiss DesktopTaskView
This CL adds 2 new E2E Tapl tests for checking dismiss DesktopTaskView.
- dismissFocusedTask_thenDesktopIsCentered validates the following scenarios:
  - Scenario: When Focused Task is in the center of the screen, with 1 other task in the grid and 1 desktop task.
  - When focused task is dismissed, the next task in the grid takes its place to be the next focused task at the center of the screen.
  - When the last focused task is dismissed, the desktop task takes its place at the center of the screen.

- dismissDesktopTask_thenFocusedTaskIsCentred validates the following scenarios:
  - Scenario: When Desktop Task is in the center of the screen, with 1 focused task and 1 task in the grid.
  - When focused task is dismissed, the next task in the grid takes its place, adjacent to desktop task.
  - When desktop task is dismissed, the focused task takes its place at the center of the screen.

Fix: 353948500
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Ie2aa28cd2b30a2bf10e877721416399bcf47acf6
2024-10-28 12:25:25 +00:00
Vinay Joglekar 972531f529 Merge "Fix flickering of tasks in desktop window when opened as static tile." into main 2024-10-26 12:18:13 +00:00
Treehugger Robot f6c4a7acb1 Merge "[PostBoot] Fix bug where post boot shader has a flicker" into main 2024-10-26 07:17:58 +00:00
Treehugger Robot 7ba66be10c Merge "[PostBoot] Don't destroy loader because of config change, not just because of theme change" into main 2024-10-26 04:52:39 +00:00
Treehugger Robot 423178c71e Merge "Match taskbar edge padding to nav button end insets" into main 2024-10-26 03:19:14 +00:00
Shamali P 656a026488 Fix issue that expanding only search result led to weird scroll
This piece of code was making list scroll for last item, which doesn't
really resolve problem or help for expanding items at end of visible
 list. As such scrolling only to get last time into visible area doesn't
 benefit anything (but creates inconsistency).

Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: I7ca519edfbb3a18c10fa518e28183da365f740e4
2024-10-25 23:00:57 +00:00
Shamali P be18ff2b7d Fix issue that items were invisible in 2-pane picker with talkback.
Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: Id8419e51bf20a38f203ce2422bae6290babcd63e
2024-10-25 23:00:36 +00:00
Stefan Andonian bb85110a0d Delete Unused Flag related to Altering how the workspace is loaded.
This flagged feature was never released, and instead was thought to be too
complicated compared to the benefits in decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: I672708e26cb37d1e2b22c4510f9c3500edd4f959
2024-10-25 22:28:55 +00:00
Stefan Andonian e87ca267b3 Cleaning up unused flag.
This feature was never released, but was meant to speed up the launcher's loading time.
It wasn't released because we ended up simply showing a Loading screen for long launch
times, and the extra complexity of this change was not deemed worth the decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: Ice0d8cbdc75ad69e80570d31d45c73f307fbf8b8
2024-10-25 22:28:29 +00:00
Toni Barzic befd6bb1ea Prevent tap in swipe up zone from closing KQS
Tap down action in swipe up start zone may or may not be start of a
navigation gesture - for example, it may be start of a tab on an icon in
the task bar. If the user taps on the taskbar overflow button, closing
the KQS on tap down produces unintended behavior (KQS is closed on tap
down, and reopened on tap up). Additionally, this produces inconsistent
behavior in response to app icon taps depending on whether gesture
navigation is enabled or not.
Instead, close KQS as part of `hideOverlayWindow()`, which gets called
when a swipe gesture actually starts (note that KQS is added to the
overlay's drag layer).
Additionally, make sure that KeyboardQuickSwitchController state is
reset if KeyboardQuickSwitchView gets detached from UI due to the
taskbar overlay getting hidden (e.g. in response to home button).
Without this, in certain situations, KQS may get hidden with the
controller thinking the UI is still shown - in case the user releases
the Alt + Tab key combination in this state, the shortcut would end up
getting handled, and switch to the next task.

Bug: 368119679

Test: Press and hold Alt+Tab (while an app is open). After KQS is open,
Swipe up to transition to overflow, or home screen - KQS gets hidden.
Releasing Alt+Tab is no-op.
Test: Press and hold Alt+Tab (while an app is open) with three button
navigation enabled. Press home button. KQS gets hidden. Releasting
Alt+Tab is no-op.
Test: Press and hold Alt+Tab. After KQS is open, open an app from task
bar (either transient or persistent), or all apps list. KQS gets closed,
Releasing Alt+Tab is no-op.

Flag: EXEMPT bugfix

Change-Id: I8b561db3c6ec8a9c7de93e330faf8e3e4d3c8f4e
2024-10-25 21:43:56 +00:00
Toni Barzic 20e420ca40 Match taskbar edge padding to nav button end insets
When calculating max number of items to show in a taskbar with overflow,
reserve space for taskbar end/start margins that matches inline nav
buttons end spacing.

Bug: 368119679
Test: None
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I1205663ed4455ae1e7807f8d4edf5aaf2beba7d4
2024-10-25 20:49:04 +00:00